From nobody Fri Apr 17 06:17:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31AA3612F6 for ; Mon, 23 Feb 2026 10:57:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771844247; cv=none; b=IWPygd3pMnSxtXBVSIwonAM7DWBeVzxyjtVSMBGT1Zw0T+kb8H/4ifW5W2gwaMV3r5omcApDs6Ps52xHpx5M3Uh8+blVmLC6XX4huyQbmZU4glBI+S1Gj60g3KnKWiczxbRLcZKKydxLK8CbbgALS8x6b5eae7F9G0fauczcLgc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771844247; c=relaxed/simple; bh=G3uoQqzwbhwMv3rHo8CzAGVUUhUj+DhmlQdTwenR1nU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=rHjPTwvP0cnDmRXUc2QSg+cBAmsXjp0VlEfMy8KGRXuuM3GKyaUnDRaUIs6RTJKkPk7WHYm+pLHGOp9ouj2AyZ8lhfLTHhOYmRiXLn/Zn+WVUz4fdHUcqJsg0P9hAtw0w+cU27kDDlRrqjFcf3h+BZ+wX1SyUf5v1PeZKvKlPyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LvfWpcdM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aSlK/qKW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LvfWpcdM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aSlK/qKW" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61N9bT7k1262788 for ; Mon, 23 Feb 2026 10:57:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=jUC9TlWmv0obtpzoHHcT8WkjssvqQiRshIt uq7Tbwls=; b=LvfWpcdMprHhI2Bo7zpuR5/qRf4NuIUS7FpexbRdIVN4kuNvcm0 Sl2rzjY/5uPjs0u1+suzqyjkPYx8Ure+n61lQXGb2WDPswxNwKNZ2Z+U4qM9iou/ Lc0u0tw3TvZMpHCxabxgEArC08BIpTV8RhW/qzmtLEpzfqkRGgZxAmd2czhbHcNA xaCbyWIDYLlcDVxT5pr+IAbkIJHj8Wbb7bkGpiON7D4PG2hIge0lc+Roz1ZBvGaY VPusb3G94vP45nqmzSaOO/RxusYA+EGfT38G2Nm4v++nZoRFgOov2KYO08vu2kGN REUIv1001T26ZJVTAJ6GQzmAFC1XALJcZQw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf603mfxy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 10:57:25 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cb3ad1b81aso6524074485a.2 for ; Mon, 23 Feb 2026 02:57:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771844244; x=1772449044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jUC9TlWmv0obtpzoHHcT8WkjssvqQiRshItuq7Tbwls=; b=aSlK/qKWJ15JFRsGFaTW/kqfWtunZhnE4Ks/75a0BWY0l5Nj9QDaBO1+b7SI99ikzw VvWisijBW3zom2izhO57SrDaBAELkcnzNz1YUv6Qa3nCcLEyOaDweaI22Dvg5CdEU2EB u41WepnNVYmmoTFVZXSQ22YUM1KizkugxeqcolycW+0wNeG3LIwr7DYABolU4rS6DTi4 pLMUa2e9t+SKftrquvc9wnHex+E3kkayjsO1VxMJHMg95/YYXIXITH3cfgyE1wk9DHh5 +S/ErhO2flOkpjcGiGLGPmz3eIGvJNgBYOzzhs9o7zhqadHarYyJuk1DI/cPRNWMx68V yQIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771844244; x=1772449044; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jUC9TlWmv0obtpzoHHcT8WkjssvqQiRshItuq7Tbwls=; b=aEMBISpac7QUUfDvtmQFWYnV8FIIfWKToN3h7rMsd3sRAS/r9dro2lwuDHDG4D13h9 FaBr6YBw6jsmCrfu5C4cbTV8sWJ0A9a0mdI4YfSGDBrEr9zuwNA8hp/O3lpOr6zIPKQH uzf4e4oNThzw5VQL51aAT/YeUeQf/gkiWz3BMCwxlGIGQNHuzFoM63lEPl9hXoNXrt5n DNtx33UE8IYtg3w/EJ7VhuTWK49O3qOOk/EWfE3jLGMZcYnDhiQnfVUDZza7XB+WKxJz kkZsHuTbcXXnDDCcjXuuVfXT0hqFKr0Nx/xhYbIZAPGZy0IfMe5AIbEFUmi2Wkl34R2B KgBg== X-Forwarded-Encrypted: i=1; AJvYcCWSgSFFPQqZLiDrRsZA6dh28baoDW+DgBhxsCgXm63hnNEmX0AiI5ssJ9aaPz9w+5oxIGQgTYm+vg62ShM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywq294sVkYLCOxyPY800+eyFiae13cx0gJbbFMPQ2T+PCY6yeop b2I9FYEtJtVc0Nkz0mFL4g8T2B5g5p3IfMu3dGvqGWgAl07eGVI2W0zRMgeLViMCuQLm7wAiVVk RXvxQ0O3N4LM7NGDnN7xbIdirTf0WwhiSDCexOv775UUKJUv57ryjbhrPija+JBBXFk0= X-Gm-Gg: AZuq6aIXk+ZhqT8W/EqQD9TwQF59PAU1ons3xlK66HNc6O4VAL+wJRVSHW2x89QRLUS moIaw9bIAg0w9doKnWcF3RctmJ7tjtInefwWzt8HH52LS2qPLnsE8HLut+puP766FRTWuE3Kt8D J/lZSvVGIGVzNvz0EdsgJG+csEWPyBpqZXTTprD67DZ3qLiciozIwn6nSt1HUi1HcvRWKkAs7Tc TX5ZT8zkCWRXVXqbDzC7F0M47Tr/04CJsx0oG1/MYlQXBCZ9fmTfssx7dU6VhB9m3dSHgABcr2x n7bYtWrJjkNyE1TO/RQj2tA08q2uLwbRLX55eYdpIqGtj38uwcmzOXMv+0agryPHvbzXa2UM/Dw Qc3vLNCb/8T9lzcdZb8sUWwb8UEuxfcinxYF1dg== X-Received: by 2002:a05:620a:d8d:b0:8c9:f4eb:ac71 with SMTP id af79cd13be357-8cb8c9e00a7mr906244885a.10.1771844244229; Mon, 23 Feb 2026 02:57:24 -0800 (PST) X-Received: by 2002:a05:620a:d8d:b0:8c9:f4eb:ac71 with SMTP id af79cd13be357-8cb8c9e00a7mr906242785a.10.1771844243651; Mon, 23 Feb 2026 02:57:23 -0800 (PST) Received: from quoll ([178.197.223.140]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d4c60bsm18140215f8f.27.2026.02.23.02.57.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 02:57:23 -0800 (PST) From: Krzysztof Kozlowski To: Linus Walleij , Heiko Stuebner , Krzysztof Kozlowski , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: David Lechner Subject: [PATCH] pinctrl: rockchip: Fix configuring a deferred pin Date: Mon, 23 Feb 2026 11:57:18 +0100 Message-ID: <20260223105717.48779-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1886; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=G3uoQqzwbhwMv3rHo8CzAGVUUhUj+DhmlQdTwenR1nU=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpnDKNtoQe5GdE1EfxYH3cWP7j5g7W2fBZbQJ1f M1XdzvUygGJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCaZwyjQAKCRDBN2bmhouD 1wHGD/9gOeDdNWNQGaIjTJ1BjcIplUgUa679M6zz4l7YF/MEDewvDNgHyTbQGKfp9FuPF87jP9W yY1adjL4z9CMML1N1Q3darmmdoeiKkKlbmM3Pn5Qh825I/eQ6J9JJ5WREUrwhp9wPuLb5MOkWxd +IL+6P72pYU5pVecdI0qkS6KPyashiEHVmK7Z6h8K0BaavFKp6w57iCEF9AF5PCIt78C3lyNcZW fNRAaeXk3RF/2Zw0i+o0Br1M2MCPjQGWQS1kvm8fLGvUOLvOmM+1S+7fu59X5htauWtaITthriJ NJh/1UfVosuobC5H3FrzvzyYtQIipzbkc6Ply3pjEMCEruUaghTSvOudTw96+VRJzQANOLQjj4l RDzrz+Mlc6BUhT03htNS7oxyZ4k3iH7J7HQ6EXe/HWomB/GeBOIHpssgdQlOxDVs33SnTFnplX9 yVqtd928i7HgQJPhggJ5x3GhHBUe4huxIcx0MthHSC/Dkq6q6XWXwas6SDsP23kElujRqAfvXDg NdYu4cqiD0no1pSWCitq3IeL0jLCGKWid7SILla8eJ+sR5ufRobefLmWht/Kzi6lf3Ls3rpAoia eNZRZ6Sn1auRE1Df8+bAqrbUHfLkTs+XVzU9Nhek3Wm8bUEFgI/uv8D+My+84RwH1SVrz4eO1fZ 6GXs2LZxL2pQE/A== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=XbWEDY55 c=1 sm=1 tr=0 ts=699c3295 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=6nO30s3o7FuWeffXwhKHTA==:17 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=IpJZQVW2AAAA:8 a=EUspDBNiAAAA:8 a=wq2r3B8GeWDWek6aAFgA:9 a=PEH46H7Ffwr30OY-TuGO:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDA5NCBTYWx0ZWRfX8TXi4V+AxIkf sZAwzgWVUg8NE+9pubkSrXfFwFjU+a/pWwJrm94Ri7Z53/tV4QcFnkDXZIWAAC0UdpVcFW9ShEi f6k0un8ogZd9KQCauBTeaFR7coonTn3Yd3Nus0g0Haxyhy7XpRnf2z5GBxxugT7JHBmsYZ2a75R civdkRfG7bpWO+IHbW5FEL+s+t+9wnNpneycnUqDtbzbOJxpwgRla3/vZV7pEJ1hwpoX7SfxVGE Ku+I+GuTvtYrDVUxsM+qMYKdGkrY1hUd1jWD+gUYx0XbmZpyVRor83pxg2+1PVOwDqbTM1NUSm5 nR1SvJOEx1EOJ3QO6ZvH1E3W/UiIz7bgvQU4oe6TyHNTlVlKbxlOdJQdTw3FFe6DpZU0GMUQnI+ 3GfMlBfBt9xjMy4p5beHHQ2i5cJoh1CllaSsJ/SgMqJK8jWI1YTnROVRYLy9Mo4GWo4718wsHhM unGpr+RdX225SKKYnyA== X-Proofpoint-ORIG-GUID: LF2y_EMHvYVdmU4RaD1J-w0I8CoR-e54 X-Proofpoint-GUID: LF2y_EMHvYVdmU4RaD1J-w0I8CoR-e54 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_02,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230094 Content-Type: text/plain; charset="utf-8" Commit e2c58cbe3aff ("pinctrl: rockchip: Simplify locking with scoped_guard()") added a scoped_guard() over existing code containing a "break" instruction. That "break" was for the outer (existing) for-loop, which now exits inner, scoped_guard() loop. If GPIO driver did not probe, then driver will not bail out, but instead continue to configure the pin. Fix the issue by simplifying the code - the break in original code was leading directly to end of the function returning 0, thus we can simply return here rockchip_pinconf_defer_pin status. Reported-by: David Lechner Closes: https://lore.kernel.org/r/f5b38942-a584-4e78-a893-de4a219070b2@bayl= ibre.com/ Fixes: e2c58cbe3aff ("pinctrl: rockchip: Simplify locking with scoped_guard= ()") Signed-off-by: Krzysztof Kozlowski --- Offending commit was introduced in v7.0-rc1 I also checked few other of my commits for similar error. --- drivers/pinctrl/pinctrl-rockchip.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-r= ockchip.c index 816823403e97..4f2e02322508 100644 --- a/drivers/pinctrl/pinctrl-rockchip.c +++ b/drivers/pinctrl/pinctrl-rockchip.c @@ -3640,14 +3640,10 @@ static int rockchip_pinconf_set(struct pinctrl_dev = *pctldev, unsigned int pin, * or the gpio driver hasn't probed yet. */ scoped_guard(mutex, &bank->deferred_lock) { - if (!gpio || !gpio->direction_output) { - rc =3D rockchip_pinconf_defer_pin(bank, - pin - bank->pin_base, - param, arg); - if (rc) - return rc; - break; - } + if (!gpio || !gpio->direction_output) + return rockchip_pinconf_defer_pin(bank, + pin - bank->pin_base, + param, arg); } } =20 --=20 2.51.0