From nobody Fri Apr 17 07:45:44 2026 Received: from azure-sdnproxy.icoremail.net (azure-sdnproxy.icoremail.net [207.46.229.174]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 92C231E49F; Mon, 23 Feb 2026 04:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=207.46.229.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771822555; cv=none; b=ibPCvVtebCfqz4vThsSyj9HAu+gKshEc0fleYLMYzT8K/1hqn10tVC/ffk7ZkmC8UCoPuQVAvvV7X8/56OF3p96FA/TLxDgghcnF6XFf3cCPY+yrnzNMXdjEvApet2Y8d3WAr+y/6bQtSTRZv3gClpQ+/pfzsfojdRzPwHHjRpE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771822555; c=relaxed/simple; bh=IxPmowjoyc9TmNT/B4dUTqUNjIDScdYdklSt8RBQ8k8=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jHX3vj5wg6xK4727J4TlTljcqQs3+DGVQGYksy52CaiZRC0zbcNpfalFOGTX4qxG8kdp7vhqzir0Zkj9n3fLTIKI9DI1YAcMCUakJRpv16Nb+cts3rlgLvwwoCFlGuId46Flw+X5RSMitmgBWq0n0s+R/L9IJQ2HHO4/cgyeidE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn; spf=pass smtp.mailfrom=zju.edu.cn; arc=none smtp.client-ip=207.46.229.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zju.edu.cn Received: from zju.edu.cn (unknown [218.12.19.25]) by mtasvr (Coremail) with SMTP id _____wD3SBzA3ZtpL2vQAA--.21416S3; Mon, 23 Feb 2026 12:55:29 +0800 (CST) Received: from ubuntu.localdomain (unknown [218.12.19.25]) by mail-app3 (Coremail) with SMTP id zS_KCgCXmGu73ZtpiElZBg--.56110S2; Mon, 23 Feb 2026 12:55:26 +0800 (CST) From: Duoming Zhou To: linux-wireless@vger.kernel.org Cc: linux-kernel@vger.kernel.org, pkshih@realtek.com, Duoming Zhou Subject: [PATCH rtw-next v2] wifi: rtlwifi: pci: fix possible use-after-free caused by unfinished irq_prepare_bcn_tasklet Date: Mon, 23 Feb 2026 12:55:22 +0800 Message-Id: <20260223045522.48377-1-duoming@zju.edu.cn> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zS_KCgCXmGu73ZtpiElZBg--.56110S2 X-CM-SenderInfo: qssqjiasttq6lmxovvfxof0/1tbiAwALAWmbXAgC6wACsE X-CM-DELIVERINFO: =?B?4Zt5PQXKKxbFmtjJiESix3B1w3uoVhYI+vyen2ZzBEkOnu5chDpkB+ZdGnv/zQ0PbP CR12ES3fGLXKU3xFI5V2mAEBjPVVwJEGY6Y1aMdwie2h8xXjXZ3zxci7uT+9ikGVrOoP3z 6Z7e2FNJeu+8q+uRFaxrHQRhvuhP6AoNhUWk54kc/wyRgdHwCtLRP0EtnQzMeA== X-Coremail-Antispam: 1Uk129KBj93XoWxJry7Aw17uF43tryrKw4Utrc_yoW8WF4DpF W3W3y3GFZ5JF1UC3WDXw4SqFyrtanIqrWfGr4rK34Igws7ZF1Sqw1IkFZIkFWjyr40qFZ0 yr18tr9xGr1kA3gCm3ZEXasCq-sJn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvqb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E87Iv6xkF7I0E14v2 6rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1l5I 8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AK xVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7xvr2IYc2Ij64 vIr40E4x8a64kEw24l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2Iq xVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r 126r1DMIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY 6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67 AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x 07j0iihUUUUU= Content-Type: text/plain; charset="utf-8" The irq_prepare_bcn_tasklet is initialized in rtl_pci_init() and scheduled when RTL_IMR_BCNINT interrupt is triggered by hardware. But it is never killed in rtl_pci_deinit(). When the rtlwifi card probe fails or is being detached, the ieee80211_hw is deallocated. However, irq_prepare_bcn_tasklet may still be running or pending, leading to use-after-free when the freed ieee80211_hw is accessed in _rtl_pci_prepare_bcn_tasklet(). Similar to irq_tasklet, add tasklet_kill() in rtl_pci_deinit() to ensure that irq_prepare_bcn_tasklet is properly terminated before the ieee80211_hw is released. The issue was identified through static analysis. Fixes: 0c8173385e54 ("rtl8192ce: Add new driver") Signed-off-by: Duoming Zhou Acked-by: Ping-Ke Shih --- Changes in v2: - Adjust the subject prefix and point out the problematic tasklet in subj= ect. - Select the "rtw-next" tree. drivers/net/wireless/realtek/rtlwifi/pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wirel= ess/realtek/rtlwifi/pci.c index d080469264c..f0010336e78 100644 --- a/drivers/net/wireless/realtek/rtlwifi/pci.c +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c @@ -1674,6 +1674,7 @@ static void rtl_pci_deinit(struct ieee80211_hw *hw) =20 synchronize_irq(rtlpci->pdev->irq); tasklet_kill(&rtlpriv->works.irq_tasklet); + tasklet_kill(&rtlpriv->works.irq_prepare_bcn_tasklet); cancel_work_sync(&rtlpriv->works.lps_change_work); } =20 --=20 2.34.1