From nobody Fri Apr 17 07:44:21 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C588A17BA2 for ; Mon, 23 Feb 2026 04:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771821307; cv=none; b=VfgKZTPekm1Cpn+K6iqgwAVx3xxCphsDvC6g+TIpFMxK9oi4SCqg095kk7sr90MyBXuvX1TeD3g+P9pEkF28YTusDMdBWTvupRONxXg29ltoPhMUNKcsm1IhQH2hkVPtyl5oiuSmGHPPm4zdoipvWWrz8VbaUu/UbnavhLYps8c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771821307; c=relaxed/simple; bh=HUeBgJePoxBqUsizCAf5PdFwYz9HgG/cx0oT689Nq08=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JFXkLkm/J5aKA09pqSoce3oW9LuVyK3bLShNX6q947Fs74VFJdU56vjiID0B3+1aMvXezQWmOLPaURhueJvbKj06/AoDAY+BN/wc6ymWZIfBxITnutai54OhJ+EJe5WobNhu5rI8iVftHk5a5FxVdwftJF8Y8fDST/ZnAocm1Sw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jLHrcDIR; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jLHrcDIR" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-354a7b089bbso2287240a91.2 for ; Sun, 22 Feb 2026 20:35:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771821305; x=1772426105; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GI3iRUIh5GHrKKs0FAr5rYUViIfZVlMQDjQ0Q0XmmjQ=; b=jLHrcDIR0nfnPKAv7+wmjz7FxpXkinu7ke0iUFrb3Fav7rkMNtl3NxlbHAt3k4WIQW 8s7mAMK/icD1/YRh0dpZS/2/waAsqvPi0ESEiczFnnk26VKfv98RJAT9aRqCxmYP1QFp Ov6ZKTVJVVNM6gUnDaLjKVKoXve8HZ0We/rt912gLPeXdMQa96dDI5+xzLt8xtqKODyc EXze94HN7gK3U4HZGCbSmlnJwwJsRaJIT63W3fi6fo0IxPUMzBg5SCCd0oSsVs+PmQ7n XCtKgzbpZdEBMO6kTts/nZGk6PTSvX+jaXwCBUH8Op5Na1nWYV/D0rzzdD0oRhhljkiX 06iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771821305; x=1772426105; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GI3iRUIh5GHrKKs0FAr5rYUViIfZVlMQDjQ0Q0XmmjQ=; b=p9fF2LJXvYqktiAkkPU/GXjRs5UieZKl55QkcfljWFR3KBFPs1yv40S8/MctSRMmYL aMIivl0dzqYrqvX0wPMHsmNO1LWkTQSZUhAqPU6eIfxYBv+h6bPx67sFKir12Evf4P9N ORqKGkgxMe8WejEV2/1IQaWA1gdc4MdiV0hz18OrSHz1l58QYpjkh4y7TZ0SsbXKoiKl TniuQOqKzZP0rP50tIGnNv5vMeHe6m4VaXDFde5xTjJ0G7kb/+i2U5MpmDNjC+afjgIm QC/PtDb18QrKbS3ns9rALPy7SFb9h4Fssbb9cbIFWbu9VrjrYRP0q37m8i7xB6RTWElm qVXw== X-Forwarded-Encrypted: i=1; AJvYcCVkBJVdjaicgnX1U0exKZZeDSkD9ogQrFQwnl2G27bFt9xAKjPYt/3Ja3LXDOtOuS5itFf5/8BPlMjz2jA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0Zr9g6XVFYWTcpYtmkG3sqdDiu/i4nczeC97AbRyb4/L/9hy9 yfttECq+ey7q9zZg69CWnUIx4aXF+uiSo4DBCJHM42hXPYahVR60jGGD X-Gm-Gg: ATEYQzyFg1OUk4ozSo2s3ZgeWW5rK5jA7RReCDWxbfhD4cbAvAgZ44pwfn/8VNDUS4y Fre40e2KcyeY/KPVMOKe1oCQkJFMft/QPAVR0XZTH4M27gHYH8RrN9kfYuZOurwyNvoP2DbzWZo CvMafEtEumQw4TFJA6gDKXzlN95vJHW/RGpPga2USiXeqwn60UfSh0myU/QoEqtEsWcWaS5+HM8 itOt1gz6OvfLlcKaFuBhaU9hpitUxB4yjWLAVPWdFB923FPELIs8LmUUHJNm6UMbXiQ/2sPS8wU hPpH6yJxEXjZMQSjkMIVzS1fVMysEVQpPotSA3qpHIfQnNVO13TmA2bn2GnYYoFtqdfUJAh/pmq Jgyuy2Kn6mvnwwFg2kIJeSrdSA6/OpxbT5Jwh9rtHpx8PxKtlSqhFaWMQ6xLed3Aezlf8alBcAB TZCMwq53bhkIZDWOunk+LQXgIs80OoR9nh4KjAjrD+sjjkxj4PFTNBvMA= X-Received: by 2002:a17:90b:558b:b0:352:d59a:b28 with SMTP id 98e67ed59e1d1-358ae8a87d8mr6149084a91.19.1771821304991; Sun, 22 Feb 2026 20:35:04 -0800 (PST) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:c33a:e011:aa68:c72a]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358af93b9ddsm5141447a91.14.2026.02.22.20.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 20:35:04 -0800 (PST) From: Chintan Patel To: sumit.semwal@linaro.org, neil.armstrong@linaro.org Cc: dianders@chromium.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chintan Patel Subject: [PATCH] drm/panel: novatek-nt36672a: Convert to mipi_dsi_*_multi() helpers Date: Sun, 22 Feb 2026 20:34:41 -0800 Message-ID: <20260223043441.5295-1-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the driver to use the non-deprecated mipi_dsi_*_multi() helpers and mipi_dsi_msleep(). This removes open-coded error handling and relies on mipi_dsi_multi_context for error accumulation. In unprepare(), reset the accumulated error between set_display_off and enter_sleep_mode to preserve the existing power-down sequencing semantics. Signed-off-by: Chintan Patel --- .../gpu/drm/panel/panel-novatek-nt36672a.c | 83 ++++++------------- 1 file changed, 26 insertions(+), 57 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/d= rm/panel/panel-novatek-nt36672a.c index 29e1f6aea480..2c8d67a69c7e 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -79,23 +79,17 @@ static inline struct nt36672a_panel *to_nt36672a_panel(= struct drm_panel *panel) return container_of(panel, struct nt36672a_panel, base); } =20 -static int nt36672a_send_cmds(struct drm_panel *panel, const struct nt3667= 2a_panel_cmd *cmds, - int num) +static void nt36672a_send_cmds(struct mipi_dsi_multi_context *dsi_ctx, + const struct nt36672a_panel_cmd *cmds, int num) { - struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); unsigned int i; - int err; =20 for (i =3D 0; i < num; i++) { const struct nt36672a_panel_cmd *cmd =3D &cmds[i]; =20 - err =3D mipi_dsi_dcs_write(pinfo->link, cmd->data[0], cmd->data + 1, 1); - - if (err < 0) - return err; + /* cmd->data[0] is the DCS command, cmd->data[1] is the parameter */ + mipi_dsi_dcs_write_buffer_multi(dsi_ctx, cmd->data, sizeof(cmd->data)); } - - return 0; } =20 static int nt36672a_panel_power_off(struct drm_panel *panel) @@ -115,34 +109,26 @@ static int nt36672a_panel_power_off(struct drm_panel = *panel) static int nt36672a_panel_unprepare(struct drm_panel *panel) { struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); - int ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D pinfo->link }; =20 /* send off cmds */ - ret =3D nt36672a_send_cmds(panel, pinfo->desc->off_cmds, - pinfo->desc->num_off_cmds); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->off_cmds, + pinfo->desc->num_off_cmds); =20 - if (ret < 0) - dev_err(panel->dev, "failed to send DCS off cmds: %d\n", ret); - - ret =3D mipi_dsi_dcs_set_display_off(pinfo->link); - if (ret < 0) - dev_err(panel->dev, "set_display_off cmd failed ret =3D %d\n", ret); + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + /* Reset error to continue power-down even if display off failed */ + dsi_ctx.accum_err =3D 0; + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 /* 120ms delay required here as per DCS spec */ msleep(120); =20 - ret =3D mipi_dsi_dcs_enter_sleep_mode(pinfo->link); - if (ret < 0) - dev_err(panel->dev, "enter_sleep cmd failed ret =3D %d\n", ret); - /* 0x3C =3D 60ms delay */ msleep(60); =20 - ret =3D nt36672a_panel_power_off(panel); - if (ret < 0) - dev_err(panel->dev, "power_off failed ret =3D %d\n", ret); + nt36672a_panel_power_off(panel); =20 - return ret; + return 0; } =20 static int nt36672a_panel_power_on(struct nt36672a_panel *pinfo) @@ -170,51 +156,34 @@ static int nt36672a_panel_power_on(struct nt36672a_pa= nel *pinfo) static int nt36672a_panel_prepare(struct drm_panel *panel) { struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel); + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D pinfo->link }; int err; =20 err =3D nt36672a_panel_power_on(pinfo); if (err < 0) - goto poweroff; + return err; =20 /* send first part of init cmds */ - err =3D nt36672a_send_cmds(panel, pinfo->desc->on_cmds_1, - pinfo->desc->num_on_cmds_1); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_1, + pinfo->desc->num_on_cmds_1); =20 - if (err < 0) { - dev_err(panel->dev, "failed to send DCS Init 1st Code: %d\n", err); - goto poweroff; - } - - err =3D mipi_dsi_dcs_exit_sleep_mode(pinfo->link); - if (err < 0) { - dev_err(panel->dev, "failed to exit sleep mode: %d\n", err); - goto poweroff; - } + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); =20 /* 0x46 =3D 70 ms delay */ - msleep(70); + mipi_dsi_msleep(&dsi_ctx, 70); =20 - err =3D mipi_dsi_dcs_set_display_on(pinfo->link); - if (err < 0) { - dev_err(panel->dev, "failed to Set Display ON: %d\n", err); - goto poweroff; - } + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 /* Send rest of the init cmds */ - err =3D nt36672a_send_cmds(panel, pinfo->desc->on_cmds_2, - pinfo->desc->num_on_cmds_2); + nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_2, + pinfo->desc->num_on_cmds_2); =20 - if (err < 0) { - dev_err(panel->dev, "failed to send DCS Init 2nd Code: %d\n", err); - goto poweroff; - } - - msleep(120); + mipi_dsi_msleep(&dsi_ctx, 120); =20 - return 0; + err =3D dsi_ctx.accum_err; + if (err < 0) + gpiod_set_value(pinfo->reset_gpio, 0); =20 -poweroff: - gpiod_set_value(pinfo->reset_gpio, 0); return err; } =20 --=20 2.43.0