From nobody Fri Apr 17 07:44:21 2026 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 306DB27603C for ; Mon, 23 Feb 2026 03:05:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771815959; cv=none; b=cwzZHL6SiWWBpL8fH+qzkOY8aIv+wj/5ARRXRIhfGfAH7UFQugDH19LzQuBr5XxPE+Zg6i2pfsZdXye0dB2coggSbIc6yEZdsJCT0RVPldPPBEp7piVixLZErJbIm9D5ZJiQeCRmRR1z3mZQzSb5e8aDgcj2EpnCtC5EuZFQd+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771815959; c=relaxed/simple; bh=i5vgvg3sg+UXIaRcyERPIMtjQmPcakNHGsM4C/i0qXs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Hnq48Go1rxuAQeXzLb/Jg3Nx0yQpyQOUfUvjIn1sxWi7eyL9/DW0YrerCN43Ch8JP/iL6dh4TIK5zpzdNUoSqHSEGNjDQox5EvEemQoXtCfHQCOY0YuBGr8VwVaG4s4+beL8HhgMs7WDuKEF5ujJg1PELng1L2/+Si8ii1UAcR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BsxjJ4/y; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BsxjJ4/y" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c6e1f417918so968193a12.3 for ; Sun, 22 Feb 2026 19:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771815957; x=1772420757; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GSnvmMEphQ4/6s6fXwVUjqcFnb8wnWTRkYiCVtaRqA8=; b=BsxjJ4/y6BkTl93062VsWGvbU0Qwsn1dDBkji8/SLcp3cbhB60u5NKtHncE+7lYJvH ragnprEQ+LqPWErcGTFtINhQGWNbYA9OzBel3WlklxA6svNOJ5PQmYYm8SRB33/wQBgY A8h35BZgo2CczdkcgLZF3ceeevWWrBrDk8rY2ecn9bmXV7VBx0BSX+Y0jg66p7m2NEUK AvZo14T09ipNA9A1n4Xar8STKtWGxN+r3WQ5HBdxi2AWdLlx8k+uoOjFSf1ubDnUbyFK yT1Dpyu4/Z6d7uqdsiGr0oW1ECQqv+dztgWDUXvN1niLC9c/afy5H2bNDSoNwllY4MzU KK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771815957; x=1772420757; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GSnvmMEphQ4/6s6fXwVUjqcFnb8wnWTRkYiCVtaRqA8=; b=HUte3iqmksxxPNzzE6pfAhgIKANpdF65Id2uVDflnWTouxVfwISX59QxhmbE7BtUWh 3AzSGtGpzphcqjz4ZKLo5rwx/7xom5X4+Zv0MHPE05rwdoLS30ZweT0OP3f7lVAqO/MV E4ux4Kud+jnfr0hgba9EDfpcdWBftbZWflqXDF+fWW+ZPXWI5YV1deYVgEzUk3emloV1 wNHDi47mj0Nyi+wTg6Fu5gn4jHq4rGFuKxo++hnPB+SslvxukRW9GEiT4BRn31+cB+6V LUSemKc3JQiqBdpwieRn62QI2xSVe4rYgZ42nDVBso4pKJ3CkXlXp5Y1HnVHPPI7lGhc 9rnQ== X-Forwarded-Encrypted: i=1; AJvYcCU5dvG4WhSD29vfFP2KbfW7JhA5xv1co3vIPo0R4ntnJq5SjrE7AJ/403po0wIH+wxUkM14SchAVde0lik=@vger.kernel.org X-Gm-Message-State: AOJu0Ywk/viGJc68qHS4b8oFkU0exkTcecZ+7Q/Z7Ea1CSEgLLlgKhj9 aNFEAYQIVTInvXAikWO5Ri1KSXJF2lJItGrcP69BSYjUoKh9HKlX3q7T X-Gm-Gg: AZuq6aLPBNicEKGFaxtzfa70dqfsps3pI3Rn+vNwzuBR5OElzLdHAuiIhrEGJWWC+Tp i/TzsQCroB3yat970lGH66SVfMamdM0442Z/k9RwfUMijiCXXpOSRijbYBjKAfIXY9qD0XsYT5S 0QZB6Kf9/83ZAPt+OJrFrPeXNby5LdEfyhw0smXNhf6nd1P+pvrzcecAk+hTuWMijqNAfKcnUhb jcsBHJi41XEkPTfIXWkzH5NNssoimeChvGw1RKYd2dv6g6D65MH4UvicJnjby6woNtn8b1JS/dw xFtbdHKppBe3IVNk+ccS+kRzSBbHg8T0yY6HCDqMXsFx+TY+vkB+6CrCJJI9fU8oWjmRSjY4SK9 PJSSBFmT9xQT8xHKu2d43EuVEb0eRCxHXp0zS+FO2jTBzzsDbzJAJ24qX7Wr6k2d0uzmjbLZWKm NUEWMuYn6Gtek/sRt4W/oZyPiht5BBz5BA3ciW6XbINk7NqjmsvFQggR0zMnh4Pphv X-Received: by 2002:a17:903:9cf:b0:2a0:8ca7:69de with SMTP id d9443c01a7336-2ad74540793mr68899235ad.41.1771815957390; Sun, 22 Feb 2026 19:05:57 -0800 (PST) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad750591e2sm56676485ad.91.2026.02.22.19.05.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 19:05:56 -0800 (PST) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Arend van Spriel , brcm80211@lists.linux.dev (open list:BROADCOM BRCM80211 IEEE802.11 WIRELESS DRIVERS), brcm80211-dev-list.pdl@broadcom.com (open list:BROADCOM BRCM80211 IEEE802.11 WIRELESS DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH wireless-next] wifi: brcmsmac: use FAM for debug code Date: Sun, 22 Feb 2026 19:05:39 -0800 Message-ID: <20260223030539.19307-1-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Debug code requires a separate allocation to duplicate a string. A FAM allows properly sized allocation with a single kfree. Signed-off-by: Rosen Penev --- .../broadcom/brcm80211/brcmsmac/mac80211_if.c | 15 +++++---------- .../broadcom/brcm80211/brcmsmac/mac80211_if.h | 2 +- 2 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c= b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c index aadcff1e2b5d..87b636273b3f 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c @@ -317,9 +317,6 @@ static void brcms_free(struct brcms_info *wl) /* free timers */ for (t =3D wl->timers; t; t =3D next) { next =3D t->next; -#ifdef DEBUG - kfree(t->name); -#endif kfree(t); } } @@ -1499,7 +1496,11 @@ struct brcms_timer *brcms_init_timer(struct brcms_in= fo *wl, { struct brcms_timer *t; +#ifdef DEBUG + t =3D kzalloc(struct_size(t, name, strlen(name) + 1), GFP_ATOMIC); +#else t =3D kzalloc(sizeof(*t), GFP_ATOMIC); +#endif if (!t) return NULL; @@ -1511,7 +1512,7 @@ struct brcms_timer *brcms_init_timer(struct brcms_inf= o *wl, wl->timers =3D t; #ifdef DEBUG - t->name =3D kstrdup(name, GFP_ATOMIC); + strcpy(t->name, name); #endif return t; @@ -1574,9 +1575,6 @@ void brcms_free_timer(struct brcms_timer *t) if (wl->timers =3D=3D t) { wl->timers =3D wl->timers->next; -#ifdef DEBUG - kfree(t->name); -#endif kfree(t); return; @@ -1586,9 +1584,6 @@ void brcms_free_timer(struct brcms_timer *t) while (tmp) { if (tmp->next =3D=3D t) { tmp->next =3D t->next; -#ifdef DEBUG - kfree(t->name); -#endif kfree(t); return; } diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.h= b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.h index eaf926a96a88..8ef6d657e487 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.h @@ -43,7 +43,7 @@ struct brcms_timer { bool set; /* indicates if timer is active */ struct brcms_timer *next; /* for freeing on unload */ #ifdef DEBUG - char *name; /* Description of the timer */ + char name[]; /* Description of the timer */ #endif }; -- 2.53.0