From nobody Fri Apr 17 07:44:18 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E025A2F851 for ; Sun, 22 Feb 2026 18:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771784681; cv=none; b=UeOciQFEhn8I/6DwGWwkmOxq57+bhYYab9tFdaZ2b0r3nhRAhqD8VTIwJepZcq5Q2OyDB5S2xF0oCtWnKYdTPgHmd+rSNfXzNSf2MxEaF2D5NJE70x8ARaaRt/bh9LcJpce0+ZYu61xN0DvDzn54PQJEVE5pBhrNRC/ur13Z8vA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771784681; c=relaxed/simple; bh=i93NP6QYfj+ybZpEhaphKCnCCgbg1xiHxnblnb3wK/A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=iTLzuECPUsg6/ZTZExQ6Urx9ganeeswg9yUVk8/EOLpqNSUzrWNowp0BhNR5VVEN89v1gLOkfok130+77GtaD7mHZQMIhskFsnKpm+eXGrHcKY+CL6FolUbNWKoIhXVjG+alfkN5Kvm7koLjW0LegRdgNWSJ5psAmMSO0nSEySQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EWJrV/b0; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EWJrV/b0" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-35621aa8c7fso1966835a91.2 for ; Sun, 22 Feb 2026 10:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771784679; x=1772389479; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=KHK7FCGl4BnguL8Rj0NYb8fv6cd9/u3eM4GUsmt3U7A=; b=EWJrV/b05eiK/S+QPRj824lixHsrsf5p4lH5ckavy4KeuSqyi/+dxhCVtPCn6Bt5CC U4inF9Z5Bq32VHt7YX0sgXSlxwAqzYZ/2iNuK8WA0ASMrwWY3DONKDT8CSRH3gK3/SB0 +74dSbKk3bOhSR2wyu5w5QSJexvPRraxAt6ys5l4tVQu7kAyzeVSu8P+NaIeZk0sv/N7 wLMOWNAZJZ/JHnjZx+YmpzeaSpv4VBXgw4kmFk7LnTN6lPLZiBvXiQXIp8iOeKYa0xjD ypP1dt4dbXFjBZKc3OnGwV86d3x/8DCFkFgKNnyWHCOLW1NmPv2o5cppMJk6w0FA6FMH VZ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771784679; x=1772389479; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KHK7FCGl4BnguL8Rj0NYb8fv6cd9/u3eM4GUsmt3U7A=; b=m9ZzpJ8B0Zy6kplZeCJCnQel0TCKgVAcYKG/Io/aCFvsg5Fdg2Jqux7aGFl75h7w9F SHqyn2Q8CKDrK8OJRCT6JMWT1XxFy+TCzpB5hheP+iVShukCNQ9nCJH31LEDW2dJ7BVK Oc6P/98ikElyBF66l0+o7VSThHNkFh4evTWQvLR9OcGpVN8kJjK8AOcOCQsm/2/XQkzW 5WGTfZ7ivZiyWcDlolb0C2prXUZvyePa8b+e0OP3BvkpM5B8p4QVqI+hQhvJO/U4s5x0 e6huYH3t0TqOvpNrb3h9WmAF7ifXXW/OdTgfMNAvc2142uL4i5mh1HGSI95BrrYAiKTr UE3A== X-Gm-Message-State: AOJu0Yy/Dj90f8Uu8/QAzzqhb54egg4xu/ZitR9s8YxBYsY7wNW5D2+r Ez7RIWPT6fLBikQxlKdcPAWXg1T1HIAFF4mVOwG93ID7MZbPRyC2xqgkdO4G09sY X-Gm-Gg: AZuq6aKhvvNs5NUxvcxIaZNGiti8AMWSiwX3arIc+ApzDVKgxpo7EJKfIIYGxyvIYws TTwT3fz7VXvCzuuBq8U/9nxhWM2To/SHDVu5YLtcrUKltX9w5JtIAQhAoAv85uPsV8Co3kTYAEO iRHICmh9izZBhwJFG1jeI56/EcCfCq9opfpE3mGql7LFcot7HbjLSZMcSxA0PVrlksEVTHgoYvN BUOwvHBfqbl8V9sGvvGUWgqSQLZSXpPAtAH/LnhqqJc5oYW9sYoiv/ByVYC96AxI7u4UDRe+eQ0 N1Cv06Sx7a2lw4PqJQq7LiIdHYU9prKBafNWukP+M8ekhr9r5Df8RGMokw91QHPK+FKEBVjDz/i itXQLXZ0uQwLScls6P/vT32DgosQMFEQPPQFutFKfhLL6Nbt685qmuAZJPpI9pC4JSppnUNwlxO V/a/G9xBW8K90YkWLsOqeWMJjPUVp6eyot9Q== X-Received: by 2002:a17:90b:3ccd:b0:34c:35ce:3c5f with SMTP id 98e67ed59e1d1-358ae7c960cmr4676492a91.5.1771784679131; Sun, 22 Feb 2026 10:24:39 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:1:8bf1:8197:6d5f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3589d8e3edcsm8393549a91.13.2026.02.22.10.24.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 10:24:38 -0800 (PST) From: Felix Gu Date: Mon, 23 Feb 2026 02:24:34 +0800 Subject: [PATCH] regulator: mt6363: Fix incorrect and redundant IRQ disposal in probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260223-mt6363-v1-1-c99a2e8ac621@gmail.com> X-B4-Tracking: v=1; b=H4sIAOFJm2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDIyNj3dwSM2MzY10Dg+RkEwOzREPD1GQloOKCotS0zAqwQdGxtbUAcyt 9CFgAAAA= X-Change-ID: 20260223-mt6363-00cc406a11ec To: Liam Girdwood , Mark Brown , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771784676; l=1500; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=i93NP6QYfj+ybZpEhaphKCnCCgbg1xiHxnblnb3wK/A=; b=Z2IFGz9lFdw34b1ycUw1uJQ1YaF0x1uytXWzC5R46Rdq8PrLz81oxaOdnmTI1gqQ/CGZhh070 +hS2pHn0F53CP/TCOHaGHDBRonIlYjShXyrnVxPJyTD8F5tCYAWoR8K X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In mt6363_regulator_probe(), devm_add_action_or_reset() is used to automatically dispose of the IRQ mapping if the probe fails or the device is removed. The manual call to irq_dispose_mapping() in the error path was redundant as the reset action already triggers mt6363_irq_remove(). Furthermore, the manual call incorrectly passed the hardware IRQ number (info->hwirq) instead of the virtual IRQ mapping (info->virq). Remove the redundant and incorrect manual disposal. Fixes: 3c36965df808 ("regulator: Add support for MediaTek MT6363 SPMI PMIC = Regulators") Signed-off-by: Felix Gu --- drivers/regulator/mt6363-regulator.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/regulator/mt6363-regulator.c b/drivers/regulator/mt636= 3-regulator.c index 03af5fa53600..0aebcbda0a19 100644 --- a/drivers/regulator/mt6363-regulator.c +++ b/drivers/regulator/mt6363-regulator.c @@ -899,10 +899,8 @@ static int mt6363_regulator_probe(struct platform_devi= ce *pdev) "Failed to map IRQ%d\n", info->hwirq); =20 ret =3D devm_add_action_or_reset(dev, mt6363_irq_remove, &info->virq); - if (ret) { - irq_dispose_mapping(info->hwirq); + if (ret) return ret; - } =20 config.driver_data =3D info; INIT_DELAYED_WORK(&info->oc_work, mt6363_oc_irq_enable_work); --- base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6 change-id: 20260223-mt6363-00cc406a11ec Best regards, --=20 Felix Gu