From nobody Fri Apr 17 07:44:01 2026 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F58134AAEA for ; Mon, 23 Feb 2026 08:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771833822; cv=none; b=YeVkVNzCpPeCSV1HxUrOyUyickPEc1cIDJQ2COa9RMcgc+2H76206I+F2OYAko4ty70cKlK7lHPv6PAwCVWBkdl7IG27CDTjnHtzYOTZxygD7Drlq8mi/RcI1Qs3ZjEvuMBEES9iOi+QChJRrMGjX86N0czmzQB07ve0g3vemQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771833822; c=relaxed/simple; bh=JQRBVo2ep5z8a2QhtECu2GO87aKrVztQ/+OOGVjVxIU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=EDkMy6lfH/i2XhRd/W8nmDUv7ZW2BXMyTDggmcg9V3VVxEMvbFhUfz1hiMfQ8VbTLTbN/hNK3jp767WsYREv5CbtxTJsbUdRYXA7e/dzLDnhVAGIvgsvWrtBguXTFlxMLB8MjgTxJl5lNWN05C8GYsZvwdUjFwA5raR0a3GzGq8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UyZuWyrZ; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UyZuWyrZ" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2a7a9b8ed69so35688835ad.2 for ; Mon, 23 Feb 2026 00:03:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771833820; x=1772438620; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=208yj0wO16cY+IBYbY4vtJGd8DAsVL59TpfoOHdonDQ=; b=UyZuWyrZQeqObJ7Q43hVNLG0LpDzTFAL3K3Bs4xmu8SjFH3FAHjfaHsugUikaInCTi gvZ3g0C8pkJ+BaFBXlVBPUrGR68EEJad0YgnP9Xeluw2+kyP3mIxc1LrOYTSFSxnUmHL deaqX0FNHej1QW6Lnlqp4IsHjE5FA4ysXDe657tQ5DsVFTWlGpnVoRhf3lseM6MOE5d9 eC1RhJkmc2HLH2RWYFE78wyQbGjF1ot5W0BZhEzmSKJEQJOoyo/O4IBY3RAaSF92PTPJ 6GL7sKXqUT/klMFzCg0ghX6SnbQaFKmXtW5FSz6Vi6eUu9Yxqck8o8aAht4STV1juq1n H0xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771833820; x=1772438620; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=208yj0wO16cY+IBYbY4vtJGd8DAsVL59TpfoOHdonDQ=; b=oeZvXutgzbnfZVuugYlr3b/wfXbMlJSc+qc0GDVKvXY9QY3RcUVeOGBC3jNlE44n1Y YnmKKgPtFofSZtQvtoqZbz/V5UOyuI5E9XX+zz+R+1YOjbxcjkLUisiZTcMt/eET/2O3 pXCr8eZGj7evP/3KyYnuQYhM/8zER7OP6951ojrugAR6f24vA+ButgEyxHgumHKf+Ycp tUJwBG8Ltfy7WD4Q9EfkdQ9b4oePwRVHlSOCZAZGyPAFtbNrGK1TXC2mBqcWlb83JiNU IRgVLKR0uO42agp9Kheu9/1FlojvFJI3O1eNo717Yua6xlu7AL4XVU5DGy6sObuMPR60 wKUQ== X-Forwarded-Encrypted: i=1; AJvYcCXg9j+auinX4A6qT0IGJIWYHEnebQpT1bvx3uplnizuN5+BvVqih2l/k0vEMt7+/YebJMP66pSPZi0LajQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxQasSm7ZLyFaxFSpGUQXjxORmyZr9xB8zerawC++fpMbJYVJxc pFtW4wgC19W4CJhmhxVUfwhLJfd/GDU+XbSoTUMgUoUdEnHEcliiSnu8 X-Gm-Gg: ATEYQzwUb69qgIMx8GXABg569XfegYMTv6AuE+KXtZX2Yl//91ZmSoH7PqITgVRFfnn iSutMVY0kvU7RTYRCYspLrWcnUkvNLr98aaxnnTjNnPExE+3HVWVK6oET3EAhRniT4JgfAcj663 kEGfvVgyvq5xIYWAljRYRkppy9/SyOJ6yhqulT7ggeFJxBOWw6+gy1/3rdC3aXd+HL8+nF2zo08 rRrxLz+eooaVATz3/QDgfb4RoZMUAQeu9kjti9h5MsUIqYUBZVxr7V4ac9kKN4JmuSExQcXGjrD Y4AMu0hwi8nKtfwcn5svktyel1h+ksK+yeTkYN+r4AiPkVoE0hvLECyk6Zmk+XM0Yaf8xkGw3F1 i/kCBA6QCAVC2EUjSbFQDU4ogh8GI5v7SOn4fV/+FBE+ruTVIv8hhdYv/FBQzw2FJYm6g1o65IN 0LQ72Gms581nPUCc8dL9w+qZ0+8u5wzHy6RGJHeA== X-Received: by 2002:a17:903:41cc:b0:2aa:dad4:d351 with SMTP id d9443c01a7336-2ad74562664mr78015875ad.53.1771833819671; Mon, 23 Feb 2026 00:03:39 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:1cfe:ae34:fdd6:6b97]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad7500e189sm65710615ad.57.2026.02.23.00.03.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 00:03:39 -0800 (PST) From: Felix Gu Date: Mon, 23 Feb 2026 16:03:34 +0800 Subject: [PATCH] iio: dac: mcp47feb02: Fix mutex used before initialization Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260223-mcp47feb02-v1-1-41f80bdbbb45@gmail.com> X-B4-Tracking: v=1; b=H4sIANUJnGkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDIyNj3dzkAhPztNQkAyPdVIOk1BRD81RDS4skJaCGgqLUtMwKsGHRsbW 1AKYHn69cAAAA X-Change-ID: 20260223-mcp47feb02-e0bed17e198b To: Ariana Lazar , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771833816; l=1334; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=JQRBVo2ep5z8a2QhtECu2GO87aKrVztQ/+OOGVjVxIU=; b=m5lrOfYwiYeYjvaMRjjK/ewwnurijle+QUAnsoVxXzRG+Z7jNd5GvEJWGRDYKgWtyuuO+PWYc L/L8EqIrcN2DyDL3rw4MSCyxifaBw3E6064i1/o1/DyPeU09BXugn17 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The mcp47feb02_parse_fw() function uses data->lock, but the mutex was initialized after this function in probe path. Fix this by moving devm_mutex_init() before mcp47feb02_parse_fw(). Fixes: bf394cc80369 ("iio: dac: adding support for Microchip MCP47FEB02") Signed-off-by: Felix Gu --- drivers/iio/dac/mcp47feb02.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/iio/dac/mcp47feb02.c b/drivers/iio/dac/mcp47feb02.c index b218f0c3a0bd..4ff5abcfecea 100644 --- a/drivers/iio/dac/mcp47feb02.c +++ b/drivers/iio/dac/mcp47feb02.c @@ -1131,14 +1131,14 @@ static int mcp47feb02_probe(struct i2c_client *clie= nt) =20 indio_dev->name =3D chip_features->name; =20 - ret =3D mcp47feb02_parse_fw(indio_dev, chip_features); - if (ret) - return dev_err_probe(dev, ret, "Error parsing firmware data\n"); - ret =3D devm_mutex_init(dev, &data->lock); if (ret) return ret; =20 + ret =3D mcp47feb02_parse_fw(indio_dev, chip_features); + if (ret) + return dev_err_probe(dev, ret, "Error parsing firmware data\n"); + ret =3D devm_regulator_get_enable_read_voltage(dev, "vdd"); if (ret < 0) return ret; --- base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6 change-id: 20260223-mcp47feb02-e0bed17e198b Best regards, --=20 Felix Gu