From nobody Fri Apr 3 02:59:58 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5FF27144B; Mon, 23 Feb 2026 14:57:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771858626; cv=none; b=tx69CbjcrLF2Rn3dHdMArBkXU9HdNvW89CEMPzeA2kgmpKnBf25v0Co/J5tY73G3syrVa8mw1Up2cUDUDiuBZZ5Js7i+bwltoU8gx6aFb4rqpxmALUloUWbASpqLsvYfLrkxToPUhmgdRuw0hU/j29ySnZS36d5G0gZZWod3kkM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771858626; c=relaxed/simple; bh=0QkG7IXYCVY7+kXNdqi/xvny/8zHAyZSF7ImhneqUvM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=WgwiEydSqRJBtAA8qY0XN0oAZLJZeOjdYZHP4OLcqEhMHVjxI5vhN7nOvDrSDws9bhCamQ9KfTfKzYWYUyKmiAzpnYViZKZHpXdqFxvEY9pOGFSxUmxyx6qOyCv3TQy1iNALURrN39eF7RWbyQwkgr8sE4i3s2IgaDt9rgFJ2qk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AMjFkSTk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AMjFkSTk" Received: by smtp.kernel.org (Postfix) with ESMTPS id 43863C116C6; Mon, 23 Feb 2026 14:57:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771858626; bh=0QkG7IXYCVY7+kXNdqi/xvny/8zHAyZSF7ImhneqUvM=; h=From:Date:Subject:To:Cc:Reply-To:From; b=AMjFkSTkrSanhesNmQ7LN96u9B4gaJtWkbpgjNowXVJOGM2L5qYuL3kqvBTeqozZd aaMiNGugn4+Le2W0LAAeWuEPdcM/69jjWyOCoAuAwW79yaUN8eD37UpJzoZ9aYJ33z dAkX3Ot2BMJKchYfxtLNGWtOSWKuwXbJJAHKnRUUuWX1Le3qvzVHMpvBRqrx37r7aN I2KuBRgDAbJzTBmj/gmvpgaJaqD+Xuon29y9jNzEr0Hlv33D1Ka4znRK1AnX6S5RgW fqXr+RfXe16T3rO1M0+U94cDAyaIwTxYUOVtiBqQy18AKKltYYjHJY0K6Sl8pOCilm jdMtYvMZGnGmA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F47CEA4FCE; Mon, 23 Feb 2026 14:57:06 +0000 (UTC) From: Dmitry Safonov via B4 Relay Date: Mon, 23 Feb 2026 14:56:57 +0000 Subject: [PATCH v5] ima_fs: Avoid creating measurement lists for unsupported hash algos Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260223-ima-oob-v5-1-91cc1064e767@arista.com> X-B4-Tracking: v=1; b=H4sIALhqnGkC/3XNSw6CMBgE4KuQrq3pCyiuvIdx8fclXUBNSxoN4 e627AxhOcl8MytKNnqb0K1ZUbTZJx/mEtpLg/QI88tib0pGjLCOUNZjPwEOQeHBgeTQcWF6hUr 7Ha3zn33p8SxZQbJYRZj1WP0EabGxFkeflhC/+2OmtX4czxRTzIxgjgsqbdvfIRYGVx0mVNczO 4GsQMclUKllS7Q7QH4CeYHUGDI4oRl0cIDiBIoClSPa9G5Qwog/uG3bD4rTvItjAQAA X-Change-ID: 20260127-ima-oob-9fa83a634d7b To: Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , Silvia Sisinni , Enrico Bravi Cc: Jonathan McDowell , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Dmitry Safonov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771858625; l=7264; i=dima@arista.com; s=20250521; h=from:subject:message-id; bh=1zfQNwMpVQJJaErTAqhxb6R+h8DyzMNUh2coTShYYwI=; b=nhQathIFcET8SfpfXIav3K2AOzBW6ism7bQXCJsUkL79MmyGOx2g3SREXbaG8SA6L98h6xupL DYdLNLtOFVNAWW9by0sqNAxU3d/NPNweGe3GN8KQ8zKG/pLhT8WPQuH X-Developer-Key: i=dima@arista.com; a=ed25519; pk=/z94x2T59rICwjRqYvDsBe0MkpbkkdYrSW2J1G2gIcU= X-Endpoint-Received: by B4 Relay for dima@arista.com/20250521 with auth_id=405 X-Original-From: Dmitry Safonov Reply-To: dima@arista.com From: Dmitry Safonov ima_tpm_chip->allocated_banks[i].crypto_id is initialized to HASH_ALGO__LAST if the TPM algorithm is not supported. However there are places relying on the algorithm to be valid because it is accessed by hash_algo_name[]. On 6.12.40 I observe the following read out-of-bounds in hash_algo_name: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D BUG: KASAN: global-out-of-bounds in create_securityfs_measurement_lists+0= x396/0x440 Read of size 8 at addr ffffffff83e18138 by task swapper/0/1 CPU: 4 UID: 0 PID: 1 Comm: swapper/0 Not tainted 6.12.40 #3 Call Trace: dump_stack_lvl+0x61/0x90 print_report+0xc4/0x580 ? kasan_addr_to_slab+0x26/0x80 ? create_securityfs_measurement_lists+0x396/0x440 kasan_report+0xc2/0x100 ? create_securityfs_measurement_lists+0x396/0x440 create_securityfs_measurement_lists+0x396/0x440 ima_fs_init+0xa3/0x300 ima_init+0x7d/0xd0 init_ima+0x28/0x100 do_one_initcall+0xa6/0x3e0 kernel_init_freeable+0x455/0x740 kernel_init+0x24/0x1d0 ret_from_fork+0x38/0x80 ret_from_fork_asm+0x11/0x20 The buggy address belongs to the variable: hash_algo_name+0xb8/0x420 Memory state around the buggy address: ffffffff83e18000: 00 01 f9 f9 f9 f9 f9 f9 00 01 f9 f9 f9 f9 f9 f9 ffffffff83e18080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >ffffffff83e18100: 00 00 00 00 00 00 00 f9 f9 f9 f9 f9 00 05 f9 f9 ^ ffffffff83e18180: f9 f9 f9 f9 00 00 00 00 00 00 00 04 f9 f9 f9 f9 ffffffff83e18200: 00 00 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 f9 f9 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Seems like the TPM chip supports sha3_256, which isn't yet in tpm_algorithms: tpm tpm0: TPM with unsupported bank algorithm 0x0027 Thus solve the problem by creating a file name with "_tpm_alg_" postfix if the crypto algorithm isn't initialized. This is how it looks on the test machine (patch ported to v6.12 release): # ls -1 /sys/kernel/security/ima/ ascii_runtime_measurements ascii_runtime_measurements_tpm_alg_27 ascii_runtime_measurements_sha1 ascii_runtime_measurements_sha256 binary_runtime_measurements binary_runtime_measurements_tpm_alg_27 binary_runtime_measurements_sha1 binary_runtime_measurements_sha256 policy runtime_measurements_count violations Fixes: 9fa8e7625008 ("ima: add crypto agility support for template-hash alg= orithm") Signed-off-by: Dmitry Safonov Cc: Enrico Bravi Cc: Silvia Sisinni Cc: Roberto Sassu Cc: Mimi Zohar --- Changes in v5: - Use lower-case for sysfs file name (as suggested-by Jonathan and Roberto) - Don't use email quotes for patch description (Roberto) - Re-word the patch description (suggested-by Roberto) - Link to v4: https://lore.kernel.org/r/20260127-ima-oob-v4-1-bf0cd7f9b4d4@= arista.com Changes in v4: - Use ima_tpm_chip->allocated_banks[algo_idx].digest_size instead of hash_d= igest_size[algo] (Roberto Sassu) - Link to v3: https://lore.kernel.org/r/20260127-ima-oob-v3-1-1dd09f4c2a6a@= arista.com Testing note: I test it on v6.12.40 kernel backport, which slightly differs= as lookup_template_data_hash_algo() was yet present. Changes in v3: - Now fix the spelling *for real* (sorry, messed it up in v2) - Link to v2: https://lore.kernel.org/r/20260127-ima-oob-v2-1-f38a18c850cf@= arista.com Changes in v2: - Instead of skipping unknown algorithms, add files under their TPM_ALG_ID = (Roberto Sassu) - Fix spelling (Roberto Sassu) - Copy @stable on the fix - Link to v1: https://lore.kernel.org/r/20260127-ima-oob-v1-1-2d42f3418e57@= arista.com --- security/integrity/ima/ima_fs.c | 34 ++++++++++++++++++---------------- 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/security/integrity/ima/ima_fs.c b/security/integrity/ima/ima_f= s.c index 012a58959ff0..3d9996ed486d 100644 --- a/security/integrity/ima/ima_fs.c +++ b/security/integrity/ima/ima_fs.c @@ -132,16 +132,12 @@ int ima_measurements_show(struct seq_file *m, void *v) char *template_name; u32 pcr, namelen, template_data_len; /* temporary fields */ bool is_ima_template =3D false; - enum hash_algo algo; int i, algo_idx; =20 algo_idx =3D ima_sha1_idx; - algo =3D HASH_ALGO_SHA1; =20 - if (m->file !=3D NULL) { + if (m->file !=3D NULL) algo_idx =3D (unsigned long)file_inode(m->file)->i_private; - algo =3D ima_algo_array[algo_idx].algo; - } =20 /* get entry */ e =3D qe->entry; @@ -160,7 +156,8 @@ int ima_measurements_show(struct seq_file *m, void *v) ima_putc(m, &pcr, sizeof(e->pcr)); =20 /* 2nd: template digest */ - ima_putc(m, e->digests[algo_idx].digest, hash_digest_size[algo]); + ima_putc(m, e->digests[algo_idx].digest, + ima_tpm_chip->allocated_banks[algo_idx].digest_size); =20 /* 3rd: template name size */ namelen =3D !ima_canonical_fmt ? strlen(template_name) : @@ -229,16 +226,12 @@ static int ima_ascii_measurements_show(struct seq_fil= e *m, void *v) struct ima_queue_entry *qe =3D v; struct ima_template_entry *e; char *template_name; - enum hash_algo algo; int i, algo_idx; =20 algo_idx =3D ima_sha1_idx; - algo =3D HASH_ALGO_SHA1; =20 - if (m->file !=3D NULL) { + if (m->file !=3D NULL) algo_idx =3D (unsigned long)file_inode(m->file)->i_private; - algo =3D ima_algo_array[algo_idx].algo; - } =20 /* get entry */ e =3D qe->entry; @@ -252,7 +245,8 @@ static int ima_ascii_measurements_show(struct seq_file = *m, void *v) seq_printf(m, "%2d ", e->pcr); =20 /* 2nd: template hash */ - ima_print_digest(m, e->digests[algo_idx].digest, hash_digest_size[algo]); + ima_print_digest(m, e->digests[algo_idx].digest, + ima_tpm_chip->allocated_banks[algo_idx].digest_size); =20 /* 3th: template name */ seq_printf(m, " %s", template_name); @@ -404,16 +398,24 @@ static int __init create_securityfs_measurement_lists= (void) char file_name[NAME_MAX + 1]; struct dentry *dentry; =20 - sprintf(file_name, "ascii_runtime_measurements_%s", - hash_algo_name[algo]); + if (algo =3D=3D HASH_ALGO__LAST) + sprintf(file_name, "ascii_runtime_measurements_tpm_alg_%x", + ima_tpm_chip->allocated_banks[i].alg_id); + else + sprintf(file_name, "ascii_runtime_measurements_%s", + hash_algo_name[algo]); dentry =3D securityfs_create_file(file_name, S_IRUSR | S_IRGRP, ima_dir, (void *)(uintptr_t)i, &ima_ascii_measurements_ops); if (IS_ERR(dentry)) return PTR_ERR(dentry); =20 - sprintf(file_name, "binary_runtime_measurements_%s", - hash_algo_name[algo]); + if (algo =3D=3D HASH_ALGO__LAST) + sprintf(file_name, "binary_runtime_measurements_tpm_alg_%x", + ima_tpm_chip->allocated_banks[i].alg_id); + else + sprintf(file_name, "binary_runtime_measurements_%s", + hash_algo_name[algo]); dentry =3D securityfs_create_file(file_name, S_IRUSR | S_IRGRP, ima_dir, (void *)(uintptr_t)i, &ima_measurements_ops); --- base-commit: 6de23f81a5e08be8fbf5e8d7e9febc72a5b5f27f change-id: 20260127-ima-oob-9fa83a634d7b Best regards, --=20 Dmitry Safonov