From nobody Sun Apr 5 19:43:23 2026 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFD64354AE3 for ; Mon, 23 Feb 2026 14:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771857235; cv=none; b=q/lW/B9L/QURBCWsNoI+35msQzxUyM/opu/niBCYafSRb1B2x/0zB+eH3KsLu2z58BAH3GCu8c/jIMYHWpj+2k6/SF3e9cYmjBNwTjRkLNyz+IkED6ErHIrUYYi4cTP/lsCncoLcVs2pUhlcBdqS4oEI6QXxjZZVBz8UvCeCzqQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771857235; c=relaxed/simple; bh=ZEEqeaCS8i/fQh/ydJoSPQSgfBIk2Lb7weS4NuofoIc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JiC5BzrRdz6GGWtk1gokugdvhY40ITQPS2ENeso3kFpEXPzi+nDyYUy+3e6/S34lrH0/AL3vM/pXLHUj/Y0m7lOzxDS5ZikScd3wv7ZJzayivCpnOqVOycgsOttVQ4xVNbH04pFWWHthCeSwDR3fNPZOi+GvfuB1EmCSFAxCBMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Yz6CTIor; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yz6CTIor" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-59de66fda55so4933132e87.3 for ; Mon, 23 Feb 2026 06:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771857232; x=1772462032; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=NlHpayBYcqc/iH584SrkLhfCupAvJIo+BPnQtA6Sgno=; b=Yz6CTIorcgR/lnCcZ8EEnN5cEh9gOtAUQvzhgnrWQw2IcjNe9qFupSvhQXoDSE9Tv5 WMxGAHUTjSsFc+Cu1s27JhKqvmYouKNxDShCOCtzNvL0fxrkoYRPvYu8OFTK12ut1aeF MOojGsQbtjk8sXebZt87BYKm7q4uZiEnVz0KDivQIHZ8jKPT9e53xoBDpxP/fmYnwiWT 9KZE88MnIthRZRthbxiKCyAHGtJudduol5zUzgcoqvKygKzp6PrJ+BkgmxSHQvyRSYOQ u4LI7CQoEeoQtghys8szUZZp4/Pc+vAq7iFYDG991UrSYBpuXqffYpgh8FiJU/kCoPJC NOlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771857232; x=1772462032; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NlHpayBYcqc/iH584SrkLhfCupAvJIo+BPnQtA6Sgno=; b=aE49qO82qmus5wUZHsjCDPfnle5cTZV7ejHW2sbEF5WKFbMo/K8RZR4NxZUX48Mrg1 SERxbOrxlaaJOMNUzhPysTgtC5e9GQOWc9bldSzcNAP3ya01FsMhmNKHgafD/jjcf53K tQ5LDIRsvlyG2lXfT+SH01XFM9opiagi8/NbYUEUUpBbMwwFTQgHlJJNYsdiUR6Wz36y 7t0Uh84HyVvRGCWb3iDDfJ0vMTJ4PmT38Z4PE8bJAQkEzz1sILXKQx9FRDv80UKew6In WqhozkYT5rOkYpTBMSROxNNpApp6ClCP8AMffvoRY0gn381jIQx2AQ1RGexB94AYZcsC a+iQ== X-Forwarded-Encrypted: i=1; AJvYcCVST9vVqRfFozjY1rZrTGGORYOh+8JVwiOEjGrelEwxFTmlZPqq+97SYzMeDnDFz2XfxFPHZ6QBZPab1gg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmr39CuQIbQBmAinYDOy2i093BSQiUBDawRqNJWfPUTzEvo+cM fZU2DS/iJ7+wYLUurC47HutgBiVaiNHd8FzKugzLh7BiL/NHF3PXLoTa X-Gm-Gg: AZuq6aLMJUBbiGbs57HJsItrbs2YyUQcKQ2RK1GV6M6xA7hzRRJ6EtW6m6p/VHCh0XY 1ixFPDugHUZXNdqP911Gg8PqkV41Dttqwkst2Ft6P7uS5Ol+5TvGWqMIoj/gV4h5bCAv0XIso4C FRN2PGjh/uepaNTEn56jJxNEquFTZmXGrwwKemv3cxHZU3I43zDYr6eHbVp1XWRkvSJES8VANoq 9srJ0NhwStcy6PNVS9oWY0oscim8/2crYPC43o3bWvT/Lh784pCPVbfpH59d9j0V+/be/cDG8ZQ f7sMrwIfLzGsj/5iCoi3BWBApxLwKGGdvMRqyABHCFlEsWTc0+iRDm3X1hORNQ1ILQudrqbzB4/ VeLRJ29yyS4YRyg2fszkE9HOedPXoV7VLRh6fY/6M3mad8bMQiOaanDEvDjTjqiNYi0zYZB6Jds rTKINIbSRXSmcmOsrn3ISnfe5kQpOgJVV+ACFnTb7AGscdCR0UVi7EuEST9RTg9tIdU+vdiZOyg pujs64= X-Received: by 2002:a05:6512:b05:b0:59f:71b7:4850 with SMTP id 2adb3069b0e04-5a0ed9b12a2mr2729556e87.49.1771857232010; Mon, 23 Feb 2026 06:33:52 -0800 (PST) Received: from [192.168.1.135] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a0eeb16344sm1631709e87.37.2026.02.23.06.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 06:33:50 -0800 (PST) From: Marcus Folkesson Date: Mon, 23 Feb 2026 15:33:52 +0100 Subject: [PATCH v7 3/5] i2c: davinci: calculate bus freq from Hz instead of kHz Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260223-i2c-mux-v7-3-ec75b214718a@gmail.com> References: <20260223-i2c-mux-v7-0-ec75b214718a@gmail.com> In-Reply-To: <20260223-i2c-mux-v7-0-ec75b214718a@gmail.com> To: Wolfram Sang , Peter Rosin , Michael Hennerich , Bartosz Golaszewski , Andi Shyti , Andy Shevchenko , Bartosz Golaszewski Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marcus Folkesson , Bartosz Golaszewski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2864; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=ZEEqeaCS8i/fQh/ydJoSPQSgfBIk2Lb7weS4NuofoIc=; b=owEBbQKS/ZANAwAKAYiATm9ZXVIyAcsmYgBpnGVdlhV+iSt5NluQ7dVjtjXvoIJaeUg0f+eo0 AqUwP+2YXiJAjMEAAEKAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCaZxlXQAKCRCIgE5vWV1S MmINEAC5kZvmViAk8BONTPcbB5SK2etSLrO/aaqbtq9S801JoBGC+bUGSqLUbTRFbjMEbU7lXDs e9lj5kcKnupgjtUm2s33OJv0jnNeoAM/A7nk4485z35RDLF3DKJ1Ys2Fuk5jZnf5mHnFEjR0Rx3 d2CakuaiCutPI8iEbaeKnivoiXYEZi45aCE1CIKoCN3OnWZa9KEPGOoxORg8x1/ZXNgDpF3FvNi 4Tkm+CYfcA/jCfxe0FUv8me8RuZkqCi5mTr9pAk8NUMTelNOhdQQst6u3pCc/w6xYkxzCVrDcMo 5lJFYyRpbbB4Uz+THhyTK4S6mRG7s+uku57/IzsfZDuuIcs/D0TpOu9OSfXO7OKyR2+c8u6PwoW wm5D9MpHBXpsHpSOU/EIvStAyo6jUWG0tovc+BORJwrc7fraWfj9AQENmNv/Nr0HofHVoap7TwO VoxOcShSKptyQjOburpGIFXjTXtKXThbTiMkRIsodWdV2vOslifczyEYbpFraopHfgaydkIUTlA rPqy6ndq0hAExeJDrhl9V4vCEUrZRWWxBO95IxhDhT04bPqPGH2yNE31w5Fr6/i/Pa04FtoKNg+ OfWAWsV7DcHhaDYRPh4xnCG/OnGZd5PfsPEpikLYVS9DXiDeP68fcD39sZ0K1d2zdSwJ7nU8qt5 yWtGr1duEV6RazA== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 The bus frequency is unnecessarily converted between Hz and kHz in several places. This is probably an old legacy from the old times (pre-devicetrees) when the davinci_i2c_platform_data took the bus_freq in kHz. Stick to Hz. Reviewed-by: Bartosz Golaszewski Signed-off-by: Marcus Folkesson --- drivers/i2c/busses/i2c-davinci.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davi= nci.c index a773ba082321..a2b578e0a534 100644 --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -117,8 +117,6 @@ /* timeout for pm runtime autosuspend */ #define DAVINCI_I2C_PM_TIMEOUT 1000 /* ms */ =20 -#define DAVINCI_I2C_DEFAULT_BUS_FREQ 100 - struct davinci_i2c_dev { struct device *dev; void __iomem *base; @@ -134,8 +132,8 @@ struct davinci_i2c_dev { #ifdef CONFIG_CPU_FREQ struct notifier_block freq_transition; #endif - /* standard bus frequency (kHz) */ - unsigned int bus_freq; + /* standard bus frequency */ + unsigned int bus_freq_hz; /* Chip has a ICPFUNC register */ bool has_pfunc; }; @@ -209,16 +207,16 @@ static void i2c_davinci_calc_clk_dividers(struct davi= nci_i2c_dev *dev) if (device_is_compatible(dev->dev, "ti,keystone-i2c")) d =3D 6; =20 - clk =3D ((input_clock / (psc + 1)) / (dev->bus_freq * 1000)); + clk =3D ((input_clock / (psc + 1)) / (dev->bus_freq_hz)); /* Avoid driving the bus too fast because of rounding errors above */ - if (input_clock / (psc + 1) / clk > dev->bus_freq * 1000) + if (input_clock / (psc + 1) / clk > dev->bus_freq_hz) clk++; /* * According to I2C-BUS Spec 2.1, in FAST-MODE LOW period should be at * least 1.3uS, which is not the case with 50% duty cycle. Driving HIGH * to LOW ratio as 1 to 2 is more safe. */ - if (dev->bus_freq > 100) + if (bus_freq_hz > I2C_MAX_STANDARD_MODE_FREQ) clkl =3D (clk << 1) / 3; else clkl =3D (clk >> 1); @@ -269,7 +267,7 @@ static int i2c_davinci_init(struct davinci_i2c_dev *dev) davinci_i2c_read_reg(dev, DAVINCI_I2C_CLKL_REG)); dev_dbg(dev->dev, "CLKH =3D %d\n", davinci_i2c_read_reg(dev, DAVINCI_I2C_CLKH_REG)); - dev_dbg(dev->dev, "bus_freq =3D %dkHz\n", dev->bus_freq); + dev_dbg(dev->dev, "bus_freq_hz =3D %dHz\n", dev->bus_freq_hz); =20 =20 /* Take the I2C module out of reset: */ @@ -760,9 +758,9 @@ static int davinci_i2c_probe(struct platform_device *pd= ev) =20 r =3D device_property_read_u32(&pdev->dev, "clock-frequency", &prop); if (r) - prop =3D DAVINCI_I2C_DEFAULT_BUS_FREQ; + prop =3D I2C_MAX_STANDARD_MODE_FREQ; =20 - dev->bus_freq =3D prop / 1000; + dev->bus_freq_hz =3D prop; =20 dev->has_pfunc =3D device_property_present(&pdev->dev, "ti,has-pfunc"); =20 --=20 2.52.0