From nobody Fri Apr 17 06:13:53 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1146B34F47E for ; Mon, 23 Feb 2026 09:39:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771839554; cv=none; b=E527gSF5SkNiNo/q1HZIkpSv3WFD5rtf28ALFldesTSFAQtrcCOMSBudVoLlv6bTZ8jWNz08W+6UvMYfM3CKIolDQtibpuBDqCpAjOeigFChTr/pA6lVkE3EVGmforZXtAamuru7tLU9yVNNCztKM7AZwf69qmNjbXpxgX9kZG4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771839554; c=relaxed/simple; bh=22g9IHd8MbqNZ/zr12muTqPn97dN/XGlfHhk6i+rqUE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=FS1HbDUmBQqrdAr+1hf83N1lz+i9qzXHd1CEUZQrKj+7Hv/NRMJZGpWBQDmDAJ5mU6mbqFV0DOw8Rt5ElQUTNO3bWWv1wa7KcTxvkhuQsmYhag4gQFosnbzpepIZoGkLIm2MvSJ7t+ExjZnzM7eVV97MwWCdHS1mP2kmH2IFdJU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d2sMFQtC; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d2sMFQtC" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-824b5f015bcso3945838b3a.1 for ; Mon, 23 Feb 2026 01:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771839552; x=1772444352; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=lYTgRFrukUXwZIV4VFCTpBL82Bk2TIngU/MKatYVmUM=; b=d2sMFQtCoQJBomprls4q04xi1xFu1N/o42WIuxHs/LDdjGb7ZtKugSxexogU/iXOK4 al4l4R0c0S/IjfAqZR7JcpG8l6pFsuqQZbSSRji99eJqNWMvwKdG2XSqvj78I2Li53zU 1svSpbphEQys+tCQFHQwHOkSgN+wz57pU/5CjYnfacZjRoiOxrbPnBv5cxMdMQfkxhfv GBHWVQ9+cttFV515A9ALpo6JxEidYzPuEK//QmyAg/ewuPRExCDerjYIpK0pzBkBjcgs /3ekycj52iIUE4Bbki3jRD4uop2XzJhs2QKqC54Eiu/DOpqwxN0gDU+mkFhOCaYT1cA9 8e4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771839552; x=1772444352; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lYTgRFrukUXwZIV4VFCTpBL82Bk2TIngU/MKatYVmUM=; b=BEQGQSXJAcbnJXYEw+9bfqJvcwre3JnvleJNKq+2Bw3GZMlQRdjw4UV7h1m/KWKuC5 PVaZ/SeuKefBcsYd35W9LvMn74JoarPnpsNmopiFrZGcCEx/qSYGa5aPGHOouq+OKMBq hG50mXD04VNNFhMNmtdBDzDerG6kcyM9YJtPOQdbytwDjYisk3dqzsoWc6jBegvdMtsF xba+g0H/bDjtRWH8cQbRnlaQY+wRQuF+8aqEWUT9lOPRowBrBuBTB23jYWDn5kKVTTEB h6iSKfSGvFwzuTxIVeOvROgFGo8BuB8voUOca+fD0pxtjnuOk6sV0DkkKGAUb2yTqmOo IdPg== X-Forwarded-Encrypted: i=1; AJvYcCXeSM44Z4SY0GHeQdqViGCCKdc6I721qMSYia9TcZosrK+MsZXyrr/R+xUATCIJ7eSULRuh6GGAfRzsE0Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwwQrP1q7mbj78RulAoqVwLXDHHEru9cUQRb+ihBgi0wCCwEbpA QWIZyqarZgT/RUDHasyu2mII9XrgQ77K57MDbStoGSX/6N+CJyDl9ouJj1GxVl0S X-Gm-Gg: AZuq6aIt/8/p6jOUFXrQBSx5hTW8cmoh0p2191DY6NymtsZTlBJK68EJyxo2mwQBnfE HB+8WNS7HMxmjNeC1ZnafzpPwR7Is81pRdZyqzNKLI9rRbuLAJ5ToPtFDbbrpqjb8HQKIUB3G5D VucxQ6BS34TNSxc5tdFsg4FVym3eLfkCZSq6afv5Q63Xg04Ah+H9MIxsgD3XBqIQPEEmpbcPZi8 DltDkDgpnG59Evx/u2TLpqzgYR2qNh/qCn0L/MGufHTcfb4M5k1127EUEZz7P06L0mf4OzwjhVv TpKhaTwkdZFRKAFZGvuUjPTI2Vr2sbcNebooK3ugc/RtAaJmi3jo2WSKQGC4RtlkQN/9KWDvxkL pmbDzoKqwNVe4NXk8oton44uczNDTL9iChNWtPyAt/0ZU7eKCgH43I2ZxdQmoVGJB2Jm4xJAOGW am1utRO3cuuGH2I1gKguyyEKi5XXy28fXVOk/JiBJGDFl/63RF X-Received: by 2002:a05:6a00:3a1d:b0:81b:8872:ae10 with SMTP id d2e1a72fcca58-826da709249mr7880573b3a.0.1771839552364; Mon, 23 Feb 2026 01:39:12 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:1cfe:ae34:fdd6:6b97]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd694eecsm6778053b3a.25.2026.02.23.01.39.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 01:39:12 -0800 (PST) From: Felix Gu Date: Mon, 23 Feb 2026 17:39:07 +0800 Subject: [PATCH] pinctrl: cirrus: cs42l43: Fix double-put in cs42l43_pin_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260223-cs42-v1-1-431b01a6f537@gmail.com> X-B4-Tracking: v=1; b=H4sIADognGkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDIyNj3eRiEyNdQyMTE1MTC1NDsyQDJaDSgqLUtMwKsDHRsbW1ANjgtD5 WAAAA X-Change-ID: 20260223-cs42-1244548516b0 To: David Rhodes , Richard Fitzgerald , Charles Keepax , Linus Walleij , Haotian Zhang Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771839549; l=1078; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=22g9IHd8MbqNZ/zr12muTqPn97dN/XGlfHhk6i+rqUE=; b=8WHsXEzaVMTmDj2uMjMZGSI4dc9xqerMg6zQzkGPGVvtglNhuH4dsu+uj16RLJn/wMnd2QKZZ mR8ljkPzNppBC2sYLuDURUr7AgKoJoUoTAKSnd9lR0Aevtlb1EWhORr X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= devm_add_action_or_reset() already invokes the action on failure, so the explicit put causes a double-put. Fixes: 9b07cdf86a0b ("pinctrl: cirrus: Fix fwnode leak in cs42l43_pin_probe= ()") Signed-off-by: Felix Gu Reviewed-by: Charles Keepax --- drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cir= rus/pinctrl-cs42l43.c index a8f82104a384..227c37c360e1 100644 --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c @@ -574,10 +574,9 @@ static int cs42l43_pin_probe(struct platform_device *p= dev) if (child) { ret =3D devm_add_action_or_reset(&pdev->dev, cs42l43_fwnode_put, child); - if (ret) { - fwnode_handle_put(child); + if (ret) return ret; - } + if (!child->dev) child->dev =3D priv->dev; fwnode =3D child; --- base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6 change-id: 20260223-cs42-1244548516b0 Best regards, --=20 Felix Gu