From nobody Wed Apr 15 23:50:32 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC0EC3612FB for ; Mon, 23 Feb 2026 10:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841318; cv=none; b=O8mN0Bv3drF1omHu0O7HWW3tJFNkQxHn4Q29M0dS//S49FZAG7MNOTZ9dgZTHzUN2+2Lko4kLh8ZhAa8jdrzYbou54X884abgz+UfUiZAKGq6/5gNsL4OCzR9lCPmeqY7FoOLVuMG825ciJmfKSlDn1BOz6GmF2cTyH8X04WeYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841318; c=relaxed/simple; bh=36uRj/yGgZFq6zKe4ExA/GGUiwSeasAUQSZStEmKulI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=UqmqMW69EC/+sFK+1yMeDHz4lrCOMdJqzm3IOvPV5Nd1aGZTgVmitkxanZUkrtQNVgx5+Q9w4Gs1Uet1PX+0tnMtK+u9XQscSn1+5z4TOUwCzFTbPeXAzglUVyd3UHCA2reZ1VK+PlidcTQwoENI1pEAWcfpK5knaMvig/uHimw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=x9Z6mM9a; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="x9Z6mM9a" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4836ff58111so53233765e9.1 for ; Mon, 23 Feb 2026 02:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771841315; x=1772446115; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=iqjAQx12kO7yn9LdoidneoYk/xISJkEpOFtnTwZu1xA=; b=x9Z6mM9aUeW6p7rPzDFLrbHskPS1OgEQPZTJU4Gz0DMBwWVYAuwnbvkxfrobD1OCwG 7XoaFbhR4FUyKfJvovGYgqZbb1TDQgaSSixyxrjnNoWALut6fuVbuQPdo/k9gYZ9AipO ptRu/3ovTplJFzv8xqt7V9nnD8chXi+DsUYPn848lFwin9I+sMTHnYIp9QZCxpb2Xx14 dZg4xv5ZU6sxfL5DUPekaCcefD+vqBivsri52kZk/UJ4ImZQkhZ5KJLOilsz5iLhbAG1 aF/GMOk++n6EjwCao3I/VZC/w26qoX0BZ8ZEncdHeMLGevBN8Of/okYdea1JHYsK/Fce G0DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771841315; x=1772446115; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iqjAQx12kO7yn9LdoidneoYk/xISJkEpOFtnTwZu1xA=; b=GK4dbCfYrwE3izDHfKELcFk4OWpF/daAVFlXoq6PcyN+xR+nmzBkJnazJxpiWRn91S wjsdbINj977Wo+6QnlX8csjIOB8y/nRSgWJ9QWcIl5M59eeSn16ZO4Behz+mxhGcfR37 KerdMxZ5H3OZekGQbTgn+KldVDpW9eMJkVkuoJ1XahVn6qq4L1sWbFIM+zLeVeqRbM3A 4V3d5YkjUv4mmcr+a0G2V6VFVe+3AxDGFVcrpAKWGLceV/MZoUdLqNUTLQLe3TjjOj5v WMH67KPR7f7br1OdX2fyy2e+uYn263RjPvHdk2ZR/2mO6BYaD98dFF3Q0rVUAUPpyD/D fkZw== X-Forwarded-Encrypted: i=1; AJvYcCX0ZiCAHPhJjaWc+zIKjCMPikr+YjRMFy7O1hKy1i/QAzRX6oRwL/0hSa3c+csknY99d6oQwyRcGLeQs9o=@vger.kernel.org X-Gm-Message-State: AOJu0Yzmr32dmZ8l/JXYDKgQ0bIperxUmRVD03uN/lI2/zl26HCaFnGs ElD4tVKGW9DErWYkfXbW/WWm3I5aD4K/Uz6kyjgNvDB6cMe9GYQjX4O/AqPzSAKKlpRxAYhCUZV vXYBu8CTZEB7AnN26ZA== X-Received: from wmqb9.prod.google.com ([2002:a05:600c:4e09:b0:483:6f09:9913]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:34cb:b0:479:1b0f:dfff with SMTP id 5b1f17b1804b1-483a95bef2amr119187925e9.10.1771841315177; Mon, 23 Feb 2026 02:08:35 -0800 (PST) Date: Mon, 23 Feb 2026 10:08:25 +0000 In-Reply-To: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1369; i=aliceryhl@google.com; h=from:subject:message-id; bh=36uRj/yGgZFq6zKe4ExA/GGUiwSeasAUQSZStEmKulI=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBpnCcgUsqqcMYjdDm7UHv8I5p4UEWxxC0fGy4J5 el4buZGr6+JAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCaZwnIAAKCRAEWL7uWMY5 RnnuD/9/liVA8UJG+WSn8bROvceJNTmyceJ6rXLYcVmGqpJOk4jTuFu1rTGNw4NmJZwjyRkr6f3 nqcjfE/k6I2/OOh5eKr4nunoY0BxzZ2n7VLcRuKU1sBKTcpCFOmLEhsYEC7BWYW8oROD3oXMJAJ VxH/5YsIZeZQYjVrRlwqkxLxT8qV0DFd5RJLhUdeaHQpwTf1lRN6PaMSkREkvM40Xamh+21zS+J /Wswc5gMzYG/bdjOQmoaunIqrs+Z6VShwf8+lVxCgh/KdXF9TwelJEw12IOpERw881MJNuGLNHW 2SnNPNWSRArfppwbyMvO+aJsiUvW5YASeJIxzeRzzppHVhDonRCKJZ98t+XrpijkTAM1u03vJJx zQWGRbXbhl8VkB913eXVDc1GozBbpqpkPcm+W2UKiqIu8IYW+DgCT0CfDPxeh+57A9oKa3AwTY/ YBTCYD2KAjkSIK7iWmd0XpCTw+Q/f2Bkrh7krhQ8PcUpi3CTNS9Dkry8ZWuduVf9A4cYQA+dI/g QTTtkf9I/u9r30jM37oq4Lp3U1UQj+21ngcbg8SuNWbDd3UuotqbNK7PXZdfFSw0SP3uun00I38 ADs08uf+SJ2rNSKDWsLURv6SjHm5roDE/3vrVODsntZ10lSlAlopUKQv0b2zGlHBnxxk8ijXqiN u67oZuhxYAK4CgQ== X-Mailer: b4 0.14.2 Message-ID: <20260223-clk-send-sync-v5-1-181bf2f35652@google.com> Subject: [PATCH v5 1/3] rust: clk: implement Send and Sync From: Alice Ryhl To: Stephen Boyd Cc: Michael Turquette , Maarten Lankhorst , Maxime Ripard , Drew Fustini , Guo Ren , Fu Wei , "=?utf-8?q?Uwe_Kleine-K=C3=B6nig?=" , Michal Wilczynski , Viresh Kumar , Miguel Ojeda , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pwm@vger.kernel.org, Alice Ryhl , Boqun Feng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable These traits are required for drivers to embed the Clk type in their own data structures because driver data structures are usually required to be Send. Since the Clk type is thread-safe, implement the relevant traits. Reviewed-by: Daniel Almeida Reviewed-by: Danilo Krummrich Acked-by: Viresh Kumar Reviewed-by: Boqun Feng Reviewed-by: Gary Guo Signed-off-by: Alice Ryhl Acked-by: Brian Masney # Active contributor to clk Acked-bys -- Danilo can pick it up if DRM needs it in their branch, --- rust/kernel/clk.rs | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/rust/kernel/clk.rs b/rust/kernel/clk.rs index 4059aff34d096264bc7f3c8bfcb39eb3f42725be..7abbd0767d8cff9f2561d1783a9= a1d774a96d1fc 100644 --- a/rust/kernel/clk.rs +++ b/rust/kernel/clk.rs @@ -128,6 +128,13 @@ mod common_clk { #[repr(transparent)] pub struct Clk(*mut bindings::clk); =20 + // SAFETY: It is safe to call `clk_put` on another thread than where `= clk_get` was called. + unsafe impl Send for Clk {} + + // SAFETY: It is safe to call any combination of the `&self` methods i= n parallel, as the + // methods are synchronized internally. + unsafe impl Sync for Clk {} + impl Clk { /// Gets [`Clk`] corresponding to a [`Device`] and a connection id. /// --=20 2.53.0.345.g96ddfc5eaa-goog From nobody Wed Apr 15 23:50:32 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62A5A361649 for ; Mon, 23 Feb 2026 10:08:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841319; cv=none; b=q2UmlwK4gouqfo9WZl9l0pRXaJVxjAFnxjcq5CTNHZNsmNF/4GXhZOXAiFWFHnRYKyw0wWLIE+4Gr7L6441JHf3lzkEExWzpCfNbJnUB+A+4YGueI3RNxfgpjQseDwU/NPWjagmXNNaOV+FiixTiqCkf2YdfA+fFyjm+E7tvhOQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841319; c=relaxed/simple; bh=pyY9kK4oV6p5HO7c/+g+XC/Va/dVtmU2Pzel1xZKbW0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=X6XrdrFJNirUBnPxDOH/qHOWGlZ0kjNAvXgLEolrMiqA5D17PaKzM+KeAaxAM001FrjE/qzZUmh3bXbd/kn3yZ3oqxl5nkfT0GxvuJTS7KYh7o+k+4CP0z4eQIrC24CPzRMFf/5mHGz6u6n28lIfeJUbEp5aIcp7H+l43X9ypT0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gz+kDW21; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gz+kDW21" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4830e7c6131so39943035e9.2 for ; Mon, 23 Feb 2026 02:08:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771841317; x=1772446117; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=74oBSEu7KeQiZ+IoO0+YkS8FCtMu2JGZ7vr9oRz0PzI=; b=gz+kDW21aShQ42gx89RO4N2FPDKFjyt/nXcSzqWPphs7dSFxRDOBzMX2IoFl2Vdqlt K3WFxjF45/i6V8Q9H8iC7XpKGOP4X7IGxF9rYz8mfkZBVO+gXruRAi1J7Aw9XdtTWgtM B/ByscH+5ewPO9qsB4HPgw2urAjrIE04AspQO1w23PU2dlOny7FOPLqNexMK280w87zz SG++UiJQgLpCbqGA7+9l6BWq9B5b+w/w5A4hw8aSBt+n/77QlU81JUlqt6AYmqXfaJ/j EQYyMCJFVMAuaj6BEdSVRdy0ub/lJQt2s//eUrW8eVKsEUyL6zXrYVr9qCv1lVoOmZ20 Yo9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771841317; x=1772446117; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=74oBSEu7KeQiZ+IoO0+YkS8FCtMu2JGZ7vr9oRz0PzI=; b=GC07CMvh9I1alAoITsEeFo5mPSOpk6jZlHcEq14qaB6vHobBh++HrXdfPCLmcCxCp6 vwuKr1qSrKDlsSGp7V6F0QR2J77yE9Zoa4IHhuYTX0HOFT5G+DO8FLSwkmyZxgeoV4LG +tQE1ogjxsrJeJHc6wXOQ8zurfSLxZOjgS7eJY6oyY6WFM7jKBNWfxbRKbxQDY248sbQ 7QrnaTZBUdsZfxqkGh/zxIPHpePhx1qky/iiNSxA4vlmB2g483HKRcW3bo8ywvevE2gg CWUIDDbQia1q6PPp7gDRNQ8384cZ8XlFmrwwWUIYRgVLblJ978q3R13hgJIvIxJugIKh 5B6g== X-Forwarded-Encrypted: i=1; AJvYcCVbZJGHJ1hwCNvwZgyHVCFWYuO2xKMEJT3LK+E+h+dqdfDfU1wIZf+tO7VXaIMlhaJcxZNKJ9K2c8hJkqM=@vger.kernel.org X-Gm-Message-State: AOJu0YzaaHtERco0vUUnl5R+KU71G3x6moqzjlbpEDBvwnHcBav7EGx1 4ju/1aO/O1sxiCOSvmtm88j+E1rld0ZaDbKMFq7PaohTLl4ra0K2voB3TtEwu6uyKUfcBLFk1Z2 Ac5GnOrjOLz1Cj/S62Q== X-Received: from wmqf8.prod.google.com ([2002:a05:600c:4e88:b0:483:509d:729b]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6298:b0:477:b734:8c53 with SMTP id 5b1f17b1804b1-483a95fc1b2mr131544185e9.12.1771841316659; Mon, 23 Feb 2026 02:08:36 -0800 (PST) Date: Mon, 23 Feb 2026 10:08:26 +0000 In-Reply-To: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1702; i=aliceryhl@google.com; h=from:subject:message-id; bh=pyY9kK4oV6p5HO7c/+g+XC/Va/dVtmU2Pzel1xZKbW0=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBpnCcgQsWGO0SyEW1aYXJHNJ1ToG77ov+/VqDIJ 2Rqb9pykuKJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCaZwnIAAKCRAEWL7uWMY5 RvPKEACcCzYO2H2oHLj3JDXRaxmHYGc/SeaInq4aZ2JbFlexxZTT4p23CkD40L5nX9RPxIEFFFi c7N8pnaUWanWESy6oExuxMGfeErXamS1NMw1HApdc8c1tN2HuU6S7Ae/5fZodqUPjq58GFujgik UjrEnwkWDYYu5Ur0biyjS07f9wtR0nHDaTokNWxkoINedZCvmyz4tHzGFVG+ckuZwdEPQTS2L4H suTrShLXwqeePnkJisxZPKyPYYcELHBOB1WnvpYJ9Y+ECidj9mgbPFjQx53XeHyg2Q7aBOa9nxN Tvn6x1DKjWkJbFpGOthc8vlwDei8eMV/hPEu5qdjPtogR4LpopTrhVGVqXoVHK0tcmV1gktjxYR fA2KrSdElAcjkxQsZWBOSpwOEKp+HjxgeMjatw3CtjYZBAeyKgmG+cGoSvZmKzcD/220WpvoDtK NiGtga+cJkHAVUyjDv6XC/R8zp6+ZwmrK0WJdqkIMoQ1vpj52EJBzZDdljwKL3knHM1h5GSlran hUcuddCm9qyCl59Tx2TgYGdiUe4UcF3qxsHzSFus/3+kaqkw7jNKs0jyZ40pz4pM+tqkOTQb2ly 5H3BRIhQ/kZhj+W1ZRRKzRuBj/lunAY1BW8Ry2zahqvU+ESFtSG4uzeTTQQBMCRRPpiPuCstoW4 wHfC88lm6sts2ng== X-Mailer: b4 0.14.2 Message-ID: <20260223-clk-send-sync-v5-2-181bf2f35652@google.com> Subject: [PATCH v5 2/3] tyr: remove impl Send/Sync for TyrData From: Alice Ryhl To: Stephen Boyd Cc: Michael Turquette , Maarten Lankhorst , Maxime Ripard , Drew Fustini , Guo Ren , Fu Wei , "=?utf-8?q?Uwe_Kleine-K=C3=B6nig?=" , Michal Wilczynski , Viresh Kumar , Miguel Ojeda , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pwm@vger.kernel.org, Alice Ryhl , Boqun Feng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Now that clk implements Send and Sync, we no longer need to manually implement these traits for TyrData. Thus remove the implementations. The comment also mentions the regulator. However, the regulator had the traits added in commit 9a200cbdb543 ("rust: regulator: implement Send and Sync for Regulator"), which is already in mainline. Reviewed-by: Danilo Krummrich Reviewed-by: Boqun Feng Reviewed-by: Gary Guo Reviewed-by: Daniel Almeida Signed-off-by: Alice Ryhl Acked-by: Brian Masney # Active contributor to clk Acked-bys -- Danilo can pick it up if DRM needs it in their branch, --- drivers/gpu/drm/tyr/driver.rs | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/tyr/driver.rs b/drivers/gpu/drm/tyr/driver.rs index beeffe36b6cb068f2a87129872b37cbea4fb2010..e833e9f537b0225368ca10f5bc7= 1b2612b0befa5 100644 --- a/drivers/gpu/drm/tyr/driver.rs +++ b/drivers/gpu/drm/tyr/driver.rs @@ -53,18 +53,6 @@ pub(crate) struct TyrData { pub(crate) gpu_info: GpuInfo, } =20 -// Both `Clk` and `Regulator` do not implement `Send` or `Sync`, but they -// should. There are patches on the mailing list to address this, but they= have -// not landed yet. -// -// For now, add this workaround so that this patch compiles with the promi= se -// that it will be removed in a future patch. -// -// SAFETY: This will be removed in a future patch. -unsafe impl Send for TyrData {} -// SAFETY: This will be removed in a future patch. -unsafe impl Sync for TyrData {} - fn issue_soft_reset(dev: &Device, iomem: &Devres) -> Result { regs::GPU_CMD.write(dev, iomem, regs::GPU_CMD_SOFT_RESET)?; =20 --=20 2.53.0.345.g96ddfc5eaa-goog From nobody Wed Apr 15 23:50:32 2026 Received: from mail-ej1-f73.google.com (mail-ej1-f73.google.com [209.85.218.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38EF935B655 for ; Mon, 23 Feb 2026 10:08:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841321; cv=none; b=XSMNCTR9lKj5XKOywQBcPB7qb/oYBF+m2tCifm/YQ9FlKFChOGRdE+A0AAX3APlQFBnOf6/t2RxNX/TEDOE8HBhUXnX4MOOCi/um9O5gU78saJ8zoU6T0sIo5/P8DaqNxmgDe3U+8epFMLAnGPEuFM/yb4E0Gm9ipPvHKQPhp1o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771841321; c=relaxed/simple; bh=+Vwn2RMiQCLbhdbFzxMNsyo+6P3BWAiCt7b4ppvm0lc=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=gco2+OoeKUZQ4XnTsGOp9qp7OQJgwkSJ+SswNyDIYFA4ili7mRkZsjDR58vX9rRdq29vyGeCSRBQwxiIvcJsfFISIrkJszaoEdac0vEheJNfiO7WHOuTUXxj1keHxrFc9I+l0J2+UEJkOQdwa1s5arOPKZ/M2fKZSlbEiDMdM5M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=pi+8rdk7; arc=none smtp.client-ip=209.85.218.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pi+8rdk7" Received: by mail-ej1-f73.google.com with SMTP id a640c23a62f3a-b8704795d25so337236466b.2 for ; Mon, 23 Feb 2026 02:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771841319; x=1772446119; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=OdnKcgHkjFRmgggTpTfgYETTa8fsvbvkTrjIctXuE0E=; b=pi+8rdk7qhbkmTrlMOBUPZ4jNC+DQ0xjprhXSbsJ3gCUHo9KrP7Lr7kLV0x6grSMs6 bU784O7TMnQAtQCyLHde1W9HWXBa7ONXfzoQ5YFxLMovRBaydbTe0heF7NklvzKeDRVb 868hZ8iuwZgo7R2AuTN25BgBFcdm7lbCNm2yKfn1oGwiKeyU9ADqezMoLGAKYG/jXBT6 bCaaP4vUbDhGHHODN3auskIP0Zm/sz0JTsQe4re8jp+UZG4j/33S48aqQTNR2rCJkAny wIm3DzEWj15C5naxm4Ts27n9ZHIwTaMn2LgYozV9C6Y7xGgP8OvC81SdE+NLzDrVK7pF 1jLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771841319; x=1772446119; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OdnKcgHkjFRmgggTpTfgYETTa8fsvbvkTrjIctXuE0E=; b=ARhOm7dKjfrDAwXU2tNGcfiNB4J21kzWRWT55umHjTEqmHEOS/HStZ8rwzxgKGzstZ /44a+f2bwZQk92dRoFM3/RLjdRs96DCDAreurszFxKrrpU1p5gTyPU9ErFljFPlF6qLI tGkQi5ai1+Hv/S/xuJqjAkuq0S64+G2bhyU7p+xRKWb7hILYM9LjZKUa1Hd5aWLEpyI2 grHhyghAIyT2R6NyrP58MwyGp2ixYmoFP2Pa3Vka8bfDkJphvLzhMqa9M4cEfY0wqedp mwyeKVRFmJZRwL4L47EK3iFN0OLGmXFZ6bOSlK/0608wbY8XHYKKUNfLRfLKCHI7h0hS qH9w== X-Forwarded-Encrypted: i=1; AJvYcCXUH9XyRnL4AbQndmBKB0ehD9U/U2Os2VU1k8f++B5PQhSXQTlJLfl40DRG9yvO0Kr0/G7QiHBagW5P2zA=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+9BbILzH5Pp96eY7Q8pEoyQugJGzKaHEa+C3A+dzjsdc264g/ GWXNvQnjkv7OvJn72Owc/fb+LzFGcNOG03jAONOy9NSCC47QNSvtBdNb6F/AiXvVNCfp1QyN2Du bT6oNT7kbxQUHpUpdDg== X-Received: from edgi6-n1.prod.google.com ([2002:a05:6402:a586:10b0:659:32e4:b9bf]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:3e25:b0:b8f:ad6:db92 with SMTP id a640c23a62f3a-b908196acb2mr410233066b.3.1771841318227; Mon, 23 Feb 2026 02:08:38 -0800 (PST) Date: Mon, 23 Feb 2026 10:08:27 +0000 In-Reply-To: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1832; i=aliceryhl@google.com; h=from:subject:message-id; bh=jAawhmP9tDMdeWRIiWq9BA5B+z9O+mAwAwRx1JUlWqQ=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBpnCcgbTxLXepdurAu3GuF7CkmSYRcJGHXg5wHK hhZLv4P056JAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCaZwnIAAKCRAEWL7uWMY5 Rmg5EACUr4q9yVqlI5z1xy9rbC8EGqAU70l/fbrINwUJqLf9Vt3GtkZDEI/b6AlgN8RQX4mTF5N HbhQXKgYr3ZoF6FEaPGouSxpJfyULOX2dOGt9yKD2+/TUDXWtEMqF3IUZi2EVrynHGVLOQ73+m+ 2f9n2iLzZXtFHFAqD6y2m4alR5jk3jY3z6OJxCUBgZsPNs0LI7md9QylC/vN1NfF5gvEv/QouDJ soiXmdHJCUYyBnyOsmDvPwMu/fbl+x92jpt87qPSH9hLWfJbGFojiA/aPlR2W3jIJCkbCVMntgY 1Ae/ApT2P85bQovYJ1xpIrQ3H0f6ywsWkuPhtEderymKHmGPSukBCAx9tbtw9kt8rX+Osg8+grg fg8/woo0bSdW0aIwDRIeUpet1ZR6eMqgjOoJyYt3ECDnWWOZrj61nr1OPmCuQAIMqcYD8rT2XxM nJ73kRZ3WpHs5JtCSYUPj+qacn/BhfJdTlXQrHmhF3ZYoHv+bJv+XYe/Z6b5rSx9PXx+nQb5Bg9 TrnpR3YQeos5D8NteZVWdTP/iLDuezjrC85tGipCA7HdZgQpAhFbDQn7ump6S53j+KhQ/g62O6M Vaaurm+dt3EGb3ZPkYJiKXj1PZ10PFUfFE7r/ZFauGbCVwih6pBzgXs3nTUUkcLAP8gj6dP9+Zi c6sJUxRyO1VAaWg== X-Mailer: b4 0.14.2 Message-ID: <20260223-clk-send-sync-v5-3-181bf2f35652@google.com> Subject: [PATCH v5 3/3] pwm: th1520: remove impl Send/Sync for Th1520PwmDriverData From: Alice Ryhl To: Stephen Boyd Cc: Michael Turquette , Maarten Lankhorst , Maxime Ripard , Drew Fustini , Guo Ren , Fu Wei , "=?utf-8?q?Uwe_Kleine-K=C3=B6nig?=" , Michal Wilczynski , Viresh Kumar , Miguel Ojeda , Gary Guo , "=?utf-8?q?Bj=C3=B6rn_Roy_Baron?=" , Benno Lossin , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-pwm@vger.kernel.org, Alice Ryhl , Boqun Feng Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Now that clk implements Send and Sync, we no longer need to manually implement these traits for Th1520PwmDriverData. Thus remove the implementations. Reviewed-by: Gary Guo Reviewed-by: Daniel Almeida Acked-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Michal Wilczynski Signed-off-by: Alice Ryhl Acked-by: Brian Masney # Active contributor to clk Acked-bys -- Danilo can pick it up if DRM needs it in their branch, --- drivers/pwm/pwm_th1520.rs | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/drivers/pwm/pwm_th1520.rs b/drivers/pwm/pwm_th1520.rs index b0e24ee724e4501b812e5f9c7904b483bfe5e2dc..6cd6fa3d298484cbd84b88cfdd3= 244217855fa05 100644 --- a/drivers/pwm/pwm_th1520.rs +++ b/drivers/pwm/pwm_th1520.rs @@ -99,21 +99,6 @@ struct Th1520PwmDriverData { clk: Clk, } =20 -// This `unsafe` implementation is a temporary necessity because the under= lying `kernel::clk::Clk` -// type does not yet expose `Send` and `Sync` implementations. This block = should be removed -// as soon as the clock abstraction provides these guarantees directly. -// TODO: Remove those unsafe impl's when Clk will support them itself. - -// SAFETY: The `devres` framework requires the driver's private data to be= `Send` and `Sync`. -// We can guarantee this because the PWM core synchronizes all callbacks, = preventing concurrent -// access to the contained `iomem` and `clk` resources. -unsafe impl Send for Th1520PwmDriverData {} - -// SAFETY: The same reasoning applies as for `Send`. The PWM core's synchr= onization -// guarantees that it is safe for multiple threads to have shared access (= `&self`) -// to the driver data during callbacks. -unsafe impl Sync for Th1520PwmDriverData {} - impl pwm::PwmOps for Th1520PwmDriverData { type WfHw =3D Th1520WfHw; =20 --=20 2.53.0.345.g96ddfc5eaa-goog