From nobody Fri Apr 17 11:34:42 2026 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D13FBA21 for ; Sun, 22 Feb 2026 09:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771753547; cv=none; b=UUyGidoUXFupUkzhXkPNu6iDWyIzLNJQ70UdFC6a8VLhOStMrGKijZnJnFPqZea/UrLJMfJrQgRZq5hkqwl7VFd7FqbdGBuDOhwS99QZJE8FciPfEVPzhbGgQDtwlkHL4sBCBDlFp5UpESXqq4oE0Ya4+m5nottrl3PPmQ5I6Y4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771753547; c=relaxed/simple; bh=Q58s3FaYS+W1+PdVhrq3Ap+aQAsxjqwX2JUo4/L8TAE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=XNk4uSKp+Tsrz/UZzug6fh/o9MnZzEFx0T9GX6K+zCHnOXaFYDcedhkG3cIQhbqyTsnIU2anIRQoHRsz4blMiAxKmY5dVM4ZYuqk9UOCD+zYat9/svkGBUmRsGdxnYkRL4fWEHV3WdMhJ/TW7Y4ITD+3jxdRgREvfrKnQS0MiEc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a2/rz2E2; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a2/rz2E2" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3585ec417f6so2165021a91.1 for ; Sun, 22 Feb 2026 01:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771753545; x=1772358345; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=e02DHxFr8gMzpHf2FtukLIqFujOEG5T0tla5YfzjmpI=; b=a2/rz2E2Lk2HmCXne5LELh1plK/cmmoNbr2Nfy5DNpBD33Tq/jWChXf0LNJ4lu0qfa mewa5Mc5Y7KC1sgKNGYkcBKRNgwxgcSyTo3zK6MhOYIsI7R00wY072hn2DaCVz9BTkvE yi/z15um7YFbOxhJC+huFvIPSwiwCslUzbyR3Gye/N4DEOdA5GhTxRghojGrog6qtdiM Nld4yE9oW7iGR9sFwSSMQb835oN8dlqolcWtVZgV7KRPwiNWtPclAO3J98Wi1pHXnzND cHse4UXtmHu0R6XrUZEqDsLd7vRg1fCq6quwSXeulyG7hHUr/NZ/EXN0KsNbDD4Uq/eh r//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771753545; x=1772358345; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e02DHxFr8gMzpHf2FtukLIqFujOEG5T0tla5YfzjmpI=; b=l6foXuRecoGiFsupjv5Fx78/mCn7Z96FsA9NaRKgLv+2iHJ2NOVd4BBKSXC/r4B9pS 4+KkPXz7ouugTD39IuUvTB3d7gm1cZF/FMwIxxrHEtfC1tkPNPvty/SuRfxEVuVjLIb/ b1wYTDTHpHwpvu3KBxfzeGXAW+IwlNMUywLtUt9/liwBVrX4lM9kyyceNrFVS8ADgH0z 3Dh7/QbNk0hiXCPzUQPTUVqt8B34tqZQtkBCt4/hTK7BCVgcdaT1O/mvC1HR67LBDv6f YcSa/cRAJ0nJcrcQ0YwYdSZH2IR/ewG4cPH1l/kME05+Hlb4UNDR25f8n/7iNa9Gsxtb Q7gA== X-Forwarded-Encrypted: i=1; AJvYcCXGAZ/6/GtJ28uf5+Wm4pfnlrAVFpiQ2m5EZNIQm1SaM2+94o5kr5j1Gx8WEilIAonEaOKlJUC4rcT5Jng=@vger.kernel.org X-Gm-Message-State: AOJu0Ywcrji0gJXR5dh98ueNLlWQIp/uxuhZkuXTIw2hlHPeGQulqE3p vJxr8oMjkSDvJ4GdPA7Ih3L2C9IjW0KhU9bJP3Yplknrk09jurNrgalizHLfrbni X-Gm-Gg: AZuq6aJf2czrLV1kNZsoU32YgbnDwG94zO1X1Fcjenwe3nDQcEuEklM4qzfREOmw9mj Di5bgAaQsrthUWOWqD0IQx9V6CMQ8x1x3deQmux9I10CgkokiWUi+r1qn55vdYqa5jVj9KkeVKQ /Uttl+f8benE3ui49yOI+n4CVlOURaxv5qVNJ7/pAA8YjKdZB/wrarwVgmiIG0rZKcKF1srqgLY bx4Ej5F6cHHk5enJ7xkLr8PMew1FIImQUO2bRoYjg4PiW9vz04Bn4oWdsmnXNLSU40olrEQfPyd eGR1BvAwp0/4ugPUuCvgg3uiPDp3wBTS/QHaao1LlpzeNnlb0k6hbBU1Es5vYxRJ12TXdFDgO4a M8DOLNyqhvmRL8KmOLddhluiZxdZiQu7mE2knMikih3h+9h5Kaaf5sJjfTArpQEvGrM8WgN96tz 1GOut41KY+YpIaq+ujk2+6Z6nX/6UKfRuN1A== X-Received: by 2002:a17:90b:4cc7:b0:34c:718c:5448 with SMTP id 98e67ed59e1d1-358984ea764mr7749218a91.4.1771753545462; Sun, 22 Feb 2026 01:45:45 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:1:8bf1:8197:6d5f]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358a2b39b66sm3278995a91.11.2026.02.22.01.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Feb 2026 01:45:45 -0800 (PST) From: Felix Gu Date: Sun, 22 Feb 2026 17:45:39 +0800 Subject: [PATCH] iio: adc: nxp-sar-adc: Fix DMA channel leak in trigger mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260222-nxp-sar-adc-1-v1-1-0ec0e00b25cb@gmail.com> X-B4-Tracking: v=1; b=H4sIAELQmmkC/x3MQQqAIBBA0avIrBvQWZR1lWhhNtVsTBRCEO+et HyL/ytkTsIZFlUh8StZntBhBgX+duFilKMbSNOoiQhDiZhdQnd4NLh7N5lT23n3FnoTE59S/t+ 6tfYBluUCdF8AAAA= X-Change-ID: 20260222-nxp-sar-adc-1-bca71f089bc8 To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Ciprian Costea , Alexandru-Catalin Ionita , Daniel Lezcano Cc: Jonathan Cameron , "Radu Pirea (NXP OSS)" , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771753541; l=2021; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=Q58s3FaYS+W1+PdVhrq3Ap+aQAsxjqwX2JUo4/L8TAE=; b=5xmjjIQ/cHPtbQPy2j6CtxJ7urk8r2qt1qoTlij1+jRB9PJkPG0E1vRI3b+DMPAmsEW20amqR HBIhxgNd7GFBzQuZowMSNZq4NDKk40C3nXcuMKar05qwirtGhLIe2S8 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The DMA channel was requested in nxp_sar_adc_buffer_postenable() but was only released in nxp_sar_adc_buffer_software_do_predisable(). This caused a DMA channel resource leak when operating in trigger mode. Fix this by moving dma_request_chan() from nxp_sar_adc_buffer_postenable() into nxp_sar_adc_buffer_software_do_postenable(), ensuring the DMA channel is only requested in software mode. Fixes: 4434072a893e ("iio: adc: Add the NXP SAR ADC support for the s32g2/3= platforms") Signed-off-by: Felix Gu --- drivers/iio/adc/nxp-sar-adc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/nxp-sar-adc.c b/drivers/iio/adc/nxp-sar-adc.c index 9efa883c277d..890c8ef3132f 100644 --- a/drivers/iio/adc/nxp-sar-adc.c +++ b/drivers/iio/adc/nxp-sar-adc.c @@ -718,6 +718,10 @@ static int nxp_sar_adc_buffer_software_do_postenable(s= truct iio_dev *indio_dev) struct nxp_sar_adc *info =3D iio_priv(indio_dev); int ret; =20 + info->dma_chan =3D dma_request_chan(indio_dev->dev.parent, "rx"); + if (IS_ERR(info->dma_chan)) + return PTR_ERR(info->dma_chan); + nxp_sar_adc_dma_channels_enable(info, *indio_dev->active_scan_mask); =20 nxp_sar_adc_dma_cfg(info, true); @@ -738,7 +742,7 @@ static int nxp_sar_adc_buffer_software_do_postenable(st= ruct iio_dev *indio_dev) out_dma_channels_disable: nxp_sar_adc_dma_cfg(info, false); nxp_sar_adc_dma_channels_disable(info, *indio_dev->active_scan_mask); - + dma_release_channel(info->dma_chan); return ret; } =20 @@ -765,10 +769,6 @@ static int nxp_sar_adc_buffer_postenable(struct iio_de= v *indio_dev) unsigned long channel; int ret; =20 - info->dma_chan =3D dma_request_chan(indio_dev->dev.parent, "rx"); - if (IS_ERR(info->dma_chan)) - return PTR_ERR(info->dma_chan); - info->channels_used =3D 0; =20 /* --- base-commit: d4906ae14a5f136ceb671bb14cedbf13fa560da6 change-id: 20260222-nxp-sar-adc-1-bca71f089bc8 Best regards, --=20 Felix Gu