From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E1941B81CA for ; Sat, 21 Feb 2026 19:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700863; cv=none; b=kyOd+fZQi9iFChd4GuEj4x8EQqcR17LzpB/9xSfhTAl1KM2CfDymc9MjBy3CE/BVKo0mzpghHyT1vtpQDA2fKKjQuOyrMqp0Jmh1DLnBfWZxIwZOjJE+OPYrSo030h5HRWD0rZC0sDHN29pS9C+syfjhqmcS2i17j5MpNskJGjw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700863; c=relaxed/simple; bh=6b0oPTW9koAsZbmXaHb3i9jfo5XigfVeTFAdWCXEudM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lYq1H+j6vtKxt+TIpOevFvejQpHjF9kB+cVsTWZfAG4sPxI2VK/nU1uPGGaQ+pD++IREsOy56yhg349eyYPYpaPO2N81WEqhR5JG3zCDC4MW6vpq10AU/2XKltOv/fxUmo1OqRWRQW2kbNLsLdKNgkkEuq1bDevkKzDSj15MeC0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=VE2uzpKV; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="VE2uzpKV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771700861; bh=6b0oPTW9koAsZbmXaHb3i9jfo5XigfVeTFAdWCXEudM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VE2uzpKVD1SvbBCOiOapjBEEZ1GbxnGAJCEJqcrg5GwwvBUqIbJII3Pj6WBWapxpC WEubysV7AqDWGdyPVfnKgQwDbSRiwcROajuG5iJClqIEDmO0qlLocikDrB/h4LP0Vi nGmnY1dn0Wtcy3LjtzlWjqT0FqdOehS6+Uq3aqaz6b015Hnv0cHicOKchaYboAf9ru Y7DTWE3GzJMsnb00tNsNjG64mQCLnI1CP14WYJ1CYSE6Ot2YWdbAB/gRli8VygGQNv W9muyjHAhWrE+oNIApP3hzNsnHgpBscBcKraSynUtn+V3wm5G2e3nD6qX4mTbOGVlj ScEDmka7/Cy5A== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id D4DFF40221; Sat, 21 Feb 2026 19:07:40 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Archit Anant , Minu Jin , Andy Shevchenko , Thomas Gleixner , Yuvraj Singh Chauhan , JJ Strnad , Dan Carpenter , Julia Lawall , William Hansen-Baird , Randy Dunlap , Abraham Samuel Adekunle , Rodrigo Gobbi , Navaneeth K , Artur Stupa , Michael Straube , Hans de Goede , Vivek BalachandharTN , Ethan Tidmore , Zhuoheng Li , Michael Huang , Nino Zhang , Ingo Molnar , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , Diksha Kumari , yingche , Khushal Chitturi , Karthikey D Kadati , Akiyoshi Kurita , Erick Karanja , SeungJu Cheon , Sun Jian , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 01/11] staging: stl8723bs: Use common round_up macro Date: Sat, 21 Feb 2026 21:01:31 +0200 Message-ID: <20260221190628.50273-2-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Get rid of driver-specific _RND macro in favor of kernel one. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++--- drivers/staging/rtl8723bs/hal/sdio_ops.c | 4 ++-- drivers/staging/rtl8723bs/include/osdep_service.h | 2 -- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/stagi= ng/rtl8723bs/hal/rtl8723bs_xmit.c index a1f2cbf2cf55..c5b172c2f839 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -232,7 +232,7 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv /* check xmit_buf size enough or not */ txlen =3D txdesc_size + rtw_wlan_pkt_size(pxmitframe); if (!pxmitbuf || - ((_RND(pxmitbuf->len, 8) + txlen) > max_xmit_len) || + ((round_up(pxmitbuf->len, 8) + txlen) > max_xmit_len) || (k >=3D (rtw_hal_sdio_max_txoqt_free_space(padapter) - 1)) ) { if (pxmitbuf) { @@ -303,8 +303,8 @@ static s32 xmit_xmitframes(struct adapter *padapter, st= ruct xmit_priv *pxmitpriv txlen =3D txdesc_size + pxmitframe->attrib.last_txcmdsz; pxmitframe->pg_num =3D (txlen + 127) / 128; pxmitbuf->pg_num +=3D (txlen + 127) / 128; - pxmitbuf->ptail +=3D _RND(txlen, 8); /* round to 8 bytes alignment */ - pxmitbuf->len =3D _RND(pxmitbuf->len, 8) + txlen; + pxmitbuf->ptail +=3D round_up(txlen, 8); + pxmitbuf->len =3D round_up(pxmitbuf->len, 8) + txlen; } =20 if (k !=3D 1) diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl= 8723bs/hal/sdio_ops.c index c9cb20c61a2b..6bfb8c0e519c 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -401,7 +401,7 @@ static u32 sdio_read_port( hal_sdio_get_cmd_addr_8723b(adapter, addr, hal->SdioRxFIFOCnt++, &addr); =20 if (cnt > psdio->block_transfer_len) - cnt =3D _RND(cnt, psdio->block_transfer_len); + cnt =3D round_up(cnt, psdio->block_transfer_len); =20 err =3D _sd_read(intfhdl, addr, cnt, mem); =20 @@ -448,7 +448,7 @@ static u32 sdio_write_port( hal_sdio_get_cmd_addr_8723b(adapter, addr, cnt >> 2, &addr); =20 if (cnt > psdio->block_transfer_len) - cnt =3D _RND(cnt, psdio->block_transfer_len); + cnt =3D round_up(cnt, psdio->block_transfer_len); =20 err =3D sd_write(intfhdl, addr, cnt, xmitbuf->pdata); =20 diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/st= aging/rtl8723bs/include/osdep_service.h index 955e8678dc26..404f81756b27 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service.h +++ b/drivers/staging/rtl8723bs/include/osdep_service.h @@ -78,8 +78,6 @@ static inline int rtw_bug_check(void *parg1, void *parg2,= void *parg3, void *par =20 } =20 -#define _RND(sz, r) ((((sz)+((r)-1))/(r))*(r)) - extern void rtw_free_netdev(struct net_device *netdev); =20 /* Macros for handling unaligned memory accesses */ --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65F5614884C for ; Sat, 21 Feb 2026 19:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700885; cv=none; b=GAGgsF6wpaZJUrBfhSat8kDfTiTANwxej+I3onvjR9nH9YMYTfIbojxs9a1l8aocUD0MTCxKf/3jRmjiERdZ33tgsqvOic50NJRyBNUqO/KdWBddP7uZ02s6epgjq1l/mMnVs+NbYbOxIw9RXzc17FMatKF5myartmmBEDcebwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700885; c=relaxed/simple; bh=6JhWdVA671Zleucf7kEbXOLunhtJI/thjqtR51/ky0M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lgbHzRbmbilErx9HbbwVDiXcr7PG5873RFhF08FAe8ym2j9+2O8QYm+MltvbDifrjlzlK7IiYb42B9LoDArZLVsxltMYj9L9oTJddL1aYLkKiErahSXkIOBOexQrL8hy9zl/LIltolpIIhTWFGm7ANGW5QkAIagGkFaX3uBiz5w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=EPFh4QMW; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="EPFh4QMW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771700883; bh=6JhWdVA671Zleucf7kEbXOLunhtJI/thjqtR51/ky0M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EPFh4QMWkTtJJelDgiEQSXqi+z3fe6AP4cbXpM2maEulWgCC2zY6AEDqho1fpW4f/ kpgDeMjb3jJMCmIgHdox/Z1hQBxIhbkM4ypUNR4X+k1pcjYaKPhtpt9XJ1GQsjHShk q5Wshrp0D/lDU8oCj66lTA4FC28YOkHMPFm4zxXIxj5/zf3p5sZvFJlMaI0E2drChc vg11F5EQi29c7u0UqJGdvlVSUtZaddowOPyMzi7HHHtRyDaeZLrW6sn5K7ut0SWhzn xaGsZYLJ8V29svzUwQ5YO90fIdkYWfZMSaboxopKa+O4PMcDK9KZe/fo+Fl6Eycndt bR7/X8eMoQa1g== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id D3E6F400D2; Sat, 21 Feb 2026 19:08:02 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Archit Anant , Minu Jin , Andy Shevchenko , JJ Strnad , Bryant Boatright , Dan Carpenter , William Hansen-Baird , Randy Dunlap , Abraham Samuel Adekunle , Navaneeth K , Artur Stupa , Michael Straube , Hans de Goede , Vivek BalachandharTN , Ethan Tidmore , Zhuoheng Li , Michael Huang , Nino Zhang , Ingo Molnar , Thomas Gleixner , Diksha Kumari , yingche , Khushal Chitturi , Akiyoshi Kurita , Erick Karanja , SeungJu Cheon , Sun Jian , Yuvraj Singh Chauhan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 02/11] staging: rtl8723bs: Remove unused BIT32..BIT36 definitions Date: Sat, 21 Feb 2026 21:01:32 +0200 Message-ID: <20260221190628.50273-3-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BIT32..BIT36 seem to be not used anywhere. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/include/osdep_service.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/st= aging/rtl8723bs/include/osdep_service.h index 404f81756b27..f7b647db1a75 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service.h +++ b/drivers/staging/rtl8723bs/include/osdep_service.h @@ -46,11 +46,6 @@ #define BIT29 0x20000000 #define BIT30 0x40000000 #define BIT31 0x80000000 -#define BIT32 0x0100000000 -#define BIT33 0x0200000000 -#define BIT34 0x0400000000 -#define BIT35 0x0800000000 -#define BIT36 0x1000000000 =20 extern int RTW_STATUS_CODE(int error_code); =20 --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81E1B1B81CA for ; Sat, 21 Feb 2026 19:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700910; cv=none; b=GIVY7DKGXtspVqX/z47Mfb83IMhrFLgRorzHDPtTC2tDhV0ubzCw8reuyXxdQaPFDlcwymx0uqv0OdtF05VrgggsiSJts6ezfwdo/6Bz4qK6k6IJzYkM5T5xJeMuSgRozi+svyxaEjnxZiT3auM1gWPGyWmXF53kKPWJy4nuIGo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700910; c=relaxed/simple; bh=hwCQRywmvHqRuyBahiI4sZ82bYWbHHqhqlXz/JcLCZ8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bVm4s+y+vhWgp0BUeSeGcxsZCzThjDISoalbj7QYIorfgqybUSPS6dvufdy7Swrwi+hvlWY2ptuaUjYXYhwafSYRQOCLlftIc+mkm0BZoEKqf/eT4SvxxC77qKMLJ51ZoJ3NMdEQ+O4Qdg7iIj4pcerqleAKZ85Iuzawoft7eMA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=nc7VqkAX; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="nc7VqkAX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771700908; bh=hwCQRywmvHqRuyBahiI4sZ82bYWbHHqhqlXz/JcLCZ8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nc7VqkAXPjiJTcyk41TFa3JgzaP6dBIRdRTumoE514J3Y0hk4iF+r1te/Af39rJuQ KgLXCoHGNBhsqn1iuoaHmCVZSCdZICrE/2YVt6o+fvmiz18bF6LlV2Kn067j6pDJbH l/mMLl6YMFgb0kPpa2HnRutARkQm2CqOXV425d+iTS39LDfCHhJaggUmIMI8mgm/vS PWXjOGJTMttTiEs1xpzgVz3sDzUkRIpyuS2FDPEgvSJeexmXlTLfpgQ/akdmKJxbmC E4cX1DG26BN8cwLMry/2KbbCGhiOUPlBa7wQBbFNG5CQKMy4g8yK3efuNrGfpzUKzq h5Rwwm5TB8sXQ== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id 10C98405E6; Sat, 21 Feb 2026 19:08:28 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Archit Anant , Minu Jin , Andy Shevchenko , JJ Strnad , Thomas Gleixner , Dan Carpenter , Randy Dunlap , Ethan Tidmore , William Hansen-Baird , Navaneeth K , Tanjim Kamal , Artur Stupa , Abraham Samuel Adekunle , Michael Straube , Hans de Goede , Vivek BalachandharTN , Zhuoheng Li , Michael Huang , Nino Zhang , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , Ingo Molnar , Diksha Kumari , Milos Puric , Karthikey D Kadati , Khushal Chitturi , Akiyoshi Kurita , SeungJu Cheon , Erick Karanja , Sun Jian , Yuvraj Singh Chauhan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/11] staging: rtl8723bs: Drop empty rtw_bug_check function Date: Sat, 21 Feb 2026 21:01:33 +0200 Message-ID: <20260221190628.50273-4-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The rtw_bug_check was no-op returing true, so get rid of it and remove calls to it. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 10 ---------- drivers/staging/rtl8723bs/include/osdep_service.h | 8 -------- 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 22dc36e8e38a..7a346cbf2708 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -358,9 +358,6 @@ int is_same_network(struct wlan_bssid_ex *src, struct w= lan_bssid_ex *dst, u8 fea u16 s_cap, d_cap; __le16 tmps, tmpd; =20 - if (rtw_bug_check(dst, src, &s_cap, &d_cap) =3D=3D false) - return false; - memcpy((u8 *)&tmps, rtw_get_capability_from_ie(src->ies), 2); memcpy((u8 *)&tmpd, rtw_get_capability_from_ie(dst->ies), 2); =20 @@ -464,11 +461,6 @@ static void update_current_network(struct adapter *ada= pter, struct wlan_bssid_ex { struct mlme_priv *pmlmepriv =3D &adapter->mlmepriv; =20 - rtw_bug_check(&pmlmepriv->cur_network.network, - &pmlmepriv->cur_network.network, - &pmlmepriv->cur_network.network, - &pmlmepriv->cur_network.network); - if (check_fwstate(pmlmepriv, _FW_LINKED) && (is_same_network(&pmlmepriv->= cur_network.network, pnetwork, 0))) { update_network(&pmlmepriv->cur_network.network, pnetwork, adapter, true); rtw_update_protection(adapter, (pmlmepriv->cur_network.network.ies) + si= zeof(struct ndis_802_11_fix_ie), @@ -493,8 +485,6 @@ void rtw_update_scanned_network(struct adapter *adapter= , struct wlan_bssid_ex *t list_for_each(plist, phead) { pnetwork =3D list_entry(plist, struct wlan_network, list); =20 - rtw_bug_check(pnetwork, pnetwork, pnetwork, pnetwork); - if (is_same_network(&pnetwork->network, target, feature)) { target_find =3D 1; break; diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/st= aging/rtl8723bs/include/osdep_service.h index f7b647db1a75..d6710e5835f0 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service.h +++ b/drivers/staging/rtl8723bs/include/osdep_service.h @@ -65,14 +65,6 @@ static inline void flush_signals_thread(void) =20 #define rtw_warn_on(condition) WARN_ON(condition) =20 -static inline int rtw_bug_check(void *parg1, void *parg2, void *parg3, voi= d *parg4) -{ - int ret =3D true; - - return ret; - -} - extern void rtw_free_netdev(struct net_device *netdev); =20 /* Macros for handling unaligned memory accesses */ --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6A611B81CA for ; Sat, 21 Feb 2026 19:08:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700933; cv=none; b=q+imoObwdEAAln9d69stclP0GXB44QiWJEm3SIjcJbpisMTRRQjkiQmIEaJnp7zAdcCjkwszcWGLLL/w1zoAKhjtl6KO/q9fYanZetljaCZmxp/8xbiQuATeRpOiNvnL6ZVbqKGOaNUCGg5bb517hs1uw02jnOi5mHcMDXYoBZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700933; c=relaxed/simple; bh=e0kFqaLm5bGYI1JkuXE+ytuyr8AfALdhetjH8LPacG4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IRBxpWp/Mn9Rn5lEERpDYT0yDSD6r8JjepdHFZ7Lg+SMNQ5rKanmDD35M66cNYj83FLpv/4Fxa5Gb5CJ8EVlUTUEOCBhVpHk/44fxTrwYark9ZmUPL2lfYSEonQaGDNoynrkMS6rgYg4wt5wh5YFyI/cwALMsSFvnSj7u0BqP4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=TZLXqfL+; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="TZLXqfL+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771700930; bh=e0kFqaLm5bGYI1JkuXE+ytuyr8AfALdhetjH8LPacG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TZLXqfL+N+9Z2GY6uTRki+tS82EceHdGhGmbniHLFG1I0EODxHD+dnxGwb3ItP2yC zbmyUNoUg+9GhDzt6jmjEG/fEkVUJEkxXTjV8Pjf5hNcAa2Pz3NyEIikQcSEFZfcQ/ wks82/KUQ82kZEdZDiuFG4r18qxpHL/NKpggWmiGixsIWHR1NOE5pbBESyLV5Ue1HR UCIz34IkZ9aWpic6cctGJVjvMn50IQebe+YQygonGBVBQ1f+hXpoZUaEf3GgxrDfi5 2TZJCvJAnD8452i+pthRueCUkz8dUZdMB5ZyXAdAvaJZPPikncsV+71Pr+CGdUWa1m slEg/SI282oDA== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id 61D00400D2; Sat, 21 Feb 2026 19:08:50 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Archit Anant , Minu Jin , Andy Shevchenko , Yuvraj Singh Chauhan , Thomas Gleixner , JJ Strnad , Dan Carpenter , Abraham Samuel Adekunle , Navaneeth K , Ethan Tidmore , Artur Stupa , Tanjim Kamal , Rodrigo Gobbi , Michael Straube , Hans de Goede , Vivek BalachandharTN , Zhuoheng Li , Michael Huang , Nino Zhang , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , Ingo Molnar , William Hansen-Baird , Diksha Kumari , Milos Puric , yingche , Karthikey D Kadati , Khushal Chitturi , Erick Karanja , Akiyoshi Kurita , SeungJu Cheon , Sun Jian , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/11] staging: rtl8723bs: Remove unused rtw_sprintf macro Date: Sat, 21 Feb 2026 21:01:34 +0200 Message-ID: <20260221190628.50273-5-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove unused `rtw_sprintf` macro. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/include/osdep_service.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/st= aging/rtl8723bs/include/osdep_service.h index d6710e5835f0..cf75760d364a 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service.h +++ b/drivers/staging/rtl8723bs/include/osdep_service.h @@ -85,10 +85,4 @@ bool rtw_cbuf_push(struct rtw_cbuf *cbuf, void *buf); void *rtw_cbuf_pop(struct rtw_cbuf *cbuf); struct rtw_cbuf *rtw_cbuf_alloc(u32 size); =20 -/* String handler */ -/* - * Write formatted output to sized buffer - */ -#define rtw_sprintf(buf, size, format, arg...) snprintf(buf, size, format,= ##arg) - #endif --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C058D2566E9 for ; Sat, 21 Feb 2026 19:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700958; cv=none; b=mnF9HDnquQi8wvDXD3v72d6glya7nn4tV/9gNYxDLo8ySavCQAuSEehWwHfJvXstcYw1IKvxSaCRCQUIFx1N0/kLcq7MRLY3NOV/tx4HA/yoHSVVt3Fg5+8t5M88C2K74yOfUEk3g6uUiEAJ5cLWTEBKxeCS+7bfKdxD0UiWyT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700958; c=relaxed/simple; bh=gV1A73BX2x9F7rmRIf6mIVSh6xQFoDvn74quOfSVF0Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RZOKgsZBChuzefs2qujB4h4dW5qT2NMEkOHZaQHJ5Lgz8sY/syPdkqDdbMtFfiYJ4wXO7WGONInU8q0DzEnlfRTVzDRa8oJTm06KWlykmIqG7gh3th1zZ6cPkiokVtuMPOWGM+SZZdbVmBpVenir/KenkGCSJvlBsF/mv7lzblM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=N470Z0wk; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="N470Z0wk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771700956; bh=gV1A73BX2x9F7rmRIf6mIVSh6xQFoDvn74quOfSVF0Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=N470Z0wk6wPoLBO7W0jbsXhYsGfQ+TNHjv0A4h7qZhN0yTC+jeQZe72KkjpjrMlJx xWubnldBIzz3UyYDelZux0kwZPInAf2jTWDVEMXAv/L3vayuGrqzLcx+tGEjC91Yz8 xj6XDsOgG0DYK3Q5EVoCq4vUFOKBzhqPzH7ZOW1RweCmcDVnaj2R5WwIl8uRSaYRdi UCnOUIs0uuVmNItGdMuRGIc04mCrpMtMIIozljJA2MjkCe8HgdrCri9wprVyepUM9m IIOz27iOZ4/d5IP3I1BHDlrJB7y/4itCgQveFLpKa45991yYsNDc16utwpjUEx06Zk yKVMOqCpqCsEQ== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id 3D37C40221; Sat, 21 Feb 2026 19:09:16 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Archit Anant , Minu Jin , Andy Shevchenko , Thomas Gleixner , Bryant Boatright , JJ Strnad , Dan Carpenter , Abraham Samuel Adekunle , Julia Lawall , Rodrigo Gobbi , Navaneeth K , Tanjim Kamal , Artur Stupa , Michael Straube , Hans de Goede , Ethan Tidmore , Vivek BalachandharTN , Zhuoheng Li , Michael Huang , Nino Zhang , Ingo Molnar , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , William Hansen-Baird , Omer El Idrissi , Diksha Kumari , Milos Puric , Khushal Chitturi , SeungJu Cheon , Erick Karanja , Akiyoshi Kurita , Sun Jian , Yuvraj Singh Chauhan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 05/11] staging: rtl8723bs: Drop unused _kfree(...) declaration. Date: Sat, 21 Feb 2026 21:01:35 +0200 Message-ID: <20260221190628.50273-6-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop unused `_kfree()` definition from header file. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/include/osdep_service.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/st= aging/rtl8723bs/include/osdep_service.h index cf75760d364a..59fc2cdb195d 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service.h +++ b/drivers/staging/rtl8723bs/include/osdep_service.h @@ -49,8 +49,6 @@ =20 extern int RTW_STATUS_CODE(int error_code); =20 -void _kfree(u8 *pbuf, u32 sz); - int _rtw_netif_rx(struct net_device *ndev, struct sk_buff *skb); =20 #define rtw_netif_rx(ndev, skb) _rtw_netif_rx(ndev, skb) --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DE6E231A21 for ; Sat, 21 Feb 2026 19:09:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700985; cv=none; b=nzprN7PczNmrMWnC0WDFtdBxca2ZB8LFAPUTk8jRAHIryrXLCmvIFCFBb+LuxfEeDtlFiYAcCyEAKSqf+LNKmKZjGFV89fAgJ9UJHwbjJACIxfCxDHvqQ7IUybGdMX01X6IverXXaNF+Z003K13zRUpipI1kRAVxF+mH5JljlAw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771700985; c=relaxed/simple; bh=CTiPD3Zm3FY+6eVc0GtVeyPiweg4pLYt7+jWqj0vv7M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q9jGaJN3ESsrRRJ0oH/FkJ6K3hsdEzZOa42l0OIv1w89rWVoh6S5mklPuHyZOdjD5PBrzYEW1QRgJi/keugyAPWsqFX9I7I1fDBpe1NogQZys3hcVP3mMEpXWwjLf6M85HmGg8qelVYDoo6X7MjYoY9JBeJ10U5uZlELaoom68M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=ldSdW76E; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="ldSdW76E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771700982; bh=CTiPD3Zm3FY+6eVc0GtVeyPiweg4pLYt7+jWqj0vv7M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ldSdW76EvUmJu1TUEHTz7+GctlEHVG9EeFi+hbmgChpn6gm0pzP+aKqHzY79wv4AC 8cSrvhHvEGSfhXV42WmtIPSffIOprl0wg/D0uLEJsX1UI6UcK5y8GfPFJKI3st5LR8 TNVDYC88nmpxLxB6wVeGLJGWyOYvk340hiqShd1iOJv/nUq3V2TccBdHDKMviVPxzF 6nz7sQxNwIhIVd5f2wsL/7dwFh/p4i4ciT6ybZKc45i9ru6aE7wSFvgHwmk1RHaE4l 9Mbok3XGj90xG8ggRet4tzwUsZwUyH2xSxoQggCV9Qz1WofOmj8qMAFAEy8/raGx/g rGWQK7fVd/81A== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id BBA81400D2; Sat, 21 Feb 2026 19:09:42 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Minu Jin , Archit Anant , Andy Shevchenko , Thomas Gleixner , Philip Thayer , JJ Strnad , Dan Carpenter , Tanjim Kamal , Ethan Tidmore , Abraham Samuel Adekunle , Navaneeth K , William Hansen-Baird , Artur Stupa , Randy Dunlap , Michael Straube , Hans de Goede , Vivek BalachandharTN , Zhuoheng Li , Michael Huang , Nino Zhang , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , Ingo Molnar , Omer El Idrissi , Diksha Kumari , yingche , Milos Puric , Khushal Chitturi , Erick Karanja , SeungJu Cheon , Akiyoshi Kurita , Sun Jian , Yuvraj Singh Chauhan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/11] staging: rtl8723bs: Get rid of unused _rtw_init_queue Date: Sat, 21 Feb 2026 21:01:36 +0200 Message-ID: <20260221190628.50273-7-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" While `_rtw_init_queue` function was reworked ~4 years ago, there were still some leftovers in commented out code and also header file. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/core/rtw_recv.c | 3 --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 1 - drivers/staging/rtl8723bs/core/rtw_xmit.c | 4 ---- drivers/staging/rtl8723bs/include/osdep_service.h | 2 -- 4 files changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index 337671b1211f..e0c901a5459e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -21,9 +21,6 @@ void _rtw_init_sta_recv_priv(struct sta_recv_priv *psta_r= ecvpriv) =20 spin_lock_init(&psta_recvpriv->lock); =20 - /* for (i =3D 0; iblk_strms[i]); */ - INIT_LIST_HEAD(&psta_recvpriv->defrag_q.queue); spin_lock_init(&psta_recvpriv->defrag_q.lock); } diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging= /rtl8723bs/core/rtw_sta_mgt.c index bdd4b6d8fd2e..76d32ae8ac9e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c +++ b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c @@ -67,7 +67,6 @@ u32 _rtw_init_sta_priv(struct sta_priv *pstapriv) =20 spin_lock_init(&pstapriv->sta_hash_lock); =20 - /* _rtw_init_queue(&pstapriv->asoc_q); */ pstapriv->asoc_sta_count =3D 0; INIT_LIST_HEAD(&pstapriv->sleep_q.queue); spin_lock_init(&pstapriv->sleep_q.lock); diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 222851e8d985..c2833f3cd10b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -43,10 +43,6 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, str= uct adapter *padapter) init_completion(&pxmitpriv->xmit_comp); init_completion(&pxmitpriv->terminate_xmitthread_comp); =20 - /* - * Please insert all the queue initialization using _rtw_init_queue below - */ - pxmitpriv->adapter =3D padapter; =20 INIT_LIST_HEAD(&pxmitpriv->be_pending.queue); diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/st= aging/rtl8723bs/include/osdep_service.h index 59fc2cdb195d..37e8ddb01dcd 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service.h +++ b/drivers/staging/rtl8723bs/include/osdep_service.h @@ -53,8 +53,6 @@ int _rtw_netif_rx(struct net_device *ndev, struct sk_buff= *skb); =20 #define rtw_netif_rx(ndev, skb) _rtw_netif_rx(ndev, skb) =20 -extern void _rtw_init_queue(struct __queue *pqueue); - static inline void flush_signals_thread(void) { if (signal_pending(current)) --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8C05231A21 for ; Sat, 21 Feb 2026 19:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701005; cv=none; b=FYWJ6z9fKQvSx9haiGG3WoJsraR8oo/mlcV740WexfRk6yH0LDX5hLTWXQ7hXw+zTbs1xaB4D29cdreZ70NmXmjWry8cxhyAZ3vAQTYAmsiSaNgCdnClyNDVhHfWa093FQcIa387Dvbfyeb4/I9XYmnp+sTtxMA3rrEdNLvYtgo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701005; c=relaxed/simple; bh=o4Jscv6vkyIh7GIMFfWCIGxqqG4HSk4Zqtr9dg2x0Hg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=phbjXIbg02EoMko/8u3x6Ajlgs7mcXQyjtilsLMz1zTZJGvrrTVoKFDR49BkV2ItE3jHbAkHMzlOM9zaw3WGB6qyw20Sjc6N2NOYCHHkK1OY5RRGzl2naJbUKwGD4aeq44uHwCT2IqilYRDtcELPL/ksTTHKjbjRWu8y4VdEn50= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=E3+NEcla; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="E3+NEcla" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771701003; bh=o4Jscv6vkyIh7GIMFfWCIGxqqG4HSk4Zqtr9dg2x0Hg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E3+NEclazmaqkrjToLac+zcKB9YX72+I5EP0mMlZZPccngip+bSX2MoFJoTFnTvWu s/2lCvwBj0DbIBwfFnTcaYcEkfjNjmpyLW/U5e9qRFiLWqg/wj16gmz/MGL5HQyAa6 yDFE8/PKFW+VMkxwIHgrFN1FRFTUArXNdNUoRQOUSNAPmUln4azJJUW/6jxMJIAokj oS+H2zqKwGYL6rqdbNQOsevujUhJ0Ff3QYUh7Qi5b+79GlADYbQOHF2SwuagiR8UkX eS0MZgyTPSDA94aVF6lOGCWh1kY0WG8Fk/h7749VwfEWzGhxRxzpeVBn+f7SVq/5Eq hMU+u1iZGeuuQ== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id 1566D40221; Sat, 21 Feb 2026 19:10:03 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Minu Jin , Archit Anant , Andy Shevchenko , Yuvraj Singh Chauhan , Bryant Boatright , JJ Strnad , Dan Carpenter , Rodrigo Gobbi , Tanjim Kamal , Navaneeth K , Abraham Samuel Adekunle , Randy Dunlap , William Hansen-Baird , Artur Stupa , Michael Straube , Hans de Goede , Ethan Tidmore , Vivek BalachandharTN , Zhuoheng Li , Michael Huang , Nino Zhang , Ingo Molnar , Omer El Idrissi , Thomas Gleixner , Diksha Kumari , yingche , Milos Puric , Khushal Chitturi , Akiyoshi Kurita , SeungJu Cheon , Erick Karanja , Sun Jian , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/11] staging: rtl8723bs: Drop unused NDEV-related formatting macros Date: Sat, 21 Feb 2026 21:01:37 +0200 Message-ID: <20260221190628.50273-8-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop unused NDEV_ARG, FUNC_NDEV_FMT and FUNC_NDEV_ARG macros. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/include/osdep_service_linux.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/driv= ers/staging/rtl8723bs/include/osdep_service_linux.h index 2ec54f9e180c..c8274da940ff 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h +++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h @@ -98,10 +98,7 @@ static inline void rtw_netif_stop_queue(struct net_devic= e *pnetdev) =20 #define rtw_signal_process(pid, sig) kill_pid(find_vpid((pid)), (sig), 1) =20 -#define NDEV_ARG(ndev) ndev->name #define ADPT_ARG(adapter) adapter->pnetdev->name -#define FUNC_NDEV_FMT "%s(%s)" -#define FUNC_NDEV_ARG(ndev) __func__, ndev->name #define FUNC_ADPT_FMT "%s(%s)" #define FUNC_ADPT_ARG(adapter) __func__, adapter->pnetdev->name =20 --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10C11307AF0 for ; Sat, 21 Feb 2026 19:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701026; cv=none; b=qtHzaOacToRcKEMSoUdmxDsOcINfQyx4v3Ij654UX/3dnnXmChaWqPifniySeVssa1B8iblAdsqs5CUs415ayOAd4Dqy+q1/eKn6fDN43almxicZhxrsbChpknvZko4OipfAa3wro9XgoPKmxQiWa63+104L7ED9zZiRUT0JXzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701026; c=relaxed/simple; bh=JxUfkBhilVvOHdFurYyaFG+IeFm8x975Z0QcPNTfezg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ktobebfz1kotW0kxUCu4pipohxdhYewmcG4o5PARkuJ+/d9daYaaY84w9acfrrfiJadr4foYWyjIaE+FpOITYM0vEk0o7Rr9lKva1BZAjcClfqQ+Z7DtRHHGSHK6vxZelaf6fbaXYuqxWAZRdIQmbu8axF5HlJiwr0D9MiuD/ko= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=UsvPUvtL; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="UsvPUvtL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771701023; bh=JxUfkBhilVvOHdFurYyaFG+IeFm8x975Z0QcPNTfezg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UsvPUvtLGsUGfQW33XPXG01VAl4Fibqav3q4g9DeNqO8O8JsBo8/m9YdFpjMXmq9j ALDUFpbjoznU/VfAIogIloWUMJ7HMPGycoA/NNpl41uQG/iHjgp/lCkA5KVTwBZ0bH seNKOSeDtKoHnTcqC51TK7NYz1SZj6j77X2K8yzCo8JCOhyToLQcpmxBhrRuq4HgHJ Z+XL4Vstq693+izscJt9Okc1A2dV1zI5h5epDrPuTA4+xyLQoZAdJwYFvYP8N6074j 1qF/Kn6n4aqrPFTMEeS35sOCIwMnue8RQpNg3gB00EblqsD826QEVi2KlqNIOOQVHo e5QQUoEBvOu5w== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id 6A96E400D2; Sat, 21 Feb 2026 19:10:23 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Minu Jin , Archit Anant , Andy Shevchenko , Yuvraj Singh Chauhan , Philip Thayer , JJ Strnad , Dan Carpenter , Rodrigo Gobbi , Navaneeth K , Abraham Samuel Adekunle , Randy Dunlap , William Hansen-Baird , Tanjim Kamal , Artur Stupa , Michael Straube , Hans de Goede , Ingo Molnar , Vivek BalachandharTN , Ethan Tidmore , Zhuoheng Li , Michael Huang , Nino Zhang , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , Thomas Gleixner , Diksha Kumari , yingche , Khushal Chitturi , Akiyoshi Kurita , SeungJu Cheon , Erick Karanja , Sun Jian , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 08/11] staging: rtl8723bs: Drop workqueue wrapper functions Date: Sat, 21 Feb 2026 21:01:38 +0200 Message-ID: <20260221190628.50273-9-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace custom workqueue wrapper functions: * _init_workitem -> INIT_WORK * _cancel_workitem_sync -> cancel_work_sync * _set_workitem -> schedule_work Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 4 ++-- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 6 +++--- drivers/staging/rtl8723bs/hal/sdio_ops.c | 4 ++-- .../rtl8723bs/include/osdep_service_linux.h | 15 --------------- 4 files changed, 7 insertions(+), 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index b2e7f479f72b..d0694a659259 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -201,7 +201,7 @@ int rtw_init_evt_priv(struct evt_priv *pevtpriv) atomic_set(&pevtpriv->event_seq, 0); pevtpriv->evt_done_cnt =3D 0; =20 - _init_workitem(&pevtpriv->c2h_wk, c2h_wk_callback, NULL); + INIT_WORK(&pevtpriv->c2h_wk, c2h_wk_callback); pevtpriv->c2h_wk_alive =3D false; pevtpriv->c2h_queue =3D rtw_cbuf_alloc(C2H_QUEUE_MAX_LEN + 1); if (!pevtpriv->c2h_queue) @@ -212,7 +212,7 @@ int rtw_init_evt_priv(struct evt_priv *pevtpriv) =20 void _rtw_free_evt_priv(struct evt_priv *pevtpriv) { - _cancel_workitem_sync(&pevtpriv->c2h_wk); + cancel_work_sync(&pevtpriv->c2h_wk); while (pevtpriv->c2h_wk_alive) msleep(10); =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index 1c9e02732687..c93c7357b3f0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -670,7 +670,7 @@ static void pwr_rpwm_timeout_handler(struct timer_list = *t) if ((pwrpriv->rpwm =3D=3D pwrpriv->cpwm) || (pwrpriv->cpwm >=3D PS_STATE_= S2)) return; =20 - _set_workitem(&pwrpriv->rpwmtimeoutwi); + schedule_work(&pwrpriv->rpwmtimeoutwi); } =20 static inline void register_task_alive(struct pwrctrl_priv *pwrctrl, u32 t= ag) @@ -971,11 +971,11 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter) =20 rtw_hal_set_hwreg(padapter, HW_VAR_SET_RPWM, (u8 *)(&pwrctrlpriv->rpwm)); =20 - _init_workitem(&pwrctrlpriv->cpwm_event, cpwm_event_callback, NULL); + INIT_WORK(&pwrctrlpriv->cpwm_event, cpwm_event_callback); =20 pwrctrlpriv->brpwmtimeout =3D false; pwrctrlpriv->adapter =3D padapter; - _init_workitem(&pwrctrlpriv->rpwmtimeoutwi, rpwmtimeout_workitem_callback= , NULL); + INIT_WORK(&pwrctrlpriv->rpwmtimeoutwi, rpwmtimeout_workitem_callback); timer_setup(&pwrctrlpriv->pwr_rpwm_timer, pwr_rpwm_timeout_handler, 0); timer_setup(&pwrctrlpriv->pwr_state_check_timer, pwr_state_check_handler, 0); diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl= 8723bs/hal/sdio_ops.c index 6bfb8c0e519c..ea373276f9cd 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -876,7 +876,7 @@ void sd_int_dpc(struct adapter *adapter) =20 SdioLocalCmd52Read1Byte(adapter, SDIO_REG_HCPWM1_8723B); =20 - _set_workitem(&(pwrctl->cpwm_event)); + schedule_work(&(pwrctl->cpwm_event)); } =20 if (hal->sdio_hisr & SDIO_HISR_TXERR) { @@ -912,7 +912,7 @@ void sd_int_dpc(struct adapter *adapter) } else { /* Error handling for malloc fail */ rtw_cbuf_push(adapter->evtpriv.c2h_queue, NULL); - _set_workitem(&adapter->evtpriv.c2h_wk); + schedule_work(&adapter->evtpriv.c2h_wk); } } =20 diff --git a/drivers/staging/rtl8723bs/include/osdep_service_linux.h b/driv= ers/staging/rtl8723bs/include/osdep_service_linux.h index c8274da940ff..ebaa2f1d4af7 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service_linux.h +++ b/drivers/staging/rtl8723bs/include/osdep_service_linux.h @@ -58,21 +58,6 @@ static inline void _set_timer(struct timer_list *ptimer,= u32 delay_time) mod_timer(ptimer, (jiffies + (delay_time * HZ / 1000))); } =20 -static inline void _init_workitem(struct work_struct *pwork, void *pfunc, = void *cntx) -{ - INIT_WORK(pwork, pfunc); -} - -static inline void _set_workitem(struct work_struct *pwork) -{ - schedule_work(pwork); -} - -static inline void _cancel_workitem_sync(struct work_struct *pwork) -{ - cancel_work_sync(pwork); -} - static inline int rtw_netif_queue_stopped(struct net_device *pnetdev) { return (netif_tx_queue_stopped(netdev_get_tx_queue(pnetdev, 0)) && --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D50F14884C for ; Sat, 21 Feb 2026 19:10:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701046; cv=none; b=LxGy3umK2x3cCVpJrQSK0iC6U2bdBZduX4DHf0HvhHohs1OxUiH+HZ/6qOwvKy93Bn53XMZCGZ/dw58k9ySD6FutYazzuboDSZ2MCd0FtWPRx+8bmz1bB2EwCM3SoxZ5s3JoA/TWWzOzQLYQLBAmzoLJN+2KrjtHcaXmT6AIALU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701046; c=relaxed/simple; bh=TTNrBDecyN7RGvcGSw5dDmPKPfVUcUS0WDDh6QU5eGY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ODWPpKsJhNj4uZW5+mRxSkKSr/a4IFeIRyaviqU6AJhMe59CS+5KRKkr4qffTGlRB4izEHG1IeOhMk177kSGmb6vS9Q+xXQdLCUZgMdxmqufczMkd9ziR8ko3K1m1PuAZNL+HoT+959I3sHympFgWw9KvmjT0aHPfYNYcb4Gc7Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=M+U4bnLn; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="M+U4bnLn" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771701043; bh=TTNrBDecyN7RGvcGSw5dDmPKPfVUcUS0WDDh6QU5eGY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=M+U4bnLnuRPZwHkM7IJQMMq62IP9brJY88iypGiyklqalHUOlon6vGVLB3o+2Y59f 1lvKRTnKBTPOE+cgzA2VGvJHMghAUBKU3FtAuc2ejQ5Tck09HtdV3F4QkHb8hIHRCK aoZ1bPaFf2XH43aDuClz0+GCebmp0qdHg7hQy6phYnL0/Ul9zt2uU0OEu7AcIwPTdr jKp4JQgVWVa/wuKWbHmyEFYEDoukEwIVil+SVZ2oPk3S5CIMJ+4WE29WJ8jzpn1SDz 24BeIQMBy3jIM1pA/za/V6+slTBIzEPtJwTXe4euazfkYE0N5gVzLBwgZO9oIVByo0 HoyuC9s2SznZg== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id A9F47400D2; Sat, 21 Feb 2026 19:10:43 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Minu Jin , Archit Anant , Andy Shevchenko , Bryant Boatright , Philip Thayer , JJ Strnad , Dan Carpenter , Tanjim Kamal , Artur Stupa , Abraham Samuel Adekunle , Rodrigo Gobbi , Navaneeth K , William Hansen-Baird , Michael Straube , Hans de Goede , Vivek BalachandharTN , Ethan Tidmore , Zhuoheng Li , Michael Huang , Nino Zhang , Thomas Gleixner , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , Ingo Molnar , Omer El Idrissi , Diksha Kumari , yingche , Milos Puric , Khushal Chitturi , SeungJu Cheon , Akiyoshi Kurita , Erick Karanja , Sun Jian , Yuvraj Singh Chauhan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/11] staging: rtl8273bs: Simplify regulatory initialization functions Date: Sat, 21 Feb 2026 21:01:39 +0200 Message-ID: <20260221190628.50273-10-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify code, by cutting out wrapper function in regulatory initialization code. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 27 +++----------------- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c b/drivers/staging= /rtl8723bs/os_dep/wifi_regd.c index f9c4d487badf..878a2ee08d25 100644 --- a/drivers/staging/rtl8723bs/os_dep/wifi_regd.c +++ b/drivers/staging/rtl8723bs/os_dep/wifi_regd.c @@ -91,40 +91,21 @@ static int _rtw_reg_notifier_apply(struct wiphy *wiphy, return 0; } =20 -static const struct ieee80211_regdomain *_rtw_regdomain_select(struct - rtw_regulatory - *reg) -{ - return &rtw_regdom_rd; -} - -static void _rtw_regd_init_wiphy(struct rtw_regulatory *reg, - struct wiphy *wiphy, - void (*reg_notifier)(struct wiphy *wiphy, - struct - regulatory_request * - request)) +void rtw_regd_init(struct wiphy *wiphy, + void (*reg_notifier)(struct wiphy *wiphy, + struct regulatory_request *request)) { - const struct ieee80211_regdomain *regd; - wiphy->reg_notifier =3D reg_notifier; =20 wiphy->regulatory_flags |=3D REGULATORY_CUSTOM_REG; wiphy->regulatory_flags &=3D ~REGULATORY_STRICT_REG; wiphy->regulatory_flags &=3D ~REGULATORY_DISABLE_BEACON_HINTS; =20 - regd =3D _rtw_regdomain_select(reg); - wiphy_apply_custom_regulatory(wiphy, regd); + wiphy_apply_custom_regulatory(wiphy, &rtw_regdom_rd); =20 /* Hard code flags */ _rtw_reg_apply_flags(wiphy); -} =20 -void rtw_regd_init(struct wiphy *wiphy, - void (*reg_notifier)(struct wiphy *wiphy, - struct regulatory_request *request)) -{ - _rtw_regd_init_wiphy(NULL, wiphy, reg_notifier); } =20 void rtw_reg_notifier(struct wiphy *wiphy, struct regulatory_request *requ= est) --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3CE314D14 for ; Sat, 21 Feb 2026 19:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701067; cv=none; b=KpwPbLXkRcdXFEqzP2ifL49ZrPuSjYQ3glBdcZ3R3uJa/NLDbum1SfzFpvfNtU/8hjxtdwMCWJ+YWFsJn4uCZ0qtOGeEhVr0RC06PqNwWkolaR+Ny/EdEXfFLpuz9W+TIMapSZzpr/SyA4rUezXY2lH/ltPbwQ2brfIpDDISNBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701067; c=relaxed/simple; bh=V0ffyhAwxWSZNSENcuj90HHm3R5vaHjc8Gev7V1Rywc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LwHGAcL4arJaeP5jc0UMCe9YoJo5O7S5OIQvlTWW6NRROhMH6Vy/Jtasqq17UN3sT7FEyzFnl4cRZ26qfNqlpv5uFQZbafAyllfI1goQERreIJntldXoTeahZA58e4uHxijDeab1ON/4OqahDJWmNpQm2cIji8GypVonkVOAwo0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=LxZuYRfI; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="LxZuYRfI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771701064; bh=V0ffyhAwxWSZNSENcuj90HHm3R5vaHjc8Gev7V1Rywc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LxZuYRfIc1jN0e/elTzlQUUYT0WacO/0s08iHQltTwQQiO80ceEwgrhbA8Y1a7khC vBiDfXICbNoyYxs6Hsg8DxzjGBnt7US5Bmj0o5e/LCJjIvNfVDnd11PHOQpsX906ie V5CSu9LdosZGN3v+TGNqjFD7s0QJ3g2TX5BP2AMLQ28qvO6HvQjNoeVUcc5R6XLBed 1Ed2075KNuEr2I7CZGOhYLm007eEAoK60uszdFMRoKav5dUADAKQTBf8mz+pgKTnJO jQYfLdztRb8Kb4dpgGI9Yn25bNrH+UqhKc8Gq5JXi9T1kXaFQ/GHV0W6/TtBZqWbOh f83wb+xqcHqeg== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id C147F400D2; Sat, 21 Feb 2026 19:11:03 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Minu Jin , Archit Anant , Andy Shevchenko , Philip Thayer , Bryant Boatright , JJ Strnad , Dan Carpenter , William Hansen-Baird , Navaneeth K , Julia Lawall , Tanjim Kamal , Randy Dunlap , Rodrigo Gobbi , Artur Stupa , Abraham Samuel Adekunle , Michael Straube , Hans de Goede , Ingo Molnar , Ethan Tidmore , Vivek BalachandharTN , Zhuoheng Li , Michael Huang , Nino Zhang , Thomas Gleixner , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , Diksha Kumari , yingche , Karthikey D Kadati , Khushal Chitturi , SeungJu Cheon , Akiyoshi Kurita , Erick Karanja , Sun Jian , Yuvraj Singh Chauhan , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 10/11] staging: rtl8723bs: Clean up wrapper functions Date: Sat, 21 Feb 2026 21:01:40 +0200 Message-ID: <20260221190628.50273-11-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove wrapper functions in cmd queue handling. Signed-off-by: Priit Laes --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 88 ++++++++----------- drivers/staging/rtl8723bs/include/cmd_osdep.h | 7 +- 2 files changed, 39 insertions(+), 56 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index d0694a659259..60e2de7991d4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -210,32 +210,6 @@ int rtw_init_evt_priv(struct evt_priv *pevtpriv) return 0; } =20 -void _rtw_free_evt_priv(struct evt_priv *pevtpriv) -{ - cancel_work_sync(&pevtpriv->c2h_wk); - while (pevtpriv->c2h_wk_alive) - msleep(10); - - while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) { - void *c2h =3D rtw_cbuf_pop(pevtpriv->c2h_queue); - - if (c2h && c2h !=3D (void *)pevtpriv) - kfree(c2h); - } - kfree(pevtpriv->c2h_queue); -} - -void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) -{ - if (pcmdpriv) { - kfree(pcmdpriv->cmd_allocated_buf); - - kfree(pcmdpriv->rsp_allocated_buf); - - mutex_destroy(&pcmdpriv->sctx_mutex); - } -} - /* * Calling Context: * @@ -246,7 +220,7 @@ void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) * */ =20 -int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj) +static int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj) { unsigned long irqL; =20 @@ -265,38 +239,35 @@ int _rtw_enqueue_cmd(struct __queue *queue, struct cm= d_obj *obj) return _SUCCESS; } =20 -struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue) +void rtw_free_evt_priv(struct evt_priv *pevtpriv) { - unsigned long irqL; - struct cmd_obj *obj; - - /* spin_lock_bh(&(queue->lock)); */ - spin_lock_irqsave(&queue->lock, irqL); - if (list_empty(&queue->queue)) { - obj =3D NULL; - } else { - obj =3D container_of(get_next(&queue->queue), struct cmd_obj, list); - list_del_init(&obj->list); - } + cancel_work_sync(&pevtpriv->c2h_wk); + while (pevtpriv->c2h_wk_alive) + msleep(10); =20 - /* spin_unlock_bh(&(queue->lock)); */ - spin_unlock_irqrestore(&queue->lock, irqL); + while (!rtw_cbuf_empty(pevtpriv->c2h_queue)) { + void *c2h =3D rtw_cbuf_pop(pevtpriv->c2h_queue); =20 - return obj; -} + if (c2h && c2h !=3D (void *)pevtpriv) + kfree(c2h); + } + kfree(pevtpriv->c2h_queue); =20 -void rtw_free_evt_priv(struct evt_priv *pevtpriv) -{ - _rtw_free_evt_priv(pevtpriv); } =20 void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv) { - _rtw_free_cmd_priv(pcmdpriv); + if (pcmdpriv) { + kfree(pcmdpriv->cmd_allocated_buf); + + kfree(pcmdpriv->rsp_allocated_buf); + + mutex_destroy(&pcmdpriv->sctx_mutex); + } + } =20 -int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj); -int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj) +static int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_o= bj) { u8 bAllow =3D false; /* set to true to allow enqueuing cmd when hw_init_c= ompleted is false */ =20 @@ -337,7 +308,24 @@ int rtw_enqueue_cmd(struct cmd_priv *pcmdpriv, struct = cmd_obj *cmd_obj) =20 struct cmd_obj *rtw_dequeue_cmd(struct cmd_priv *pcmdpriv) { - return _rtw_dequeue_cmd(&pcmdpriv->cmd_queue); + unsigned long irqL; + struct cmd_obj *obj; + struct __queue *queue =3D &pcmdpriv->cmd_queue; + + /* spin_lock_bh(&(queue->lock)); */ + spin_lock_irqsave(&queue->lock, irqL); + if (list_empty(&queue->queue)) { + obj =3D NULL; + } else { + obj =3D container_of(get_next(&queue->queue), struct cmd_obj, list); + list_del_init(&obj->list); + } + + /* spin_unlock_bh(&(queue->lock)); */ + spin_unlock_irqrestore(&queue->lock, irqL); + + return obj; + } =20 void rtw_free_cmd_obj(struct cmd_obj *pcmd) diff --git a/drivers/staging/rtl8723bs/include/cmd_osdep.h b/drivers/stagin= g/rtl8723bs/include/cmd_osdep.h index 5506f513dc01..b0ac41d2be24 100644 --- a/drivers/staging/rtl8723bs/include/cmd_osdep.h +++ b/drivers/staging/rtl8723bs/include/cmd_osdep.h @@ -7,12 +7,7 @@ #ifndef __CMD_OSDEP_H_ #define __CMD_OSDEP_H_ =20 - -int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); +int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv); int rtw_init_evt_priv(struct evt_priv *pevtpriv); -extern void _rtw_free_evt_priv(struct evt_priv *pevtpriv); -extern void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv); -int _rtw_enqueue_cmd(struct __queue *queue, struct cmd_obj *obj); -extern struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue); =20 #endif --=20 2.53.0 From nobody Fri Apr 17 09:18:08 2026 Received: from mail.plaes.org (mail.plaes.org [188.166.43.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FD7E30CD80 for ; Sat, 21 Feb 2026 19:11:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=188.166.43.21 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701086; cv=none; b=K92iZF1aCvGLq0KlyHlK6AZLXypBzJjvHrzYtRbr63TELUj7/NpXr5lwE58OI4rz/WFNHjvgtn6jP/cIsm6h1+gpMCxmwE4pmxWbZTRlgxUeIIXsft+okC9nW+iiENBJRsHyLT9BgsJUCqn9vwAFGinFYCziRLgBNzHZIxxjffw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771701086; c=relaxed/simple; bh=YW2MHtu4BX5PpdvF2kWST6cAlvywTMR2LqAThPB29wA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ksOUB0zD1vVhrbuGbcMxQgXB27SeIuXo2pj7bIPOV98by8/91ziPCX95hVz4N9BuH+BVlEN7frqTRoKAf2y3qBcuhRk2bIpilaoZcXMqfET7tr5xk31BD8wdkw65Ex0OxGnGol+4GLBax9jgS0R4fXJTspqklWr7ZRraDNtjpX0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org; spf=pass smtp.mailfrom=plaes.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b=kAjFGu5+; arc=none smtp.client-ip=188.166.43.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=plaes.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=plaes.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=plaes.org header.i=@plaes.org header.b="kAjFGu5+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=plaes.org; s=mail; t=1771701084; bh=YW2MHtu4BX5PpdvF2kWST6cAlvywTMR2LqAThPB29wA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kAjFGu5+lIa8/o2xOH25zf4BGMkfWvcP4s4UxHgG86WFwILj1SyeG5IiZv8MjRrnc FHsuA0KTeHVUWQqFAizG0nuRfwIf9g13mye/JM3vjG/Esq3Iy3N4RQwIGDgB2q0kkK EhefrbbaYXl9Zei7AKkz5rflhaVG7o02sSoR0uKaLGrYoXHXdr+69c/r57gUgieU2d dMnTqyYmZ3gWqWxxTfrrajzQ12TJKOcn+RiKSWrm2/Qc0nQFfhKD+S2XmTEDiAUc3c ZlKaCs7RjYY5TDceqx1wmCxcR9WoNol7t97e53u4nXGFOUCYaEsO7K0dMXWtL0icgu Coomju9DHK8SQ== Received: from localhost (0bd2-0000-0000-0000-6400-8cb1-07d0-2001.dyn.estpak.ee [IPv6:2001:7d0:8cb1:6400::bd2]) by mail.plaes.org (Postfix) with ESMTPSA id E1894405E6; Sat, 21 Feb 2026 19:11:23 +0000 (UTC) From: Priit Laes To: Cc: Priit Laes , Greg Kroah-Hartman , Minu Jin , Archit Anant , Andy Shevchenko , Yuvraj Singh Chauhan , JJ Strnad , Dan Carpenter , Julia Lawall , Ethan Tidmore , Navaneeth K , Artur Stupa , William Hansen-Baird , Randy Dunlap , Tanjim Kamal , Abraham Samuel Adekunle , Michael Straube , Hans de Goede , Vivek BalachandharTN , Zhuoheng Li , Michael Huang , Nino Zhang , Thomas Gleixner , =?UTF-8?q?Rog=C3=A9rio=20Fernandes=20Pereira?= , Ingo Molnar , Diksha Kumari , Karthikey D Kadati , Khushal Chitturi , SeungJu Cheon , Akiyoshi Kurita , Erick Karanja , Sun Jian , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v2 11/11] staging: rtl8723bs: rtw_ieee80211: Reduce global symbols Date: Sat, 21 Feb 2026 21:01:41 +0200 Message-ID: <20260221190628.50273-12-plaes@plaes.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260221190628.50273-1-plaes@plaes.org> References: <20260221190628.50273-1-plaes@plaes.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Mark internally used symbols/functions as static and drop some unused ones. WPA_CIPHER_SUITE_WRAP/RSN_CIPHER_SUITE_WRAP are left as commented, as these might be actually useful for understanding the code. Changes since v1: * Comment out unused variables WPA_CIPHER_SUITE_WRAP/RSN_CIPHER_SUITE_WRAP Signed-off-by: Priit Laes --- .../staging/rtl8723bs/core/rtw_ieee80211.c | 41 +++++++++---------- drivers/staging/rtl8723bs/include/ieee80211.h | 30 -------------- 2 files changed, 19 insertions(+), 52 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ieee80211.c index 6cf217e21593..61280c349d9a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -11,26 +11,23 @@ #include =20 u8 RTW_WPA_OUI_TYPE[] =3D { 0x00, 0x50, 0xf2, 1 }; -u16 RTW_WPA_VERSION =3D 1; -u8 WPA_AUTH_KEY_MGMT_NONE[] =3D { 0x00, 0x50, 0xf2, 0 }; -u8 WPA_AUTH_KEY_MGMT_UNSPEC_802_1X[] =3D { 0x00, 0x50, 0xf2, 1 }; -u8 WPA_AUTH_KEY_MGMT_PSK_OVER_802_1X[] =3D { 0x00, 0x50, 0xf2, 2 }; -u8 WPA_CIPHER_SUITE_NONE[] =3D { 0x00, 0x50, 0xf2, 0 }; -u8 WPA_CIPHER_SUITE_WEP40[] =3D { 0x00, 0x50, 0xf2, 1 }; -u8 WPA_CIPHER_SUITE_TKIP[] =3D { 0x00, 0x50, 0xf2, 2 }; -u8 WPA_CIPHER_SUITE_WRAP[] =3D { 0x00, 0x50, 0xf2, 3 }; -u8 WPA_CIPHER_SUITE_CCMP[] =3D { 0x00, 0x50, 0xf2, 4 }; -u8 WPA_CIPHER_SUITE_WEP104[] =3D { 0x00, 0x50, 0xf2, 5 }; - -u16 RSN_VERSION_BSD =3D 1; -u8 RSN_AUTH_KEY_MGMT_UNSPEC_802_1X[] =3D { 0x00, 0x0f, 0xac, 1 }; -u8 RSN_AUTH_KEY_MGMT_PSK_OVER_802_1X[] =3D { 0x00, 0x0f, 0xac, 2 }; -u8 RSN_CIPHER_SUITE_NONE[] =3D { 0x00, 0x0f, 0xac, 0 }; -u8 RSN_CIPHER_SUITE_WEP40[] =3D { 0x00, 0x0f, 0xac, 1 }; -u8 RSN_CIPHER_SUITE_TKIP[] =3D { 0x00, 0x0f, 0xac, 2 }; -u8 RSN_CIPHER_SUITE_WRAP[] =3D { 0x00, 0x0f, 0xac, 3 }; -u8 RSN_CIPHER_SUITE_CCMP[] =3D { 0x00, 0x0f, 0xac, 4 }; -u8 RSN_CIPHER_SUITE_WEP104[] =3D { 0x00, 0x0f, 0xac, 5 }; + +#define WPA_SELECTOR_LEN 4 +static const u8 WPA_CIPHER_SUITE_NONE[] =3D { 0x00, 0x50, 0xf2, 0 }; +static const u8 WPA_CIPHER_SUITE_WEP40[] =3D { 0x00, 0x50, 0xf2, 1 }; +static const u8 WPA_CIPHER_SUITE_TKIP[] =3D { 0x00, 0x50, 0xf2, 2 }; +// static const u8 WPA_CIPHER_SUITE_WRAP[] =3D { 0x00, 0x50, 0xf2, 3 }; +static const u8 WPA_CIPHER_SUITE_CCMP[] =3D { 0x00, 0x50, 0xf2, 4 }; +static const u8 WPA_CIPHER_SUITE_WEP104[] =3D { 0x00, 0x50, 0xf2, 5 }; + +#define RSN_SELECTOR_LEN 4 +static const u8 RSN_CIPHER_SUITE_NONE[] =3D { 0x00, 0x0f, 0xac, 0 }; +static const u8 RSN_CIPHER_SUITE_WEP40[] =3D { 0x00, 0x0f, 0xac, 1 }; +static const u8 RSN_CIPHER_SUITE_TKIP[] =3D { 0x00, 0x0f, 0xac, 2 }; +// static const u8 RSN_CIPHER_SUITE_WRAP[] =3D { 0x00, 0x0f, 0xac, 3 }; +static const u8 RSN_CIPHER_SUITE_CCMP[] =3D { 0x00, 0x0f, 0xac, 4 }; +static const u8 RSN_CIPHER_SUITE_WEP104[] =3D { 0x00, 0x0f, 0xac, 5 }; + /* */ /* for adhoc-master to generate ie and provide supported-rate to fw */ /* */ @@ -406,7 +403,7 @@ unsigned char *rtw_get_wpa2_ie(unsigned char *pie, int = *rsn_ie_len, int limit) return rtw_get_ie(pie, WLAN_EID_RSN, rsn_ie_len, limit); } =20 -int rtw_get_wpa_cipher_suite(u8 *s) +static int rtw_get_wpa_cipher_suite(u8 *s) { if (!memcmp(s, WPA_CIPHER_SUITE_NONE, WPA_SELECTOR_LEN)) return WPA_CIPHER_NONE; @@ -422,7 +419,7 @@ int rtw_get_wpa_cipher_suite(u8 *s) return 0; } =20 -int rtw_get_wpa2_cipher_suite(u8 *s) +static int rtw_get_wpa2_cipher_suite(u8 *s) { if (!memcmp(s, RSN_CIPHER_SUITE_NONE, RSN_SELECTOR_LEN)) return WPA_CIPHER_NONE; diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/stagin= g/rtl8723bs/include/ieee80211.h index 0f28c904a714..7e6858c712c0 100644 --- a/drivers/staging/rtl8723bs/include/ieee80211.h +++ b/drivers/staging/rtl8723bs/include/ieee80211.h @@ -94,35 +94,7 @@ enum { #define WPA_CIPHER_TKIP BIT(3) #define WPA_CIPHER_CCMP BIT(4) =20 - - -#define WPA_SELECTOR_LEN 4 -extern u8 RTW_WPA_OUI_TYPE[]; -extern u16 RTW_WPA_VERSION; -extern u8 WPA_AUTH_KEY_MGMT_NONE[]; -extern u8 WPA_AUTH_KEY_MGMT_UNSPEC_802_1X[]; -extern u8 WPA_AUTH_KEY_MGMT_PSK_OVER_802_1X[]; -extern u8 WPA_CIPHER_SUITE_NONE[]; -extern u8 WPA_CIPHER_SUITE_WEP40[]; -extern u8 WPA_CIPHER_SUITE_TKIP[]; -extern u8 WPA_CIPHER_SUITE_WRAP[]; -extern u8 WPA_CIPHER_SUITE_CCMP[]; -extern u8 WPA_CIPHER_SUITE_WEP104[]; - - #define RSN_HEADER_LEN 4 -#define RSN_SELECTOR_LEN 4 - -extern u16 RSN_VERSION_BSD; -extern u8 RSN_AUTH_KEY_MGMT_UNSPEC_802_1X[]; -extern u8 RSN_AUTH_KEY_MGMT_PSK_OVER_802_1X[]; -extern u8 RSN_CIPHER_SUITE_NONE[]; -extern u8 RSN_CIPHER_SUITE_WEP40[]; -extern u8 RSN_CIPHER_SUITE_TKIP[]; -extern u8 RSN_CIPHER_SUITE_WRAP[]; -extern u8 RSN_CIPHER_SUITE_CCMP[]; -extern u8 RSN_CIPHER_SUITE_WEP104[]; - =20 enum { RATEID_IDX_BGN_40M_2SS =3D 0, @@ -740,8 +712,6 @@ void rtw_set_supported_rate(u8 *SupportedRates, uint mo= de); =20 unsigned char *rtw_get_wpa_ie(unsigned char *pie, int *wpa_ie_len, int lim= it); unsigned char *rtw_get_wpa2_ie(unsigned char *pie, int *rsn_ie_len, int li= mit); -int rtw_get_wpa_cipher_suite(u8 *s); -int rtw_get_wpa2_cipher_suite(u8 *s); int rtw_get_wapi_ie(u8 *in_ie, uint in_len, u8 *wapi_ie, u16 *wapi_len); int rtw_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher, int *p= airwise_cipher, int *is_8021x); int rtw_parse_wpa2_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher, int *= pairwise_cipher, int *is_8021x); --=20 2.53.0