From nobody Fri Apr 17 09:30:28 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3AFC1C68F for ; Sat, 21 Feb 2026 12:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771678152; cv=none; b=UqqB8wdkdD57d0kckcioNo8uWUUbMojxsw7Ull3k4mvfSseEgmTg5G8CEE4n6jEIvabb5c2cp7sneZcr9SsShJ1Lu0zZWGhcOXVXTOpW+Vdl/CC5Ju8BDZbpPmpQFLv/ZvmHJ+VHExkZq6qbWjpLeXivvS4zjoLzgBxI40NvWCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771678152; c=relaxed/simple; bh=SJCH74Fi3XVpLSYBNl90Os049Ruc/NjS9rgH3HAgdC0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IwtaJAD5wXPPRWmIY1BaYUMliO4E5sKYxjsNtOkfQ1HwL90uz37pfxAd4eqIG8Nlsm7CwEg1ddLvaBwbezK9HHmDCvweO4lHZHPvX1oez925iBICiJmC/8iLEOxJhWgd65sDrybb25QYlTL+UPJPmZ0t7dTqpYaMxXiHavOMpi4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m4nO0Kdv; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m4nO0Kdv" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4830b67aa6bso4064525e9.0 for ; Sat, 21 Feb 2026 04:49:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771678149; x=1772282949; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=w0JV+oXZsMoEYt+my8k4u1Lt0rpk3zovYNjUGyw5Eno=; b=m4nO0KdvbebFHLzQtnkghU/sKrKk9jF47Smy/zkxgY3sQ4F/vSrAyS5Hm2AIrXnI+W a5XX3tmmuNHBkil69xhXXOev1RM4bYTY7HeU0DkSf5C8tDNel2IOnyxi97ug1hkTQY1U s6hqM1Ib0WU9dIPyvT2TuwKPpFujIueFNf55RC0jM9z3JXEG+f+lq5OPhCpHRCJPeyHW 1oM9+iMq6t0nEabHUBSav4+hIh4EuaGFTc3BkdRH0eh3a+zXkA+CxwOxhPzxE3e493oA 33hu53B9Q9PmyDmYNHfnaa9xKhnbuNkJrL314iU0s8y/5YaFVkJZjhhr5F4TBJvk6hyX cLGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771678149; x=1772282949; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=w0JV+oXZsMoEYt+my8k4u1Lt0rpk3zovYNjUGyw5Eno=; b=XwIkwz5kdsZUnLMPuB0vc0NVGfWcLKJO973di3QAQtDfsIGKhJ+T7Lx41wa+NL4SxT F6R3crcLtV8r6lPUUCYrfZGKEnzAu3ioB+CxF+U9eT9yWaKdOYTqgmdceBvLOvkXjnnu ds4/TrZ/1/E4dxgNu1WSE30j9rIesKClXWhXTwd0YzvkETPBxWIUOiTIfgmHZQVw72sR pv59YeQy+y/mJOoulhaMM9JpRzNb/JiCR9Z66HCBKCm//h4rvFf4G7n560YV7/WS78wt 5jvo/WtsfG9qvYvI1Pqks/jnnqLQZmdjGWcb+sOGZ7yHApqyw91y6OgC4XcAotlq1qPZ 8ubg== X-Gm-Message-State: AOJu0Ywpoy9pdpm/hZFuv+W/oa1v/U+8d0WxWdgXtU9C2JCfo526jzzv EPwnmoEiMIc9lr7fUzjCFeUkSXau73ib76uvgy+G8NzGLzjFVDHNxKdGJofdRc77FDo= X-Gm-Gg: AZuq6aJjIvB78/k2/i2Un8vWHlUDeIEMrPhhoDU547Hq4uRjcHOYy1sQUj2V9Z+rjkO YopykSaI39zxGVaO1TnPCtUcUr4h7MuhtXjFHMtXtH+KLXaCi3xc/SG0/a8StNV9D/z9lXQq/f9 r7NeGOxuZsxWfIpXjtryHlXi3gbjxnohSepuRUD61s8A41osD4ZCUoR8sLJIwpZjkxoFpEsRwzN +iAhTA53lkjqsN0Kj8odC1UxTwUmpquFEEgp7dRXDVGk3gnQhnpBpSss6LvUQupQmpy2+soDNHG zBO4QnViiRuwcXNMZPloQP5o82LBMibQgJ82B3o6CfUWgtvHD/NtQrHg6fyDMEI1SJMQ2dv5S17 jMPeoZ4h3jMr5svsyhAm9kmb1HiUFleYlFJSRzqoimKyG4kfnoRHxex9FnKSkX4Do8NNc5Ps3dd aaDn2TotTYWh3AiK8Ei5XveVEFfROuW+PIcHgD5Qxvv23i6nxpnR9NfzuA1W3dV1bwPIFSeyWlG 7m9B2rxQSwmvuKDgTQMV4BUFHwYEKjob2tWKzgt97ZUVhFAzDa7AcRpkHA/y58= X-Received: by 2002:a05:600c:3b10:b0:477:a6f1:499d with SMTP id 5b1f17b1804b1-483a95e24aemr24260295e9.3.1771678148793; Sat, 21 Feb 2026 04:49:08 -0800 (PST) Received: from fedora ([149.3.87.76]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a3dfd902sm40538995e9.7.2026.02.21.04.49.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Feb 2026 04:49:08 -0800 (PST) From: Giorgi Tchankvetadze To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Giorgi Tchankvetadze Subject: [PATCH] staging: rtl8723bs: remove redundant NULL check on premainder_ie Date: Sat, 21 Feb 2026 16:47:33 +0400 Message-ID: <20260221124732.327156-2-giorgitchankvetadze1997@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" premainder_ie is computed as pwps_ie + wps_ielen, where pwps_ie is already validated non-NULL earlier in the function. Pointer arithmetic on a non-NULL pointer can never yield NULL, making this check always true and misleading. Replace with a simple check on remainder_ielen. Signed-off-by: Giorgi Tchankvetadze Reviewed-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_ap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8= 723bs/core/rtw_ap.c index ebe73abab892..2b28c5fd436b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ap.c +++ b/drivers/staging/rtl8723bs/core/rtw_ap.c @@ -1439,7 +1439,7 @@ static void update_bcn_wps_ie(struct adapter *padapte= r) =20 remainder_ielen =3D ielen - wps_offset - wps_ielen; =20 - if (premainder_ie && remainder_ielen) + if (remainder_ielen) pbackup_remainder_ie =3D kmemdup(premainder_ie, remainder_ielen, GFP_ATO= MIC); =20 wps_ielen =3D (uint)pwps_ie_src[1];/* to get ie data len */ --=20 2.52.0