From nobody Fri Apr 17 09:18:17 2026 Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D35B31ED62 for ; Sat, 21 Feb 2026 02:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771640297; cv=none; b=P3//u3BOdipJlY5vK810Rl83fJ7g2uje/I+3IV3K7oDKc02iP3jwxOFuxYrle6Uth3X1IltICk/5eqdtWYZCoMutZuQlJEH9i9XyvOiJKxWXGVNRmz3BIGySd+N5vMosgaq9gtaagVaa132a9UiG/+SUzqYBR4nAuhI2slZT7sM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771640297; c=relaxed/simple; bh=Sqb/asAMbhSRZWB7GQc/6Bty2AQhF3CVn5hsPOZrdGs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QDZixJ3I1IiEQonWME/Z7xSfy6vnDXJfp5DWNOcdh6T4YESculCJuU/lIr33ndxgFFwuGisAgfnCSsYqUGkJKj9uNtlvXYowDUDPIFrfMPfEZNGX6QUEm/OF1gH2s1T+VYIQdzD7Aw4hmvQzb2SwaEJE0ie6mNoy94A6n9MJHFw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=l+9qpp5Y; arc=none smtp.client-ip=209.85.219.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="l+9qpp5Y" Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-89577f866d6so34061106d6.0 for ; Fri, 20 Feb 2026 18:18:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1771640295; x=1772245095; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TN/Qem4uDJq0+sZtDcRn3RixwcqOTbW5UgRyD976tVI=; b=l+9qpp5Y32qmTHQwSDXJN55P/7LkcjEAayE03D0J5gKk0h4BzInXguj3FLKZCNZmjV zZrOM+YhPhRvx/LWRN6rYjsLNnPBKi2EGcZdQlSlB1uYUe68YqE5mRc5REBhF9req8c3 jUV3514Bw1g1mn1a0M2DBBD1zjLvTF4xE1lkk7ERk+ErZhZKnnB/7fcpDwniCvFwk1nI UjkEtI/N88knwF1oAsqUQ9ltTFkkK6KE5IJUj1j5OH3D75XdoLWZB5tW3bvBfRG226mJ XVx06NDC50EPCaTCHcn4N3LsXuhevy1+jByW40wP6ev5ekT8jHUsI1XLn2pKGw+mNfUm 2HKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771640295; x=1772245095; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TN/Qem4uDJq0+sZtDcRn3RixwcqOTbW5UgRyD976tVI=; b=nxPEdG9ir89sUs/Tv2BhzLPQy+64go9AdK4o4jwUE7YYkvZc7+JdXwzWMBMLTkm6A3 QDZOvjDBfYxtWQl55smnR9Bd4VbqHKKm5ew16vghEmKazLQiiLWuJfhsdFaSIUQRCxTv n14Z+3TicVIyYzUn6MwqGUBiAzaCyJDBo+cALnyhn/byJ38jBcsW9iJK/l0a0XjDy1Vu LMJvkn6wdzONm65WnTeBF0Qo60RWRJmbTyTMBHVFdzcp7NCxszAgnazkaAi2klAe5tjt YGftcSr3JLgabhz95Y1cXNVMzOJnj4OCxSri8kbwebT967+XDZCNZmNRKexJXEBKSl6/ zv7Q== X-Gm-Message-State: AOJu0YyAjA69PAa6GH75n5OWk8+JW/+Z4lGYIOjgOYpG83+xGwfOMPUB 4KT5BZs5hby17cuoMFaeomRdZHddqva9rhUeHKozTs6eUc6c8fwPkLInbEqVtk+j/EythDDEB3Z gewd3 X-Gm-Gg: AZuq6aKtvmtqs+REetJk2VOBJCEX6Bw7CVUyA7tcZxHliW8tv1mY2L8CK419wAjcyqT SVtJrKZaVgyXj/RFD2lQDHHxKTO5n0EOpxMsE9M9v5nYWMYYwfs38+nSxDO1fgqR29TzYtfAKkc dhWSMgXZBCYBdLSclTn8bXYgfSV7U/cuOEPyvSlSmKQnC2CjxZgn066cgudIteEcvWg1Zh2AIJo 76cPV4sKMeesdHiocG13o4ZZatZyUCprjFPSf3zQOOCYP66h9WvNTRs767ZYQ+hoY7tQJzub5Hw fMvxy7+ArJAa6H+j7SXYWLCgbuY9Nyv4ni5KcK+349esoRLpUG2sjo2iQe4VgkxaW6ITjG5hI+8 UOpyAIDp8e7hIvn81wWhPn8ewGP3jto81QbjLId7hjlRAVyPied/EJSCUcjJP9s02BPSyeIDsPV mPQ9Mc6dnlz3WTFi496JhkNe+WH58Tg5z9HfeB+sWPJn2HENHRcIxCdV1D+5wUhRV15I4JjCSFf hjFED8kDerewPY= X-Received: by 2002:a05:6214:2a45:b0:894:6f00:82e2 with SMTP id 6a1803df08f44-89965c94fe1mr110186876d6.36.1771640294810; Fri, 20 Feb 2026 18:18:14 -0800 (PST) Received: from gourry-fedora-PF4VCD3F.lan (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8997c6bb2cfsm7315746d6.18.2026.02.20.18.18.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 18:18:14 -0800 (PST) From: Gregory Price To: linux-cxl@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com Subject: [PATCH] cxl/core: fix test_bit misuse with CXL_DECODER_F_ bitmask flags Date: Fri, 20 Feb 2026 21:18:10 -0500 Message-ID: <20260221021810.1390342-1-gourry@gourry.net> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" CXL_DECODER_F_LOCK (BIT(4) =3D 16) and CXL_DECODER_F_NORMALIZED_ADDRESSING (BIT(6) =3D 64) are bit masks, but three call sites pass them to test_bit() which expects a bit number. Replace test_bit() with direct bitmask tests, consistent with every other use of these flags. Fixes: 2230c4bdc412 ("cxl: Add handling of locked CXL decoder") Signed-off-by: Gregory Price --- drivers/cxl/core/hdm.c | 2 +- drivers/cxl/core/region.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c index b2db5967f5c0..c8fcb9d9aa3d 100644 --- a/drivers/cxl/core/hdm.c +++ b/drivers/cxl/core/hdm.c @@ -904,7 +904,7 @@ static void cxl_decoder_reset(struct cxl_decoder *cxld) if ((cxld->flags & CXL_DECODER_F_ENABLE) =3D=3D 0) return; =20 - if (test_bit(CXL_DECODER_F_LOCK, &cxld->flags)) + if (cxld->flags & CXL_DECODER_F_LOCK) return; =20 if (port->commit_end =3D=3D id) diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index bd4c4a4a27da..385be9cb44cd 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -1100,12 +1100,12 @@ static int cxl_rr_assign_decoder(struct cxl_port *p= ort, struct cxl_region *cxlr, static void cxl_region_setup_flags(struct cxl_region *cxlr, struct cxl_decoder *cxld) { - if (test_bit(CXL_DECODER_F_LOCK, &cxld->flags)) { + if (cxld->flags & CXL_DECODER_F_LOCK) { set_bit(CXL_REGION_F_LOCK, &cxlr->flags); clear_bit(CXL_REGION_F_NEEDS_RESET, &cxlr->flags); } =20 - if (test_bit(CXL_DECODER_F_NORMALIZED_ADDRESSING, &cxld->flags)) + if (cxld->flags & CXL_DECODER_F_NORMALIZED_ADDRESSING) set_bit(CXL_REGION_F_NORMALIZED_ADDRESSING, &cxlr->flags); } =20 --=20 2.53.0