From nobody Fri Apr 17 09:18:11 2026 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 341D01552FD for ; Sat, 21 Feb 2026 14:48:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771685333; cv=none; b=cQMPFBBWVGplNwLlTjXDfBHIYdHiDjvuYViIz/WPvkSUtr9PgrFke5iqVQ0DUPlbZnhQYIU7P9+ZuuhzmDQuuwxJxPc7w0x0mpFnvHwgbMRAW9TdtLOdOxg3ShMqv6c7gcN8pSZ2JwVT3gVECBN1TUYCpXkvs6WEMlcf75HKMtY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771685333; c=relaxed/simple; bh=TIW7di7W9B6L4rzU//z3c0xJPlQEQJg5QsLFlDFJjv0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=H22YdVD5enfBXgGds4JSelV8/k5tqNFHbhGZu9NTEfMwQnoDdO+fUsKAOlebLoa/UZytu4STRI2aw+bGbbad4nZDc5HjYZGivoJ5xT4lZtjBE+WprQpkCvgiZzuWmJ2geuuKSEKHGAfyXKUd/bSUrHO6hQW7LRWUfW0dnM7kjO4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Ci0WmNfF; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ci0WmNfF" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2ab0b2e804cso36334845ad.3 for ; Sat, 21 Feb 2026 06:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771685331; x=1772290131; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=gz+ZDGsHMTEG/Ms65NnPn5UMtTR5l/RI93OOKvh7syQ=; b=Ci0WmNfFG1mnAwc/0RO8a744/gOKqHKaBcrO3kjBwppylof0dDDwOR5lX0xyV6WYUB L1CFFGFq7AEmFD/wDxxeM+lTKfK5ResbnMLJyU6MkWsIK53eKiAeTpfwt6GCgjKKoZkr +c0xdo974BSo3jyP27lDHI87yKpW9JWCLHotkInnPRzvqtchQtxbAVPvriDUHAW8aqQo gJ7+3+ZstJf/87z9xu9zljA13ZH1wnxrmiOdGtTspjfHil9qQK2Exg3nomj+R+KP0Hd8 DdReMvmn/Qbw7TOQERKxYwkcmrdWrcgXOiSygNImfS75haoXG9nBdsy/dYEcsaZIzAS9 w82w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771685331; x=1772290131; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gz+ZDGsHMTEG/Ms65NnPn5UMtTR5l/RI93OOKvh7syQ=; b=T5NnGfraCXyaxAz6znLP2r1AhtoTI59NDQcVpxJo8nbNOxfvL6pFuMMbSNh0pOB2vL QI4TKgdnTZ92Zw7kLOmnZaD6KqDQaIxhLVythlMP6cZnnzkKGwGPb0s2r0S8r/F55PET z5n7YcpqXLQgM5V9Qd7NVHB2E2WFWD7mBzSN5t148K9smdJjBqwKy6+MAngFMUffkDfE kVljDCtLoqBKKTqDtJ0M84pdlFgCkh81KDFokru7yvrPo1cp8VT2f4RZZTablP/nWLhd jp6i7NzQ/7vo5urrmvp+SJegVdkPiXzP2Pzc8EyTu0PYA0IXtUT2iavvfgSgAaDwDB8q Dang== X-Forwarded-Encrypted: i=1; AJvYcCUAsixBpkEi9Feys2k9OR3DYJoS8vsMAf//u+PivPlC8GEiGZG0H8tJjlzyKdja/mrikJjwskc/6KxRs40=@vger.kernel.org X-Gm-Message-State: AOJu0YyDbxoa6YTiCn0eNiLrJsuDkQi5hCy04EFBXFyKNS1RW9LtkluS 3zDr3pe4P7KC3JBgVZx9KIC/gcJ+0AverQl3wUvzG3cR9PvbIgDkqU3Jki1w3rmWML5KGXZqry0 IKsL+HA== X-Received: from plv12.prod.google.com ([2002:a17:903:bcc:b0:2ad:5a23:794e]) (user=khtsai job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:3bcb:b0:2a9:327f:aa2f with SMTP id d9443c01a7336-2ad7451256amr27135015ad.26.1771685331374; Sat, 21 Feb 2026 06:48:51 -0800 (PST) Date: Sat, 21 Feb 2026 22:48:15 +0800 In-Reply-To: <20260221-legacy-ncm-v2-0-dfb891d76507@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260221-legacy-ncm-v2-0-dfb891d76507@google.com> X-Developer-Key: i=khtsai@google.com; a=ed25519; pk=abA4Pw6dY2ZufSbSXW9mtp7xiv1AVPtgRhCFWJSEqLE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1771685327; l=2555; i=khtsai@google.com; s=20250916; h=from:subject:message-id; bh=TIW7di7W9B6L4rzU//z3c0xJPlQEQJg5QsLFlDFJjv0=; b=tT2ibPRmS7uKKQm5BH41kwejb6ZUF26AK2nvOFDZs6YaDsP8VT92urhA7PFfBNqiuoM62Q7LS A9Usc2eUI0YCx/s9FShl7a4IrvB8+jvW9V+rEpYN9brlUxx9xVd9jnu X-Mailer: b4 0.14.2 Message-ID: <20260221-legacy-ncm-v2-1-dfb891d76507@google.com> Subject: [PATCH v2 1/2] usb: legacy: ncm: Fix NPE in gncm_bind From: Kuen-Han Tsai To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kuen-Han Tsai , stable@kernel.org, kernel test robot Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Commit 56a512a9b410 ("usb: gadget: f_ncm: align net_device lifecycle with bind/unbind") deferred the allocation of the net_device. This change leads to a NULL pointer dereference in the legacy NCM driver as it attempts to access the net_device before it's fully instantiated. Store the provided qmult, host_addr, and dev_addr into the struct ncm_opts->net_opts during gncm_bind(). These values will be properly applied to the net_device when it is allocated and configured later in the binding process by the NCM function driver. Fixes: 56a512a9b410 ("usb: gadget: f_ncm: align net_device lifecycle with b= ind/unbind") Cc: stable@kernel.org Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202602181727.fd76c561-lkp@intel.com Signed-off-by: Kuen-Han Tsai --- drivers/usb/gadget/legacy/ncm.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/legacy/ncm.c b/drivers/usb/gadget/legacy/nc= m.c index 0f1b45e3abd1a1ead7b2776be10a2a5747960136..e8d5655340530aa38fde698f876= e785122f0cce8 100644 --- a/drivers/usb/gadget/legacy/ncm.c +++ b/drivers/usb/gadget/legacy/ncm.c @@ -15,8 +15,10 @@ /* #define DEBUG */ /* #define VERBOSE_DEBUG */ =20 +#include #include #include +#include #include =20 #include "u_ether.h" @@ -129,6 +131,7 @@ static int gncm_bind(struct usb_composite_dev *cdev) struct usb_gadget *gadget =3D cdev->gadget; struct f_ncm_opts *ncm_opts; int status; + u8 mac[ETH_ALEN]; =20 f_ncm_inst =3D usb_get_function_instance("ncm"); if (IS_ERR(f_ncm_inst)) @@ -136,11 +139,15 @@ static int gncm_bind(struct usb_composite_dev *cdev) =20 ncm_opts =3D container_of(f_ncm_inst, struct f_ncm_opts, func_inst); =20 - gether_set_qmult(ncm_opts->net, qmult); - if (!gether_set_host_addr(ncm_opts->net, host_addr)) + ncm_opts->net_opts.qmult =3D qmult; + if (host_addr && mac_pton(host_addr, mac)) { + memcpy(&ncm_opts->net_opts.host_mac, mac, ETH_ALEN); pr_info("using host ethernet address: %s", host_addr); - if (!gether_set_dev_addr(ncm_opts->net, dev_addr)) + } + if (dev_addr && mac_pton(dev_addr, mac)) { + memcpy(&ncm_opts->net_opts.dev_mac, mac, ETH_ALEN); pr_info("using self ethernet address: %s", dev_addr); + } =20 /* Allocate string descriptor numbers ... note that string * contents can be overridden by the composite_dev glue. --=20 2.53.0.345.g96ddfc5eaa-goog From nobody Fri Apr 17 09:18:11 2026 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 688A61FF1B5 for ; Sat, 21 Feb 2026 14:48:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771685335; cv=none; b=AA1OQmX2le0aFkAhhgQX8M593Q/66eSamQ9BJ5fIbuasmG/f1sHX2P/FHsdWJLSNMmU/t5LYhvWFQkyzoBCXj7QHlf8YA51zTYtTf+xYZFzXLzn8UBobY20i61doMkbEufiGq/pITJCSfzM5BBlwvGNAQypg+cxTKLhJI39V8Tk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771685335; c=relaxed/simple; bh=c6Au8SEnwAzozh8LgOHPKTcZtSKVQWswj+SVzNT6OAA=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fN3IxBnSthaJgkrqM0baCVUdw+LgBt8W4e7/yVNo3WD05mCrQ/KuK6EjzNWEpmIjxwsvjE7j4g9GjN04aVCqkIgKty/74/ZKaTdAQVup6ayt3fVeQo+t1usBLAxI0BoDEC8wyLlRF3mDCBMp3apdG1PxEWz0S0fJiL6/XWntCcg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=MJhjaEYY; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--khtsai.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MJhjaEYY" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-c629a3276e9so15113905a12.2 for ; Sat, 21 Feb 2026 06:48:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771685334; x=1772290134; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=cxLkydTf9614aLgaebvByTpNLFxiZkbf4oPlXDhy8+A=; b=MJhjaEYYylyuHdRWu8p25QNg0vAHTlJPrQ3JTWMNB2L2LzBkOCOjceS0R6E0xBTs8H aQrPu3Pt6Y+YMVwnYT+dRpUQNcwzxtzcKlMEbHGeMUSAMz8dQoMFfvPXwZ3q1xa3XnBK NNO6sGn6scpzWgjNAxLMr47cpFw9HnwPjvfYHvcNu2uNOJb4WhDCvBekmyVY43HxPRP2 aI2K2OPuu9j0AJIKnrQJSAr+0Hztp7nrJCORK/Rnpdt6tKQxrCC6aH99UA+ZWthOk4yf IwTV3f1JVgVali8P6uoyf6YAtRePNdDEssHBJa306roE/6ug6ngQzHe7padCc0CP2Ov+ 0c0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771685334; x=1772290134; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cxLkydTf9614aLgaebvByTpNLFxiZkbf4oPlXDhy8+A=; b=iwi+1+Qh3EhJ+yQ6fh+uoU2gW8+F+aHxZ4mpCWaQ7xIqIW1kqX0wr3P+nb886yDC0M md+x4LGwwcmohHVdHtv0wgWedQVM2QJrgZXPUp2t89YbHTgWwsdMwh5o9FCM6fRFCcsc Q6/DX9PWyRmXQtr28zCasYLvU8u2QU+R3shyt37+Fm9gCMo/hwA3/vpkhNUVa7aqmtEQ xq5chF1Pyx0UvbQQuc580sJE1AQnW2+h876Giwz2vdMssA6dQcCO8n5+Fg2uMaLaz0zq OIWL4SSu6BDvD5y0ysPlqHEIjBhxxffBccsL2IGWdyokz+KyfQ/vHdHGFr+awO2QUPXX LLnw== X-Forwarded-Encrypted: i=1; AJvYcCUbDPtHfO9akOl6jcDvvYyfvCi8vRDcsDglgGQSqj/lC/ptOddDNJHzdcNBV8OHMz5j5kZnvsFZOPpfRz8=@vger.kernel.org X-Gm-Message-State: AOJu0YxY2Goko0LuM3V2duK148/VmT0SdneFqF9TU+irLLIHlIJtJ86U BJu2VXSaLSJV73H1vjJX4jugF/jvea6MCaHBl50dAXCpSvyGv+mG9P7O39pF+/JT4wQfCnIPasZ 1aCan0w== X-Received: from pfbhc21.prod.google.com ([2002:a05:6a00:6515:b0:824:afd9:57a7]) (user=khtsai job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2d03:b0:821:849a:a65b with SMTP id d2e1a72fcca58-826daa80907mr2857476b3a.60.1771685333359; Sat, 21 Feb 2026 06:48:53 -0800 (PST) Date: Sat, 21 Feb 2026 22:48:16 +0800 In-Reply-To: <20260221-legacy-ncm-v2-0-dfb891d76507@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260221-legacy-ncm-v2-0-dfb891d76507@google.com> X-Developer-Key: i=khtsai@google.com; a=ed25519; pk=abA4Pw6dY2ZufSbSXW9mtp7xiv1AVPtgRhCFWJSEqLE= X-Developer-Signature: v=1; a=ed25519-sha256; t=1771685327; l=5279; i=khtsai@google.com; s=20250916; h=from:subject:message-id; bh=c6Au8SEnwAzozh8LgOHPKTcZtSKVQWswj+SVzNT6OAA=; b=YOSnht4KhONMB0BJZGT/GYeKGKddU5XYhRqFS6YIejyzJ5CHov7R00f4isUByNRmtdeWbhlT3 baQ3+R+PRZrBInHf404WhAITE4IiTHLpZlkepsZNVeMAG7yj8r8Owxt X-Mailer: b4 0.14.2 Message-ID: <20260221-legacy-ncm-v2-2-dfb891d76507@google.com> Subject: [PATCH v2 2/2] usb: gadget: f_ncm: Fix atomic context locking issue From: Kuen-Han Tsai To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kuen-Han Tsai , stable@kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The ncm_set_alt function was holding a mutex to protect against races with configfs, which invokes the might-sleep function inside an atomic context. Remove the struct net_device pointer from the f_ncm_opts structure to eliminate the contention. The connection state is now managed by a new boolean flag to preserve the use-after-free fix from commit 6334b8e4553c ("usb: gadget: f_ncm: Fix UAF ncm object at re-bind after usb ep transport error"). BUG: sleeping function called from invalid context Call Trace: dump_stack_lvl+0x83/0xc0 dump_stack+0x14/0x16 __might_resched+0x389/0x4c0 __might_sleep+0x8e/0x100 ... __mutex_lock+0x6f/0x1740 ... ncm_set_alt+0x209/0xa40 set_config+0x6b6/0xb40 composite_setup+0x734/0x2b40 ... Fixes: 56a512a9b410 ("usb: gadget: f_ncm: align net_device lifecycle with b= ind/unbind") Cc: stable@kernel.org Signed-off-by: Kuen-Han Tsai --- drivers/usb/gadget/function/f_ncm.c | 29 +++++++++++-----------= ---- drivers/usb/gadget/function/u_ether_configfs.h | 11 +--------- drivers/usb/gadget/function/u_ncm.h | 1 - 3 files changed, 13 insertions(+), 28 deletions(-) diff --git a/drivers/usb/gadget/function/f_ncm.c b/drivers/usb/gadget/funct= ion/f_ncm.c index e23adc132f8865f6bbce6c88c8b5f3f06110faaa..6f074b85eebcf93a67e0fbc3b0f= ecaf702286f83 100644 --- a/drivers/usb/gadget/function/f_ncm.c +++ b/drivers/usb/gadget/function/f_ncm.c @@ -58,6 +58,7 @@ struct f_ncm { u8 notify_state; atomic_t notify_count; bool is_open; + bool is_connected; =20 const struct ndp_parser_opts *parser_opts; bool is_crc; @@ -864,7 +865,6 @@ static int ncm_setup(struct usb_function *f, const stru= ct usb_ctrlrequest *ctrl) static int ncm_set_alt(struct usb_function *f, unsigned intf, unsigned alt) { struct f_ncm *ncm =3D func_to_ncm(f); - struct f_ncm_opts *opts =3D func_to_ncm_opts(f); struct usb_composite_dev *cdev =3D f->config->cdev; =20 /* Control interface has only altsetting 0 */ @@ -887,13 +887,12 @@ static int ncm_set_alt(struct usb_function *f, unsign= ed intf, unsigned alt) if (alt > 1) goto fail; =20 - scoped_guard(mutex, &opts->lock) - if (opts->net) { - DBG(cdev, "reset ncm\n"); - opts->net =3D NULL; - gether_disconnect(&ncm->port); - ncm_reset_values(ncm); - } + if (ncm->is_connected) { + DBG(cdev, "reset ncm\n"); + ncm->is_connected =3D false; + gether_disconnect(&ncm->port); + ncm_reset_values(ncm); + } =20 /* * CDC Network only sends data in non-default altsettings. @@ -926,8 +925,7 @@ static int ncm_set_alt(struct usb_function *f, unsigned= intf, unsigned alt) net =3D gether_connect(&ncm->port); if (IS_ERR(net)) return PTR_ERR(net); - scoped_guard(mutex, &opts->lock) - opts->net =3D net; + ncm->is_connected =3D true; } =20 spin_lock(&ncm->lock); @@ -1374,16 +1372,14 @@ static int ncm_unwrap_ntb(struct gether *port, static void ncm_disable(struct usb_function *f) { struct f_ncm *ncm =3D func_to_ncm(f); - struct f_ncm_opts *opts =3D func_to_ncm_opts(f); struct usb_composite_dev *cdev =3D f->config->cdev; =20 DBG(cdev, "ncm deactivated\n"); =20 - scoped_guard(mutex, &opts->lock) - if (opts->net) { - opts->net =3D NULL; - gether_disconnect(&ncm->port); - } + if (ncm->is_connected) { + ncm->is_connected =3D false; + gether_disconnect(&ncm->port); + } =20 if (ncm->notify->enabled) { usb_ep_disable(ncm->notify); @@ -1687,7 +1683,6 @@ static struct usb_function_instance *ncm_alloc_inst(v= oid) if (!opts) return ERR_PTR(-ENOMEM); =20 - opts->net =3D NULL; opts->ncm_os_desc.ext_compat_id =3D opts->ncm_ext_compat_id; gether_setup_opts_default(&opts->net_opts, "usb"); =20 diff --git a/drivers/usb/gadget/function/u_ether_configfs.h b/drivers/usb/g= adget/function/u_ether_configfs.h index 217990a266b2f6528d7bf8537a77214c538f681a..25d8fb05b598d68268cf849f260= b435f9c52337c 100644 --- a/drivers/usb/gadget/function/u_ether_configfs.h +++ b/drivers/usb/gadget/function/u_ether_configfs.h @@ -327,18 +327,9 @@ out: \ char *page) \ { \ struct f_##_f_##_opts *opts =3D to_f_##_f_##_opts(item); \ - const char *name; \ \ guard(mutex)(&opts->lock); \ - rtnl_lock(); \ - if (opts->net_opts.ifname_set) \ - name =3D opts->net_opts.name; \ - else if (opts->net) \ - name =3D netdev_name(opts->net); \ - else \ - name =3D "(inactive net_device)"; \ - rtnl_unlock(); \ - return sysfs_emit(page, "%s\n", name); \ + return sysfs_emit(page, "%s\n", opts->net_opts.name); \ } \ \ static ssize_t _f_##_opts_ifname_store(struct config_item *item, \ diff --git a/drivers/usb/gadget/function/u_ncm.h b/drivers/usb/gadget/funct= ion/u_ncm.h index d99330fe31e880f636615774d212062952c31e43..6d75388557448e7acebf2401f8d= a48105f740e2f 100644 --- a/drivers/usb/gadget/function/u_ncm.h +++ b/drivers/usb/gadget/function/u_ncm.h @@ -19,7 +19,6 @@ =20 struct f_ncm_opts { struct usb_function_instance func_inst; - struct net_device *net; =20 struct gether_opts net_opts; struct config_group *ncm_interf_group; --=20 2.53.0.345.g96ddfc5eaa-goog