From nobody Fri Apr 3 11:10:26 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 207CB32D7FB for ; Fri, 20 Feb 2026 17:20:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771608047; cv=none; b=oVq6ER+vY8Gkzv2SHbjJhFyEo3+TWcSWASyvosgNctY60i5JHr0aWd6e40AhcaGUT2u/Ns5v/LKDnwrd49AGYcSKvGpiSfaSEoUA1pCPnA5yOULTVPXWGq+z1LPLRJFB5fO/TY3uD3IcEI7QXQhFAYqmEVfaEeoW2KlwrEdpcj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771608047; c=relaxed/simple; bh=uOc0fDf04EQ8RyzPVLGzEI4dw1mJvaQtdkifqNIDJXk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Atsk7VapaeQuQ2iSkd1QDPZHMX6d21snvLLihnmlZ95LSjdtypZ2tVCnJjXl/A2HR+RXcJBt5pvFQWVLaUag/3oZOwaWoBfF3bFA4/RGE6DPb4jzvRxJ3SwgjU1wAVumdkg+GK3QDLDFor4nx2Mhm+JR4K2r1RABamfaQ/4qPkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cnvLmMjk; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cnvLmMjk" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c6de0527ce1so1213324a12.2 for ; Fri, 20 Feb 2026 09:20:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771608045; x=1772212845; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=nYqT5KLYsWEUGFK6ywQ3Q9lDeS9gE2QhSfhmn5e1kHg=; b=cnvLmMjkEgymrzrwJQUJfJhjnJMJ4hJELK7H+gHw4Yszw5twOr94TABkPju8nq7ZaB cF+hedhT9Y3tk2wsB3ip2T3n5LbPABLF4KvOkGrGQOWnfyxGzf5mJmb6qN5H06lzJvSM 9fLdtuiCXKKGzzziDFVBZlGaZxFaFsghdYNyzL0SpYBWjUxzTUQXqkG37F0TE3aycFy4 4zIjztZIDpHxprcrQYUlRSnO9Fooknr10IXkb+cfFtjF91+vFVTpwgAzz1nZURFYMfA0 +Xhw0usXquh2x8YO9dtS9E/NAKbq4/cFhVwrxDjEux/CspGkqsEkbMEU/va1iJuOlhO/ u1Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771608045; x=1772212845; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nYqT5KLYsWEUGFK6ywQ3Q9lDeS9gE2QhSfhmn5e1kHg=; b=qh0WeFDaNbhe2bkJprMiwnqUTXgp0hCPDVvADdfGL3Aar4ZkkOzwELjgWk0ntv2Ed6 VAMcR25ultyEKaSe3+70ZuVpFWnxdvnepv5NCBo7uPhFPqJdHBK0vL3QVBLp+d6GXglt orW1uKfZXs0UZjnIoPUiBWk3m8Aci0dRLg9dfg64IU671jNpEcDpP7lNR6TpLN05+jow dzRu+39VQDPG8trOZuuEFEucK2RxTgrk+DN8bNHzd0RmTpW1B7PjaxunJwMa4XOLDf0E RFxUcyJSFEYiVzhHThv58jTk0joyyRS7wX6Zu1PQe2r/5lleoKGmUoANtioKlYl6JhO6 YlYA== X-Gm-Message-State: AOJu0YzuvEi31UjKudBl9M+n6/VD5NKZ04jWIjUAwJf0tTLoYYV4T3vl pAeZSj2c5x9pQfWToBJ3sAstAFE/EumAI90x1PSuLwzLs1kgGSFIR9Fr X-Gm-Gg: AZuq6aINGRyainxSsyoCV6r7+TrwNmhmqDsBz1OdGOrPPrFA2KHvIq3Mt51bY6T2K2A 9m8rPtH4ETuNe/5HnqEifITa6+tQu8/+MhJfEbb9ZhFNacleOaZC3Qe1UIh1CLealNsHOUeOcnk ygubPIZwbAtjUlGiTz05KNJi4XU4lBwqzEwM3x0F/iNUerCU+7rf2rpfeq4020WRqibJ7kDiOsY hkn2zBOPEM9/aSxEsq1fiAHynfFQQ42OQb3U5AsqR4xK47ilTE6Yk+KLSTA8K9yMb/d3zJCy6Ze mqzHIVRmwUwQ3QzJLQ3Y9Lga0bXCiWKBVklfQ3m97ZRuxzo/YDCy5i7Eh38Mjt+MwXpmaQEYYMO 6/grRHJmAL3cfXhX5Wr+13m4+p6NqmDK4jt2PXpJbbEJ80552bjsyrh0TqP+MW8NszkF65JPiT7 WhgOxuOSqSgLiVyagAlDRYQloGkSTrmlg5eJku8w== X-Received: by 2002:a17:90b:4f89:b0:340:c179:3657 with SMTP id 98e67ed59e1d1-358ae9034a8mr333090a91.33.1771608045353; Fri, 20 Feb 2026 09:20:45 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:eca9:ad9e:7878:7ec4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a7132fasm206172595ad.23.2026.02.20.09.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 09:20:45 -0800 (PST) From: Felix Gu Date: Sat, 21 Feb 2026 01:20:31 +0800 Subject: [PATCH 1/2] misc: ti_fpc202: fix off-by-one error in port ID bounds check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260221-fp202-v1-1-4d28cb8b28fb@gmail.com> References: <20260221-fp202-v1-0-4d28cb8b28fb@gmail.com> In-Reply-To: <20260221-fp202-v1-0-4d28cb8b28fb@gmail.com> To: Romain Gantois , Arnd Bergmann , Greg Kroah-Hartman , Andi Shyti , Wolfram Sang , Linus Walleij Cc: linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771608039; l=904; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=uOc0fDf04EQ8RyzPVLGzEI4dw1mJvaQtdkifqNIDJXk=; b=QiJnYLFtw9dr68moEG8Alp+gp/CC3mRMHSqQTHFLcMRBl8iYFQ9Cb8DwjRWnimfRaJWbmAOCo hZQQbdt691WCAvL1wiZZEENv34ow0l3r4KJz0myJ1mScDl3S8F7MhuZ X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= FPC202_NUM_PORTS is 2, valid port IDs should be 0 and 1. A port_id of 2 would incorrectly pass the check, potentially causing out-of-bounds access to the port-related arrays. Found by code review, compile pass. Fixes: 1e5c9b1efa1c ("misc: add FPC202 dual port controller driver") Signed-off-by: Felix Gu Reviewed-by: Romain Gantois --- drivers/misc/ti_fpc202.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c index 8eb2b5ac9850..578feefb77f1 100644 --- a/drivers/misc/ti_fpc202.c +++ b/drivers/misc/ti_fpc202.c @@ -366,7 +366,7 @@ static int fpc202_probe(struct i2c_client *client) goto unregister_chans; } =20 - if (port_id > FPC202_NUM_PORTS) { + if (port_id >=3D FPC202_NUM_PORTS) { dev_err(dev, "port ID %d is out of range!\n", port_id); ret =3D -EINVAL; goto unregister_chans; --=20 2.43.0 From nobody Fri Apr 3 11:10:26 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C6C232AAD1 for ; Fri, 20 Feb 2026 17:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771608050; cv=none; b=X/nZaD6it8yk43EjtHplZ8xR/A/AWvwkH0XSWfBj8FJtrhCE1jcBjiHJoDkcl0FcRY/A4DhM8+nmKKiUdbo9UPfG4sLxTowJ2hgC6JF6Y8rWa3ai5DH4q4w3AS2TzNbHnVMwgWeSwOYyJk+KRk0iy73hf7LH6f1ESwpMBhuRwpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771608050; c=relaxed/simple; bh=amv7S8gFyr0UjqpEyK8eqReO0EbMJQQu5GYJVS5dTyo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fN5vy4Do1MnWajDL2g3d95NF8TCbkZ2v1IV9r9EOpAMZqvzEWAyBWl9cboMyTkIISNEODG4FB/xV6ESiYD7si3ptpLDpwwIABkfVX7OiBkWdflp2nWVlMmDfacMvLFe9m6FkQO/HeW7fN5MsCRYSgexj49NjqwMWC59QShHpN20= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IT60eT1j; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IT60eT1j" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a871c8b171so14519725ad.3 for ; Fri, 20 Feb 2026 09:20:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771608049; x=1772212849; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=PGd7vR0806nlOrfORO5kZuV57pgFgQlgV/jKJkGot8w=; b=IT60eT1jGk3jN4VN4CzhlMp7rBKzwxSV6LSXH20MX3fKiJGZbhRhdkptFZVqWbqiWP /OBjTWVdcbi9tLamZztirLZegOdBMqJmSZycqGWedJ42J2iPhTmba1dnSwXckk+YkdXM iz0G9XzfXMeIve5Bt2fcM60x9aD892ZKioS5N4M4X78OjfH4rtk7OCqsyZzCSe+apSfB 31B9+Rgqu6mECN7QnPO1KHnuet8sf/vrQYIvq7BQT5ca5FJ3AldzFtNS8iwBDsB/GQrU cci4EEjXclspUVYwY1Y6f/8dx4j1pyLXzFoSD+7q3MmrG2LY6zFQLnjfZbmuTyrac7UC zU3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771608049; x=1772212849; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=PGd7vR0806nlOrfORO5kZuV57pgFgQlgV/jKJkGot8w=; b=llV4I5L/uZXmOmaMqpDOUTbRbYPJzaTl2upuC1P22wP+5d5GaRQfBZYzU+BxBEGSj4 EX5BlLdgMiBZHJ82H/saO3d2ysn9fRbsDMJzx8UkRHoVBzrQ5aaQ6t13G2TqryUnLnp/ yXZPMlpgJJgpYbYIqMODcHOHW7jJe23gbJOfPI7a73AttAtCsnXSxb0E5QrWYGcJFAzk 24miLFS/PVRCDPh1ZNz0E4KK1+YDPex6zNh/nS/VmLd8bt4stG/hA6XJWXoIbXNmj56e jQsfkOQmyeEb7c9HejFqnk086GV2r/Wakp5il9Jn8DR0Huqzl4F7zJfvDB2f2R1lNEiR gW8Q== X-Gm-Message-State: AOJu0YzCgaGN4YMTg+VDdxwV1yYNqDQ+AmP6bP9RL6LO61c6jgv+DQ9+ x2ioZK6P5wtShRQx2IpcQAI/jShMeY1iqvZqFW0QSIIXzhl3BA4S0Gws X-Gm-Gg: AZuq6aKlA42T9ipyqrYzKrpCfA7tZDnnLm5tG56gUwsqvPoBqSxQxjGsaVJ6DDsOLpz suIR0EMYKvJsm2RXAQm5/KSVhzFvIFW2+lozhsipASG45D5Z4RZ9lzqkd3WtfSlWII+5c0nq14x +YzbGYv8f+IxC0yxEfRO4O5XkzkxXx2S4Yn8FIys23l/GnHOzlvL8O6iCll+sHFWeOhsFXL4aGZ G5maP3/k8ThP/kzZ6QXmRWVXIpLlpcrzLz0iLFKMJofxAZ+TiF5L9vhPn4PRrC2kkwtvyrqSHHm e2OvZRvCDb69YJfqF+oNHJy/4Aro+iMPJyggXtl3pv6EuWlH7HVISO7/6sNz8yrJlsorqx8VFGE eVH6XSPs0v3I8hNKi3v75uuZQAiSnU3+TJHoG7L+NvA8frKrct7Murwq3CtwDVt1zBFSITYgeg9 YUNU4YtbdxhnC5JNTWYZUhP6AdpZ2myDqc17dDZOV4mC4x9A7K X-Received: by 2002:a17:902:d4c8:b0:2ab:3ac6:8d03 with SMTP id d9443c01a7336-2ad744e2769mr2786965ad.36.1771608048123; Fri, 20 Feb 2026 09:20:48 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:eca9:ad9e:7878:7ec4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a7132fasm206172595ad.23.2026.02.20.09.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 09:20:47 -0800 (PST) From: Felix Gu Date: Sat, 21 Feb 2026 01:20:32 +0800 Subject: [PATCH 2/2] misc: ti_fpc202: remove dead code in fpc202_detach_addr() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260221-fp202-v1-2-4d28cb8b28fb@gmail.com> References: <20260221-fp202-v1-0-4d28cb8b28fb@gmail.com> In-Reply-To: <20260221-fp202-v1-0-4d28cb8b28fb@gmail.com> To: Romain Gantois , Arnd Bergmann , Greg Kroah-Hartman , Andi Shyti , Wolfram Sang , Linus Walleij Cc: linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771608039; l=1205; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=amv7S8gFyr0UjqpEyK8eqReO0EbMJQQu5GYJVS5dTyo=; b=1gtvgeNJMUmFK6hn+775Tl+pjnVJ+DE7o8P7covBKvMz7B9Tr1+panT9f3ApMVlo05DM7zAnZ g4kXex7+gYvB0PgMSWKrwd2JnDRJsuVvVIHDTWAa+gF3ffDDBa1wk6v X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= val is assigned from addr_caches, which is a u8 array. So the check will never be true. Found by code review, compile pass. Signed-off-by: Felix Gu Reviewed-by: Romain Gantois --- drivers/misc/ti_fpc202.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/misc/ti_fpc202.c b/drivers/misc/ti_fpc202.c index 578feefb77f1..79a029d79f7a 100644 --- a/drivers/misc/ti_fpc202.c +++ b/drivers/misc/ti_fpc202.c @@ -243,23 +243,15 @@ static void fpc202_detach_addr(struct i2c_atr *atr, u= 32 chan_id, u16 addr) { struct fpc202_priv *priv =3D i2c_atr_get_driver_data(atr); - int dev_num, reg_mod, val; + int dev_num, val; =20 for (dev_num =3D 0; dev_num < 2; dev_num++) { - reg_mod =3D FPC202_REG_MOD_DEV(chan_id, dev_num); - mutex_lock(&priv->reg_dev_lock); =20 val =3D priv->addr_caches[chan_id][dev_num]; =20 mutex_unlock(&priv->reg_dev_lock); =20 - if (val < 0) { - dev_err(&priv->client->dev, "failed to read register 0x%x while detachi= ng address 0x%02x\n", - reg_mod, addr); - return; - } - if (val =3D=3D (addr & 0x7f)) { fpc202_write_dev_addr(priv, chan_id, dev_num, FPC202_REG_DEV_INVALID); return; --=20 2.43.0