From nobody Fri Apr 3 11:10:26 2026 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8893302750 for ; Fri, 20 Feb 2026 20:05:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771617943; cv=none; b=hQaffM71ZkHSeECM1956K7trwT96WMFcFgnx4GpiMJ1hKUPRYnY9yyVbt+bnAc0G+H1Lt5VRMAuB/k5c+tyfP8TfLDbsoeL5otP3vGlT60F5+3W4gxfrVSsCtFG3hnDKlQbcxxAADAMa2v0FjyL2QK5dKjsEQUyvrRsqdyLvv9o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771617943; c=relaxed/simple; bh=0pAur40aIVokjmvof3QFs4tXl7zzEl7jVb1e9lTygE4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X0tn2XNvT8Zq5MX6P/s9HMkbu4mYvTEt66NrVq8+QX9KuMzLcXamMoCXDHwwUWJqequFGHvj4NvUXJPBTewK1mCvaJrIXqo3l2lw5g7pqBG5UlWP7ir2LYkChT4BDjpQlqHGG03tof0QM5Ig8JCA25qXoQE1gHpyeTjFN0wQTEQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hbZavnyL; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hbZavnyL" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-790b7b3e594so24139947b3.3 for ; Fri, 20 Feb 2026 12:05:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771617941; x=1772222741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VvDSAjEuHdFeISLoPILiJTDna5OcaqVB9UyXP3sHwBY=; b=hbZavnyLsLYLEjXC0cO+KIojUuR0v+o9pQM98K5CahpuCCEmRwOlp+ktIQDVnK/X5w U+6As26v4hVofVTeZEFT0CKw2UHfiLhicM3LrPfAIp5kCSjgVG54ubJ20uQ3zDNBgzX0 K984CVux+u6LZ2CWeK9m8NCMLC06QdGsfxFvaW3kkcTXJVY+R8n8Zh+K6bpstHydNKiJ B64fuTGkDB1DuDKSmicX50Bheeaifb0LOqNoNAgiid/Y8TZpvLarLlm8Qw3kr/5d3/Dn hMbs0u0suKFXJn9mGYz7ZMP1Azy2ImU81yQwAjMe9cJFXjcEL2150+LRbda9bBLnFswC j4hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771617941; x=1772222741; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VvDSAjEuHdFeISLoPILiJTDna5OcaqVB9UyXP3sHwBY=; b=tvk5Rrkoz0iLf/mon/GaSDB8eMSW/QagcIAkTMC/rAVlcNlIkFdOWs9J0cudPJXSq3 5G4sNlAiBoAfNm4IZUYFFoMbqqMw2K55IU6gCxBpJoJlXJ4FvWM+rI58IsfYV4BF/Vnu ndI+0JWAZIG07aSUW9gJSe6uRfiuFYju1UPHCNagl/3d7GOLCuRkxF77b+TfReXOy6Nr daSXF0erUdVkWxPzbZpJ/MJJ2p0UV/Cvh1tHxSgtqQZ+/QJFGqG5/PJeyms4l7Ym59it VIFyEgHMYvsH+9JMxnMMS0xNEHcDcf6pfPDOhibS4AkhBSLDEyaYCFuIyuIX8Gy0bsAK EPPQ== X-Forwarded-Encrypted: i=1; AJvYcCX7CxE8D7UMK7oaDHC8tCJu6afBcwasCV8V0Dwhoy99l0zbi5swzpXOnuySnuqUGvhEdSHN4LKbglDbORY=@vger.kernel.org X-Gm-Message-State: AOJu0YxcYbKgB8hQomMnYYeHRBQlnbwR9OJJKA5ZgmmkrMCg30GWDl9C XC1cjaY7ESJXNl5QocHfX507VwwOQWgz4R3CiDr2m7qjeyA/vBpj+Rii7szitU97Dr8= X-Gm-Gg: AZuq6aLLjFC5GOUNJMlJofYj1qNSpvnc+OHCk64aapaBKuZ7dJr3tjhvhH7prQbS2cO 7Amry+iOcQv/GokTo5lB3zhN4rwxYuHcyB4ymJOdmsx6idKApAdeGiQxSXg0V15Uc7CgXz7lxJm ihCpslS52NLAqHNfQpdVb5RSu8nkcMLnjamEP03WpIexkgnmYBfVphkqdeDbrWPOd5t1pTjpC47 DyrCSUEsNpNgtI2SMNxkjGfn/Wn79MhCaxnEjbDfkfgapWY8rWP0YcSUyhyujmtw7uBsOtf3vMj piZMpJz+9hLFkb0GL8W8GvsSoJWw/bsDACXktLgnG5UUr1gfncx9W3nkmTcwI123XqwoWm4pXiP IMX7ve7+ShgbSlL8JDBKAIHFYCKpxl8G60JCXGas9opkCCOsyhFEUqd34vQj1ftKe63ejVqhrjh a+G/iYq48M+28woyarFJ9r/2/0/8dcuSV73S+I39lL6fj0F49EQOXEuxc6IijkARAalA+URtpXD InKtvE2ItfNSl4qhjXkNRQm81f2rhUUksroq0iafz8= X-Received: by 2002:a05:690c:6e8c:b0:796:3079:ae1 with SMTP id 00721157ae682-79829149f70mr10878467b3.50.1771617940895; Fri, 20 Feb 2026 12:05:40 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7982dd81f73sm898267b3.25.2026.02.20.12.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 12:05:40 -0800 (PST) From: Ethan Tidmore To: linusw@kernel.org, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] iio: gyro: mpu3050: Fix resource leak Date: Fri, 20 Feb 2026 14:05:22 -0600 Message-ID: <20260220200522.19967-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The interrupt handler is setup but only a few lines down if iio_trigger_register() fails the function returns without properly releasing the handler: ret =3D request_threaded_irq(irq, mpu3050_irq_handler, mpu3050_irq_thread, irq_trig, mpu3050->trig->name, mpu3050->trig); ... ret =3D iio_trigger_register(mpu3050->trig); if (ret) return ret; indio_dev->trig =3D iio_trigger_get(mpu3050->trig); return 0; } Change request_threaded_irq() to devm_request_threaded_irq() to resolve resource leak and use current API. Detected by Smatch: drivers/iio/gyro/mpu3050-core.c:1128 mpu3050_trigger_probe() warn: 'irq' from request_threaded_irq() not released on lines: 1124. Fixes: 3904b28efb2c7 ("iio: gyro: Add driver for the MPU-3050 gyroscope") Signed-off-by: Ethan Tidmore --- drivers/iio/gyro/mpu3050-core.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-cor= e.c index ee2fcd20545d..eeac4ad47396 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1103,12 +1103,13 @@ static int mpu3050_trigger_probe(struct iio_dev *in= dio_dev, int irq) if (mpu3050->irq_opendrain) irq_trig |=3D IRQF_SHARED; =20 - ret =3D request_threaded_irq(irq, - mpu3050_irq_handler, - mpu3050_irq_thread, - irq_trig, - mpu3050->trig->name, - mpu3050->trig); + ret =3D devm_request_threaded_irq(dev, + irq, + mpu3050_irq_handler, + mpu3050_irq_thread, + irq_trig, + mpu3050->trig->name, + mpu3050->trig); if (ret) { dev_err(dev, "can't get IRQ %d, error %d\n", irq, ret); return ret; @@ -1260,8 +1261,6 @@ void mpu3050_common_remove(struct device *dev) pm_runtime_put_noidle(dev); pm_runtime_disable(dev); iio_triggered_buffer_cleanup(indio_dev); - if (mpu3050->irq) - free_irq(mpu3050->irq, mpu3050); iio_device_unregister(indio_dev); mpu3050_power_down(mpu3050); } --=20 2.53.0