From nobody Sun Apr 5 16:31:07 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DAE4346E55; Fri, 20 Feb 2026 13:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593209; cv=none; b=QCqEPEucpf8D4cNbd2yybU288LGk1pCfMfpUC/h2YhH7op9Z4dhAMd6X8ckBD88WxmtB76DCUa7vvOWVy/55bU9UFW8AsA7Aq/Df+LfTG1mAvQrXWKh3k7MC7JxMu4uR1uqnvFWmZfv8X51QUWLHrScunzigqpRnmTI7eIPiBZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593209; c=relaxed/simple; bh=I+0MI7+p9k2zIKVwh20XGhhZHjJRVGZ8A4tR2ykS+G4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F41n89/JPysNCrzHnf/xmpXW0KvneR6FXHgCsZhgE0dfpA7IE70vE6gnOQLGs0zSsC/lipCgDhsBS44SnhEvaxqbfpNw2vF5I+lcfRQXhczJ8lb8jcBPYLoz9p73aJhCMbHIe04uWZnyfhu0wTwWBW163J17Lm+YiBDTgLL27Vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=xbrCvEZS; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="xbrCvEZS" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K87Kv63823499; Fri, 20 Feb 2026 08:13:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=yM8Je lkQUF5DCFyNHSUHRRY+1jKrXIVKcZwRRco+HdM=; b=xbrCvEZSW82Hs7JYai7xB mElva3w6Efgs+FicjVjl4tiVJ4nng2WYtHEnLm5jeEkFHjMSK+19k3KZKSI6iIrB w1fjYGZPsdO970YEaZb/0pMqzmkDs4fgGgqAE8liWdh0EjMpUk0+8rqO0uq42ZGq R1kYu8VcQo7RrIzsGNMn/5MVKm0akEWRCLfCfTe2O71J07cfHzsMAULAIjVNJ3JZ rHcSFDAlc+5uHJpZVXDBWCcY09Xg80TcP+WgfkIM//ucD4os2vyI+/gKaaeiqkqU CVYlx4KsMTFj6kcC16Sk56tl6JxRmVEayGpyPI7NDtCukklqElI+Db9TI1G1qWdV Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4ce0xvw0j2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 08:13:14 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61KDDDVi064746 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Feb 2026 08:13:13 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:13 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 20 Feb 2026 08:13:13 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61KDCsHU009613; Fri, 20 Feb 2026 08:13:07 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH 3/7] iio: frequency: admv1013: use dev_err_probe in probe path Date: Fri, 20 Feb 2026 15:11:41 +0200 Message-ID: <20260220131151.74329-4-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260220131151.74329-1-antoniu.miclaus@analog.com> References: <20260220131151.74329-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=AeK83nXG c=1 sm=1 tr=0 ts=69985dea cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gAnH3GRIAAAA:8 a=SYtYyVRKRuBxfkzjSfcA:9 X-Proofpoint-ORIG-GUID: axqia_kY4NS9Hcgi84gdd_hN30oMltuT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDExNSBTYWx0ZWRfX1cN23K9EnAC7 h2PwaowHQlx3g0QKTjwi6xxuYqpfjM/Bdx7EWWD/Cf4nExKlXOv8tDhkUpIQvCiVmv8yOsxO7xJ UVqIG7W0ohTK5xozc/GVbSrxJ7kgWIelAuj9M0C32BkVwkTgFTzaGqSBxQqmLJdAQUOnw2hesMA pgzFnr4Dv9QrkuGV6Ft9YOtyWmke9RsxwcSnx1TjYpnMfOAkmVdEqa8cKzy+jRJod0exQlOJUUE EDZt+8nickNYjYpOSAtE2HqK7lBspen4mrCT1xg7TTW8Ch822XFIW/SN6o/PsMQLJtlBupP2eoF +PR7h7Kzi/W+6nxc+lX/GTljzEV+7/ORraqAtF+iViVIJO7IQ4KHpTUNDj9aYODsv8ziwZRsAGG h7/s97ftyoT5E3R+x/2nbrpm0DmrCduuO8sE6HHpgsZwBIZ2zf/3yb8c6fqhLXig/CtwGaDbY8i 2qNyIb5djUgWWgeC3EA== X-Proofpoint-GUID: axqia_kY4NS9Hcgi84gdd_hN30oMltuT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200115 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in admv1013_init(), admv1013_probe(), and admv1013_properties_parse(), which are called during probe. This simplifies error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1013.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1= 013.c index d8e8d541990f..6e8beea51c25 100644 --- a/drivers/iio/frequency/admv1013.c +++ b/drivers/iio/frequency/admv1013.c @@ -461,10 +461,9 @@ static int admv1013_init(struct admv1013_state *st, in= t vcm_uv) return ret; =20 data =3D FIELD_GET(ADMV1013_CHIP_ID_MSK, data); - if (data !=3D ADMV1013_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (data !=3D ADMV1013_CHIP_ID) + return dev_err_probe(&spi->dev, -EINVAL, + "Invalid Chip ID.\n"); =20 ret =3D __admv1013_spi_write(st, ADMV1013_REG_VVA_TEMP_COMP, 0xE700); if (ret) @@ -549,11 +548,9 @@ static int admv1013_properties_parse(struct admv1013_s= tate *st) ret =3D devm_regulator_bulk_get_enable(&st->spi->dev, ARRAY_SIZE(admv1013_vcc_regs), admv1013_vcc_regs); - if (ret) { - dev_err_probe(&spi->dev, ret, - "Failed to request VCC regulators\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Failed to request VCC regulators\n"); =20 return 0; } @@ -601,10 +598,9 @@ static int admv1013_probe(struct spi_device *spi) mutex_init(&st->lock); =20 ret =3D admv1013_init(st, vcm_uv); - if (ret) { - dev_err(&spi->dev, "admv1013 init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "admv1013 init failed\n"); =20 ret =3D devm_add_action_or_reset(&spi->dev, admv1013_powerdown, st); if (ret) --=20 2.43.0