From nobody Fri Apr 3 12:28:43 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46198346AC6; Fri, 20 Feb 2026 13:13:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593206; cv=none; b=sLzuu7aBZPx0SzLvQ/uAGHgGnzU78YYpph8N6D5r7YtMx4+AYWaRxopletA5NIhOBeFtGhsPF37mEr1GnOQ+q+ijKrH+b54djwKrVbeoQ1/v/LRA2ytkxHIjz1FEDbffU0jmz3u8KDaPUV6tRgsdDmZina18iWVuUnQ9rX9AYII= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593206; c=relaxed/simple; bh=wLhJLSu0aVKoGTWm/9Egmm8iOfhh9dXCdrrthOGhdwQ=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LCqoZ6pllAjZqKQY/e4FbIq8XaqZ4PHEmTF3M+fTRQOAsJmtjtJ9EAg86OGhmpoz/J0tUfSDq8hEChXWraFV0nRNZfNCJI1COOkyJJ5eDsmUt7ShWx0QPzzLw2eHQP3mMsVhOzoM7XrGW/jGJW9WZoKY9Rd1RlcrX4SSMFhmsKk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=sZDk8GZE; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="sZDk8GZE" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K87Eoj3823368; Fri, 20 Feb 2026 08:13:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=DEuFm NafNVsXKll4VaSZ6Pz+4oDilUnQ2SU67Xp29do=; b=sZDk8GZEFMFrps0jpeEeK BUiRD1yfQVQorxwffhKwsA0EYMVb9aIXyHCcFZ92gdnKfiqy7nTzR1KVEOt7uFg6 a4IpOwtNKWvqjkuI3TVMNpisA3K5+z2/IIIQTTEB4n/bkph4EY4ynvLLUZAJWVkb ZJ4f2idomo6RXIdNxJj7+VmgFewPP3FQ3nY4e2JbEYOfoNyE3qDSaEVGVXLwwYAf 4qhRA3fyhmlrBS00gaY/OYvSKS2nwtAOMZQr/Ih0ZzpmH3sdIr4FY0cPds6iOSJd U3u7OvrEtrWeU70Sm5tmFmsUNYRhtRFeth/y3tHFQ+FOSxdWyV7hYwP7Dn4Yg0x3 Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4ce0xvw0hv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 08:13:10 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61KDD9Qj064737 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Feb 2026 08:13:09 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:09 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 20 Feb 2026 08:13:09 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61KDCsHS009613; Fri, 20 Feb 2026 08:13:03 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH 1/7] iio: frequency: adrf6780: use dev_err_probe in probe path Date: Fri, 20 Feb 2026 15:11:39 +0200 Message-ID: <20260220131151.74329-2-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260220131151.74329-1-antoniu.miclaus@analog.com> References: <20260220131151.74329-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=AeK83nXG c=1 sm=1 tr=0 ts=69985de6 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gAnH3GRIAAAA:8 a=QrChBGosppEjk4s3f_0A:9 X-Proofpoint-ORIG-GUID: RNYexWOfVUYrzW2yAn6mSeBvdNp8v7Zb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDExNSBTYWx0ZWRfXwn/IHCt2JoGf ZzVFEBVmFRiJLy2EK6Py7Ts/8h+8m02s5+mPo+H49NvFfwTean2OjD9eUSOs4uGHINsp9N4lIEe cN8/tA/L2na5O4bYhCvlekWJILEE/il7Ed+5xgzjJNc89B5tLZJoDv7hhB99wEIkIUPlIW7q+ll 0j1OmPVaBu/jCi8rbLMd8Ba9eTJdmAZNlJIc7whoF3TV9G5OvO1T0Hf9yE2Nz9M6TqdATxKV58k uP/dz3uSHDavxLjRtA08y8C2l+4A0T1mr2q++m5q6Ot1CAJMFaoP9mgirwsFadRas0LvbSL5M0H tStuJVANp8N7G72orPedrWOOOBsR/RZccCNyn6DdHScFONo6KrHmdqpZwgkgBGhicgAd2wf8sGB 49ZQEICpmcDPSjfipQl2qMNpsKqODwwuBw1YEcgFsa/Eo5Fw/Y0z0DG7WgLW2ECmxGRi+h3N6iZ 2LLXboN/lF0YG1Y6kDA== X-Proofpoint-GUID: RNYexWOfVUYrzW2yAn6mSeBvdNp8v7Zb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200115 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in adrf6780_reset() and adrf6780_init(), which are called during probe. This simplifies error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/adrf6780.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/iio/frequency/adrf6780.c b/drivers/iio/frequency/adrf6= 780.c index a7a21f929970..bdb922667bc2 100644 --- a/drivers/iio/frequency/adrf6780.c +++ b/drivers/iio/frequency/adrf6780.c @@ -351,18 +351,16 @@ static int adrf6780_reset(struct adrf6780_state *st) ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADRF6780 SPI software reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "ADRF6780 SPI software reset failed.\n"); =20 ret =3D __adrf6780_spi_update_bits(st, ADRF6780_REG_CONTROL, ADRF6780_SOFT_RESET_MSK, FIELD_PREP(ADRF6780_SOFT_RESET_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "ADRF6780 SPI software reset disable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "ADRF6780 SPI software reset disable failed.\n"); =20 return 0; } @@ -383,10 +381,9 @@ static int adrf6780_init(struct adrf6780_state *st) return ret; =20 chip_id =3D FIELD_GET(ADRF6780_CHIP_ID_MSK, chip_id); - if (chip_id !=3D ADRF6780_CHIP_ID) { - dev_err(&spi->dev, "ADRF6780 Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADRF6780_CHIP_ID) + return dev_err_probe(&spi->dev, -EINVAL, + "ADRF6780 Invalid Chip ID.\n"); =20 enable_reg_msk =3D ADRF6780_VGA_BUFFER_EN_MSK | ADRF6780_DETECTOR_EN_MSK | --=20 2.43.0 From nobody Fri Apr 3 12:28:43 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C89E346A1C; Fri, 20 Feb 2026 13:13:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593206; cv=none; b=Et0kV/L3CiwBh4lcmaDqwzvL7oGEKIZ4PAFYP/Ci3qLJ+uOdCQFgS0dM0by+z1rNEK/7LswQsDp2UTD66eC/cF5yGwG3MxTdW69yT4/cdDL05oZHA2w+Z6qECmr2Yd33iltcjLAN5teOt/xit0i/k/SX6Y6hyMdZp8tfhnh1i24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593206; c=relaxed/simple; bh=1fA/QhxTz9c2lIvElxS1lIKLaYwaXASLBCsTi/Mrj30=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kCgFWUmJLQlacKD8OOEC9JZ2Z+sPt2XB0nLWmyKdJShJ7nAw8IL4kzWWuWwI+fEzAFckrWEzWfbIJx3WH7JW+hDaPIC3XCp/O10xDS5c6NB7Qo3BG3g/olIXIelY4GYhZHPRW0nC2UN8sdpuNi6UHhziIfr6U5+1XJ/y0c10kIc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=qhYNujS7; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="qhYNujS7" Received: from pps.filterd (m0167088.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K890Gj897178; Fri, 20 Feb 2026 08:13:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=4Kcoc pnGwE68A9yG4p2Sj7hi2Upe2GSSf3vrdrZ4ccA=; b=qhYNujS7ZohTzpTmaFhfj sysn/9IyiLL9jhjMaT5nT5l/otl1Ekwd9dBtkdQ8G1b0w85vMMqyXWbrv/FP61oc Qg1MqZ4ym03Ve+rp94eMxKuhopOBoq0r/k8D9SwuU5viUfADb7MgIPH/g/fyLPVa e+q0xCz7bYel8T1IDCA7jUsjcQsNaUofD69JcyO1Immmz9TKfgezQshyttHjhytp c3FIzz98QJo3NoZUzrSh42T2oOndQ3KQPJ5C4HxKQaI5SCfOGDaltXXWlE1AkpFE KLtXTbTous0LEVOQnmXn9Y4duLtxrfi+e86FPuOPTDtUmxyQIvQrpJP0KflCIgo7 w== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4ce69kkrmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 08:13:10 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61KDD9Gk064740 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Feb 2026 08:13:09 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:09 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 20 Feb 2026 08:13:09 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61KDCsHT009613; Fri, 20 Feb 2026 08:13:05 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH 2/7] iio: frequency: admv1014: use dev_err_probe in probe path Date: Fri, 20 Feb 2026 15:11:40 +0200 Message-ID: <20260220131151.74329-3-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260220131151.74329-1-antoniu.miclaus@analog.com> References: <20260220131151.74329-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=Z//h3XRA c=1 sm=1 tr=0 ts=69985de6 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gAnH3GRIAAAA:8 a=v94z4MtexB56KsHqelIA:9 X-Proofpoint-ORIG-GUID: -0k24L0tjMImaLPVI2V0CWyEjnDI8tQW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDExNSBTYWx0ZWRfXwFRlJkbCmSjt vid/WWot6e+5xGLk71T1hSDbMrZprFHpMJZ24yzbiiHBykDhP8iTewdHnNf0kD2ZqqN7KDSlhm8 kx3hv13u0fpULASjK26/ak14Q5qPK8BTZeKBmZuQ/jWjSk4HP6hHsN7rRh4WqXPXz4p+3rYBzxE BVeGAufYIn1pObk2XB2HvJBvOZ/b1CdTGXyts0/p12iyMrVUtrxK0fAYub0enKhydl6EKZuacMI dKIM6MAYKXgWn4s0a33emk+TF3COct6ef4vZuCf0rVMjLP/RVPOnn03u25V7oJ+6nk+zWXU3+3K f31eGuoet6eWiwvTzW/3Jltcv2Tl+fMjvLlxLJbbHCIWJzpQzlqWFDBEP4hYVBQX23hxr/6RuZq srwZVHRTQ06LkhzuCYNmdvgkYuQg4oOnvElu3V4TjxCiBZfU2mzS87YZbWqy2ADt/g8Ni6Fjxf6 8640r3zZGjY8CDrXk4w== X-Proofpoint-GUID: -0k24L0tjMImaLPVI2V0CWyEjnDI8tQW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 clxscore=1015 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200115 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in admv1014_init() and admv1014_properties_parse(), which are called during probe. This simplifies error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1014.c | 63 ++++++++++++++------------------ 1 file changed, 27 insertions(+), 36 deletions(-) diff --git a/drivers/iio/frequency/admv1014.c b/drivers/iio/frequency/admv1= 014.c index 7a8f92ec80a2..5fc7c9fdf2e3 100644 --- a/drivers/iio/frequency/admv1014.c +++ b/drivers/iio/frequency/admv1014.c @@ -613,10 +613,9 @@ static int admv1014_init(struct admv1014_state *st) int ret; =20 ret =3D regulator_bulk_enable(ADMV1014_NUM_REGULATORS, st->regulators); - if (ret) { - dev_err(&spi->dev, "Failed to enable regulators"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Failed to enable regulators"); =20 ret =3D devm_add_action_or_reset(&spi->dev, admv1014_reg_disable, st->reg= ulators); if (ret) @@ -643,55 +642,48 @@ static int admv1014_init(struct admv1014_state *st) ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_SPI_CONTROL, ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADMV1014 SPI software reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "ADMV1014 SPI software reset failed.\n"); =20 ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_SPI_CONTROL, ADMV1014_SPI_SOFT_RESET_MSK, FIELD_PREP(ADMV1014_SPI_SOFT_RESET_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "ADMV1014 SPI software reset disable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "ADMV1014 SPI software reset disable failed.\n"); =20 ret =3D __admv1014_spi_write(st, ADMV1014_REG_VVA_TEMP_COMP, 0x727C); - if (ret) { - dev_err(&spi->dev, "Writing default Temperature Compensation value faile= d.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Writing default Temperature Compensation value failed.\n"); =20 ret =3D __admv1014_spi_read(st, ADMV1014_REG_SPI_CONTROL, &chip_id); if (ret) return ret; =20 chip_id =3D FIELD_GET(ADMV1014_CHIP_ID_MSK, chip_id); - if (chip_id !=3D ADMV1014_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADMV1014_CHIP_ID) + return dev_err_probe(&spi->dev, -EINVAL, + "Invalid Chip ID.\n"); =20 ret =3D __admv1014_spi_update_bits(st, ADMV1014_REG_QUAD, ADMV1014_QUAD_SE_MODE_MSK, FIELD_PREP(ADMV1014_QUAD_SE_MODE_MSK, st->quad_se_mode)); - if (ret) { - dev_err(&spi->dev, "Writing Quad SE Mode failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Writing Quad SE Mode failed.\n"); =20 ret =3D admv1014_update_quad_filters(st); - if (ret) { - dev_err(&spi->dev, "Update Quad Filters failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Update Quad Filters failed.\n"); =20 ret =3D admv1014_update_vcm_settings(st); - if (ret) { - dev_err(&spi->dev, "Update VCM Settings failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Update VCM Settings failed.\n"); =20 enable_reg_msk =3D ADMV1014_P1DB_COMPENSATION_MSK | ADMV1014_IF_AMP_PD_MSK | @@ -739,10 +731,9 @@ static int admv1014_properties_parse(struct admv1014_s= tate *st) =20 ret =3D devm_regulator_bulk_get(&st->spi->dev, ADMV1014_NUM_REGULATORS, st->regulators); - if (ret) { - dev_err(&spi->dev, "Failed to request regulators"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Failed to request regulators"); =20 st->clkin =3D devm_clk_get(&spi->dev, "lo_in"); if (IS_ERR(st->clkin)) --=20 2.43.0 From nobody Fri Apr 3 12:28:43 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DAE4346E55; Fri, 20 Feb 2026 13:13:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593209; cv=none; b=QCqEPEucpf8D4cNbd2yybU288LGk1pCfMfpUC/h2YhH7op9Z4dhAMd6X8ckBD88WxmtB76DCUa7vvOWVy/55bU9UFW8AsA7Aq/Df+LfTG1mAvQrXWKh3k7MC7JxMu4uR1uqnvFWmZfv8X51QUWLHrScunzigqpRnmTI7eIPiBZ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593209; c=relaxed/simple; bh=I+0MI7+p9k2zIKVwh20XGhhZHjJRVGZ8A4tR2ykS+G4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F41n89/JPysNCrzHnf/xmpXW0KvneR6FXHgCsZhgE0dfpA7IE70vE6gnOQLGs0zSsC/lipCgDhsBS44SnhEvaxqbfpNw2vF5I+lcfRQXhczJ8lb8jcBPYLoz9p73aJhCMbHIe04uWZnyfhu0wTwWBW163J17Lm+YiBDTgLL27Vc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=xbrCvEZS; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="xbrCvEZS" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K87Kv63823499; Fri, 20 Feb 2026 08:13:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=yM8Je lkQUF5DCFyNHSUHRRY+1jKrXIVKcZwRRco+HdM=; b=xbrCvEZSW82Hs7JYai7xB mElva3w6Efgs+FicjVjl4tiVJ4nng2WYtHEnLm5jeEkFHjMSK+19k3KZKSI6iIrB w1fjYGZPsdO970YEaZb/0pMqzmkDs4fgGgqAE8liWdh0EjMpUk0+8rqO0uq42ZGq R1kYu8VcQo7RrIzsGNMn/5MVKm0akEWRCLfCfTe2O71J07cfHzsMAULAIjVNJ3JZ rHcSFDAlc+5uHJpZVXDBWCcY09Xg80TcP+WgfkIM//ucD4os2vyI+/gKaaeiqkqU CVYlx4KsMTFj6kcC16Sk56tl6JxRmVEayGpyPI7NDtCukklqElI+Db9TI1G1qWdV Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4ce0xvw0j2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 08:13:14 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61KDDDVi064746 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Feb 2026 08:13:13 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:13 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 20 Feb 2026 08:13:13 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61KDCsHU009613; Fri, 20 Feb 2026 08:13:07 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH 3/7] iio: frequency: admv1013: use dev_err_probe in probe path Date: Fri, 20 Feb 2026 15:11:41 +0200 Message-ID: <20260220131151.74329-4-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260220131151.74329-1-antoniu.miclaus@analog.com> References: <20260220131151.74329-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=AeK83nXG c=1 sm=1 tr=0 ts=69985dea cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gAnH3GRIAAAA:8 a=SYtYyVRKRuBxfkzjSfcA:9 X-Proofpoint-ORIG-GUID: axqia_kY4NS9Hcgi84gdd_hN30oMltuT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDExNSBTYWx0ZWRfX1cN23K9EnAC7 h2PwaowHQlx3g0QKTjwi6xxuYqpfjM/Bdx7EWWD/Cf4nExKlXOv8tDhkUpIQvCiVmv8yOsxO7xJ UVqIG7W0ohTK5xozc/GVbSrxJ7kgWIelAuj9M0C32BkVwkTgFTzaGqSBxQqmLJdAQUOnw2hesMA pgzFnr4Dv9QrkuGV6Ft9YOtyWmke9RsxwcSnx1TjYpnMfOAkmVdEqa8cKzy+jRJod0exQlOJUUE EDZt+8nickNYjYpOSAtE2HqK7lBspen4mrCT1xg7TTW8Ch822XFIW/SN6o/PsMQLJtlBupP2eoF +PR7h7Kzi/W+6nxc+lX/GTljzEV+7/ORraqAtF+iViVIJO7IQ4KHpTUNDj9aYODsv8ziwZRsAGG h7/s97ftyoT5E3R+x/2nbrpm0DmrCduuO8sE6HHpgsZwBIZ2zf/3yb8c6fqhLXig/CtwGaDbY8i 2qNyIb5djUgWWgeC3EA== X-Proofpoint-GUID: axqia_kY4NS9Hcgi84gdd_hN30oMltuT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200115 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in admv1013_init(), admv1013_probe(), and admv1013_properties_parse(), which are called during probe. This simplifies error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/admv1013.c | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/drivers/iio/frequency/admv1013.c b/drivers/iio/frequency/admv1= 013.c index d8e8d541990f..6e8beea51c25 100644 --- a/drivers/iio/frequency/admv1013.c +++ b/drivers/iio/frequency/admv1013.c @@ -461,10 +461,9 @@ static int admv1013_init(struct admv1013_state *st, in= t vcm_uv) return ret; =20 data =3D FIELD_GET(ADMV1013_CHIP_ID_MSK, data); - if (data !=3D ADMV1013_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (data !=3D ADMV1013_CHIP_ID) + return dev_err_probe(&spi->dev, -EINVAL, + "Invalid Chip ID.\n"); =20 ret =3D __admv1013_spi_write(st, ADMV1013_REG_VVA_TEMP_COMP, 0xE700); if (ret) @@ -549,11 +548,9 @@ static int admv1013_properties_parse(struct admv1013_s= tate *st) ret =3D devm_regulator_bulk_get_enable(&st->spi->dev, ARRAY_SIZE(admv1013_vcc_regs), admv1013_vcc_regs); - if (ret) { - dev_err_probe(&spi->dev, ret, - "Failed to request VCC regulators\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Failed to request VCC regulators\n"); =20 return 0; } @@ -601,10 +598,9 @@ static int admv1013_probe(struct spi_device *spi) mutex_init(&st->lock); =20 ret =3D admv1013_init(st, vcm_uv); - if (ret) { - dev_err(&spi->dev, "admv1013 init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "admv1013 init failed\n"); =20 ret =3D devm_add_action_or_reset(&spi->dev, admv1013_powerdown, st); if (ret) --=20 2.43.0 From nobody Fri Apr 3 12:28:43 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 663DA347BD1; Fri, 20 Feb 2026 13:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593211; cv=none; b=Exyf/ZyThjO/ShLk73C37mFtuoalaCFnlvXzGd+K73UseCZmcNR/zoQA0cg84NeP81nxsGIqWVnt4Irn7hsCSEh8vKLi/loz0wq0MHEHph864BIfdMeiVcj4q6HqXO4v4DWncktXa/Ruh+8MAwE5OEhYfRACt63zWA/aP+JIAC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593211; c=relaxed/simple; bh=VJqEdk4RNwf6HD2vCqOoPdgHs+BN3YS6SpqBJjU9q+s=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XmfMIW7WIi00jtKKiNqEgrtvNrjdOO1ZmmbvsKB3wJsohvQc6M0fAn1fwLZKxrKvBhjv8MueNV/hq9TKdrmNiCH1irpIwc4fcuKQIPBFI7B6axYXV4FVMYGnCMO0ZM/5FnI2DP4coOfSNWMROUy9jB4bt78lS48nlKxRrGH3D/k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=q1ZGt8Mx; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="q1ZGt8Mx" Received: from pps.filterd (m0167089.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K87W7e2962780; Fri, 20 Feb 2026 08:13:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=cJ9v6 xlXujLoH2/eMWvOisOyZdtpd+d27fWyHWKDWOw=; b=q1ZGt8MxDm4dg2DaEamlb Iw4ZstFFexTPuMM+tEkZ4equU19QYT3TFKqg9CmPmGgeVzS0gOi4GlEgKVVPLgEK 1qPvYuNrR1mBjznHH/pQsERkPsvwxHxcLOA1R+RtyVh0er8E5w4vaSV6Ss8WoA5N M8Iq8rMmcGt8k3fSVeWGLAj5i4nBVvPVTQwkUFDYZ/miqsmVJgbGcWUsc0XyAV25 9duJ9G1anElztkktqGae4a3c5w2yTyX9rLul29OcMk7Y3ykibZboeqim2H/k6OyX 5DINqVmSuzHsJzA/rg9YZX3d8QjNqIWyizyG/k06uMIAbf3OJ+XM0UXqSMIbib9X g== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4cdanw9wtd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 08:13:16 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61KDDFYp064752 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Feb 2026 08:13:15 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:15 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 20 Feb 2026 08:13:15 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61KDCsHV009613; Fri, 20 Feb 2026 08:13:09 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH 4/7] iio: frequency: adf4377: use dev_err_probe in probe path Date: Fri, 20 Feb 2026 15:11:42 +0200 Message-ID: <20260220131151.74329-5-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260220131151.74329-1-antoniu.miclaus@analog.com> References: <20260220131151.74329-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDExNSBTYWx0ZWRfX21AyfLat4+8C TZJj3vqGFAjimk+UYJyOFBLFoaJFHgFCUS5YLVpAdHonopiG3VK9RzNiHnNhRPci2006KLIFbHw 0HmW2a+Yso3BWL7tEEFAeU8DrUN7K+B0ASaZlM+225K2W2juj/dwhZbLLZboweVaIS6xXn0OlyF sB3OyVpYekaxtAZlfcpx16IYzyINf7uG5/TNTXzttOhoGOs8EdReCCVY6jQQYRP0Y6JVd1ScDPj 162MjYjsURfYXegkSxqi4Wmcecfy0/A5mzcr/9rTbQyzlkaEVlEe5j9oGWPe1ZNXc1p62SOjH1j GWCYoq/IFnXjVit2Kgwk0tIlZdTB4VDwNcWuvj3fO4ars8tECmr5aJLRHsZVfktRmH2TWT7SOJQ zYAR11Dv87s78WOTV2kumVcOkJz7HFSkmCpoddAWIOsM7uqO4/+uq9rsJmhBrDvEQ13r0as+zfF /BlFqaLlSVSkvCKYJeg== X-Authority-Analysis: v=2.4 cv=TtvrRTXh c=1 sm=1 tr=0 ts=69985dec cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gAnH3GRIAAAA:8 a=B8pQ3PUFIzGLwB8xx_sA:9 X-Proofpoint-GUID: chntGoqEzKw7qS6BnezA7R8MNhvhGFvR X-Proofpoint-ORIG-GUID: chntGoqEzKw7qS6BnezA7R8MNhvhGFvR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200115 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in adf4377_init(), which is called during probe. This simplifies error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/frequency/adf4377.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf437= 7.c index fa686f785fa4..7420eb98822a 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -712,17 +712,15 @@ static int adf4377_init(struct adf4377_state *st) adf4377_gpio_init(st); =20 ret =3D adf4377_soft_reset(st); - if (ret) { - dev_err(&spi->dev, "Failed to soft reset.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Failed to soft reset.\n"); =20 ret =3D regmap_multi_reg_write(st->regmap, adf4377_reg_defaults, ARRAY_SIZE(adf4377_reg_defaults)); - if (ret) { - dev_err(&spi->dev, "Failed to set default registers.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Failed to set default registers.\n"); =20 ret =3D regmap_update_bits(st->regmap, 0x00, ADF4377_0000_SDO_ACTIVE_MSK | ADF4377_0000_SDO_ACTIVE_R_MSK, @@ -730,10 +728,9 @@ static int adf4377_init(struct adf4377_state *st) ADF4377_0000_SDO_ACTIVE_SPI_4W) | FIELD_PREP(ADF4377_0000_SDO_ACTIVE_R_MSK, ADF4377_0000_SDO_ACTIVE_SPI_4W)); - if (ret) { - dev_err(&spi->dev, "Failed to set 4-Wire Operation.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Failed to set 4-Wire Operation.\n"); =20 st->clkin_freq =3D clk_get_rate(st->clkin); =20 @@ -747,10 +744,9 @@ static int adf4377_init(struct adf4377_state *st) FIELD_PREP(ADF4377_001A_PD_PFDCP_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT1_MSK, 0) | FIELD_PREP(ADF4377_001A_PD_CLKOUT2_MSK, 0)); - if (ret) { - dev_err(&spi->dev, "Failed to set power down registers.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "Failed to set power down registers.\n"); =20 /* Set Mux Output */ ret =3D regmap_update_bits(st->regmap, 0x1D, --=20 2.43.0 From nobody Fri Apr 3 12:28:43 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 367DA347FC3; Fri, 20 Feb 2026 13:13:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593212; cv=none; b=UadhU3m3x7789FSAIDMMuYQOh02zj0rQ3E2H5lxiEWH+d7EYRhGkmwNXfzh28/0nnZhFRoEl3WTbaAjhghurxQsnD8DTyRynM61+w3mQixFh1effk78qqfZ7INb5EqykRCuW/EnnhnxUWOSg39LUGtTk3zKWGprqUB9SaCZoHd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593212; c=relaxed/simple; bh=CUuqhlVJvNxE5FQrIwrsv2yBSbA6vtQ8ip1XV+wVNcU=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dqwO6Cb0Ft7ssbUtpYj4wwyOhfezpLtlpe8xeHo8H3ownlvXL45Zhq6BIpnwMcxnb/NVw2/VGUHwyE6dfgZk0+XRzVWoFnztd104YOzNfTfkjD5QQnMdKGM8JXzqAyF/AOqrU3pJMCz5Q9yvfnhDZOJzEelfN/eOVG191f5d2EM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=GXH4NHin; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="GXH4NHin" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K87Eok3823368; Fri, 20 Feb 2026 08:13:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=xvffL j/vFG7xvKWKOgO9Hwtq/cjm4cl2y0XaG1ZlLbM=; b=GXH4NHin63cBa72lGJEoy YMQF42pM6NVseXl/i/VnXk3qcivMFAEtbrXlyvL14z80yexnvGBhc6K7WdKaaG8L w2hOkGJrToQpmOlryxxMZZa6qJoqxB+BlxPEvmrTgd33noNlHmall3pIKhrP11d8 bCGIPdYdU2FaKxre0yxA05MJ4PXmM/xWqYBPqrjwbNaJzrIBZGmlCb0k/Ot2ZNMx r+O2FHjFIZL2w7AlYUXirkrBAvYhrh7sehteJD5YUbWVA8e3RxtHwydPdziCsfAb +zCpqZmNPIqWzfbaPfSW2d8p2mYayt0ubjSdfQcQJZDvMKLAxO0StkWh/iNLldn8 A== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4ce0xvw0j8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 08:13:17 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61KDDGZ2064758 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Feb 2026 08:13:16 -0500 Received: from ASHBCASHYB5.ad.analog.com (10.64.17.133) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:16 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB5.ad.analog.com (10.64.17.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:16 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 20 Feb 2026 08:13:16 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61KDCsHW009613; Fri, 20 Feb 2026 08:13:12 -0500 From: Antoniu Miclaus To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH 5/7] iio: adc: ade9000: use dev_err_probe in probe path Date: Fri, 20 Feb 2026 15:11:43 +0200 Message-ID: <20260220131151.74329-6-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260220131151.74329-1-antoniu.miclaus@analog.com> References: <20260220131151.74329-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=AeK83nXG c=1 sm=1 tr=0 ts=69985ded cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gAnH3GRIAAAA:8 a=uB8TIoAt5Nq-SBkLwMMA:9 X-Proofpoint-ORIG-GUID: qJLk5qufT8M4K_zyiBNeRGmW_dUSgk7F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDExNSBTYWx0ZWRfX9vhVm8y9Qlfk BEM7tHVwOHe1fKC8VjQMC7FKfapAeQnKkHr/cg77jifFpF/Q7rLDIb8LucMeM0JTsIM+35SCvGR thmSQo4+8f6Tm4zWbI4j4pegJtLXOe0H4/AlX2VM7qa0+SAMHYDlEkHOW+pIs6Llb4UEEV9LHoD ojFkCvDrimMGTrNePo8HwU1Lmc2Adjo48/FIPEvvjBf6P+KUUMqb/WhE9QDMu8FnIwWQHZMxFCr IpqfooJMJnpmDSby7w23UQu2Wgoj/7i4wlP4kLYTuS0PyvO/Vp9KuzmNAS3wp+B68bFYyphSS7J BHJuWV5HLqA8X3uDFRi+leooeMnprmjd+Iu2TLM6BXu1fNZ5X5SbfDJ3PwZ0T1t1Wzk790yHUnw edCGJXgQZpcmecX1z0P/eGZksI2+5096nt15eF92p/QCDPSTHwTqW+pcNiCmVHnISJyyQpNjkye HbQYZAFcFdy7rMiHOQw== X-Proofpoint-GUID: qJLk5qufT8M4K_zyiBNeRGmW_dUSgk7F X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200115 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in ade9000_reset(), which is called during probe. This simplifies error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/adc/ade9000.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ade9000.c b/drivers/iio/adc/ade9000.c index db085dc5e526..5dcc26a08970 100644 --- a/drivers/iio/adc/ade9000.c +++ b/drivers/iio/adc/ade9000.c @@ -1589,10 +1589,9 @@ static int ade9000_reset(struct ade9000_state *st) /* Only wait for completion if IRQ1 is available to signal reset done */ if (fwnode_irq_get_byname(dev_fwnode(dev), "irq1") >=3D 0) { if (!wait_for_completion_timeout(&st->reset_completion, - msecs_to_jiffies(1000))) { - dev_err(dev, "Reset timeout after 1s\n"); - return -ETIMEDOUT; - } + msecs_to_jiffies(1000))) + return dev_err_probe(dev, -ETIMEDOUT, + "Reset timeout after 1s\n"); } /* If no IRQ available, reset is already complete after the 50ms delay ab= ove */ =20 --=20 2.43.0 From nobody Fri Apr 3 12:28:43 2026 Received: from mx0b-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8422B34A3A5; Fri, 20 Feb 2026 13:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593216; cv=none; b=FEXFzO3piYTkLKeQpfMlgNXKoRmsx0HJiHYiBgYzHOc5Kzxh5QkG2nU8mFUB9rQaCXb1JPRGsapom4QBB83YIBeWFqSiIuRh2ie9sm2D0RPRAAXOOjZqINOSMzJBIRdeXriPkkiO2wxbfC+jUQm1aDV3QA/6XdixpxjjUo8eKL8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593216; c=relaxed/simple; bh=j0xWNF4QuGkz4EMB56wwLbUkQRdsAeGbI9ybj/DkxL4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PiPnUSC+2C+CJphEXkY3NxvHGbsIIJkTM3vu50I7QBWvl3IZy6RWlSBgp6pkz+ViAtv7oBg8hxzKdbj3EoZ7Z5vabptcrpJv2XYRXyi4Tp3rzuAfMHviI/0Z4yArIsD/5P9DDKCLFIMyvVAw+Yf4t++drxZ8nqdvu3ncmYxONbc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=W3bSc1tA; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="W3bSc1tA" Received: from pps.filterd (m0375855.ppops.net [127.0.0.1]) by mx0b-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K87FRS631909; Fri, 20 Feb 2026 08:13:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=pdhUq drGdZlRhafi8KemCaiqOW8/LF6dZRoWJGJGU24=; b=W3bSc1tAJ9vTXXcfTxA/x W+/mXEcxnwhkm8RZ3bgmhwwPiMrR3FnTyBcX04dZtxyUHX+l720y4YXH9VyIpihT SffvDauzAZfGP+xAhk73qPU93a7Di5dMqrZmy/9+Ty377mFtqZDGFc61st6WzmFF Zr1Yz7x2+zhspxWjRD2EeNi4CH7HDTbcrgRC6Wjjo84Bvjva59mH+PrxJA/KhaLC RX/y9Fd63AL2uuWD65NQ3KeJmRE7JRDvnHBiyWv19L3DquG5KyDzVC/hXzynoMIq tPTE8xDMJQVOfby0mC7UTdXMi0/YxUNPY5InCGpu6awM8jJZ8rKILOy+jAKRA1yt Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0b-00128a01.pphosted.com (PPS) with ESMTPS id 4ced6fa77m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 08:13:21 -0500 (EST) Received: from ASHBMBX9.ad.analog.com (ASHBMBX9.ad.analog.com [10.64.17.10]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61KDDKsH064766 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Feb 2026 08:13:20 -0500 Received: from ASHBMBX9.ad.analog.com (10.64.17.10) by ASHBMBX9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:20 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx9.ad.analog.com (10.64.17.10) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 20 Feb 2026 08:13:20 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61KDCsHX009613; Fri, 20 Feb 2026 08:13:14 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH 6/7] iio: dac: ad7293: use dev_err_probe in probe path Date: Fri, 20 Feb 2026 15:11:44 +0200 Message-ID: <20260220131151.74329-7-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260220131151.74329-1-antoniu.miclaus@analog.com> References: <20260220131151.74329-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Proofpoint-ORIG-GUID: rtIC7A5adKF0bGcl2Qci5WYgyVWEo0Jp X-Authority-Analysis: v=2.4 cv=fPg0HJae c=1 sm=1 tr=0 ts=69985df1 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gAnH3GRIAAAA:8 a=x5IjUgJfq7T6UiCw_XoA:9 X-Proofpoint-GUID: rtIC7A5adKF0bGcl2Qci5WYgyVWEo0Jp X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDExNSBTYWx0ZWRfX/770e2Akj992 6xfCjILzgayv0JS0H9QkgTCNixUqR5eiCNtEJZDXzD874KU+DGfIQ8X/aRa1CSTiZDbatJXwW8G 7FG2DGzC5Ky7fwrrTm3+fxx4QtBeptInm/M3hLm/9dYtVuihqNyQf9Qx9BeXP3cCAxeHc+mCEh5 NqLD7MWyharOs+jvbOhCS2wS3/6uwl2l+8/r6NPIu/doz0T8IC9FpYoGjSKNpGJYnXXOlZDw2WL RgqFfifO9/FTJM+GFT2KPEVRHf7k7S9XbaYxy/ow4O9utzidB7VEc1ug6v1zPx6U+FVp4QqYr+a mWCTf44sUkxaKHGDn3shdRhYUCjSy8fwWXH/rfVgXKm+BEdrQIubpJ+RlKtznTGUI8KIVVENwut 8GIUq/atoPHUPihivLIhK/yQYzLrRrWxI50/W1Ga3rqh6WCqkE1GTM4/BKjzcGeSEYeuoC3ri+/ kI8LYTtJu1axgqqn7rg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 bulkscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200115 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in ad7293_init(), which is called during probe. This simplifies error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/dac/ad7293.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/iio/dac/ad7293.c b/drivers/iio/dac/ad7293.c index c3797e40cdd9..acee565d5bb7 100644 --- a/drivers/iio/dac/ad7293.c +++ b/drivers/iio/dac/ad7293.c @@ -821,10 +821,9 @@ static int ad7293_init(struct ad7293_state *st) if (ret) return ret; =20 - if (chip_id !=3D AD7293_CHIP_ID) { - dev_err(&spi->dev, "Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D AD7293_CHIP_ID) + return dev_err_probe(&spi->dev, -EINVAL, + "Invalid Chip ID.\n"); =20 if (!st->vrefin_en) return __ad7293_spi_update_bits(st, AD7293_REG_GENERAL, --=20 2.43.0 From nobody Fri Apr 3 12:28:43 2026 Received: from mx0a-00128a01.pphosted.com (mx0a-00128a01.pphosted.com [148.163.135.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3D47734A3B4; Fri, 20 Feb 2026 13:13:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.77 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593218; cv=none; b=SOFdaoR9ejnqLvbeTJ2mvWyp/p/nTQZCiNELo1UZSUglN0gsjqqv4S5g2GX9KujhQEMPKXKHDeXsQlH6pd5bBlR/+FQlfzZI7YhEkh5C9uo0IwDbOPKCHOXiKlOfOUsPw0EKZMmo9hbUsFLxiZCnZE1suyadDEMeTF8I4XXIg8I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771593218; c=relaxed/simple; bh=Lpud9j+44BJBJlNjY7bXCrCuUEASvfR4cd58OmzQLI0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oQtwYia8Z3+joeRbGKcMzK6i+IJr1Ur8Ngfn7WhK2B+kqapeFxGq8hUIMJZvUbmjcMWInAyQrvU7pWto/2NOOsCoa3aFXBnIIe9nogWYZi5wnoJeCfaAb+5cXbFJJdNo//6CqUdqS8zUkDnOh2KlRo/N5dSIkzPksxcBJblBkTM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com; spf=pass smtp.mailfrom=analog.com; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b=JQFmmJ9O; arc=none smtp.client-ip=148.163.135.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=analog.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=analog.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=analog.com header.i=@analog.com header.b="JQFmmJ9O" Received: from pps.filterd (m0516787.ppops.net [127.0.0.1]) by mx0a-00128a01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61K87Eil3823365; Fri, 20 Feb 2026 08:13:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=analog.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=DKIM; bh=Ke3fd +UlR1q+igf1bOC8NQ2MbLfihgCO//HgGoRP22E=; b=JQFmmJ9Ol+5A9CrlNrMig tJVhN2cPSeXSbPyH8B4/qW52+mKBh3hHlkAcSjwIT0+hyI/vLm5TKHmdn/3Rg85M yrpL8VOJiEOgbTSKqh4RpJuMY0zLm/r/+FnY2x7TfTG2nWNKuYx6LHGG+mslGdwq Z5CJ2cNMEOcWgJsuI47JHP2Zw4agCAxdgaQcgp2PlBanm3daeSMZLf9aCnfc6whF HDYYsNbqc/7vF/lpjKnxJ+BRqLfLuDfyJbsJpLBFBU94F0QMkf71b2MRhX0HvJwe jMcCB1/QZYQmcxd6fzr27OoawX/gMEI+5ciJ4UNvSzaBPfYj2DYDUaUpvyeDqIDn Q== Received: from nwd2mta4.analog.com ([137.71.173.58]) by mx0a-00128a01.pphosted.com (PPS) with ESMTPS id 4ce0xvw0jf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 20 Feb 2026 08:13:23 -0500 (EST) Received: from ASHBMBX8.ad.analog.com (ASHBMBX8.ad.analog.com [10.64.17.5]) by nwd2mta4.analog.com (8.14.7/8.14.7) with ESMTP id 61KDDMAx064769 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 20 Feb 2026 08:13:22 -0500 Received: from ASHBCASHYB4.ad.analog.com (10.64.17.132) by ASHBMBX8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:22 -0500 Received: from ASHBMBX8.ad.analog.com (10.64.17.5) by ASHBCASHYB4.ad.analog.com (10.64.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.37; Fri, 20 Feb 2026 08:13:22 -0500 Received: from zeus.spd.analog.com (10.66.68.11) by ashbmbx8.ad.analog.com (10.64.17.5) with Microsoft SMTP Server id 15.2.1748.37 via Frontend Transport; Fri, 20 Feb 2026 08:13:22 -0500 Received: from HYB-b1tGeUj4GP1.ad.analog.com (HYB-b1tGeUj4GP1.ad.analog.com [10.48.65.247]) by zeus.spd.analog.com (8.15.1/8.15.1) with ESMTP id 61KDCsHY009613; Fri, 20 Feb 2026 08:13:16 -0500 From: Antoniu Miclaus To: Antoniu Miclaus , Lars-Peter Clausen , Michael Hennerich , "Jonathan Cameron" , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , , Subject: [PATCH 7/7] iio: filter: admv8818: use dev_err_probe in probe path Date: Fri, 20 Feb 2026 15:11:45 +0200 Message-ID: <20260220131151.74329-8-antoniu.miclaus@analog.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260220131151.74329-1-antoniu.miclaus@analog.com> References: <20260220131151.74329-1-antoniu.miclaus@analog.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ADIRuleOP-NewSCL: Rule Triggered X-Authority-Analysis: v=2.4 cv=AeK83nXG c=1 sm=1 tr=0 ts=69985df3 cx=c_pps a=3WNzaoukacrqR9RwcOSAdA==:117 a=3WNzaoukacrqR9RwcOSAdA==:17 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=gAnH3GRIAAAA:8 a=aH7txxTo_R53wjfIuwcA:9 X-Proofpoint-ORIG-GUID: 3W4bCOGvjBfqx7uPVWJKkbz25kolT91l X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIwMDExNSBTYWx0ZWRfX0Fq3uBmD4e1j 4u3y0pptByECjCOqs1QX55GoEmbOeiBSwHTw1lWXV46Mlk1s3EEuoKkktvt7bY+RtNK/4R3R8S7 dszgtmpUEBZIqwjNmMViHcbWJ+V9hjLVERdNaNkF+Xj2Zt5iFOd5kcCHOMhH7xLx4MSY+Ojh72T T4GxohpUcokwuX5+P3LaEc5azY0EgdzrpM7vJ2NcYHE4VixPPohe9oo8luiiJvhRk4mPx38it7I yF1AlDAfVzk9pgh/vaVrKkdS+yE+gXLrBYeoCbAAXFFcADOrFHNWewc2kbsGP/HL+XK0faq8gxx sJIT9UFQ+w5Blf6LCaYXz11fODZD/PrtbSsgqO/4mh6uRbK/ezFZ8hfN1eV9W2UqOS8pbLZYs9/ maOxn1octOcD5lcRhMbhmh4w2lcVXYsaUtdFiXk4eNQ07TXGmelG9K/zgpPj6BKlLPSDxb8gEEF knN+YmQYwG93+cNDOww== X-Proofpoint-GUID: 3W4bCOGvjBfqx7uPVWJKkbz25kolT91l X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-20_01,2026-02-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 adultscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602200115 Content-Type: text/plain; charset="utf-8" Replace dev_err() + return with dev_err_probe() in admv8818_init(), which is called during probe. Also use dev_err_probe() for the regmap initialization error in the probe function. This simplifies error handling. Signed-off-by: Antoniu Miclaus --- drivers/iio/filter/admv8818.c | 38 ++++++++++++++++------------------- 1 file changed, 17 insertions(+), 21 deletions(-) diff --git a/drivers/iio/filter/admv8818.c b/drivers/iio/filter/admv8818.c index 19f823446cda..d440f37811a2 100644 --- a/drivers/iio/filter/admv8818.c +++ b/drivers/iio/filter/admv8818.c @@ -662,36 +662,31 @@ static int admv8818_init(struct admv8818_state *st) =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SOFTRESET_N_MSK | ADMV8818_SOFTRESET_MSK); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Soft Reset failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "ADMV8818 Soft Reset failed.\n"); =20 ret =3D regmap_write(st->regmap, ADMV8818_REG_SPI_CONFIG_A, ADMV8818_SDOACTIVE_N_MSK | ADMV8818_SDOACTIVE_MSK); - if (ret) { - dev_err(&spi->dev, "ADMV8818 SDO Enable failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "ADMV8818 SDO Enable failed.\n"); =20 ret =3D regmap_read(st->regmap, ADMV8818_REG_CHIPTYPE, &chip_id); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Chip ID read failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "ADMV8818 Chip ID read failed.\n"); =20 - if (chip_id !=3D 0x1) { - dev_err(&spi->dev, "ADMV8818 Invalid Chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D 0x1) + return dev_err_probe(&spi->dev, -EINVAL, + "ADMV8818 Invalid Chip ID.\n"); =20 ret =3D regmap_update_bits(st->regmap, ADMV8818_REG_SPI_CONFIG_B, ADMV8818_SINGLE_INSTRUCTION_MSK, FIELD_PREP(ADMV8818_SINGLE_INSTRUCTION_MSK, 1)); - if (ret) { - dev_err(&spi->dev, "ADMV8818 Single Instruction failed.\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, + "ADMV8818 Single Instruction failed.\n"); =20 if (st->clkin) return admv8818_rfin_band_select(st); @@ -766,7 +761,8 @@ static int admv8818_probe(struct spi_device *spi) =20 regmap =3D devm_regmap_init_spi(spi, &admv8818_regmap_config); if (IS_ERR(regmap)) - return PTR_ERR(regmap); + return dev_err_probe(&spi->dev, PTR_ERR(regmap), + "failed to initialize regmap\n"); =20 st =3D iio_priv(indio_dev); st->regmap =3D regmap; --=20 2.43.0