From nobody Sun Apr 5 16:27:57 2026 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBD3C2DBF40 for ; Fri, 20 Feb 2026 03:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771558728; cv=none; b=AOWRoxhfB5ojrMdc8ZJSl/iX/FSYlCqUBGNJnW92Cw0dNW2TNkfkfCB6fP1vzO2THvBw++sjK45CudCWDngKYw7X+pHy4khMmN+QKGZ55s0+4OT8cHVGJFRyg73GZvKB0YGV+S1w9VB1wrBfc7GPSNLGvQUepOHjyFIGCU3JRdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771558728; c=relaxed/simple; bh=ERiI0ik+7C8U2bOZoMUPA8NBk6mNeP8oUH1ilI5DrIk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hE7BjGrwreHBbqKn1wBS4sMyReXDnBGuQN+0XBW5xId7tBCEm9D+Tf+QDbpeZFM0pJxHD6pFik1hJOO1exHLzsdpx0Hkagp9keOhIurZgYTsxSX7fTgfcxc4qXovgx8a1XVyW+CWpZoqeilu734im3+C6fNk9aGw2L2MAGl7qks= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=I2mzisgh; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I2mzisgh" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-64ad46a44easo1563744d50.0 for ; Thu, 19 Feb 2026 19:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771558726; x=1772163526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TYi5KdDTrgKmUbM9Hgtml02i+c073pK3aRdi4XL87EQ=; b=I2mzisghLi54jACxIHeX8n3kJC+GUbKVsBaMTS0RIZ1mrQ7Uy+rXOU5GNEbSJJ5kVj d96b8G2UbQKwo1R1/3iv5Xc4kb5Nnl7UqbnqWwJxsqmPkTFrgVT+bMl9Wcm5J1OooJQ6 TI+5UDTRMCa0r0UtTkS6m0d4vf/fG+QIZ28K71uLaxB7Gxmw6iPmi8vLveN7Sgsujf4a h2ljmIBhLr8qR1pbzqgX6OM77tMCFM9QsL7WTwQMR4nTtjZfQHtdAvJi4dk6MFxKMU8K oOKkszHSEZyPGz8xUpUW3rC7z0f7jfq65VQA/L5uuRhEdAJVYFPImPyfyGny9rGvH+Te ozYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771558726; x=1772163526; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TYi5KdDTrgKmUbM9Hgtml02i+c073pK3aRdi4XL87EQ=; b=RWlWbvoIbBPJymn9pPR2+Em7HwFBFBvJDjcprHUnLvc9EAyqy3tTzN9JGjuUfwfaZB BkQK+Sc3WMtRJeVOygE1OL8s0ByLoadKtYrnjQHQ+4IoiYhTgsSv/O1zGOx4znV9HGc4 RpuWK3ofGkfFjTCLZCKAsMVRktw5JyNrglWvyBkxuBmK0k8+Qx0WuCmb9m6iBxYHmdQ4 y78xJxz2RW/3vHEeyZOk2+2aG/l8vw4dTl+7M9Sv3/2tGHPsAXOPU1JCRhcAukjisv4P HBIecde+WAQxUo81P/aRYrxct0NIkdcyHQuOGsTO3QOgjTXbYGVa3LsCqfbPfnaFTUgv Do3w== X-Forwarded-Encrypted: i=1; AJvYcCVDvql5e2FrFzriXxYsBooPCgk/k4zdy46SmZCKOomiK6kY+IPgWkGrhhoD7r5XxBr6j7RrMK393Ql5gf0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzf1wfm8NjPqSvQlM/Jtdm3DOerzs4D2SMti8pty70HcKW2tbSb 7yokivVjSZxs2oPLTp+o1/B6tz0Nt4Q00l2/cWvFYvig88fAq1+BXYJk X-Gm-Gg: AZuq6aINXyTTTr9B+0XXu3YpWhFO+iXwhjten0E+51k1+dF0teZWVVhYQPStNFwib0i klkphmyOUlvhEwph3X8uWGB7BUIuWuXq1IeTbCdoAGYm19bGARBWpm41KK/CEB/SXjSSPC5E6mI eO66dvtb/aTyXNppLWf1D3kG8DD52WkirlGwUNfavHR5fNmcltrS+VliyN56+OMlFWRd6Q1TQ15 62glYJEZjER0ffn6L3fF55ca1oiGIW7KbykgjtcsdUH7f+9/vVAkUs96fNsqgilSgS8Q68ZPvPc 9snzOx+5itBJyxLKV2yfgJ/k7EBGALyFFaMR5TMikQRfC2FpM8V4c4O8x777xc/fDWNyH0FBUFr +ZRBnKe8LItkTpJKJKhPgwQVaHSF5N0AdMfTI48mwUwtRSeXUYWMY4/RKYcSgS3gJHsh4oB5b5X ltUNu/kGaGwgAQ+3xk0jw3eExhEUAMIuDQBZYLySGh/OVxcrl/f29hZ5DfsNK48HO4E4YEnU/vI xD/ZwGkZULiR7qe8vznRNSG8ybDLsRRUjjfvhjAyGw= X-Received: by 2002:a05:690e:408a:b0:646:b1f3:aeb2 with SMTP id 956f58d0204a3-64c70ba3c7dmr277466d50.3.1771558725713; Thu, 19 Feb 2026 19:38:45 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c22eb2059sm7927069d50.10.2026.02.19.19.38.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 19:38:45 -0800 (PST) From: Ethan Tidmore To: cem@kernel.org, djwong@kernel.org Cc: brauner@kernel.org, neil@brown.name, jlayton@kernel.org, amir73il@gmail.com, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , stable@vger.kernel.org Subject: [PATCH v4] xfs: Fix error pointer dereference Date: Thu, 19 Feb 2026 21:38:25 -0600 Message-ID: <20260220033825.1153487-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function try_lookup_noperm() can return an error pointer and is not checked for one. Add checks for error pointer in xrep_adoption_check_dcache() and xrep_adoption_zap_dcache(). Detected by Smatch: fs/xfs/scrub/orphanage.c:449 xrep_adoption_check_dcache() error: 'd_child' dereferencing possible ERR_PTR() fs/xfs/scrub/orphanage.c:485 xrep_adoption_zap_dcache() error: 'd_child' dereferencing possible ERR_PTR() Fixes: 73597e3e42b4 ("xfs: ensure dentry consistency when the orphanage ado= pts a file") Cc: # v6.16 Signed-off-by: Ethan Tidmore Reviewed-by: "Darrick J. Wong" Reviewed-by: Nirjhar Roy (IBM) --- v4: - Add blank line after closing brace. v3: - Add dput(d_orphanage) before returning error code in=20 xrep_adoption_check_dcache(). - Revert xrep_adoption_zap_dcache() change back to v1 version. - Include function names where error pointer checks were added. v2: - Propagate the error back in xrep_adoption_check_dcache(). - Add Cc to stable. - Add correct Fixes tag. fs/xfs/scrub/orphanage.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/xfs/scrub/orphanage.c b/fs/xfs/scrub/orphanage.c index 52a108f6d5f4..33c6db6b4498 100644 --- a/fs/xfs/scrub/orphanage.c +++ b/fs/xfs/scrub/orphanage.c @@ -442,6 +442,11 @@ xrep_adoption_check_dcache( return 0; =20 d_child =3D try_lookup_noperm(&qname, d_orphanage); + if (IS_ERR(d_child)) { + dput(d_orphanage); + return PTR_ERR(d_child); + } + if (d_child) { trace_xrep_adoption_check_child(sc->mp, d_child); =20 @@ -479,7 +484,7 @@ xrep_adoption_zap_dcache( return; =20 d_child =3D try_lookup_noperm(&qname, d_orphanage); - while (d_child !=3D NULL) { + while (!IS_ERR_OR_NULL(d_child)) { trace_xrep_adoption_invalidate_child(sc->mp, d_child); =20 ASSERT(d_is_negative(d_child)); --=20 2.53.0