From nobody Fri Apr 3 10:57:46 2026 Received: from mail-dl1-f97.google.com (mail-dl1-f97.google.com [74.125.82.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A9E02D7D47 for ; Fri, 20 Feb 2026 03:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771558100; cv=none; b=sEvZ+sLBd+PYcDqKvBcPaO3pw3UZk6ZSw2ULtb4tWAv2hzS45l20IpTYg4b2MrJcmOnoZFs1sbhb7ZUpx/V6KtfaTKrg2JGbrRQOTuxYDT0aM4XD4D5K+WQf0ebH56a058/0fVAzqSXVVLLkVdcWI77fuboWDrhF7tSzHHnwYPY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771558100; c=relaxed/simple; bh=zUFAUVdTh72rKbrvljdX0A6hoTRSWJwJzaFgdY0Zch8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dizWcoovc3ce/yb3MXT8E7JAlnGMSLFAMSeo45JYr9uxcSdgc/mjXFEub3qgKDIDnPbdcSSkOA1BTjyencD7UI1MYY0/pmz4CUmAJLC1YLmbQ7iLUuhtXP8M4XQiDFkGOy/o4eZpCWFrNutYEvnrlKHWwGhTdKBrmnRiG20p5ps= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=ZythDX3m; arc=none smtp.client-ip=74.125.82.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="ZythDX3m" Received: by mail-dl1-f97.google.com with SMTP id a92af1059eb24-124a7216c9cso166661c88.0 for ; Thu, 19 Feb 2026 19:28:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771558099; x=1772162899; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A00Y3pDN9iUYHER17pm03ZbljFG3KevPDkg+zFu7U1Y=; b=ZythDX3mVb2mDctZ5IKAmgaBNtPGzT5ftPTaDmomsop0AiWCDWGTwwcyA1I6pj2KH1 7gSuqIUV+Q1SB9T5ADNhX1z9RQPIv7oQ3FdO0wkGIiz9MVNeDmboCi4B8oHjqQVYbeOn riOjxux2N8pZ7tjgAgut0IT37Dc6mh4Hd0T/aQ8iQwUVEfAfvIWOyyWxDzG9PYaSx0ni W/LWqyhMC/lQDT2E+kRFAQewk0Iq04qcuPoWlriHbcchlzLRUpxHa8FNgSrD8F/8HTx6 U17SdGPwSgYfhG79/+i5SIu35mWwPyzaCpl39gHjN2ar8dKjOgt0C3HKf1pjCc2fnH9W CGIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771558099; x=1772162899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=A00Y3pDN9iUYHER17pm03ZbljFG3KevPDkg+zFu7U1Y=; b=LG0vl7o3bxyzD92AX7hSOimny90o9k2NmAqDQvtt9Kk116yYM3G0zed28PoNd1icJ3 hnfl6DtI8uiob1CoZEw74CWb/eJwc6k+hq2ociiTCNgFFnIE89H575zETKKCpqvTH1Ru IgUFjl9I/n8UV5AItgYRuOL5zHdsjHAMnQcv2hFtorpTCj/33HRTr1J62dmJ0P42wAhX qw4c7kZ9JCLqRh/RTWMHs2DSn6NnrLvOwqEKvOs1ta7uDpVwB5WUcRnu21XGARC0d/ii aJEbq8991Yx9WC55hC72/ZjdfQO2NA7hBGH9SgiE4jo0MXXj+Bf4CeTtVB7n87frfNOX QE3w== X-Forwarded-Encrypted: i=1; AJvYcCWItuRN4M/inC0qCc5MMwRvOx6Qput3J68wiOfAtcCRUQ0HhB0onRi8hB+anIbhH3M65xR5uIkYWwj9f1Y=@vger.kernel.org X-Gm-Message-State: AOJu0YwMWe/pEVcFrM7x622OsNtCEmPCR2lq596VU5QzDQ70P26kxpAp KidvdIqTkq6G1Sx/+d88xBs+kgKavHh2VrSj4Ccs5CtC0zZS1kPLp5i1TLm5gQ+9l/7MzGg4aoZ Bpmdh6le5tm19odfsnm2q4AbYrUJezmdXQYA5 X-Gm-Gg: AZuq6aIHgVPPdACkpF3v7l1M5ZPceH6rXr2Kim+7mJh1sHMaww2UiI+YJF2Aspg3A71 VGSHupGSnJ9/fbvfOgmUb7tSR4PGYVYHjv34EvPJgy6zN4U1kvtDzU566wiTSvAFfOnTM2SyklY ReDFl7svnTXxxuR9qDS/FPiVjZi7VBLbBgSjKOIDAjYdByrQUcifd8nkckaJvu7L5abm7OsWgn1 WYBUweGwhtiHwusPUP56vJ0t0pnlZZB3QvIM0XTH9oqjUV40oiHU6XzjPfPmGGOeSfH81buXNZP 6m3T3u1Dek60pySyVzR+I0QXqw6uBzDQbb3j+dtGqRDAhjJPDNXIbp5qeEoWCLJyPC/3hSOSndx dtsREayYhGRFxS8662z89yUV/nkVp3nYrlaOkSAF2bmu1IIT+c5E+tg== X-Received: by 2002:a05:7022:7e03:b0:127:3480:7ca5 with SMTP id a92af1059eb24-127397d8408mr4869659c88.2.1771558098534; Thu, 19 Feb 2026 19:28:18 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.129]) by smtp-relay.gmail.com with ESMTPS id a92af1059eb24-12742b60d29sm3074231c88.1.2026.02.19.19.28.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 19:28:18 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 7CF1F341CC1; Thu, 19 Feb 2026 20:28:16 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 7A67BE420F8; Thu, 19 Feb 2026 20:28:16 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH 5/6] nvmet: use NVME_NS_FEAT_OPTPERF_SHIFT Date: Thu, 19 Feb 2026 20:28:08 -0700 Message-ID: <20260220032809.758089-6-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260220032809.758089-1-csander@purestorage.com> References: <20260220032809.758089-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use the NVME_NS_FEAT_OPTPERF_SHIFT constant in nvmet_bdev_set_limits() to set the OPTPERF bits of the nvme_id_ns NSFEAT field instead of the magic number 4. Signed-off-by: Caleb Sander Mateos Reviewed-by: Christoph Hellwig --- drivers/nvme/target/io-cmd-bdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd= -bdev.c index 8d246b8ca604..d94f885a56d9 100644 --- a/drivers/nvme/target/io-cmd-bdev.c +++ b/drivers/nvme/target/io-cmd-bdev.c @@ -28,15 +28,15 @@ void nvmet_bdev_set_limits(struct block_device *bdev, s= truct nvme_id_ns *id) id->nawun =3D lpp0b; id->nawupf =3D lpp0b; id->nacwu =3D lpp0b; =20 /* - * Bit 4 indicates that the fields NPWG, NPWA, NPDG, NPDA, and + * OPTPERF =3D 01b indicates that the fields NPWG, NPWA, NPDG, NPDA, and * NOWS are defined for this namespace and should be used by * the host for I/O optimization. */ - id->nsfeat |=3D 1 << 4; + id->nsfeat |=3D 0x1 << NVME_NS_FEAT_OPTPERF_SHIFT; /* NPWG =3D Namespace Preferred Write Granularity. 0's based */ id->npwg =3D to0based(bdev_io_min(bdev) / bdev_logical_block_size(bdev)); /* NPWA =3D Namespace Preferred Write Alignment. 0's based */ id->npwa =3D id->npwg; /* NPDG =3D Namespace Preferred Deallocate Granularity. 0's based */ --=20 2.45.2