From nobody Fri Apr 3 12:22:36 2026 Received: from mail-pl1-f227.google.com (mail-pl1-f227.google.com [209.85.214.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06320283FE5 for ; Fri, 20 Feb 2026 03:28:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771558099; cv=none; b=jijUjFbQ3ZOaspXb/WV2M3NRmxjrq69+fMdgRRBVf1IGnw+qgTgcsd6VpU7WpYw7jTnfU0ZFFwZpZRGrM8/yUERVf/pxnyHpMlTUJZ64hg/NbI+2B/QDQrBBhYR5sjQf5wIQzoK9Vnas+7mBD7algIfqRPSomAF0wNcW74aTR24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771558099; c=relaxed/simple; bh=bIAp2X9ovbr07d2sa5XIRpO5C9thT7Y5hErLWfChn/s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KiaWkoVQpS6HdEL+tE8yd8yale95cHbKDA0Buoenzwm7hm8Nc8HLWfW+UqkVfAF+7A0Z/NKz23RRHHTzzx22RkFzFmF9CBR0cAgoZkkZlyrO8RLr1NaUbHIVlz89wfs/PIsWOVdF2pVpeII9PdZTP1+58kFU7hXemm8QrG9tVwM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=ZSlcuNgI; arc=none smtp.client-ip=209.85.214.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="ZSlcuNgI" Received: by mail-pl1-f227.google.com with SMTP id d9443c01a7336-2a3e79fe2b8so1854355ad.1 for ; Thu, 19 Feb 2026 19:28:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771558097; x=1772162897; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rnvrwXKPD1mz6+9mov3GXHuRhTeAw5K2AjQa0fuRQNA=; b=ZSlcuNgIZMb2b+mLcR4RMechhcuhkuvtCA21XRI+sRSb4Nr5n/7KpsXdpQFwE4QQC5 kWzfUy0p5pOK1oIfhgdAVROUA/PxmAevGAF3YHRvZGe1ISzCcCSVvkjqZoKZI9TD61ir vtaxN0kyWjc+CfFJop/pIC03TuuyOx8ByDia/gLj3Wx2LbmyJ9Yi+RL75VV2SzFoP0sX 4QBT1ymyI1sfPwIN9VnzeWsLCJKQ8JoA8V0vQdUls/3IFLOcIxcdEIoTEnjvIjrY5w3t Af0NdvBtePLWwrUfKgm1LBxpY5FJSXaCtbsXpmJ8vNtCf0UVzqBa7xT3cTJNEnh1lxKj vP4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771558097; x=1772162897; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rnvrwXKPD1mz6+9mov3GXHuRhTeAw5K2AjQa0fuRQNA=; b=ERam3p+C9AgJ7kgLEtTYl+JfQOC3kjw4yvCizsJoe9HkHxl6fJckf99iIkh9Z96MLL jN01nd7Wc/qc0qfkDe7lO9uOrPGjSqfXz7EFOgKfICxQaXI5C/Zg8HFdcabsvPMCdKzR qD9OJf0R6NgEhtoH6ebWg4CIDLdp2k8aqR6mTjlaqymdpSVzE8jIff8Zh3HjpNpZ0ZWB YtarfJEOur88PWZ8/QJX/y5PUZF93zSxYdV+3gkdvh2bENXi+h7uxgMVNlaps00ImuvI P6n3asWsJnWaI0lgA+RDufBHv+gVoeudsOOnHViMbvC0rfyTbBUpmwZh6txnJsigj//z cv0Q== X-Forwarded-Encrypted: i=1; AJvYcCWzr7rT6bCH4ToEupleBAUp3KjmnARsI/OwYfpyDOddhd95z3c+J7GHTf7PyypNOjnFeOooojrLoXmFuQg=@vger.kernel.org X-Gm-Message-State: AOJu0YzLu7UuBza6opIe3TvoFVEfFrhXDquGT0Rlk8VzDOCpqNjz0Mqc xpbup1IN8EqIptGlH8euQdN2W7BmJoQUmnOFaoVNGZFLSH0UjSuVC3qrlg4kQ9k1PTjiizT3XiP qMMRUm7YuBIqkVbgKQgCzCpxMKeNT8Vi2VSDD4tt0fLxo2RlQRSve X-Gm-Gg: AZuq6aI0Z+mhKtYwguHO5ItgPqP1+M7YMcQfgEcQkVgUYgz4TnyTwVY29lvUVSZe0wO 5Y8gL5PsjPLQjWJ3pc6118UaxRGRIJHmoMW2fQL+0Qs0OJxvDRvK5xLeKDlZOdzs6mQ9Gw3c2Qo zPCHQv0yP+e2woQvcTQ220tughhAXy5xTEV/swslAMoFTigwFc6XI0AgYcmokRNvgzflN3yaS17 fJxiWLU9k3BLoyrUOYkVV2fDKj541sKmJM+q9hEBU8vgacCEREwRfhibhYiu1Y8R+sSRN4feM/2 2Zu2Nu04oZKWYARU0JEwQyU5IP2RFslqFQJWblMNDTTWD7PC+xz++nDAil96zhivTO7esIRmgWL F+9984ei2cKeXioEb0UY0y4q1KW2gOvtMfijSJTw= X-Received: by 2002:a17:903:1983:b0:2aa:d5fe:f193 with SMTP id d9443c01a7336-2ab4d001292mr157822975ad.4.1771558096920; Thu, 19 Feb 2026 19:28:16 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2ad1a79387csm23110195ad.27.2026.02.19.19.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 19:28:16 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 2CA6F341568; Thu, 19 Feb 2026 20:28:16 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id 2AAFAE420F8; Thu, 19 Feb 2026 20:28:16 -0700 (MST) From: Caleb Sander Mateos To: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Caleb Sander Mateos Subject: [PATCH 3/6] nvme: always issue I/O Command Set specific Identify Namespace Date: Thu, 19 Feb 2026 20:28:06 -0700 Message-ID: <20260220032809.758089-4-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260220032809.758089-1-csander@purestorage.com> References: <20260220032809.758089-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently, the I/O Command Set specific Identify Namespace structure is only fetched for controllers that support extended LBA formats. This is because struct nvme_id_ns_nvm is only used by nvme_configure_pi_elbas(), which is only called when the ELBAS bit is set in the CTRATT field of the Identify Controller structure. However, the I/O Command Set specific Identify Namespace structure will soon be used in nvme_config_discard(), so always try to obtain it in nvme_update_ns_info_block() if the controller supports NVMe version 2.0 or later. Signed-off-by: Caleb Sander Mateos Reviewed-by: Christoph Hellwig --- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 674dd823b209..70ff14a56a01 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -2351,11 +2351,11 @@ static int nvme_update_ns_info_block(struct nvme_ns= *ns, ret =3D -ENXIO; goto out; } lbaf =3D nvme_lbaf_index(id->flbas); =20 - if (ns->ctrl->ctratt & NVME_CTRL_ATTR_ELBAS) { + if (ns->ctrl->vs >=3D NVME_VS(2, 0, 0)) { ret =3D nvme_identify_ns_nvm(ns->ctrl, info->nsid, &nvm); if (ret < 0) goto out; } =20 --=20 2.45.2