From nobody Sun Apr 5 13:11:56 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8354E1B0F19 for ; Fri, 20 Feb 2026 02:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554409; cv=none; b=QZPCGuTXCvBfc8/yuJAfHNWgxRaHs+4gU05JKBVx8y7VZfINEPPXOV5ozaEet10rv0W5o2jhAfJ2SXCifwLoO9beGbRafle6BLf6o1dsVZ3gRfGG0bRG0uo4LszJiBnORtWN0Jl8vsyjWXvXIYXSk4e6gQ4diVnTvN8dvzH06ZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554409; c=relaxed/simple; bh=sW4m8N5gSsBxYC/zHDddIGyYQ0Jk/YeZwZ0HLGR0qYs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dfkJ7lZdpMNkW5ieuwovmS818sh6AvzLKUPPiVg1yY2/3bRmUimVwIDz/2Apthbw5RL2fGld0WYVlxkgtyh7yc2jG+hDj1i6fb8dRju7Pj8N9LVjWLLAbIbyQNoIs/h1te6VS8hBLaqwiPtdGILBkBCnU46wHv7QyINEzbU/T2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QLuB+Hdr; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QLuB+Hdr" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-483a233819aso11050945e9.3 for ; Thu, 19 Feb 2026 18:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771554406; x=1772159206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yfpS8DlXvvljKpn2dCpU5kHCKROr07RH+HWjYwPkZPA=; b=QLuB+Hdrmhwk0dLVsfsPsOyN8RJJy5L/N2MK5bjFCi1nzz6qwbF0q80ot8DWBizGU6 ye7qtL3TVyscoFyPoy1NyX/9b1zuKeLio0qfbeT+R1AXO6aAgPcN3NGl3IhpEeeM9zEW UT09W/nrU4IwAFFFH68tsTId7+nBDTWxZkUlPP6CiZ0LHdrf8I81k2V+Xl0mc8VNrzDY XxOn8JhnOELSGWBFRhNDFaJvYeGLGGxGIEXIKCfsdqr8RQ3ioKbsNTZVGP536qWPj7Cw bSHNZQmkwNY/D4FkEERaWI0XsiBibbKTYKEAIeX+GuXXA597fFUUuD/QM8AgNYz2sDLn QeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771554406; x=1772159206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yfpS8DlXvvljKpn2dCpU5kHCKROr07RH+HWjYwPkZPA=; b=smBkAxdKhS3N4D9cp2RjnlAn3WgsBI48P1zuEKFodF5FGwPYwaLstU5NaNbEcfUTKb PlWqrDeGXF9vjH0INPKyGTK0Kt3KC7T+llQMBRkGYUps0ED5CBZz2ia2x4KHcAxZC7PT imSZRVyX27jcG5Age2MFKy5vcI1vfj6oyP+kEj1gzC0L1oVXrSBGCZXaY78giIZiAhNO CJI5GVYTvvx96Jdw+Xvl2wuZLpBI5RvMZ5Epyz9+XiNhHJ5twdzbKuO/M1aT2Qumvj8P iIBW+nAzCa2eCGSkwpOUURTdMNUSc9BISgmxfddBlXK69BAfe3aKch8vl502ZZyLinxe C7tA== X-Forwarded-Encrypted: i=1; AJvYcCVjETsUP/dwSBdFdiNfidOj7PVeaZy7+eTPWUMk6qSFVxJqccfkqm/VwL02jIwVVdabpmFAoPU2NOhA+G0=@vger.kernel.org X-Gm-Message-State: AOJu0Yze0gFJhb2XT7CFmgMoDf1LarPnhP7/s/W00QbqdwOaVWsyMNiQ ZZv7LgI2+ckE7ORBC4kLdB6yXCyhB5pxpRKCaHVt6VHuNDvKfwELvMEn X-Gm-Gg: AZuq6aLaMOwb3nc+mqlORSYjJ+GR0EYYq2Pug3MSKbMjmJoUdGPitc6HhSWrahcObSn s7inz9b3rbqoro5F8QV79LNj7a1F+89xqo2715c2w7536bIXYKOT7JH1orqXpKvBL4TTVC3U38j RyyZlVJp1wwKB30MHtnTdt2SqqIngdddy/zVmwG/2fIhfCKAYvsGbew5ae4TjAG42F2LgrhuTq5 yC5uGqYf/Gcf1syQZbcCdVSFeVpPDbpZQesC8r15VlHUul7swuJTYBj964ZB6c7k9eXBthRSeiG Vddxm85UFAcVMQRZxYLYDLEB1UuNWGdm+7brk9XIzHP7uPEM4VA2XVqPDc9LTR7d0dXX3x9mk2j OFiPNAmiDOeh0k4mFwK7UqlRIZRLIM/dQYnuviUv+miSgLU2V4xrfr6YqSvskO5yt4d7i2O3OMQ iyJIknCkt98OMcckhr0VJmvydXmMnyFfRy5C2AJUSWNQR9nAC0S5t71c0FViZ7n0RDmf9N X-Received: by 2002:a05:6000:26c6:b0:434:2569:275d with SMTP id ffacd0b85a97d-43958e0cde3mr13182560f8f.26.1771554405557; Thu, 19 Feb 2026 18:26:45 -0800 (PST) Received: from Arch-Spectre.dur.ac.uk ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ad0166sm53446975f8f.35.2026.02.19.18.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 18:26:44 -0800 (PST) From: Yicong Hui To: christian.koenig@amd.com, michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Yicong Hui Subject: [RFC PATCH v2 1/3] drm/syncobj: Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to query errors Date: Fri, 20 Feb 2026 02:26:26 +0000 Message-ID: <20260220022631.2205037-2-yiconghui@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260220022631.2205037-1-yiconghui@gmail.com> References: <20260220022631.2205037-1-yiconghui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to make the DRM_IOCTL_SYNCOBJ_QUERY ioctl fill out the handles array with the error code of the first fence found per syncobj and 0 if one is not found and maintain the normal return value in points. Suggested-by: Christian K=C3=B6nig Suggested-by: Michel D=C3=A4nzer Signed-off-by: Yicong Hui --- drivers/dma-buf/dma-fence-chain.c | 52 +++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_syncobj.c | 21 ++++++++++++- include/linux/dma-fence-chain.h | 1 + include/uapi/drm/drm.h | 1 + 4 files changed, 74 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-= chain.c index a8a90acf4f34..076d78b73379 100644 --- a/drivers/dma-buf/dma-fence-chain.c +++ b/drivers/dma-buf/dma-fence-chain.c @@ -76,6 +76,58 @@ struct dma_fence *dma_fence_chain_walk(struct dma_fence = *fence) } EXPORT_SYMBOL(dma_fence_chain_walk); =20 +/** + * dma_fence_chain_find_error - find the latest error + * @fence: current chain node + * + * Walk the chain repeatedly until reaches a fence with error, or the + * end of the fence chain. Does not garbage collect. + * + * Returns the first error it finds in the chain. + */ +int64_t dma_fence_chain_find_error(struct dma_fence *fence) +{ + struct dma_fence_chain *chain, *prev_chain; + struct dma_fence *prev; + int64_t error =3D 0; + + chain =3D to_dma_fence_chain(fence); + if (!chain) + return fence->error; + + if (chain->fence->error) + return chain->fence->error; + + while ((prev =3D dma_fence_chain_get_prev(chain))) { + prev_chain =3D to_dma_fence_chain(prev); + + if (prev_chain) { + + if (prev_chain->fence->error) { + error =3D prev_chain->fence->error; + dma_fence_put(prev); + break; + } + + chain =3D prev_chain; + } else { + + if (prev->error) + error =3D prev->error; + dma_fence_put(prev); + break; + } + + + dma_fence_put(prev); + + } + + + return error; +} +EXPORT_SYMBOL(dma_fence_chain_find_error); + /** * dma_fence_chain_find_seqno - find fence chain node by seqno * @pfence: pointer to the chain node where to start diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 2d4ab745fdad..322f64b72775 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -1654,14 +1654,17 @@ int drm_syncobj_query_ioctl(struct drm_device *dev,= void *data, { struct drm_syncobj_timeline_array *args =3D data; struct drm_syncobj **syncobjs; + unsigned int valid_flags =3D DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED | + DRM_SYNCOBJ_QUERY_FLAGS_ERROR; uint64_t __user *points =3D u64_to_user_ptr(args->points); + uint64_t __user *handles =3D u64_to_user_ptr(args->handles); uint32_t i; int ret; =20 if (!drm_core_check_feature(dev, DRIVER_SYNCOBJ_TIMELINE)) return -EOPNOTSUPP; =20 - if (args->flags & ~DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) + if (args->flags & ~valid_flags) return -EINVAL; =20 if (args->count_handles =3D=3D 0) @@ -1680,6 +1683,22 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, = void *data, uint64_t point; =20 fence =3D drm_syncobj_fence_get(syncobjs[i]); + + if (args->flags & DRM_SYNCOBJ_QUERY_FLAGS_ERROR) { + int64_t error =3D 0; + + if (fence) + error =3D dma_fence_chain_find_error(fence); + + ret =3D copy_to_user(&handles[i], &error, sizeof(int64_t)); + ret =3D ret ? -EFAULT : 0; + if (ret) { + dma_fence_put(fence); + break; + } + + } + chain =3D to_dma_fence_chain(fence); if (chain) { struct dma_fence *iter, *last_signaled =3D diff --git a/include/linux/dma-fence-chain.h b/include/linux/dma-fence-chai= n.h index 68c3c1e41014..b4ada124d7b6 100644 --- a/include/linux/dma-fence-chain.h +++ b/include/linux/dma-fence-chain.h @@ -122,6 +122,7 @@ static inline void dma_fence_chain_free(struct dma_fenc= e_chain *chain) iter =3D dma_fence_chain_walk(iter)) =20 struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence); +int64_t dma_fence_chain_find_error(struct dma_fence *fence); int dma_fence_chain_find_seqno(struct dma_fence **pfence, uint64_t seqno); void dma_fence_chain_init(struct dma_fence_chain *chain, struct dma_fence *prev, diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 27cc159c1d27..2640cc0a09fe 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -1044,6 +1044,7 @@ struct drm_syncobj_array { }; =20 #define DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED (1 << 0) /* last available = point on timeline syncobj */ +#define DRM_SYNCOBJ_QUERY_FLAGS_ERROR (1 << 1) /* fill out error codes if = they are found */ struct drm_syncobj_timeline_array { __u64 handles; __u64 points; --=20 2.53.0