From nobody Sun Apr 5 13:12:58 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8354E1B0F19 for ; Fri, 20 Feb 2026 02:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554409; cv=none; b=QZPCGuTXCvBfc8/yuJAfHNWgxRaHs+4gU05JKBVx8y7VZfINEPPXOV5ozaEet10rv0W5o2jhAfJ2SXCifwLoO9beGbRafle6BLf6o1dsVZ3gRfGG0bRG0uo4LszJiBnORtWN0Jl8vsyjWXvXIYXSk4e6gQ4diVnTvN8dvzH06ZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554409; c=relaxed/simple; bh=sW4m8N5gSsBxYC/zHDddIGyYQ0Jk/YeZwZ0HLGR0qYs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dfkJ7lZdpMNkW5ieuwovmS818sh6AvzLKUPPiVg1yY2/3bRmUimVwIDz/2Apthbw5RL2fGld0WYVlxkgtyh7yc2jG+hDj1i6fb8dRju7Pj8N9LVjWLLAbIbyQNoIs/h1te6VS8hBLaqwiPtdGILBkBCnU46wHv7QyINEzbU/T2E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QLuB+Hdr; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QLuB+Hdr" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-483a233819aso11050945e9.3 for ; Thu, 19 Feb 2026 18:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771554406; x=1772159206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yfpS8DlXvvljKpn2dCpU5kHCKROr07RH+HWjYwPkZPA=; b=QLuB+Hdrmhwk0dLVsfsPsOyN8RJJy5L/N2MK5bjFCi1nzz6qwbF0q80ot8DWBizGU6 ye7qtL3TVyscoFyPoy1NyX/9b1zuKeLio0qfbeT+R1AXO6aAgPcN3NGl3IhpEeeM9zEW UT09W/nrU4IwAFFFH68tsTId7+nBDTWxZkUlPP6CiZ0LHdrf8I81k2V+Xl0mc8VNrzDY XxOn8JhnOELSGWBFRhNDFaJvYeGLGGxGIEXIKCfsdqr8RQ3ioKbsNTZVGP536qWPj7Cw bSHNZQmkwNY/D4FkEERaWI0XsiBibbKTYKEAIeX+GuXXA597fFUUuD/QM8AgNYz2sDLn QeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771554406; x=1772159206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yfpS8DlXvvljKpn2dCpU5kHCKROr07RH+HWjYwPkZPA=; b=smBkAxdKhS3N4D9cp2RjnlAn3WgsBI48P1zuEKFodF5FGwPYwaLstU5NaNbEcfUTKb PlWqrDeGXF9vjH0INPKyGTK0Kt3KC7T+llQMBRkGYUps0ED5CBZz2ia2x4KHcAxZC7PT imSZRVyX27jcG5Age2MFKy5vcI1vfj6oyP+kEj1gzC0L1oVXrSBGCZXaY78giIZiAhNO CJI5GVYTvvx96Jdw+Xvl2wuZLpBI5RvMZ5Epyz9+XiNhHJ5twdzbKuO/M1aT2Qumvj8P iIBW+nAzCa2eCGSkwpOUURTdMNUSc9BISgmxfddBlXK69BAfe3aKch8vl502ZZyLinxe C7tA== X-Forwarded-Encrypted: i=1; AJvYcCVjETsUP/dwSBdFdiNfidOj7PVeaZy7+eTPWUMk6qSFVxJqccfkqm/VwL02jIwVVdabpmFAoPU2NOhA+G0=@vger.kernel.org X-Gm-Message-State: AOJu0Yze0gFJhb2XT7CFmgMoDf1LarPnhP7/s/W00QbqdwOaVWsyMNiQ ZZv7LgI2+ckE7ORBC4kLdB6yXCyhB5pxpRKCaHVt6VHuNDvKfwELvMEn X-Gm-Gg: AZuq6aLaMOwb3nc+mqlORSYjJ+GR0EYYq2Pug3MSKbMjmJoUdGPitc6HhSWrahcObSn s7inz9b3rbqoro5F8QV79LNj7a1F+89xqo2715c2w7536bIXYKOT7JH1orqXpKvBL4TTVC3U38j RyyZlVJp1wwKB30MHtnTdt2SqqIngdddy/zVmwG/2fIhfCKAYvsGbew5ae4TjAG42F2LgrhuTq5 yC5uGqYf/Gcf1syQZbcCdVSFeVpPDbpZQesC8r15VlHUul7swuJTYBj964ZB6c7k9eXBthRSeiG Vddxm85UFAcVMQRZxYLYDLEB1UuNWGdm+7brk9XIzHP7uPEM4VA2XVqPDc9LTR7d0dXX3x9mk2j OFiPNAmiDOeh0k4mFwK7UqlRIZRLIM/dQYnuviUv+miSgLU2V4xrfr6YqSvskO5yt4d7i2O3OMQ iyJIknCkt98OMcckhr0VJmvydXmMnyFfRy5C2AJUSWNQR9nAC0S5t71c0FViZ7n0RDmf9N X-Received: by 2002:a05:6000:26c6:b0:434:2569:275d with SMTP id ffacd0b85a97d-43958e0cde3mr13182560f8f.26.1771554405557; Thu, 19 Feb 2026 18:26:45 -0800 (PST) Received: from Arch-Spectre.dur.ac.uk ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ad0166sm53446975f8f.35.2026.02.19.18.26.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 18:26:44 -0800 (PST) From: Yicong Hui To: christian.koenig@amd.com, michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Yicong Hui Subject: [RFC PATCH v2 1/3] drm/syncobj: Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to query errors Date: Fri, 20 Feb 2026 02:26:26 +0000 Message-ID: <20260220022631.2205037-2-yiconghui@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260220022631.2205037-1-yiconghui@gmail.com> References: <20260220022631.2205037-1-yiconghui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add flag DRM_SYNCOBJ_QUERY_FLAGS_ERROR to make the DRM_IOCTL_SYNCOBJ_QUERY ioctl fill out the handles array with the error code of the first fence found per syncobj and 0 if one is not found and maintain the normal return value in points. Suggested-by: Christian K=C3=B6nig Suggested-by: Michel D=C3=A4nzer Signed-off-by: Yicong Hui --- drivers/dma-buf/dma-fence-chain.c | 52 +++++++++++++++++++++++++++++++ drivers/gpu/drm/drm_syncobj.c | 21 ++++++++++++- include/linux/dma-fence-chain.h | 1 + include/uapi/drm/drm.h | 1 + 4 files changed, 74 insertions(+), 1 deletion(-) diff --git a/drivers/dma-buf/dma-fence-chain.c b/drivers/dma-buf/dma-fence-= chain.c index a8a90acf4f34..076d78b73379 100644 --- a/drivers/dma-buf/dma-fence-chain.c +++ b/drivers/dma-buf/dma-fence-chain.c @@ -76,6 +76,58 @@ struct dma_fence *dma_fence_chain_walk(struct dma_fence = *fence) } EXPORT_SYMBOL(dma_fence_chain_walk); =20 +/** + * dma_fence_chain_find_error - find the latest error + * @fence: current chain node + * + * Walk the chain repeatedly until reaches a fence with error, or the + * end of the fence chain. Does not garbage collect. + * + * Returns the first error it finds in the chain. + */ +int64_t dma_fence_chain_find_error(struct dma_fence *fence) +{ + struct dma_fence_chain *chain, *prev_chain; + struct dma_fence *prev; + int64_t error =3D 0; + + chain =3D to_dma_fence_chain(fence); + if (!chain) + return fence->error; + + if (chain->fence->error) + return chain->fence->error; + + while ((prev =3D dma_fence_chain_get_prev(chain))) { + prev_chain =3D to_dma_fence_chain(prev); + + if (prev_chain) { + + if (prev_chain->fence->error) { + error =3D prev_chain->fence->error; + dma_fence_put(prev); + break; + } + + chain =3D prev_chain; + } else { + + if (prev->error) + error =3D prev->error; + dma_fence_put(prev); + break; + } + + + dma_fence_put(prev); + + } + + + return error; +} +EXPORT_SYMBOL(dma_fence_chain_find_error); + /** * dma_fence_chain_find_seqno - find fence chain node by seqno * @pfence: pointer to the chain node where to start diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 2d4ab745fdad..322f64b72775 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -1654,14 +1654,17 @@ int drm_syncobj_query_ioctl(struct drm_device *dev,= void *data, { struct drm_syncobj_timeline_array *args =3D data; struct drm_syncobj **syncobjs; + unsigned int valid_flags =3D DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED | + DRM_SYNCOBJ_QUERY_FLAGS_ERROR; uint64_t __user *points =3D u64_to_user_ptr(args->points); + uint64_t __user *handles =3D u64_to_user_ptr(args->handles); uint32_t i; int ret; =20 if (!drm_core_check_feature(dev, DRIVER_SYNCOBJ_TIMELINE)) return -EOPNOTSUPP; =20 - if (args->flags & ~DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED) + if (args->flags & ~valid_flags) return -EINVAL; =20 if (args->count_handles =3D=3D 0) @@ -1680,6 +1683,22 @@ int drm_syncobj_query_ioctl(struct drm_device *dev, = void *data, uint64_t point; =20 fence =3D drm_syncobj_fence_get(syncobjs[i]); + + if (args->flags & DRM_SYNCOBJ_QUERY_FLAGS_ERROR) { + int64_t error =3D 0; + + if (fence) + error =3D dma_fence_chain_find_error(fence); + + ret =3D copy_to_user(&handles[i], &error, sizeof(int64_t)); + ret =3D ret ? -EFAULT : 0; + if (ret) { + dma_fence_put(fence); + break; + } + + } + chain =3D to_dma_fence_chain(fence); if (chain) { struct dma_fence *iter, *last_signaled =3D diff --git a/include/linux/dma-fence-chain.h b/include/linux/dma-fence-chai= n.h index 68c3c1e41014..b4ada124d7b6 100644 --- a/include/linux/dma-fence-chain.h +++ b/include/linux/dma-fence-chain.h @@ -122,6 +122,7 @@ static inline void dma_fence_chain_free(struct dma_fenc= e_chain *chain) iter =3D dma_fence_chain_walk(iter)) =20 struct dma_fence *dma_fence_chain_walk(struct dma_fence *fence); +int64_t dma_fence_chain_find_error(struct dma_fence *fence); int dma_fence_chain_find_seqno(struct dma_fence **pfence, uint64_t seqno); void dma_fence_chain_init(struct dma_fence_chain *chain, struct dma_fence *prev, diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 27cc159c1d27..2640cc0a09fe 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -1044,6 +1044,7 @@ struct drm_syncobj_array { }; =20 #define DRM_SYNCOBJ_QUERY_FLAGS_LAST_SUBMITTED (1 << 0) /* last available = point on timeline syncobj */ +#define DRM_SYNCOBJ_QUERY_FLAGS_ERROR (1 << 1) /* fill out error codes if = they are found */ struct drm_syncobj_timeline_array { __u64 handles; __u64 points; --=20 2.53.0 From nobody Sun Apr 5 13:12:58 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E60E1CAA65 for ; Fri, 20 Feb 2026 02:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554409; cv=none; b=Pnej5DUQ7vkutikM9kGYZivMN4SSFGLBlTU8QDqJ6cMtU29Egi0EvBvBBtTMWDgN7mtK4t19tgLjZZrWnDiXNNwoeOPLUNDSpdUYMAlgYrontgYdYZi+UJYT05QfAVrRbgY58Sh3tHV+rre416a46sqzfVWVWVVWhEtT87ptC8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554409; c=relaxed/simple; bh=/B4nvKknrKi3NJZmLJv3aG8mYi+Z/m5WS+UAxTJuONg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=esbWqVMDX7pjBGhaFhmlqLPRiQANgozB5lkYUPVrVLNna5qA4DnZOAmCxmbBHikb+QBGMjJ06WoIB8W/+sJuxlxWTPGXLVBwWwz8ebrG5cWuthpgeRa69xHnUTnJBSip7xplfJcWfehvKBC1Yxsvysg+Saie/UFlccuWUZ7plV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RtQ0ZVGN; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RtQ0ZVGN" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43638a3330dso1307833f8f.0 for ; Thu, 19 Feb 2026 18:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771554406; x=1772159206; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pJloV9r3ybizJNpOABCJHtRr3/jWkPGIyeA16Sq8DIo=; b=RtQ0ZVGNgA2ReduuObzlG72+rXzWmdX4ca+jWo2Kz/R5E5AoJPhxLa+3SExGLlA1fy xmK06R6xYiKn7R7ZGns6rUSQ1eZ7PUgK5NDScOsF69uvgYMIpfcgBVY/b3ebQDnO/LM2 wz6OcggjOfJb7NqXWkabPHpQeXngz//zGFaoLkf1xlqqK6Lb8jZfJCW+QyKjbBxnEZZd 7GsxmtNoehQmppTKUHPzC/E0ZcvOTqqUz2zCr+u3rfFeayRk4mbZR4ICyreWM1TO2lZd 7dTVxVtQa40KI3wvIx7DZ9WJiPWcRUYFJRbU4EdUOwAKC+TTvzcd4ENVOMca0exDUUN9 9IuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771554406; x=1772159206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pJloV9r3ybizJNpOABCJHtRr3/jWkPGIyeA16Sq8DIo=; b=hZc1PjZeE6KXBefFPBlLqrQjhYrkplGPzn0Cvyujd/6Ronc12UJE4iheBQ+H5kD+OL DdFyTKXs6S8B/mitE4nbIRK0/lbYqQ5d0FdBwlAai9R/ushQKwWYfYH58igwXewziW3c 3wXYwZxzDRsQXDkz/wDwE3FJk3IgiIxoUeze5nKugSvFr23adiKw5A1csQpfzpG7cyRt hvBycCmtm66eUvj8JupZUTDWVK4pPbxVcaimDTvAkOxkYs15DGV82folVnTK1ORSlTu0 SEx9KY1lw33Xwpv/BFDtXmzJ+s/fUVTxSq0RCGulVillgtTXiqOZU1e02hoJ+Z8U22pO j/4w== X-Forwarded-Encrypted: i=1; AJvYcCXH2F0njhAUoFqvAL55sYqBBuhsBdZ/6hWi3iZeS1eXKlmosarpwya++lleTF6Ag/SsPVFsCIHk3+X8Q80=@vger.kernel.org X-Gm-Message-State: AOJu0YzIEWoAcVqaqaAeR8EtQ0CEqKj/b/DI8+1lAfiZSuXUXE8DQHTK bws6f99X7xO27q5+BY30aM9CZ4PVMKJi3NZXPtyTuqtIiv10nVake6BKUCSQgg== X-Gm-Gg: AZuq6aJK6wmikHOdx2lsrmrDRoNM7DZV0DD43hdh79/gznCDtEDvefFoydLUIBpjFQt n0zn0B0e5YjhNhRvQRvpPxVFHQxcywAJ0HcpJZt/icS+iGoCta3bIOrkIfE7Yt2o2McGTCUVrYJ KCPk8u6bBsF2YYqyDAKG3+8vIcR5cPLDS5QsdePwwGuC5qd6He+cPEY+aSP3QcPCxO7h9mx9OD4 e7OumWobhKou98oAmu0CuWp3YRSXJPRjhZn4XtSPM3m+cew3RSskvcnHgeWA5pHX/Xnl1lVldSu Tz9Jq3u9Zwmdh/vU9NWMGHgVSVFeizllzLToH1O2wBSpBlD7odr6VPpIchOr2Li+vQ0TtnU9PU9 d7X+n/5dqpUi+Qp9DtLtijMnB+ppCWZ96OnxcjlxgQbphm2a7TyTxuTlzmxBNbHTpl/hSVuJJEE swgy+Yx0MpLRN1M62QMQyDX/GaO+bYvls60r+Ksxbg3lPpLgN+RHZolH/1K0tulfss2rPjeAP1x F0rMRM= X-Received: by 2002:a05:6000:2601:b0:436:3707:2bfb with SMTP id ffacd0b85a97d-4379db934a8mr33089800f8f.34.1771554406141; Thu, 19 Feb 2026 18:26:46 -0800 (PST) Received: from Arch-Spectre.dur.ac.uk ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ad0166sm53446975f8f.35.2026.02.19.18.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 18:26:45 -0800 (PST) From: Yicong Hui To: christian.koenig@amd.com, michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Yicong Hui Subject: [RFC PATCH v2 2/3] drm/syncobj: Add DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR ioctl flag Date: Fri, 20 Feb 2026 02:26:27 +0000 Message-ID: <20260220022631.2205037-3-yiconghui@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260220022631.2205037-1-yiconghui@gmail.com> References: <20260220022631.2205037-1-yiconghui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Add DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR ioctl flag for the ioctls DRM_IOCTL_SYNCOBJ_WAIT and DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT, which will make them abort their wait and return the error code and its associated syncobj. Suggested-by: Christian K=C3=B6nig Suggested-by: Michel D=C3=A4nzer Signed-off-by: Yicong Hui --- drivers/gpu/drm/drm_syncobj.c | 25 +++++++++++++++++++++---- include/uapi/drm/drm.h | 1 + 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c index 322f64b72775..fb55fd46fb84 100644 --- a/drivers/gpu/drm/drm_syncobj.c +++ b/drivers/gpu/drm/drm_syncobj.c @@ -1139,6 +1139,13 @@ static signed long drm_syncobj_array_wait_timeout(st= ruct drm_syncobj **syncobjs, if (!fence) continue; =20 + if ((flags & DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR) && fence->error) { + if (idx) + *idx =3D i; + timeout =3D fence->error; + goto done_waiting; + } + if ((flags & DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE) || dma_fence_is_signaled(fence) || (!entries[i].fence_cb.func && @@ -1242,8 +1249,12 @@ static int drm_syncobj_array_wait(struct drm_device = *dev, wait->flags, timeout, &first, deadline); - if (timeout < 0) + if (timeout < 0) { + if (wait->flags & DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR) + wait->first_signaled =3D first; + return timeout; + } wait->first_signaled =3D first; } else { timeout =3D drm_timeout_abs_to_jiffies(timeline_wait->timeout_nsec); @@ -1253,8 +1264,12 @@ static int drm_syncobj_array_wait(struct drm_device = *dev, timeline_wait->flags, timeout, &first, deadline); - if (timeout < 0) + if (timeout < 0) { + if (timeline_wait->flags & DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR) + timeline_wait->first_signaled =3D first; + return timeout; + } timeline_wait->first_signaled =3D first; } return 0; @@ -1332,7 +1347,8 @@ drm_syncobj_wait_ioctl(struct drm_device *dev, void *= data, =20 possible_flags =3D DRM_SYNCOBJ_WAIT_FLAGS_WAIT_ALL | DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT | - DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE; + DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE | + DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR; =20 if (args->flags & ~possible_flags) return -EINVAL; @@ -1376,7 +1392,8 @@ drm_syncobj_timeline_wait_ioctl(struct drm_device *de= v, void *data, possible_flags =3D DRM_SYNCOBJ_WAIT_FLAGS_WAIT_ALL | DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT | DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE | - DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE; + DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE | + DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR; =20 if (args->flags & ~possible_flags) return -EINVAL; diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 2640cc0a09fe..bc958af5a910 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -977,6 +977,7 @@ struct drm_syncobj_transfer { #define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT (1 << 1) #define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_AVAILABLE (1 << 2) /* wait for time po= int to become available */ #define DRM_SYNCOBJ_WAIT_FLAGS_WAIT_DEADLINE (1 << 3) /* set fence deadlin= e to deadline_nsec */ +#define DRM_SYNCOBJ_WAIT_FLAGS_ABORT_ON_ERROR (1 << 4) /* abort upon any f= ence failure return err */ struct drm_syncobj_wait { __u64 handles; /* absolute timeout */ --=20 2.53.0 From nobody Sun Apr 5 13:12:58 2026 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C9C022BDC04 for ; Fri, 20 Feb 2026 02:26:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554410; cv=none; b=UdqnB1hpJpMBtBneW84RR1HcLqjUkY7Gxhx27hmeQ2R+zwjAX5S4VMP4Kcd8MV0x9VjysuarxQGYrm3X4OggKX68ssB1QJRAr1g5L5AVZRXP8jMi1GXt7p7q3os7g7SdShedN6yPrC7uHH5es+HXwqj+zXnT90Jxz7TzNwQzrNg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554410; c=relaxed/simple; bh=Inke+v9G8UVsM7i6besl6qC4FRL7yMHSFy+fqcBsMbY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rPU81/k/kmVMIV39uRFIgPaEBEJ60oPyFCnDx7/bgThjEu/AzsTqRBYvS7C/GnhdVAiCkC9gnpGPv2uAKJcdNwb5Us+Gwfh/vDtRBER9HYaQeqVIQf75r+GKmRo4YQaPCCGstJg3b371ZMG0vI1xx8UFvZk2Ldr8Rqkwah8hPc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PECYl8Ri; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PECYl8Ri" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-4375d4fb4d4so1030814f8f.0 for ; Thu, 19 Feb 2026 18:26:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771554407; x=1772159207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i143R6oTYaMRVTgVRJMuG7Fi9AjA6YkMNWJRTVzxJWI=; b=PECYl8Rikqto7qEcVCr6yXDV3BImRnqwIP+rfe9D7we+s+gnGwvqHG9OXgmqpKMiMe 5gK5QZYRlNnSQjJPy3CUOEOyLJYQWV+f4HNdWNd0O0p9vGv/7/ybOXsWkDWXyT6i9Pqg OSDqyFsF5Vkekc5tZJ70xR5bZR8nllnhRAUQj/uboyittZKUWwDZGO7EGhtM3hR/K/bo xSmoFopQ4Mp1K2uGI5RVf8z3E79ZcD0PTc00hJv5ynJGoNFHgxqoxpL3WG0f+kxXo8mj RX6r+y6uNsk3qksu4g+/cBFJsOtzVtdNE4zH4nOsPg/Q+9kVRfGrPAPfSPvO4JStUMk3 cmwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771554407; x=1772159207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i143R6oTYaMRVTgVRJMuG7Fi9AjA6YkMNWJRTVzxJWI=; b=Ag190MtyFLQkxAtn3FCbzBguGKNneqYWFEV5/FwU2GghyFbBtAn1qKnoWZg09cArGm Ux4Q1akCB+PKKhGGjVxDwPwbphngXYDPT8kPBMskrbdIRb3aBERW50AIbkTQDFSDBKR9 bTWQRptgKsDJkslQtjRM/rnyaZUge/wtAOf4kv2i8HezHjUfJ+02Vlv80YDHa44ClVU2 Gmd8nMuvWd9IEJ4nDriHsQOH2v80kw8pCx64DGKgnEUvUXtgukieBf9EjjP+WzBJp0Sd Mm25Y4NH2mr1q0LfxZmuRZqWyl3A00HImwBmpv84uRBPhw506OnhUEF+AHLdgftfili7 B5Fg== X-Forwarded-Encrypted: i=1; AJvYcCWuY84w9ESmZ8oOjy4KIdKtdi2S+Uv6VDQoHEG14NuwjotRwv+RJGuotpjV/dvtskOh+MSY9IsSzhJN0cs=@vger.kernel.org X-Gm-Message-State: AOJu0YyHuLDqygXNLPhRzSotYSOQF3vf6FFLjBLyLN301ns7UPpbosqQ F74id4Mxdb1xu8rjbfvzpq0cl7RsSBtQeevLRXIPhFWiHNoTness5xXV X-Gm-Gg: AZuq6aL3fKVPpKf48PpKf25R4VuKRgyWQd1A8k3fvzJsryt8Zy5/mlA4f+yEicO+IpT dRWixH6osQ5UK0Ae/YYowE2O5vGvS13ANJMurgVdGJTX0N0Q5o4tcOPOOcQfjyvd14Zm/9F2rYP UDtt19R31ftfxoTV4iAsCYSL2cV4ZG51A4laxAz6teEXasy6Zc/LbZ1oPE2A8XJMjusea4Vvbcf 47yAngOkr2QbRfo8aC2ny7VL53KM80MEaHBDiJwiUMWXq0aAy//4xralk4tGIEJVyUEexccVteD WCFt7yO/jbrJvg1UuxZ8HebkSnf5tjKO1r3CqTBSc8Q32Stv6E2VmPhdVDwi00+yfnFzNlIeHRm QwNNkH6+9brapaCqA84FMRXqwPImG8HFcm4FTK6GfDG3KJj90RK7HRFLGBzXUI8ASp4gSN73ZNm K7WfqHQbErqxbYqj/ifY6XE1uOBXOfWFOCGbTRygl3TOoQF1gcrVREYxHN0uGc48imkBkj X-Received: by 2002:a05:6000:22c9:b0:437:707e:9f57 with SMTP id ffacd0b85a97d-43958d55f30mr12299521f8f.0.1771554407038; Thu, 19 Feb 2026 18:26:47 -0800 (PST) Received: from Arch-Spectre.dur.ac.uk ([129.234.0.168]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ad0166sm53446975f8f.35.2026.02.19.18.26.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 18:26:46 -0800 (PST) From: Yicong Hui To: christian.koenig@amd.com, michel.daenzer@mailbox.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, david.hunter.linux@gmail.com, Yicong Hui Subject: [RFC PATCH v2 3/3] drm/syncobj/doc: Remove starter task from todo list Date: Fri, 20 Feb 2026 02:26:28 +0000 Message-ID: <20260220022631.2205037-4-yiconghui@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260220022631.2205037-1-yiconghui@gmail.com> References: <20260220022631.2205037-1-yiconghui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Remove the starter task for adding a way to query syncobjs error codes through an ioctl. Signed-off-by: Yicong Hui --- Documentation/gpu/todo.rst | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 520da44a04a6..8dcb1901142e 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -878,22 +878,6 @@ Contact: Javier Martinez Canillas =20 Level: Advanced =20 -Querying errors from drm_syncobj -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D - -The drm_syncobj container can be used by driver independent code to signal -complection of submission. - -One minor feature still missing is a generic DRM IOCTL to query the error -status of binary and timeline drm_syncobj. - -This should probably be improved by implementing the necessary kernel inte= rface -and adding support for that in the userspace stack. - -Contact: Christian K=C3=B6nig - -Level: Starter - DRM GPU Scheduler =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.53.0