From nobody Sun Apr 5 13:23:58 2026 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1096F278779 for ; Fri, 20 Feb 2026 02:20:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554012; cv=none; b=EEyWx86ihvpPxapgFaXJZBH0HjqhU3MccgW/w5Jsdsz4+/ozVE61KfvdXeZcmgsd3NFkTfOdhW7cvlfQhABhk7dvbtxOCBYSv/i5poYk+JC7Ev0weJ2/jWpz2VBEp58g1y3Tv2BKdR2UFd1so1LnB0lJYAU1KU1FURmKlSwQpSE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554012; c=relaxed/simple; bh=rZiuIMhkMsKmv6L4yKMkGETytLUnkf9qArtZhO/vcSk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lJmgC7sJokVBYzfsHi3Ox/j/u4sQ7Ku8RfN+Hx/mf7iesuRQKJQmxcvmj6ZWIB22Nq3bCVpgYrY4dWmJAPl3ZplkCg2TE8atZNGl3xhFDJLiZKX4INjRl0o7NkzmGv+cUg2X/2dwIzeLqVfrpgemRex4NdcGBU2mId0n45R/v+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MKJhS24i; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MKJhS24i" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-794719afcd4so16277507b3.1 for ; Thu, 19 Feb 2026 18:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771554010; x=1772158810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4POBYQSP3NtQUs6h8lOqxUK4xnDwwBeCf4pQ96aVpUs=; b=MKJhS24ipmDlmm49D1/LiNxN07xlcuCvU1yXRI5e3fzTE4KnH8z7ZeUXCRAYGLraxB hXwuNnSTY2YUVY65ucR+z/QocS5Qon1sVGoP7Uk/mLk9FWgwwp96PmsmTwuCUW+T8J8v GQNxjLImvSj6ZNhi+o3NsFCt7zTMazoptEQ9N0dHKPrmvwYd2tcfwMjZoyIloQ3OP+yV 4GHYxEmHF5KGbQoQFUAgynoOuvPjqH+fX0qcv+jhHGO+OBzQOlwezaqDXMyaIu/FiQeu HH90avG+JwBqJnenzOBs/d1wUbuNZcLr9FG6NXmX/6RD+vMVyiztyjog6SYfXnIpTGo3 Sb3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771554010; x=1772158810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4POBYQSP3NtQUs6h8lOqxUK4xnDwwBeCf4pQ96aVpUs=; b=ggEFWM5ZYS4dQw8gsH3v2a7tLkN+Hb1dID2q4m9iXsM6IMSMSy6vohcVRNVOxj6vac GikvCJgkviUgjyt174KX/3P+WKB/s2qoExhqarOD+/KYIwnZPQhbcVHOb2oPtMR/3sO3 E9dGVvxfgBBp990GLffEMrYk1srzHAAJ7P0wQZnwk1n4MHBMD8OePNapozISHbzOIngL fSrCQGznDL338R5Fqb5YBko4cL//xfpZLx2AKuwL8k/LPCGtj4fs38IZOoNcUPnD/AIW +PM2Q95BscUmX4f3nW+qtIclBfbl++oOc5V1K2uOO9NH3mKsjHXyD/+EP+3nV0CgiNQo DT1w== X-Forwarded-Encrypted: i=1; AJvYcCWZBhskv6ythtLEbP1oHQY8JL6I7+AVZvBo+IRKMQ2+PxfaNFP3p1CU6pN/zreFpLAjqKHX+sTQfay8dk0=@vger.kernel.org X-Gm-Message-State: AOJu0Ywo+zRmJXj7zc6Uag7VODwuH8pxTZwdOJE3DTYqOFFMYGu0LE82 pOxR0MULg+9kJ3rgahdRpea8ApuyTLmw0VNpG88DU/RVbIhPz2DqXLgp X-Gm-Gg: AZuq6aKs0uJRB/X1NMQLWMe1r90mBU1gfR2dn0FMd8bfpF2URry1cpEqnOIH9GDpaQm c3RSgMZmk2kAftSpkEPvhBahGfC03LEwujfmwrv3YgV5MBam7GRDWIpZLM5kqKKvC5rostthYP6 ovTsH6Sd1/W/eyse0gt/ROx/BCdEZ4KtlRdv8tfeLq7vDL9amK+xIYvJapE5clTkLD0DVTyF4zS SPbrNgr/fBkjL7W1mn2nEcgNnyQAtjhKh685MybpFo5a7Nd4zjiiQRTfuEgm7IMPcZuXWNZ5zH3 3+O+On9FPRj0Q71MGVOXmJnTZIDNR1qbvlSzyFPZKjFnaZLnjgkGdLjLeNyHUeXk8Y3T5jyxd7l cEVXpwiy17Hp0q0CnJpYBcn73lZGa5BX1gDgrqr4YvDOeU727tsDRp0kAAfUjii5Q1Ivc X-Received: by 2002:a05:690c:4a02:b0:796:6d46:8f8d with SMTP id 00721157ae682-7981cdeb482mr444877b3.41.1771554009873; Thu, 19 Feb 2026 18:20:09 -0800 (PST) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-797d142c2dbsm45550347b3.47.2026.02.19.18.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 18:20:09 -0800 (PST) From: Rosen Penev To: netdev@vger.kernel.org Cc: Hans Ulli Kroll , Linus Walleij , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org (moderated list:ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 1/2] net: ethernet: cortina: use devm to enable clocks Date: Thu, 19 Feb 2026 18:19:48 -0800 Message-ID: <20260220021949.40817-2-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260220021949.40817-1-rosenp@gmail.com> References: <20260220021949.40817-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Avoid manually disabling them. devm can handle this. Signed-off-by: Rosen Penev Reviewed-by: Linus Walleij --- drivers/net/ethernet/cortina/gemini.c | 23 +++++------------------ 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/c= ortina/gemini.c index a55f4b82d1ba..8726e5ffbce7 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -2348,7 +2348,6 @@ static void gemini_port_remove(struct gemini_ethernet= _port *port) phy_disconnect(port->netdev->phydev); unregister_netdev(port->netdev); } - clk_disable_unprepare(port->pclk); geth_cleanup_freeq(port->geth); } =20 @@ -2475,14 +2474,11 @@ static int gemini_ethernet_port_probe(struct platfo= rm_device *pdev) port->irq =3D irq; =20 /* Clock the port */ - port->pclk =3D devm_clk_get(dev, "PCLK"); + port->pclk =3D devm_clk_get_enabled(dev, "PCLK"); if (IS_ERR(port->pclk)) { dev_err(dev, "no PCLK\n"); return PTR_ERR(port->pclk); } - ret =3D clk_prepare_enable(port->pclk); - if (ret) - return ret; =20 /* Maybe there is a nice ethernet address we should use */ gemini_port_save_mac_addr(port); @@ -2491,8 +2487,7 @@ static int gemini_ethernet_port_probe(struct platform= _device *pdev) port->reset =3D devm_reset_control_get_exclusive(dev, NULL); if (IS_ERR(port->reset)) { dev_err(dev, "no reset\n"); - ret =3D PTR_ERR(port->reset); - goto unprepare; + return PTR_ERR(port->reset); } reset_control_reset(port->reset); usleep_range(100, 500); @@ -2554,24 +2549,16 @@ static int gemini_ethernet_port_probe(struct platfo= rm_device *pdev) port_names[port->id], port); if (ret) - goto unprepare; + return ret; =20 ret =3D gmac_setup_phy(netdev); if (ret) { netdev_err(netdev, "PHY init failed\n"); - goto unprepare; + return ret; } =20 - ret =3D register_netdev(netdev); - if (ret) - goto unprepare; - - return 0; - -unprepare: - clk_disable_unprepare(port->pclk); - return ret; + return register_netdev(netdev); } =20 static void gemini_ethernet_port_remove(struct platform_device *pdev) --=20 2.53.0 From nobody Sun Apr 5 13:23:58 2026 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB57C2C029C for ; Fri, 20 Feb 2026 02:20:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554013; cv=none; b=joJft7sARapyLlm6FWROdlfw4+TxMfUKvocxvKBtPWvpusMz4HOgdkhumn/xpRhyIAbv+cz4+YsLMOY8F0VaHoTskzTT/0E3MSxWfV9jVvfyWLXjSHMpz+P+ZXoeNyxzE/1dlLUV7sHdjgSvz7LY3akAGGAPnhc+QZsZPohN6rI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771554013; c=relaxed/simple; bh=hWgcS6hW5BnKXv4iu4HmBnm+2LB33SX/iNSBf6jMyew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CBMZgrV1/v0/dUYkRZa7JzqMIfBC9aHdJv+0GMOYMYNrNEkCrhK4S28ulm0TCQZLr8tPG5tLXoFF0hcEWlPPf0ID5eULXNK9rnFMAs+C+NVqBtIKs8l8TeoAVtJd1hH0dj2YHW76yIRPBGoGVPpG8N28HMvCaFxBk5fdWjd0DYc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZmGGFKtV; arc=none smtp.client-ip=209.85.128.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZmGGFKtV" Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-794911acb04so16609067b3.0 for ; Thu, 19 Feb 2026 18:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771554011; x=1772158811; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6RaV8hw3AXOrpstqaeQMdx39+aahmt7LDfsKU5eK6HU=; b=ZmGGFKtVRMXDH7xtK3EansrrcpwesZRVh4YCk7id9V5hwpMCOmj3hOvdToNIjIIiPS /IQra1kJ3K9qiR5VvD2s2LdpeajQFqsUy0nKQWMTAmDtoS9IGP3uQ7i5kXf9mOrgdaH/ FD/siNkLCXz4zn3dbr3ck9PYBYnqFxy1Fehu62xLc+e7kVUnM4+NxyI3PYeGTjmKmduk YMSWZIzHimmk8LJ0z25gJbKQ7BM9WjD28E6aVXTz/6QFg0O1jiMJ7u+eEJU2BJc/KzLH 4cJ4ayAnFxUhpp7Yv5de34EUI62HlkQ3gcTYYi3IaHxfYoujQgi0nftVgJDQ+Sgv6Oc9 68zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771554011; x=1772158811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6RaV8hw3AXOrpstqaeQMdx39+aahmt7LDfsKU5eK6HU=; b=MtB+CV0Xk0mNTlEZ3d4LyTQl+C1rQBWEFCls16mcMTLSOvZaN0RydGdtew1trrzBzB Ni3jBZR7uUG+bTO2ItmNV7PP3VB9bgqDeS7rJ/hr6mTkxeQzt4tOSwHQIZyPazfHXJRI fOGwSxgqOa0BjRjyCwO4smJrS92CPAgcYtysG2T53V9MVR0nVzKdZhRRIOs9f6sWnbrH /5EyKCUwEcj4zuRDXvnrcRkplCiZLt8phQSIuLrSHb5tUm8Hu1rmvykTqsNS/3W94teg ZAQDxYqVoNVICvdjZ39MQtcLv360ZAV5TpRlFcuwNyEe2xr/ciMXvgzCs6i+fc0vBsFr vaKw== X-Forwarded-Encrypted: i=1; AJvYcCUkwVFk403rE9mBBbgTfKHpNjeYVLRbdQ+muJQYzmcwzKBOZHuEWIv9myM3/FhxIyK3NASl/fUul/IezN0=@vger.kernel.org X-Gm-Message-State: AOJu0YyRCOX3fBVxtNZMmUkG9M8cXwvk9wrUBlnIx/idBMJ6lL9WTWlb o05mz3VcIQ/kMoO6pb5GR52E9A73Nva/LJNnBUf/nIju/Qs7B4j7jUUQ X-Gm-Gg: AZuq6aLN+4cSG4eUiHSDRY35PrTwqD8EWF3Vvhq3/8KWHop8LzW9SAIdq4VZW/JGltJ KNqbudQXZo3BLq7ptUpQyHc0PInudwUFrLjdX7z6ebNj9oSz29k4D3AX0vor+KrVnr3mC0OeaTt If3HrOKXX1+8A58+gk40WaQmaJIYT3rw//ZOLw1jZm+sFm5rxRbNDEp+N/z9fXrLs1HQwlc10aG 6Thz8Kqm7w2G2PiMRdJsPn8uUBY3Xt1HXMivGdkGPdVlZPPFspbaTW6H84xTjG8ebP9i6QfVtqV BZIMifjNotOFXLcdxW5EhMeXyIFoM8D8uiUq0yivUj9oncGzhMvcEwsdlBYRGTI21mLYdkWism3 49MQgkMUcaJ+JEA09fOpQMJQriH4BVrZD9XQ2AF+7mN9gurbfDMKXrb42eH38PuFYZhM8 X-Received: by 2002:a05:690c:802:b0:796:2fde:5df5 with SMTP id 00721157ae682-797ac5ce756mr105281867b3.32.1771554011568; Thu, 19 Feb 2026 18:20:11 -0800 (PST) Received: from ryzen ([2601:644:8000:56f5::8bd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-797d142c2dbsm45550347b3.47.2026.02.19.18.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 18:20:11 -0800 (PST) From: Rosen Penev To: netdev@vger.kernel.org Cc: Hans Ulli Kroll , Linus Walleij , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-arm-kernel@lists.infradead.org (moderated list:ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net-next 2/2] net: ethernet: cortina: fix nvmem mac addresses Date: Thu, 19 Feb 2026 18:19:49 -0800 Message-ID: <20260220021949.40817-3-rosenp@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260220021949.40817-1-rosenp@gmail.com> References: <20260220021949.40817-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_get_mac_address can return EPROBE_DEFER in case an nvmem driver needs to be loaded. Handle to allow nvmem mac address overrides. Signed-off-by: Rosen Penev Reviewed-by: Linus Walleij --- drivers/net/ethernet/cortina/gemini.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/c= ortina/gemini.c index 8726e5ffbce7..4225676662c8 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -2525,6 +2525,8 @@ static int gemini_ethernet_port_probe(struct platform= _device *pdev) netif_napi_add(netdev, &port->napi, gmac_napi_poll); =20 ret =3D of_get_mac_address(np, mac); + if (ret =3D=3D -EPROBE_DEFER) + return ret; if (!ret) { dev_info(dev, "Setting macaddr from DT %pM\n", mac); memcpy(port->mac_addr, mac, ETH_ALEN); --=20 2.53.0