From nobody Sun Apr 5 16:33:03 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 954A134D91F for ; Fri, 20 Feb 2026 15:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771599894; cv=none; b=gZm+LG5eB1avEXjR3R4fdHF3JYQCIZpSjMe9uQmculnNZjjDo5i4wWO4e+BWZGbl49bDYoz2bUBv6qKhlQ/A6cbYDitp8QtTSyT4+FlfVkgDBGu7AYA54/pXLapbVdCn483qboOd+VIM/j2JTXe1ig/7vI/31TJONIkoYP64kDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771599894; c=relaxed/simple; bh=LSJ6iVt1fKqUBE+D4hO2jHttM0Mg6l5uyfncK8nFUsY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gZxasjUF1Ev74jrzruA98Ef2beMnyIZkxHdwzJ8/K0uhDVAWMqY/FR+JRv1Z5xIZaPQtYydT+vOboVmyNWDm22wRWBSk4diEtVLD5N+p8RMSiIBTD+WixQVtdRKPtihCpTid1CahQ6pz5vFoAMeAXRaj4Xs1+LMN2dmov50P9Tg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=vaY3bOWv; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vaY3bOWv" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48329eb96a7so13081695e9.3 for ; Fri, 20 Feb 2026 07:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1771599890; x=1772204690; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rodd3MUSh6tvMD3m/O9jejBF/2t7v6lgidsmMLGv4EQ=; b=vaY3bOWvB8wfenM1n/uiGN6jYBQB+v/2Vw6aUutuHsP7o2gnVdyCgbUjaxVDA/AqN1 THOf8YafjiuZhxotDgo9THQPaW76zX3xcOK5MTCIIppuz3HTWqJ2L2649vVSJdX8rgQZ wW6LyTMcwhqZriR+JvKxktSAqZOHWi1JplGh5NXIr3HuWBBVoWOhhr3abXznBbvzRpsZ 2IhFu7NGsXtaabNy8w7eYDDPa3E+hdYgVKQsYfX5AMo2yriKQpx+L8VfVEiZSsDvamtU abIDs+wmE9Mp/ljWp8djG0S8qFcFeg4b76en8cOL0IAkf+bnsbm5NRR0OlOQwP8P78Z6 Kp7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771599890; x=1772204690; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rodd3MUSh6tvMD3m/O9jejBF/2t7v6lgidsmMLGv4EQ=; b=ado8lARgHqEpV4d5GxgXCsfnF1aTznLcc6E0DvjlzXMJNgyEIBZEfdS8Fqg096qoPT pByn8PKAgt3LMY4V8ohQHApoI4kqKokC2aLjLA2Q/WweR+2pJD+i/BJkhZVkNy9oS4iT jKZn35jsiWXgYDv8JeMr0S7bc+kT91WDunEgRwBrPfH+tDjgYng6gKfWnjKS/2uWefmW Kp8GyAcFoE5COukckBHS28x6UZXf/MBBfK3yw+To1E5v5IzlOvXiNwKzdQjBCWsV28Av t3I6k96FNkm6Xw7kruWjxgbUUA8hXm8SQgVisJGf/WjfPKnwGudH+METs9E0vh9Fma9O Ju9g== X-Forwarded-Encrypted: i=1; AJvYcCV9bfC3QlmdphvbDArrZPYvDbkUPbwlftg8QlC0efF7fSZKBmaekuoSV7T6vQUwjlQ7TmhFxwgQZzgE8ew=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl8g7TikrxB2DDBMuHTmo6geSDcJWIpf/17mpd57+ZXyDkqCZY gJJZVvf/IUsmIEyUroItmGslLT8q6+6dk/OWbJ2zqZKOFogrUPQFEsFvU9zYdBRIo50= X-Gm-Gg: AZuq6aL2sYIMLQZeqT/Nq8Z4Qt75TwM3tl7OptDvB0qavsr9WNjHavg4I/BkZInYRMn yyAhLUE2FfiMp/cFqsp0u5mPWmQchkie9I2QnhIG39g8Ga70HnqBGWxAWuxBxVS0wIzLEJUDHk5 N/NAqDNzwi1Xe/pl5sciwKC4zSvJxSytppoEnE4snCZaxIhe0REx9WttoaSpDhuy5QJDjHzGCWH GOKZmYA/TIn25Ei80ut0GMvwhIeFibyPzlIlwf/Jrel9ziNjq53Yp1SClYgPhK55pAPWtc+LUML qQlYh5qhLmsvAH5PsBxrYBbBaU+g/UAz38+/WyIFmVXB/NXomvDnlMMC2AfBl5hNMnModFhdJCG s8ny9dNqpI6CJtYgm/oax9n7YiRIjswov3ctsy9so5WB7Zd5dVPJtOIHH4hkfRxkYoxV6E1ojQz 0Xr6LCOdlcVjfQ1PgWZTp/9e/Fm3mRoRhgyQvcb1hAiQJ7 X-Received: by 2002:a05:600c:1e24:b0:483:a21:774c with SMTP id 5b1f17b1804b1-4839e668a55mr114317005e9.25.1771599890008; Fri, 20 Feb 2026 07:04:50 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:106d:1080:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483a31c56d8sm122064505e9.8.2026.02.20.07.04.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Feb 2026 07:04:49 -0800 (PST) From: Neil Armstrong Date: Fri, 20 Feb 2026 16:04:41 +0100 Subject: [PATCH v5 2/9] pci: pwrctrl: slot: fix dev_err_probe() usage Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260220-topic-sm8650-ayaneo-pocket-s2-base-v5-2-1ad79caa1efa@linaro.org> References: <20260220-topic-sm8650-ayaneo-pocket-s2-base-v5-0-1ad79caa1efa@linaro.org> In-Reply-To: <20260220-topic-sm8650-ayaneo-pocket-s2-base-v5-0-1ad79caa1efa@linaro.org> To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Bartosz Golaszewski , Manivannan Sadhasivam , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, Neil Armstrong , Bartosz Golaszewski X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1313; i=neil.armstrong@linaro.org; h=from:subject:message-id; bh=LSJ6iVt1fKqUBE+D4hO2jHttM0Mg6l5uyfncK8nFUsY=; b=owEBbQKS/ZANAwAKAXfc29rIyEnRAcsmYgBpmHgLvAqgpyS3WqEtzwpidrWJupURRMxHHCbYRiCH s2cHeQGJAjMEAAEKAB0WIQQ9U8YmyFYF/h30LIt33NvayMhJ0QUCaZh4CwAKCRB33NvayMhJ0VnvD/ 9JxYCAzcI+M+RYnaW+fQ5gm0DcADfB4wSW/ncXdOTNzw9LTvMkqbhtK/7qp6IsesiNZUWpif2ZiEH2 sD0fr3RdWo6TI9uUGAsICG/mc+tHB7Gh/cp1PxprLrUhMhp3pXVcTkDF3qoZkDmK4TYEzV4I75VKci N+/dXI4qgpOF5T3LMvCbX7fREmTfv/rF/f3D7UrEYqaH36oer49SaEoylq0qVPnwCZzeTLjKhyP6RW yoYjWDKEeSF/Kf6uM2K7SAFwio4KNXa+3GI2q+d4IhFk8rG2lrVaka4OGbCRFrUZQ5X4STcq55P+4v gHB7ieWqafW4DQ4wd7vQT/sJvSuWk9CnYjEYcCsgR0rb9jVh5ThwVQJrERNkmOGOxwzP7hssqBqDAE r3i252QykXNG2nMtKhk0+4LbIecm+vxLaccSD00waLDeeoIlN/avkIvJpnQdL1pkzyKySq6UEQqrrk SmQYoxPeSo7mVZrSdUS88t2HudZGcHtvmL/+LMXiNExUbtecw/na81wuyhIhgCwrwfoMXED+NzNUa7 FSnOdRPJCjd51v5reoU6dOzC2aUDV5KFeVM8EGvMeiA6B6M+6LM79Wt0/iIfEwRlHtiwfZ+occGxe2 E09RHwUZpi8mZQ4Ju4EpL/GnLuHGdrlZFz8FyiXUabhd06ixIwXQeLHQs5yQ== X-Developer-Key: i=neil.armstrong@linaro.org; a=openpgp; fpr=89EC3D058446217450F22848169AB7B1A4CFF8AE The code was not returning dev_err_probe() but dev_err_probe() returns the error code, so simplify the code. Suggested-by: Bartosz Golaszewski Reviewed-by: Bartosz Golaszewski Reviewed-by: Manivannan Sadhasivam Signed-off-by: Neil Armstrong --- drivers/pci/pwrctrl/slot.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/pci/pwrctrl/slot.c b/drivers/pci/pwrctrl/slot.c index 082af81efe25..f03debabbc73 100644 --- a/drivers/pci/pwrctrl/slot.c +++ b/drivers/pci/pwrctrl/slot.c @@ -88,18 +88,15 @@ static int slot_pwrctrl_probe(struct platform_device *p= dev) =20 ret =3D of_regulator_bulk_get_all(dev, dev_of_node(dev), &slot->supplies); - if (ret < 0) { - dev_err_probe(dev, ret, "Failed to get slot regulators\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Failed to get slot regulators\n"); =20 slot->num_supplies =3D ret; =20 slot->clk =3D devm_clk_get_optional(dev, NULL); - if (IS_ERR(slot->clk)) { + if (IS_ERR(slot->clk)) return dev_err_probe(dev, PTR_ERR(slot->clk), "Failed to enable slot clock\n"); - } =20 skip_resources: slot->pwrctrl.power_on =3D slot_pwrctrl_power_on; --=20 2.34.1