From nobody Sun Apr 5 13:12:01 2026 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 807B532ABC3 for ; Thu, 19 Feb 2026 22:44:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771541086; cv=none; b=mQW3+oNS4GCOUsPfRmeLelrNxTxOjQN9//0aAO59yFvSSc2+HSGZnZebIxDyca0gIjLi2O78dQVEOqgSPvfVTHVxkrOjmQ33oXRSvSx5GnyPoxk/L7jARLxnUkRo6Yi1Urql559R+iFtNUZDJ+pp7PYNbt1CymRV2Oif0XaRrKg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771541086; c=relaxed/simple; bh=g7J6hdsYFCZHzem7+YfLRfFGfCdn64QO1bk2fFbvdRU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=USK/eiBldgLXRc+PHTIZwBEY/+TSwEmevMIPgCzQYu4X9XJQLex5pa0IfY5ZRMqImr/hQSzZIdL1vlktg4UkwglN3w2fkUTwp8/RtWilm2fZMcGmZkR1y6woa4HWRG0ClCyMO81G9rbYXcWbaE7eo9JZWrQieeGzwOLyb2QgdB4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nGxKXHvq; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nGxKXHvq" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-649dbff9727so1595334d50.3 for ; Thu, 19 Feb 2026 14:44:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771541084; x=1772145884; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pH/3gnQr87FHbNqJn52DgWvIFWAoFRDTMQB92zG80ZM=; b=nGxKXHvqSa4sIyh9X6hYCNhnEfe5r1tcUhG5jCkYSXGs4Sw/DtMJEc14/NXrXTwwuN 6QjmtzeKg9zuGnaSK35vscLW2vHsHfbh4PieZbHkYJUNr4WB8DNx3aJsWBSbv0nHCbfJ 7swKnqG5VKNMhsmBoVH0hTUuDtb1DtvbkWSggcxALHghVXaDMw9pheuIH2vEaVcoDSsu GPqtYWFoEb0M8YyDvB2y5tId0fuGEmw9LpiShb1dooCkwKqi1cDEvzD1jCmaEVKK91HH Pc05wlIRAPatPHZpHTG79nNOdHaLbQdRgSjxI/rRDIuj9RZ86i0f6cNF4v4okt3A2di7 xCvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771541084; x=1772145884; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pH/3gnQr87FHbNqJn52DgWvIFWAoFRDTMQB92zG80ZM=; b=VW9ingHDcbZ3tbRDpUd8FULVOLaHFZ2Nf8Q8UydUwC2OipVZE/wMjjzHyqeHSsSP9R GFzHrM1i+bxmp0PQ4zJAi9l4+rhwudDXFcWMGIYzfpZyOeBgMeZYpXPAM8cXnPNkaG79 kJsrL+qAkioOGH39aP7YEC3g39qjY2AAivUroZtsYrkkfwPX9nsAxDWlkQ/HzwrCHMbP jVKEXwNAeLHzlV8NOd8Del6hunZTyB7Eih2tCUCkN4qBamOwvFFEr4QB9dzJ0M72bXgj lrtlHd9HjriPgKlY7WnoQOjlegk5ypLrfTyrlYh9XbiR80vcTxBfXa4hmkSf+y1mOsGi UO4w== X-Forwarded-Encrypted: i=1; AJvYcCVqvHPL4lG+s/IiS1PyUVDB6q+a3TtjUjf11jwKJAiYGKmBnpfXRCVqp+6YaTaK6QrS7jevrs3ADauioec=@vger.kernel.org X-Gm-Message-State: AOJu0YzZPrj0KHfo29+D5+dNtv6KWr7al38uziWSUBe6eK0vv3ygHd/a hCa0rHY/oLHG9OUDZeWOG5D0O9ErbTVuhzEkRd1lowGXiL2T4ZvgEDc/ X-Gm-Gg: AZuq6aKa3G440RESh06pb2M9+JYXVbZc8IRGmY6gt5a6pdV34eJhBlfw3MxtjqoD7Ek umGEoEAnkQCpvpJ1UIu+L9svBStCa0U0etQk/QbYME/c5AGPFoPiLEaLcbnJRQfU4awJrENpmBs 5dIj92ea+btsstOk4atMmEUJO5o/fhTlvQXCGWtzt0c3Vn1jG1dfvIGLAwX5gsUU1+l0F37q3de fAQ6UP327DLkfOioJVjv8qBsss2z4DJxqhgY4nYmuM8CDxkYW7UHl7B+81v6xbgv13eHiV2BLuV ntcnlo7Wh//WSSqX4NmQCRMCwoB6IkxILx78dFttgN8ZnyM5tucVlaCHS9u8KtKz3t0hlLLfmhn N75C3lCyZoMazG8r6DOWLnFiY268y5FKCR3houmI//cz1fijhHn+U1gvrbXL1hnHw3dqxZd3pYh IBvH1TFYMrgjGaTNyK8pJyP20CKMtlZQhafTKSUBcC1ktlVl3+146XjQA2CugO8hakivzSfRqqW NKpL5oPEGhshYQrGaEiSg2SmvwW66+8Elq1J0/pSmo= X-Received: by 2002:a05:690e:1281:b0:64a:e61f:a6f7 with SMTP id 956f58d0204a3-64c21b599a4mr13503566d50.71.1771541084386; Thu, 19 Feb 2026 14:44:44 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-64c22fb1d22sm7453050d50.17.2026.02.19.14.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 14:44:44 -0800 (PST) From: Ethan Tidmore To: Anitha Chrisanthus , Edmund Dea , David Airlie , Simona Vetter Cc: Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] drm/kmb: Fix error pointer dereference Date: Thu, 19 Feb 2026 16:44:26 -0600 Message-ID: <20260219224426.1122073-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function kmb_dsi_init() can return an error pointer and is checked for it, and once confirm here in this code block below, goes to the label err_free1: kmb->kmb_dsi =3D kmb_dsi_init(dsi_pdev); if (IS_ERR(kmb->kmb_dsi)) { drm_err(&kmb->drm, "failed to initialize DSI\n"); ret =3D PTR_ERR(kmb->kmb_dsi); goto err_free1; } At the label itself it dereferences the confirmed error pointer. err_free1: dev_set_drvdata(dev, NULL); kmb_dsi_host_unregister(kmb->kmb_dsi); return ret; } Add check for error pointer before running kmb_dsi_host_unregister(). Fixes: 7f7b96a8a0a18 ("drm/kmb: Add support for KeemBay Display") Signed-off-by: Ethan Tidmore --- drivers/gpu/drm/kmb/kmb_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/kmb/kmb_drv.c b/drivers/gpu/drm/kmb/kmb_drv.c index 7c2eb1152fc2..9eabbce7574f 100644 --- a/drivers/gpu/drm/kmb/kmb_drv.c +++ b/drivers/gpu/drm/kmb/kmb_drv.c @@ -576,7 +576,8 @@ static int kmb_probe(struct platform_device *pdev) drm_mode_config_cleanup(&kmb->drm); err_free1: dev_set_drvdata(dev, NULL); - kmb_dsi_host_unregister(kmb->kmb_dsi); + if (!IS_ERR(kmb->kmb_dsi)) + kmb_dsi_host_unregister(kmb->kmb_dsi); =20 return ret; } --=20 2.53.0