From nobody Fri Apr 3 09:52:01 2026 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A46861DE3B5 for ; Thu, 19 Feb 2026 22:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771539029; cv=none; b=XKWa2C/xTuLkhxaNJjthxsOatEZzfwD+Ov4WA9fQJih9BxLz/AZbuHNwAfO3oGLQP2PWAEGUwHUlDYCMsTj4VHx6zKzPGiXNxvY7vZfBV89hJzRoxEJUfwhbf/ix45pjPyuAoRPdQroJhIi5T9WAkprWVakTTDosrwQKLPowzME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771539029; c=relaxed/simple; bh=hUW9m+r47rZ6vHviD7NNPFmBgbzY8tzfEH7senHJ5Kg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oD+bKrAbB2Xy6VhJzUX4GyypvqsXq064/kjLwreqNjXRIcdyxBALOo6xFfyf71zOfacqkC6Zh9NTiXDKDCiUC8v3gAFvDLR95mzOF5MxRFSf2WIJbXz6oW1Ky4QqG/j+lu+qZWlQHgeKgjCpZY99+kzpRK/ZeLPzJM7vb/64kt0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DK/Vvi2/; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DK/Vvi2/" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-797d6f934e2so14812607b3.0 for ; Thu, 19 Feb 2026 14:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771539027; x=1772143827; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=o802JVQtq+NP8/p4O20P5wd73rV8MTWnZYjcAz5Bn64=; b=DK/Vvi2/95Vf0foIq9adn+3DuAb7LiOS4K/Oxkv9bsamk7/zs8quzPvyI6SpneC1AD v+wy34bU7uHvk1kBuXLK/7mXci4iTrYxU1j72CKNuFSmgciXC/BSwU3DzMrar7v/tJ5M RWXKpLsMD4GlatEmX+ub5F73TwduJ/rHwqz13fny70D5BpZC/u/WXOosMFwAyGEcYr9U HbU6aLMBCPerJT40tvXRgTy6TtYd9L2LUKyjpadBzE2LXwlxtiWwawKEsB5XxklS1sGa QrUw9CiqYRLyDI2TBj96+K1Na69bNpx7y69l+O8y0QfadeDk/rfEkCtlSWDbY2DzDeA+ Wm8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771539027; x=1772143827; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o802JVQtq+NP8/p4O20P5wd73rV8MTWnZYjcAz5Bn64=; b=lCR/Ccevnt+69GvmG67HrNC+ZjV4j5lZpCIZIIDEBSpjHE/U6zPfmQpyzkNBrAFQiM QabZgkddI64aCIQ2Uwikq33h7ggtWGNNBoRgMrtUUXFTLlPYAWrAImpEH4Y5WX8bWVCX x2au/7hvkLgQoUjZtqYwmKAcqOvqD6OBlganY9ynw1hpcUpmL0iHErh33cg65PBdwAX1 ia45ZdhhnzRQ7xKYpLzG1P/ssDWkT2JGJSg9EEnxAD1yj7El5yhzBJYbaJ0Pna31ro00 FXkmHGKMtFXyuobtigRLhtR2my9sseN5nKm0hfTN7t0rA6j/uV/LV3xoqd/ipzaRy30j M8LA== X-Forwarded-Encrypted: i=1; AJvYcCUw7FRlxm+Fzgls0HFb0F+BsBx/lVbaCuiYGZk2gFoLPTsaFJqo+j6eTZT/MMTL9AZAdH76M5HSgVoyNiY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxj0ZtRaOjZumdKnWhsDl6/XH7j76df+XR1ylVFWCLa3eS6k4aB B2gdIRvsqOmbRjMdU1B6nmXncmlqbdxfSMCHs021XLZaoNpF6Ej92yTQ6Blw5XAPEGM= X-Gm-Gg: AZuq6aKi4XtdbbcICAgWQWNAqF4q4fAAohcHlCrMn60qUux+zsvMxY9FRuPbK65y3Za tuAucKvc4zrtgvLjUJvrJB1BNJIccw3mmmj7bIuICGsT/6vOeJaJcqox2FDUraVyHBpgWAruPcv +t4Yo69te1vjkYyQSwGgL3tBoIqP5S1t6Nl9Lzp4WWeomiasqlCAps56B2jfHAF62ovSNgR1AEv qfOMlMzTVZsgFWKnSPo3xL5pi7GHijq6PHIWAzQsnyuycIGhHE9lpbg0IXvc43YsnIhzr2har7q raqUA1pc4t9g2yrzyTwp7DLkuCmYL2CtH2NrbcILYfBl881jmJwQFF0SqisFgOk8QMaoWHsB78u 88Qqid8BxM6u6JVdER7J7WGFZlTaoqBJGiOa+WPfUbfScqmd8I8gwT4KkVJ2l2s3EazrKdQRcfQ HWjynxEyazkeS4oE/dM/KkqbNc3DD7rPjxjHGi398/mCaCJDMOQ5812Hnel/uKwwhQ0otRO0rdW Qwm6oZEjuiJ7kCVjfV4wkA///qBHzzIz3FQJVg3AO6UVhuURUhaNw== X-Received: by 2002:a05:690c:d96:b0:787:f755:5ae5 with SMTP id 00721157ae682-797f734c502mr47511417b3.40.1771539027618; Thu, 19 Feb 2026 14:10:27 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c18a935sm132936067b3.12.2026.02.19.14.10.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 14:10:27 -0800 (PST) From: Ethan Tidmore To: akpm@linux-foundation.org, brauner@kernel.org, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, rppt@kernel.org, neil@brown.name, bvanassche@acm.org, superman.xpt@gmail.com, tglx@kernel.org, oleg@redhat.com, mingo@kernel.org, ebiederm@xmission.com, Ethan Tidmore Subject: [PATCH] proc: Fix pointer error dereference Date: Thu, 19 Feb 2026 16:10:01 -0600 Message-ID: <20260219221001.1117135-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function try_lookup_noperm() can return an error pointer. Add check for error pointer. Detected by Smatch: fs/proc/base.c:2148 proc_fill_cache() error: 'child' dereferencing possible ERR_PTR() Fixes: 61a28784028e6 ("proc: Remove the hard coded inode numbers") Signed-off-by: Ethan Tidmore --- fs/proc/base.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index 4eec684baca9..4c863d17dfb4 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2128,6 +2128,9 @@ bool proc_fill_cache(struct file *file, struct dir_co= ntext *ctx, ino_t ino =3D 1; =20 child =3D try_lookup_noperm(&qname, dir); + if (IS_ERR(child)) + goto end_instantiate; + if (!child) { DECLARE_WAIT_QUEUE_HEAD_ONSTACK(wq); child =3D d_alloc_parallel(dir, &qname, &wq); --=20 2.53.0