From nobody Fri Apr 3 10:54:51 2026 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC3FD327C18 for ; Thu, 19 Feb 2026 21:36:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771536995; cv=none; b=gEXSzVWi5O97IOeqja6spXyTuN3hIckyThBgt4jj3jFYkwawcz/uTECqsZ3Kw5XQ4W8yD7HxpRCXzaEdmpMFWX0xLtQnMAD4o/sCE0qo6kXj6IAGf4f35H7r/mZ1wggJkcZCbE3aFEJPxViKtVUng0Vaa7hWI/aDLS4qWWnRhk0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771536995; c=relaxed/simple; bh=FA4WOPgvDycyyHB2/mEGb4o0SEvbAYbqtnEqBnxYnHs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YQR11nrGT+cMA3Mnb2g5P5N4mb5C6cMz5muPI3Sy0BdTBXy+eaJCIWssveuVVFnXn7olOq4KCZiFauDrrU2jDYiSDWj2L1MRcf8RihZd1dG3KmlJC7bTdJHgnY9yDMJ3PvapSsoYpkk09JSFGgJrbL+nXhDN2H6Kg3Iz4UNz6jU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SyB5sL30; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SyB5sL30" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c626bd75628so500840a12.3 for ; Thu, 19 Feb 2026 13:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771536994; x=1772141794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=snfBJanBL4Z/KaYXmLO1nWQ2apjpeu56D3VSCWFakAo=; b=SyB5sL30vcLonMVB9mNLy0NWoeKac1OVFYfW+mlzeq3Kikh3qFuOkMUbHG29LIkm5D xveuy3dWAtY4JyVBnt/LwluX0sOWqEYBYlb+xwmnEuSbYmgl5tnP9VahNlgASMW81oJ0 kZ+uRiHWJh73T7gqIjd2xdozQIsZZWAbpTM1JOGpVTqeB3VOkvj9AZJgfNHJTJLdrJcT 1uBPtru3TZwDjCA5hGAKqY0eSbwTI1+x8Hhj5OcfQ5RNBDqMvu06NOA8ihGZNyhiGMKJ pm8damdJSNxTcC38qbeO38ryNK8QwQC3mpNd/NHLScglC8nqoDU1CBT4cgu1N9fyx7Hl t9vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771536994; x=1772141794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=snfBJanBL4Z/KaYXmLO1nWQ2apjpeu56D3VSCWFakAo=; b=trc6jtMwqnF7lFCuZggIH6EDvMkKakDrcd9PdoUbWC3BStEGFUXOBFWkn6RkuU56ek MtIyQH+JXrqS88Lyp1ziqdAnuZd3FuirNf/Zl28FwgvF1MHeKxnQpIYp6CH0uO/mdvHR POoI2aw2DYziJKNvpJdz1TP0TDIDwJ4WNaTfd/zijClG6eaE76W9pQkC6dVAD4KnQ3Ex 9lFwmRtTMKUpdguy4HVlNBnOpXL2LMC3fbljtkE+iFfF5NU3MhmGuKSmnt7rXu5LbTtZ I1RwgaDdfDtXJDDNFzYjlmOPsyzRMTWEtSeolRc0AC9vdpKpWLjnjud76y18Bvt162X7 rS/Q== X-Forwarded-Encrypted: i=1; AJvYcCWXo3unHD2cT2QkSyqKSYNq43Zdmkrl3d6jhbstr9vI212PsWIb/D3DXzIeB+ryuT4CDyWWnqdnT4HZQ+k=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh2LwYzmBU3rwLeygEIQ42DJhsnrOd/0ab/R8wDJM80piR7RVu AQTWQObckqamyJS59bcA02NujvRQv5Go2PCwJ1VPBDUV4jMiumdJYaTqM1VIcQ== X-Gm-Gg: AZuq6aLrsNFheeeWl3UzlhK1sF0sytiwmdFa3iKsaAHhGMrcbzEVT00OO2ch6NcBnGM vdHKaQUt+jdWwZQh/kDxWNMpOUjCUpJZv58fLXO7/FCADJ5al3uARQ3svzz6ZkMFbDHC1H8kfPo PDWI9hskBBN9jEOSvzva4F5S0eHvyycay+C5zpd4edeCoHyxVYH2n0K74yp4JyWjW15C+IEHr1Y Da/yvFy8kc5tYNcxmnhs0beJ5Yzf/WZA/6vniqmsqIGJeOQeDwaRdFI6RVxLLMiBQl4gT4JY/BX u6qgKz+kwX5UwGaI12J7U89tkHdE5i7cYqzZsAnZ49cS3snzP3matR4nUSD5h6ar3n1CqhrNz5W nA2MzzrvYNCd62NpdfJXjVNYr/DlIP6aLcGJidqnpIddZ9VPCu3wjqnQJFaaiPz0ueDEzn0E+AT 5sT/TLbnHPeXlwQbNZuYlwODFq X-Received: by 2002:a17:902:f651:b0:2a7:d5c0:c661 with SMTP id d9443c01a7336-2ad50e9dd43mr67541685ad.15.1771536994270; Thu, 19 Feb 2026 13:36:34 -0800 (PST) Received: from arch ([2409:40c2:5415:8e16:49a5:aac1:3b74:3ed7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a7145cbsm238938475ad.30.2026.02.19.13.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 13:36:33 -0800 (PST) From: bhargav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v3 1/3] iio: frequency: ad9523: fix implicit variable usage in macros Date: Fri, 20 Feb 2026 03:05:47 +0530 Message-ID: <20260219213549.59645-2-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260219213549.59645-1-rougueprince47@gmail.com> References: <20260219213549.59645-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable named 'ret' instead of using passed argument '(x)'. Update the macros to explicitly use the argument '(x)' for their operations. This also resolves the following checkpatch.pl warning: WARNING: Argument '(x)' is not used in function-like macro Signed-off-by: bhargav Reviewed-by: Andy Shevchenko --- Changes in v3: -replaced 'x' with '(x)' in AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) drivers/iio/frequency/ad9523.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 63c485e9e44c..5725ab62e0fd 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -167,9 +167,9 @@ =20 /* AD9523_CHANNEL_CLOCK_DIST */ #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18) -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F) +#define AD9523_CLK_DIST_DIV_PHASE_REV(x) (((x) >> 18) & 0x3F) #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8) -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1) +#define AD9523_CLK_DIST_DIV_REV(x) ((((x) >> 8) & 0x3FF) + 1) #define AD9523_CLK_DIST_INV_DIV_OUTPUT_EN (1 << 7) #define AD9523_CLK_DIST_IGNORE_SYNC_EN (1 << 6) #define AD9523_CLK_DIST_PWR_DOWN_EN (1 << 5) --=20 2.53.0