From nobody Sun Apr 5 13:12:17 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DFB8D30DD1D for ; Thu, 19 Feb 2026 20:33:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771533220; cv=none; b=IYJIPiWWEtwguI5Uaoldpxx7hAlb+SMXVH3KM2DP+UmdCaCo/qblv/kXmydraf0QIKfHZ8JhFjaPzZUWvPCWzgHTbLd4Y4879l3GxQvnMVngEW4U2ybuDbpC8c+YiZDV0ulZyStRnMDULYVYdDyZaqHjb298wkY6ExAUTAgO0B8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771533220; c=relaxed/simple; bh=0eZ6yzY4ylhIMJgYuPyp2CXQhgxqcrQbq+0L5NsPyaw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Y1RbjOEucIARmXiBrxlBLJpWx+XjhI54XreKCLH3BZj+sni6LQcwv/oc87lilJMyH4LPRME5bT2fiw+7fyQ81P1afghyjFhN9EI/XaRpu6lPPVloHpU7lBS03PrHZ55/TRfwett2tUybk1jBDWCuQ8Bzkfa/gQNp8w/3ObRpTpM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DRispM5o; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DRispM5o" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-823075fed75so718840b3a.1 for ; Thu, 19 Feb 2026 12:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771533218; x=1772138018; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eUggxPaSmMAVQzWY8puyB/mctdVv7nxnhnv5JC+qPdc=; b=DRispM5o6UH6cvMHMPbHm84+KyHyoNhprcb1zmOnqkim4EKTv9srZDaDs0a+kWjT+G xIetif7Jhq9uj47Br8OCJkDmQHNwwtSq/c03lyis6c0CX0Wwim10nczeOWhdmTsLaiDr 3n1+6AbpU6gK9k6Nu5mmzfwZqoL+fDtAXwRyZWR5hcfgh0kQMH0ZW5rXdskg6o8fLKUg Yitui6MrfCg8PdgLuioXU1ry1f8dWdeKDxrkx/tt27sSUNdY61CvZcdnjO+Bv2qfxPPV mlMtI+NmcqoMazsIM6Kh+q4k00nYFx3a+u1T1ibZeQQBRlx7joOriSw8NK1kwcsTD7VO 7Iew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771533218; x=1772138018; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eUggxPaSmMAVQzWY8puyB/mctdVv7nxnhnv5JC+qPdc=; b=MKkAM2Juovmpds8olDo2+rZOloSLhlnn7e9BBgxavHqWwUEcpiKVQE7roaosj+zh93 AbpCx4wxpRfGsAkZ7s2fS6IQG6c+JN3ieYk6d7cWqvC++YG+yw5QxBauFkBflr0l4Wcl 8SLzDDxAUKDiPW8+sB/YOtE04L31z09UssYiWejciC8g3Y9H3WFi2T4QAs7iq/ydtOSX b8Jts+NTLRBt+8H+HTanP7bHNhdRroe77OhnsTV/brupelnQVtkI2jYebYUyM/nDpHow qIQanKv3a3pqvJexvjJNwgKWcCV7oTrXxLcqmTTnW1K6Y2MGgYvhUIPYpwGakwfvcrDn iWEA== X-Forwarded-Encrypted: i=1; AJvYcCVOGjjwpWgIDts3IBwmKTw3BGRPgcxWOZaGP1ERTPLX2SHpauT+O2SsNMfpSdMhQfyUKt6zeJMm2mUW/tg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxm2zCNEZWTAY8hGqYTlnIzTNQL4GT1uvz8Wm39fupq0FYkoZxC ni9saYEXYe+8029wmPLCLcPKxyvu3UWheei8QF3tzyMTDN8eWL16Uh3C X-Gm-Gg: AZuq6aLwyb4j2mfxjVZSUSjy7VrqYK5qzklIg+rEM1r3bzj/qcLpQIdZgQaZuNH3mUX uvstAs4TrdK0MxUiEYwGAVw/JWXSkkXn/v37Yg67QUQv+aDR0qit5tDx4oMsKPRoVBPw+XldYlQ cYt0vedLtI4/lTjlWV2UJRDXoNBEz8UvI2+ILX31hyMStkME5rv09Mj2PHYONewVOdLeo4rDWKw qCv1C6ET49q+Yov0CFnw3lilEjpiSDdZMC71+mpI5CjcKDy8Oiii50VTJVzj4NCgzHLQzGrmPux mD60Yj7SfiELR6A33/497UYST0u/IQ43zFhL9IWKQjgNUZChMLgKgQOWLFcrq+kaqP/qHnMDbOe mmUJl5bD+Ap30PA7d+RBJ/y/bwgI1d5W9El0hlFWq0stFcS6s4Y9rgtAU5j6pSLquVlfoY8zgJr sIoBQqWHLUwB6lQREHNo0IiJ7p X-Received: by 2002:a05:6a00:1d0a:b0:81f:804f:af26 with SMTP id d2e1a72fcca58-826badc17ffmr2708281b3a.19.1771533218052; Thu, 19 Feb 2026 12:33:38 -0800 (PST) Received: from arch ([2409:40c2:5415:8e16:49a5:aac1:3b74:3ed7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6b94b80sm20339278b3a.55.2026.02.19.12.33.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 12:33:37 -0800 (PST) From: bhargav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v2 1/3] iio: frequency: ad9523: fix implicit variable usage in macros Date: Fri, 20 Feb 2026 02:02:13 +0530 Message-ID: <20260219203215.15566-2-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260219203215.15566-1-rougueprince47@gmail.com> References: <20260219203215.15566-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" macros AD9523_CLK_DIST_DIV_PHASE_REV(x) and AD9523_CLK_DIST_DIV_REV(x) implicitly relied on variable named 'ret' instead of using passed argument 'x'. Update the macros to explicitly use the argument 'x' for their operations. This also resolves the following checkpatch.pl warning: WARNING: Argument 'x' is not used in function-like macro Signed-off-by: bhargav --- drivers/iio/frequency/ad9523.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 63c485e9e44c..d127f3aa6cb8 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -167,9 +167,9 @@ =20 /* AD9523_CHANNEL_CLOCK_DIST */ #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18) -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F) +#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((x >> 18) & 0x3F) #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8) -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1) +#define AD9523_CLK_DIST_DIV_REV(x) (((x >> 8) & 0x3FF) + 1) #define AD9523_CLK_DIST_INV_DIV_OUTPUT_EN (1 << 7) #define AD9523_CLK_DIST_IGNORE_SYNC_EN (1 << 6) #define AD9523_CLK_DIST_PWR_DOWN_EN (1 << 5) --=20 2.53.0 From nobody Sun Apr 5 13:12:17 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0D6A30C620 for ; Thu, 19 Feb 2026 20:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771533232; cv=none; b=sj6d8+5sD6Wtqc0vLiQnLPRcqwy35wGcleK0LkEsFSozAZEMuIgDxg6DYhdqO1UHQfWH5Ywn2JQmYLW0A3HgRf2d8FaNg2adtY1+hEDDnXLZP1lonOzY/Ui6omvEUTwXVMp/85AiSwuuXWHFbFySCULpRLBrxqna3aZwgP1Zmtw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771533232; c=relaxed/simple; bh=cKXXqkuHdb/6PVrhi193Kpkk1MRt/bN7Gazuqm4hFTI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Cy+sQ/RRC2+zHiBQU42FDee9HfSjyaK2/rDv+CzKBbl6GH7tt2h/aCuB3pSR5gxI2lJ9AhigHeDG0ZWWucosJccG9n0TROIKAvJA1iqfH06OuAdpw1B9YbILfnjhD2cbWaC6xSoXZEJCqDnrAoU94haw1eq7UcRi99mCVeL6aHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iPxWi4TW; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iPxWi4TW" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-8217f2ad01eso1429400b3a.2 for ; Thu, 19 Feb 2026 12:33:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771533231; x=1772138031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BIi+OMPIEGzkATcR3nbeDpG++Q/GFRTfTECN7DMuE60=; b=iPxWi4TW7O7Tj7gcsYwBPsnFNBkceHZHuofKPsqT55nVzGM9wyAfyZarjFPi46MQkt LwuLxthqBiXYLVUNBJWVR4qebJhhYiqwfwSrZU0uiI8awCSy+b3xI0dxVlbFXagsBJvz +4BVlV7Y2mKR0wApzy+aUNXE7r0lvy8iYbr1LJnS8ogIYK9pnDlTCgm8+k1ZzIjSEL+H l1pfiKs3SkELVWBcUa7TjulVJMK79dax/qFJPfYBgNj1WINWxmK4ywqUsLoSUS6JXN/F 8vNlvWyCaEnPzqRxHKKnV0bIVclg2xwJnbY3pBW7Vr3/PsAiyLJojmnhffOz0cG3p21Y 6f3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771533231; x=1772138031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BIi+OMPIEGzkATcR3nbeDpG++Q/GFRTfTECN7DMuE60=; b=VtOwLO/jo2mt0RGjrvDbipqbCI/5J5JIIbl1JZne5LdQrL/W6j1ITM5a0r30OVwcee vJMklBRbps9+8fnLMfkT5R32nGiB9bMVyUxAgd2rERhIUS+Q6vqfdjRfWS5DZkfwDZkS N8uofMsyNmQcaroYynndAe7WbtVNkAQeWzPoUCCWN0+zJUNaQrKzv2Wv1qqeH/j01Rgc WfhDnU9v0Mm/qYypg44/VTdDgxOgRJEbRDEwH1R7zQN2U7AE+9zo7hCLyISqHQDGwB2n azc9lX0U+Y94ikpXCykuQTDtS3zkK8C9BoPKN2sWiMFS67SZ2cSkGnofyWuRERrxuaZS 3VoQ== X-Forwarded-Encrypted: i=1; AJvYcCWqAHwqfok0GlWG8b15emI+wf14ZuMTjjlxI5KSrXG0W4IXDqHHucBT2ApZmuqfpV5yuKPr2xodx5nJVyc=@vger.kernel.org X-Gm-Message-State: AOJu0Yyl1wCcg0RrQ7uisjwjCJRvXrvMKFLj6pTpOFwSJTFt7hhDkJzT 07hkr/95IbhtOzmM19P03JbcnHhMMz3mzfiTRUyOwT5yEHtUiY5EdEpW X-Gm-Gg: AZuq6aKdTmDQ1JDfyZJbUrE8UZ+y7/pVhZcEUYb30L2zvw2uqBF7SwCajpPOdP23zeO yeD3DCEIVwIJrhbYizc0LL9JQrIIDEneh9BsHmi/Iojwl9qFR2NI7n6dM6ThyGKwe/x9cZ3zy4L +UOeBQKuDYmKZ6GaZCmB7GTF2L8kuz2kpEjO/dMFrMqFZRzsebUJGR9ov6Fwfw3YhfHaWN/VwWg b6JlU92F/gDU0AzZPx675rtMGsiQ2MCosYCH8oalp/5jv6RJl6wZaZ8FyZn8UCFSgtQS9+rOW8G g0UQ7ihcjHQRoASq50uJqumZCZgoIc0gsO1w/rzPwmfjEbjY8fgyyKpaNmf6BL2Dr7iGnMOoo2M ipUP4UafPbu1/sKfUx0bY1FaeQ1w6zyG2pkAP5b+J3F0FWVIBnWk0vofVFDETctoBjI6TU9rcMJ aEgkOiU2vPz6XAyHkCHaEjBemS X-Received: by 2002:a05:6a00:7584:b0:81f:997e:59a0 with SMTP id d2e1a72fcca58-824c615e2bfmr17662092b3a.64.1771533231072; Thu, 19 Feb 2026 12:33:51 -0800 (PST) Received: from arch ([2409:40c2:5415:8e16:49a5:aac1:3b74:3ed7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6b94b80sm20339278b3a.55.2026.02.19.12.33.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 12:33:50 -0800 (PST) From: bhargav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v2 2/3] iio: frequency: ad9523: avoid multiple line dereferences for pdata Date: Fri, 20 Feb 2026 02:02:14 +0530 Message-ID: <20260219203215.15566-3-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260219203215.15566-1-rougueprince47@gmail.com> References: <20260219203215.15566-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Platform data pointer dereferences for pll1_charge_pump_current_nA and pll2_charge_pump_current_nA were split across multiple lines. Bring the dereference chains onto a single line. This resolves the following checkpatch.pl warnings: WARNING: Avoid multiple line dereference - prefer 'pdata->pll1_charge_pump_= current_nA' WARNING: Avoid multiple line dereference - prefer 'pdata->pll2_charge_pump_= current_nA' Signed-off-by: bhargav Reviewed-by: Andy Shevchenko --- drivers/iio/frequency/ad9523.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index d127f3aa6cb8..4d0556ff5601 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -797,8 +797,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) return ret; =20 ret =3D ad9523_write(indio_dev, AD9523_PLL1_CHARGE_PUMP_CTRL, - AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata-> - pll1_charge_pump_current_nA) | + AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata->pll1_charge_pump_current_nA) | AD9523_PLL1_CHARGE_PUMP_MODE_NORMAL | AD9523_PLL1_BACKLASH_PW_MIN); if (ret < 0) @@ -842,8 +841,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) */ =20 ret =3D ad9523_write(indio_dev, AD9523_PLL2_CHARGE_PUMP, - AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata-> - pll2_charge_pump_current_nA)); + AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata->pll2_charge_pump_current_nA)); if (ret < 0) return ret; =20 --=20 2.53.0 From nobody Sun Apr 5 13:12:17 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFD9030C620 for ; Thu, 19 Feb 2026 20:34:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771533242; cv=none; b=UHWF3ad8oD/MZnacIDZimNyEtIcPOSRcRcsOEsjbye4Kwqwl+CHlRFfx6niwu95crXrvGmLQ4IquoJOgjI32lqwJhiD6gcgnQZtmSylbz9DwRO+TRmX8rScBnUeQhsEgb1LBlSIMr4IlFa6aEsIBnEVs3EFWy4dQFYhJBr4gBpo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771533242; c=relaxed/simple; bh=MFsqeaI3f9penNDTUHKZULsatT4hpvovywGhQC/KZAc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hGAPEUDBNaceyOrUaww/X0jYF28j/hDPw2CHDMSOH8jTW+3Z6i3R93K5NPhLoTDXmNdHVOINiQK3zCWGlsNGhl+e+4oXl8D9wKxS4Ewf8iJCHb4KD6emNUmA2RK1omuNwK5pFikbQ9rsm3Ouh2kmM5/ymW7DZyxxQ3QPJexf5D4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=esdiTmJK; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="esdiTmJK" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-81df6a302b1so1411224b3a.2 for ; Thu, 19 Feb 2026 12:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771533241; x=1772138041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=26gzJtloJijZDesoemSh9i7X2im5JgocENjBucao4eA=; b=esdiTmJK5gYXxj8bxNtiE/H8L8V/jKrmw8d2dfOUeZLt4X+xZKCnriiml5fVblYktf 54X2paXYs/CFAN5XtQz7Ua1dhueEX4JVYCUaLDqk9F8PSq/GpNi7zmNcbLg08W1eztxn NIjaKVqXykSxQRsnlRTS8L9rYLqX/zda56+B29DwX0RSO5KPOEynrVSTz++XcRLUz+pa WdirOKZY1HL8xlc4B2al7+SWK3pqUJLuI9ZqwU2JM4grMcBGHEyNeTmNMmVRMsxAdEIJ zz79fwRHTw8BTdu6WhBEfbbgkSDQABcT9f6wlRI7UPeSBifk7ccTt689in61IB/Ogml1 j+ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771533241; x=1772138041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=26gzJtloJijZDesoemSh9i7X2im5JgocENjBucao4eA=; b=kQs1uAxU0vxnwN/JWa6gFEpuSKUPzYZBKXr3P9+y/pg8MBvncepSa4aMrKEc4J5ix0 sCtmC4delFAjcdjK4UpfRWO7TuCRJxQJlb/3QfPvO1I27ZZbJTumAozq53KYACPPxfNJ rpVU0V6/EnT+ZOjgbjfHjnUrquemCIApCCio6pjKs8wirl45UZ4EfyhTed8v/k5ZmxAY t9veLV2vtLNepQJ6yi36uIe8TF4JDuRAXAdJAWktBAuGQXstFNIuqAvVNeAPGD4h8amn 9uAI5FhgjcI5YdZr6o6zgeOMqP98sChnqm7levnhElFgsTwKspeeElL6tkhWVR1Av8hK etgw== X-Forwarded-Encrypted: i=1; AJvYcCXLtN6AcEjxpElk+N4EdkJaImR0rPJhf4VGkybVI0P8+Z3wI/LGaRCAto3qzVeGDiUmAtXqPAIQHAHyEGc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/sudohQlZm25Ia6+9tccfoFQogCK338uIB/MUbLMWIpkFKWdz A+bTIaez31MCvV9tFAbYxS4GIB1Eptej7JbHnfZXIHgBBDqEm3rSTrzy X-Gm-Gg: AZuq6aKgm0c7fZFwU1uYLEjURmjltWkYO2jxvZFmJZEtqpy1Xd74bW9CrA7JOZPYDJH K0p3zKa+sAfYlzOABszrEP2zzN3EEYWTogrlQP3rbdNAxFhCPL0LUTt3A1B63hTHfC776v+isWa pCm18Q2N+XAe19JiQEUisAxeS4+Mx/RjPwV/1VDZkGyPBYpaOmAn9wIP14moZUSYGOxoO1KP91c CMIQ2wfgbmJgJSxdeqHKN0dc1KHFEguyG3KZxcjmWamIwzK1bk/yed/VmcpgfjMsY/fPg9BptuJ Byhium+kGrhHEQkJ3tXRhw1LjT2mcVknIv7V6RRVoJlEfavslAreSjmU7ByXZGQucvE48m7xJUW wSLbhCB8NhpNSj1hcH9IiZb0NiHHovD2SJed7tu/qHjqLiCEbur15hZASVigp1t3AjQPDchFIJi 1HvghpH2gd0yAPpCTvgbbK3KoA X-Received: by 2002:a05:6a00:992:b0:7f1:4:66b with SMTP id d2e1a72fcca58-824d95e6759mr20544408b3a.44.1771533241192; Thu, 19 Feb 2026 12:34:01 -0800 (PST) Received: from arch ([2409:40c2:5415:8e16:49a5:aac1:3b74:3ed7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6b94b80sm20339278b3a.55.2026.02.19.12.33.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 12:34:00 -0800 (PST) From: bhargav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH v2 3/3] iio: frequency: ad9523: fix checkpatch warnings for symbolic permissions Date: Fri, 20 Feb 2026 02:02:15 +0530 Message-ID: <20260219203215.15566-4-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260219203215.15566-1-rougueprince47@gmail.com> References: <20260219203215.15566-1-rougueprince47@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver currently defines device attributes using symbolic permission flags (S_IRUGO and S_IWUSR). Update these to use octal permissions (0444 and 0200) to resolve checkpatch warnings. Signed-off-by: bhargav --- Changes in v2: - It was suggested in v1 to convert these to=20 IIO_DEVICE_ATTR_RO() and _WO(). However, those helper macros=20 expect uniquely named callbacks (e.g. pll1_locked_show),=20 whereas this driver uses shared multiplexed callbacks=20 (eg. ad9523_show). Converting to the helpers would require=20 generating wrapper functions.=20 Therefore, this v2 keeps IIO_DEVICE_ATTR but updates the=20 permissions to standard octal format. drivers/iio/frequency/ad9523.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 4d0556ff5601..2a075d09ab83 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -558,52 +558,52 @@ static ssize_t ad9523_show(struct device *dev, return ret; } =20 -static IIO_DEVICE_ATTR(pll1_locked, S_IRUGO, +static IIO_DEVICE_ATTR(pll1_locked, 0444, ad9523_show, NULL, AD9523_STAT_PLL1_LD); =20 -static IIO_DEVICE_ATTR(pll2_locked, S_IRUGO, +static IIO_DEVICE_ATTR(pll2_locked, 0444, ad9523_show, NULL, AD9523_STAT_PLL2_LD); =20 -static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, 0444, ad9523_show, NULL, AD9523_STAT_REFA); =20 -static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, 0444, ad9523_show, NULL, AD9523_STAT_REFB); =20 -static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, 0444, ad9523_show, NULL, AD9523_STAT_REF_TEST); =20 -static IIO_DEVICE_ATTR(vcxo_clk_present, S_IRUGO, +static IIO_DEVICE_ATTR(vcxo_clk_present, 0444, ad9523_show, NULL, AD9523_STAT_VCXO); =20 -static IIO_DEVICE_ATTR(pll2_feedback_clk_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll2_feedback_clk_present, 0444, ad9523_show, NULL, AD9523_STAT_PLL2_FB_CLK); =20 -static IIO_DEVICE_ATTR(pll2_reference_clk_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll2_reference_clk_present, 0444, ad9523_show, NULL, AD9523_STAT_PLL2_REF_CLK); =20 -static IIO_DEVICE_ATTR(sync_dividers, S_IWUSR, +static IIO_DEVICE_ATTR(sync_dividers, 0200, NULL, ad9523_store, AD9523_SYNC); =20 -static IIO_DEVICE_ATTR(store_eeprom, S_IWUSR, +static IIO_DEVICE_ATTR(store_eeprom, 0200, NULL, ad9523_store, AD9523_EEPROM); --=20 2.53.0