From nobody Fri Apr 3 10:56:14 2026 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E8EA30CDB1 for ; Thu, 19 Feb 2026 20:07:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771531662; cv=none; b=lcnG+SwPm2NSWWVb0McQn8etRRMgu2DMilIeAbpj/r7MHknOtk3lCP3eyhVU3bcymcwXk0c6EaXXuP7RmHGmKG0YgXZPAlrtqtGN+3kkcfE/DQZpbYDJeZdXD6mr1T10jskhg/pSkz1bURSXYynFIKy0DoB7U+isEoQeDK1BiFM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771531662; c=relaxed/simple; bh=4hKDGUDaKLhwYa10wo2QUB1w2/7YI/N2c1XW+iZG8HU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=liKo8cPcTENajmT5BYzWKtg+6KpIB51G3a0i1OTEdAieNoc6Ox0wfL54u6xdR4DcT0PorHDyNYFxfvveWrDe69QnzRqo2rw381aKycCyeFfjZBncdNWscGIzZOEW2wYL12BwhA7VfIODfOmySuAbSAfIN6aOnDoJvIqkzwpFIJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lmqO1imb; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lmqO1imb" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-797de0727a4so13616647b3.0 for ; Thu, 19 Feb 2026 12:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771531658; x=1772136458; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/qmzM+i4dYpgByb8fBfDVhdvTlZELGZrVQkv0zNaF9U=; b=lmqO1imbRIlo79Y9c90FVho2utTjZJQIdRzOHniaQM8FskebgEI4dwQ2qK6W9ew/YY TrmZv0HXIYr8kGiDvJQ3FZJqbblCKMFryGZTo9TP6765CQ3gf6PLMXWKFuBuiq/XTuHL SowL8LfohVNlVlzGgZxiTwb1fSp3G5iRloRUJUCIdIOtbrnS3N48pdQ0aFU22sEEbLbs 2RUaNwGV5Lh0pRuOa4jCxalBPMgeZ7Vd3qlVHY0pHyfZpAHaTEjLIP64rUZty27mOmZo fqNYEP13hjG6HQKpSv/kF5et9V3HXhaimnohpW/tVqGSr3G0/T1f230s1xgGNZ+EAAdP J60g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771531658; x=1772136458; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/qmzM+i4dYpgByb8fBfDVhdvTlZELGZrVQkv0zNaF9U=; b=uyVMBekDMHwqv7o7G4MR4LujD0CxJ9DOSwYu12XPchNL1FGYFPT+YGXpkBkjVOQrI7 0+CoBX8Kf/CLs4doJUXzAHR3S2qckEmzmaCsQvtsByKvAlvLnm8Ocjj6wE4fiEVC7XqK OJz1SayZgYblmhRF/0KGTBnMHZAodUXDWQ1XJA9Gl+HNfIGxZumZYOMLlYTdVFS3HnUy q8vVMWXpnmKtydt4ZHsc6GqsQU8Oiyrh2KQ15HKdu5WvjUsdb6NUtliEyfpN3A/SCWmg X9toZQWEIZ82vHpGivCS36ZH43HFVuYm9Ib2wxmIEzgWJgr97lZjzSNZsVY1vftMQ/qC UVMg== X-Forwarded-Encrypted: i=1; AJvYcCU0v1YWHQBFEU4MY20mndlUWYQiecglBjNwAwbnwDSIMKVBciMclSQdBci7MxjuozhM2L9kmdc4FHkyuQk=@vger.kernel.org X-Gm-Message-State: AOJu0YyRweaWoK1wER8gTAs8ULcPstLJY5VkhmjcSA0zmm6d6O/CDRFG p5q4rlqUe8BFy8fTOPrFBj7ZY1E7bV4BsmCEVP6O9BHkWoF+20Fe22tp X-Gm-Gg: AZuq6aJpkXjb3HvcLOD4rikjTznDjRN4nHlx2uDO5ITEMu1fvLnEEfRO6+ep5dopugH px1drogwPsAM6PDQ2eSuQN8Kor9JdjXxREYeO2jDcGce7WjYL2ZgorvPwqXj9qdSd8SGur62+KU ZS9yHyPEJkg5B09ggAAumFzkPekCs1W4gvm2dnh6OfsJKumS++M9I5FeiqIuKRw2fEeSYljEOk9 ARSQgTKPPrJPMiMv91n4tug1WAnxa/gh/BbqVElI7N0v8Yazbq8slP8Wpw8ELMAl0hhb0r4abhg Fa2RtGC/JX+04AKOf8o58f7Y7w5z/pk9JrrEG7A7fimBUbOYjJST20tWS9+d7pX0QMRPg4pKcfa zKmVDxTjcnZoYUR0TN+dj7ovv8RxC/PY/Qlc031J8IclYGcEV44FnUXyIhNsDmTZkNkUiFj6IvJ UIf0DtAC3XVsU05IJv11i7FZCYIeJtkUqRa/yA4eB2O3nuDkGe0f5Yz+nQjmIsArCn+xLT3FJrg U2BW5hzXXH5iwCcN71BTWYhId82PBJ58LVY0ElaL9c= X-Received: by 2002:a05:690c:6612:b0:796:4ab9:f29b with SMTP id 00721157ae682-797f7353b65mr48586537b3.39.1771531658458; Thu, 19 Feb 2026 12:07:38 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c2667f9sm138276567b3.46.2026.02.19.12.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 12:07:38 -0800 (PST) From: Ethan Tidmore To: cem@kernel.org, djwong@kernel.org Cc: nirjhar.roy.lists@gmail.com, neil@brown.name, brauner@kernel.org, jlayton@kernel.org, amir73il@gmail.com, jack@suse.cz, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , stable@vger.kernel.org Subject: [PATCH v3] xfs: Fix error pointer dereference Date: Thu, 19 Feb 2026 14:07:15 -0600 Message-ID: <20260219200715.785849-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function try_lookup_noperm() can return an error pointer and is not checked for one. Add checks for error pointer in xrep_adoption_check_dcache() and xrep_adoption_zap_dcache(). Detected by Smatch: fs/xfs/scrub/orphanage.c:449 xrep_adoption_check_dcache() error: 'd_child' dereferencing possible ERR_PTR() fs/xfs/scrub/orphanage.c:485 xrep_adoption_zap_dcache() error: 'd_child' dereferencing possible ERR_PTR() Fixes: 73597e3e42b4 ("xfs: ensure dentry consistency when the orphanage ado= pts a file") Cc: # v6.16 Signed-off-by: Ethan Tidmore Reviewed-by: "Darrick J. Wong" Reviewed-by: Nirjhar Roy (IBM) --- v3: - Add dput(d_orphanage) before returning error code in=20 xrep_adoption_check_dcache(). - Revert xrep_adoption_zap_dcache() change back to v1 version. - Include function names where error pointer checks were added. v2: - Propagate the error back in xrep_adoption_check_dcache(). - Add Cc to stable. - Add correct Fixes tag. fs/xfs/scrub/orphanage.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/xfs/scrub/orphanage.c b/fs/xfs/scrub/orphanage.c index 52a108f6d5f4..682af1bcf131 100644 --- a/fs/xfs/scrub/orphanage.c +++ b/fs/xfs/scrub/orphanage.c @@ -442,6 +442,10 @@ xrep_adoption_check_dcache( return 0; =20 d_child =3D try_lookup_noperm(&qname, d_orphanage); + if (IS_ERR(d_child)) { + dput(d_orphanage); + return PTR_ERR(d_child); + } if (d_child) { trace_xrep_adoption_check_child(sc->mp, d_child); =20 @@ -479,7 +483,7 @@ xrep_adoption_zap_dcache( return; =20 d_child =3D try_lookup_noperm(&qname, d_orphanage); - while (d_child !=3D NULL) { + while (!IS_ERR_OR_NULL(d_child)) { trace_xrep_adoption_invalidate_child(sc->mp, d_child); =20 ASSERT(d_is_negative(d_child)); --=20 2.53.0