From nobody Sun Apr 5 13:12:23 2026 Received: from mail-pf1-f227.google.com (mail-pf1-f227.google.com [209.85.210.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E12541C62 for ; Thu, 19 Feb 2026 17:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.227 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771521787; cv=none; b=G5MXhh12CBsRPcG4+iGEfN6N8kDWxcnOTsxxx5xs+lwmDneKXJ9aogO65bD9CMap6i1KYiejifKS3HsmCoe9UQXt4TirM3djd0MH3H/ghuYdV7IpmtANIpc8QusXSNCYjTwjZ7RKr9nyivXnaAmFbAAezhM+88oqk0fkzrz2T1c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771521787; c=relaxed/simple; bh=EHWMm11e5TVx8NT/hLERqyUnuuxjz5z5bCiInE9uL2M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j6R02XOmT3acBuRTJq1lLAc8s31ZRniy7UEihBAZKxvW/bNUwX3xKXxrFnmbTVINUQQ4B15PpKcJX2v3dWCUmY3bwDVlOI+Lxzy2dzyEDjxgNuGcYDUeRqPDH2dShbjdESREG0F6nyoms2MyWau7rgkhsD+rraGarjBFOCv7/VU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=OYO+ntTS; arc=none smtp.client-ip=209.85.210.227 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="OYO+ntTS" Received: by mail-pf1-f227.google.com with SMTP id d2e1a72fcca58-824a16c1d2aso91221b3a.2 for ; Thu, 19 Feb 2026 09:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1771521786; x=1772126586; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CUz10elldwZxLQFWq4Cian3B5sXmfA0qWI2X4aUf25A=; b=OYO+ntTSm29oRNhf2zM2LaZJSmhofr4nthTgO/zxqyVxVW6lvpRdjcSjED/8EOOb1x GVmGqyjpap6RswRRWcJOWjnMF1qBnbm1lrmX5P3MNsOWnzQu57rxa1tLej1Y+kdvYvST CCG5/E0+6vFUUh4CkKh4wJzjZxAD1c/z8FvthxyIo0+Q7XJKmWwShK4yTCvb+HiBVicN YTrJL5Gt3RVPnjUfJjasA7QsD8+qTyMuSqXC1QfUqp6Y8vJ0atNAhzr5TaVYrPek75NS vrSMCHNdAhQ60qy+zxgO5lqJvCyjn2th7AXEP/jBrTuswzM6Kq/QPOZxmDau1pPhfpMZ Kclg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771521786; x=1772126586; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=CUz10elldwZxLQFWq4Cian3B5sXmfA0qWI2X4aUf25A=; b=W3zKATn6yt5V4KmMcLrjEmy6u5HTe0hRV1ENjRnO36fiiSNuHZtmFVoMdDdidz30AL WN8Fj7vP/w5OfFPSwWeNCYGTHoR0oQS+jd6kfF3NoCDvfG175ePxb/WWnXuLg1yCMzx8 t0hU2zzcEs8dDEgNDkqiQaaK8oIFIzdHNmM+QH1ndThHXFZHUunejPDytKoMyQc1OrOH ESpmRlliWCzC25OqWbtWHIS/NaU5782wqShKknryXjsZ44aytnSkTQGJFI6GiqD90OEu nDdGI5PmgbX/a01mHm4a3doUq1Wyqp8NDW+z2iL4YPEQoGQpONYOiQTsWKiW0YSfqT/f LbWg== X-Forwarded-Encrypted: i=1; AJvYcCWPJubNekLYQ+oNxLMAJvOzjFhPav7Pp6RPYtu5yBa7+XT/f9W/4YXE/dUutEEu509LetDWCHTr7bCpC1M=@vger.kernel.org X-Gm-Message-State: AOJu0YxWVTrRVMxiQfL+34BJEGhXLQ7xB+OtCtUUBBBhBwneiyuIDSqQ mLsI8o6T2uFxrGmy5OoLvojukRPNTKlD4qjEz56FZFei3UdeFDd94Jj8usVN3ZztO3pLIzzRNwZ /x8uMnTR9sdY2rboIc+8x7Zm2xK5+Wn8OR0leK5fqfCqDqja02+Od X-Gm-Gg: AZuq6aIA+RbiCuKNPmGa4NhcTMFFeZI+FY6qxVPjQmf2p6IC+++0KpNEhyoZr7Kr7Vy yPGHlBhVCwE9fo9CwBBgNJwv6taAm3Y9J5MMv2rRl5B7Cy+B7hTMX/oSqxg6CBKxeMQIEZo6HmC 9m4dtf6S3okWGmZFs3n8ENTWlwecOJ1D2D1WRpW0NKPz1SFM1Q1+wzT1uJRNhS1JXUAkl6K4XVy NJnVo0Y2f30z5jOaDcHosRHc8Zhuw4YK/lPy7fiV+LzIK0DO5747c6xpMybeXig0fGeWAC8RXh3 K+kZdqQ08HEpPR74vBFR9opd073edQfl0Z/ck8mvlzIg8e56ClG6jdNNtYsPoROohy2mF/u/ti+ 88bHhoPCtyXml7kRFGIYUjM4KFI3RQbmbnuY1xs0= X-Received: by 2002:a17:90b:2cc5:b0:356:1f2b:7e9b with SMTP id 98e67ed59e1d1-356a6e38413mr14529793a91.0.1771521785723; Thu, 19 Feb 2026 09:23:05 -0800 (PST) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3589d81739csm95093a91.4.2026.02.19.09.23.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 09:23:05 -0800 (PST) X-Relaying-Domain: purestorage.com Received: from dev-csander.dev.purestorage.com (dev-csander.dev.purestorage.com [10.112.29.101]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id EA2563420F0; Thu, 19 Feb 2026 10:23:04 -0700 (MST) Received: by dev-csander.dev.purestorage.com (Postfix, from userid 1557716354) id E3B5AE41AE3; Thu, 19 Feb 2026 10:23:04 -0700 (MST) From: Caleb Sander Mateos To: Jens Axboe , Christoph Hellwig , Keith Busch , Sagi Grimberg Cc: io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Anuj gupta , Kanchan Joshi , Caleb Sander Mateos Subject: [PATCH v3 2/4] io_uring: remove iopoll_queue from struct io_issue_def Date: Thu, 19 Feb 2026 10:22:25 -0700 Message-ID: <20260219172228.429479-3-csander@purestorage.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260219172228.429479-1-csander@purestorage.com> References: <20260219172228.429479-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The opcode iopoll_queue flag is now redundant with REQ_F_IOPOLL. Only io_{read,write}{,_fixed}() and io_uring_cmd() set the REQ_F_IOPOLL flag, and the opcodes with these ->issue() implementations are precisely the ones that set iopoll_queue. So don't bother checking the iopoll_queue flag in io_issue_sqe(). Remove the unused flag from struct io_issue_def. Signed-off-by: Caleb Sander Mateos --- io_uring/io_uring.c | 3 +-- io_uring/opdef.c | 10 ---------- io_uring/opdef.h | 2 -- 3 files changed, 1 insertion(+), 14 deletions(-) diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 43059f6e10e0..2be46e11e1a7 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -1415,12 +1415,11 @@ static int io_issue_sqe(struct io_kiocb *req, unsig= ned int issue_flags) } =20 if (ret =3D=3D IOU_ISSUE_SKIP_COMPLETE) { ret =3D 0; =20 - /* If the op doesn't have a file, we're not polling for it */ - if ((req->flags & REQ_F_IOPOLL) && def->iopoll_queue) + if (req->flags & REQ_F_IOPOLL) io_iopoll_req_issued(req, issue_flags); } return ret; } =20 diff --git a/io_uring/opdef.c b/io_uring/opdef.c index 91a23baf415e..4b3fb19b0cde 100644 --- a/io_uring/opdef.c +++ b/io_uring/opdef.c @@ -65,11 +65,10 @@ const struct io_issue_def io_issue_defs[] =3D { .buffer_select =3D 1, .plug =3D 1, .audit_skip =3D 1, .ioprio =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .vectored =3D 1, .async_size =3D sizeof(struct io_async_rw), .prep =3D io_prep_readv, .issue =3D io_read, }, @@ -80,11 +79,10 @@ const struct io_issue_def io_issue_defs[] =3D { .pollout =3D 1, .plug =3D 1, .audit_skip =3D 1, .ioprio =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .vectored =3D 1, .async_size =3D sizeof(struct io_async_rw), .prep =3D io_prep_writev, .issue =3D io_write, }, @@ -100,11 +98,10 @@ const struct io_issue_def io_issue_defs[] =3D { .pollin =3D 1, .plug =3D 1, .audit_skip =3D 1, .ioprio =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .async_size =3D sizeof(struct io_async_rw), .prep =3D io_prep_read_fixed, .issue =3D io_read_fixed, }, [IORING_OP_WRITE_FIXED] =3D { @@ -114,11 +111,10 @@ const struct io_issue_def io_issue_defs[] =3D { .pollout =3D 1, .plug =3D 1, .audit_skip =3D 1, .ioprio =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .async_size =3D sizeof(struct io_async_rw), .prep =3D io_prep_write_fixed, .issue =3D io_write_fixed, }, [IORING_OP_POLL_ADD] =3D { @@ -248,11 +244,10 @@ const struct io_issue_def io_issue_defs[] =3D { .buffer_select =3D 1, .plug =3D 1, .audit_skip =3D 1, .ioprio =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .async_size =3D sizeof(struct io_async_rw), .prep =3D io_prep_read, .issue =3D io_read, }, [IORING_OP_WRITE] =3D { @@ -262,11 +257,10 @@ const struct io_issue_def io_issue_defs[] =3D { .pollout =3D 1, .plug =3D 1, .audit_skip =3D 1, .ioprio =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .async_size =3D sizeof(struct io_async_rw), .prep =3D io_prep_write, .issue =3D io_write, }, [IORING_OP_FADVISE] =3D { @@ -421,11 +415,10 @@ const struct io_issue_def io_issue_defs[] =3D { [IORING_OP_URING_CMD] =3D { .buffer_select =3D 1, .needs_file =3D 1, .plug =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .async_size =3D sizeof(struct io_async_cmd), .prep =3D io_uring_cmd_prep, .issue =3D io_uring_cmd, }, [IORING_OP_SEND_ZC] =3D { @@ -554,11 +547,10 @@ const struct io_issue_def io_issue_defs[] =3D { .pollin =3D 1, .plug =3D 1, .audit_skip =3D 1, .ioprio =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .vectored =3D 1, .async_size =3D sizeof(struct io_async_rw), .prep =3D io_prep_readv_fixed, .issue =3D io_read, }, @@ -569,11 +561,10 @@ const struct io_issue_def io_issue_defs[] =3D { .pollout =3D 1, .plug =3D 1, .audit_skip =3D 1, .ioprio =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .vectored =3D 1, .async_size =3D sizeof(struct io_async_rw), .prep =3D io_prep_writev_fixed, .issue =3D io_write, }, @@ -591,11 +582,10 @@ const struct io_issue_def io_issue_defs[] =3D { [IORING_OP_URING_CMD128] =3D { .buffer_select =3D 1, .needs_file =3D 1, .plug =3D 1, .iopoll =3D 1, - .iopoll_queue =3D 1, .is_128 =3D 1, .async_size =3D sizeof(struct io_async_cmd), .prep =3D io_uring_cmd_prep, .issue =3D io_uring_cmd, }, diff --git a/io_uring/opdef.h b/io_uring/opdef.h index faf3955dce8b..667f981e63b0 100644 --- a/io_uring/opdef.h +++ b/io_uring/opdef.h @@ -23,12 +23,10 @@ struct io_issue_def { unsigned pollin : 1; unsigned pollout : 1; unsigned poll_exclusive : 1; /* skip auditing */ unsigned audit_skip : 1; - /* have to be put into the iopoll list */ - unsigned iopoll_queue : 1; /* vectored opcode, set if 1) vectored, and 2) handler needs to know */ unsigned vectored : 1; /* set to 1 if this opcode uses 128b sqes in a mixed sq */ unsigned is_128 : 1; =20 --=20 2.45.2