From nobody Thu Mar 19 05:28:10 2026 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C41EC34AB0D for ; Thu, 19 Feb 2026 16:27:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771518467; cv=none; b=Mcv5VokAxVpTAZihNKhtl9mjjiOJrHKNHQYV/dDhb0M6kqep0gAwHuVQ72hWlxHVVt85mswVIgGYksmAsxn3dYx5mmdhO+NHu7maiRKiNHvho4Ryf18b8oGh+Ecf0pC8Rl1S7tUwnIwY7v7pVsBOHFeVoa/qYffqFlgL1eOCr5c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771518467; c=relaxed/simple; bh=oz+04hEQM4d1rwxHpRDrO4zzKJ7Z7kOfi68mc4rkKH4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XZsN8TgBiH9zmibxTaskF4Tt0VBsTBXXifGCD5SqnGI6lR0DE1F5XNxFznOZyV0cd5Nq9lxEOHpwmxT3KiiIR2cImj6Y4VFhU8xXwL8CSCqjYSeCWxAzNqMpQpRtjSpl6X6/cgnO9Ypkmym5VY7HZCB3UlDAmJrwBlhdibyKk/M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=B/Jv8VL/; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="B/Jv8VL/" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43638a3330dso977217f8f.0 for ; Thu, 19 Feb 2026 08:27:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1771518464; x=1772123264; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D3kvNkKdoYfEDJexUIfvxiiZkFHsP2vDeB3pQYKUtGQ=; b=B/Jv8VL/HRvLxYIh43pm/Rt3euxp/y2j7Xatvd8U2OKcwAg9RKBasONpq+8Vc/FK6s ZPDCu1KAho46njkvU6zc2D6xHR5+fFhSonoeP3MmFbVd1OGKbPVQMxmgKA2oEOmu48ZH 48VDh1nIDYW1EEcroEYtIFH38dB/SpulkLWG77+oJJw48LGy5Kl7SLtfgB0d59CnqnKR z/9rRwoWcsKPjs8YV7yeIFiQLuEGZtJSbrBrYeV8mWGd98Zmjzpw854mteUGchWosPz8 2SwtYxq3Mfi7wwfpavKxXZYiiNxqim9WGOFRWlaIK1uX7+j/bRaNyFeCt0R+vLwUEUCM QiLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771518464; x=1772123264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=D3kvNkKdoYfEDJexUIfvxiiZkFHsP2vDeB3pQYKUtGQ=; b=L61DHvgP4uyZLsVGGkAcZNuHrMen+TQD0UekHb6V4tcnj4GP0/O9DCeNsS/HayxS1Y jWvLHCTn+WqeUqWbR31ZmFqBlXuziiw8EJo5cJBBYMV+zAR1v9kbx/PQmRFZ217IPWMH oc9oqB6xVxrt1Eev2G6Gu67Y8lSIQCnbbvD6T+UxBiN0e/PFlk3TSDtlpYX9/4m2R9F5 dFpCKBWqB0OboDQ5YKDPvEf2n7PJCFIkSutQZZGD+fLSLJf57yqaUgAqG2HruuXqHg5A 9p67jrlvZbiiVxFWUpyz5DtD0+kjRgTzzx52wmTe2qJwsoEGN59jIhlYYzPQatu9qzpp mm9Q== X-Forwarded-Encrypted: i=1; AJvYcCWwRmLL1gtVn01AOxWlv2VZEZFnTp42aY865lmdFDlqRBERdVrK2YO/tCK2BJJVrHJiztr2dnWZFGsR3Sw=@vger.kernel.org X-Gm-Message-State: AOJu0YzbddzVRcK4DSyLNKW59Pybbrm/TiNi/njwcqr4s0FOgtO2rw84 zmsCgjA/nBDKogt6wk25Fb12qStejhaiD8s4mnjeCu7U83fCa4wkdeiRBey1CAM0rvBcZYJo2Zo SZbEN X-Gm-Gg: AZuq6aJ+91flKSTcwwuWhNYiQ7n4jSq4fzn5T03Dq4VjF+nWr9CXgRK9YxlVd5E25wF 5LluOL7nMrOoXwy17gqnBegwuqA4WbK2n5C0PCOiu79mbeHYqFU9R3k65uknJ9kwreF+eZaP0QG 1PmrvpqryDP+HxhM79+NJZTRSPL9/1V7cdPL/PgZE2OFeIF8ISZ/7ePYAddkJ9n2B63DbjEbpZG w2BI3b1ANvtZQzOwTi3ccG4yRa65U1AewahhChei5Y0pte1Mg2diSOrOLq68jsf+bC8+WNcQ+WQ Y0VpHt7syh0otIKtHbGAWs3pjcwXzcdMnov10u+qO5GfW3aNYWilWGlr50rLQL6s5fCtiUtR9h7 A0l1mwU+rDeJZmim8YylNnFc5B1/5lIfiBn6jSNJbDd7aI2OaedLf1z4qpT9SCgfrDRJc9Bie/9 +SO353MwDOJ55dUdMuHXahVZVfjV/SQJvDwsDzyY/I2w35RrrRUX8= X-Received: by 2002:a05:6000:2f87:b0:435:a136:b8a2 with SMTP id ffacd0b85a97d-4379db7017cmr35432454f8f.28.1771518464029; Thu, 19 Feb 2026 08:27:44 -0800 (PST) Received: from zovi.suse.cz (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43796ac8075sm47324631f8f.29.2026.02.19.08.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 08:27:43 -0800 (PST) From: Petr Pavlu To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , Tom Zanussi , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Petr Pavlu Subject: [PATCH v3 2/5] tracing: Wake up poll waiters for hist files when removing an event Date: Thu, 19 Feb 2026 17:27:02 +0100 Message-ID: <20260219162737.314231-3-petr.pavlu@suse.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260219162737.314231-1-petr.pavlu@suse.com> References: <20260219162737.314231-1-petr.pavlu@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The event_hist_poll() function attempts to verify whether an event file is being removed, but this check may not occur or could be unnecessarily delayed. This happens because hist_poll_wakeup() is currently invoked only from event_hist_trigger() when a hist command is triggered. If the event file is being removed, no associated hist command will be triggered and a waiter will be woken up only after an unrelated hist command is triggered. Fix the issue by adding a call to hist_poll_wakeup() in remove_event_file_dir() after setting the EVENT_FILE_FL_FREED flag. This ensures that a task polling on a hist file is woken up and receives EPOLLERR. Fixes: 1bd13edbbed6 ("tracing/hist: Add poll(POLLIN) support on hist file") Signed-off-by: Petr Pavlu Acked-by: Masami Hiramatsu (Google) --- include/linux/trace_events.h | 5 +++++ kernel/trace/trace_events.c | 3 +++ 2 files changed, 8 insertions(+) diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h index 0a2b8229b999..37eb2f0f3dd8 100644 --- a/include/linux/trace_events.h +++ b/include/linux/trace_events.h @@ -683,6 +683,11 @@ static inline void hist_poll_wakeup(void) =20 #define hist_poll_wait(file, wait) \ poll_wait(file, &hist_poll_wq, wait) + +#else +static inline void hist_poll_wakeup(void) +{ +} #endif =20 #define __TRACE_EVENT_FLAGS(name, value) \ diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 61fe01dce7a6..b659653dc03a 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1311,6 +1311,9 @@ static void remove_event_file_dir(struct trace_event_= file *file) free_event_filter(file->filter); file->flags |=3D EVENT_FILE_FL_FREED; event_file_put(file); + + /* Wake up hist poll waiters to notice the EVENT_FILE_FL_FREED flag. */ + hist_poll_wakeup(); } =20 /* --=20 2.53.0