From nobody Sun Apr 5 13:04:38 2026 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E00E3451A9 for ; Thu, 19 Feb 2026 15:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771513414; cv=none; b=S2lMZCP3G4th735nAZJJl+BU9+t0cHDX8Ixv41GY7YIfHCiKnhqpGRZWGqeSD37E1HffeVPXQ/GCuX2epzo2HKCjkKTAp83nawPoo3JnbVry3aQ+gfgC2xMx8Po6uz8AL4ZZtJPIL6osi9WnTrzUryqpcPLlp2Ik8H9o33xAD1k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771513414; c=relaxed/simple; bh=PXpJDqJ0XKLx8AEYlCoqKcNyiX2KW5l+gr+E3jTZCo8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=sxG7VWZcFjGocjFb6HvnMfUhfjFQpcBDzLZrEu7Z6B71bTOW8UD2h57bg6JPsMuHPM7Q+Pqm0b6n3MZigxXBwY7jPlKIeLdfRO6SK4u9foMFujmeczu2YDdAZv/GJZ+5E+75LLUhMnHTm5GAzUiN2/lqcfqmlXw44BKrTiK0WZc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=sm6OpaPt; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--vdonnefort.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sm6OpaPt" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-48071615686so11156715e9.1 for ; Thu, 19 Feb 2026 07:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1771513412; x=1772118212; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=o0tMse5C0cVtD+YfhWwQcdctiKYpi7dPFiIDpWgHDos=; b=sm6OpaPt32GdB5J6hU66F8h/a6IXuOIBFKGdsAlMSkpWi4oQzrWvSQXPud63c8elGe P282vMU4hVnLxUCLQ10IPnR1zSszsTqU5IIaQLuqN0me8VJ+MTzMpdIX6awuaKYXfvJ0 PwByfdoZE/jcm9pv3ulu2EKT3gTD7xvHWrEup1FZjOaupp4n6alN+DgllcP5pEVBdRVr W8iFTc8v175hTbOcuOEYtxyT731t0ZmGhcmVQf4QmA1x50q601kl8ZxkI5qy2dFcTfgi q9fh1soF3BWHl1GnQmXMYLGR8zenitJvNNC6xv42Tx7uQJqOlxV/+oi+CBaJgs4sZO7u 6lTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771513412; x=1772118212; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=o0tMse5C0cVtD+YfhWwQcdctiKYpi7dPFiIDpWgHDos=; b=tVvWzLoMx+BrSD3hcdMcpRbR6QQ0Zjg6bUia76t1vSbf+Ink1s/nQlMBZ5B5HqXpAb NotUQZis92T1zsxG9q+4xRHZB2a6xb4hNshzTwzXhE8OQufy7hTaIusz1kKf3FETKYs+ miMENN3RWCcZWWgQ69+i0atV6RRdoHQC9FFrhxj3LeGj77NC9JhEvjlD1/PN03w7ER+i V7JRVvPmSoBAHcPGbkseskrweGxJv7Fc53pckGffPqO+1pvDRW6QxKYfwOQLaXp4IlYJ Mgj2x7CmUgud89/wOgjR/UtI5g0TyHEnAZXVm5shf7MfxulBImEONswx1dfjsK1zCYQq EjpA== X-Forwarded-Encrypted: i=1; AJvYcCXLamohSoUlCU+IGwCzJJvxV69HKfAz1nm7fVpWM843n/qy5RergrUziiVeqWli80YiGHSg/yx53t42l8A=@vger.kernel.org X-Gm-Message-State: AOJu0YwciMxIZiiGO9OQE28aFhnGHwC/6Mw6tVoBSkJIpIRaqoGXwWYV cnVX2d0Qn1HL0DhDkwzuR/pnCJI4Y9uY6My0hwI5mZFpVzWgBNpd00lrLEDGJvSVqBP9d86e9OA 8rgRjPGCXBivNNz+8u8LU9w== X-Received: from wmg8.prod.google.com ([2002:a05:600c:22c8:b0:47e:dc0c:276f]) (user=vdonnefort job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6290:b0:47e:e952:86ca with SMTP id 5b1f17b1804b1-48398a4287fmr89687085e9.2.1771513411495; Thu, 19 Feb 2026 07:03:31 -0800 (PST) Date: Thu, 19 Feb 2026 15:02:49 +0000 In-Reply-To: <20260219150307.14538-1-vdonnefort@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260219150307.14538-1-vdonnefort@google.com> X-Mailer: git-send-email 2.53.0.335.g19a08e0c02-goog Message-ID: <20260219150307.14538-13-vdonnefort@google.com> Subject: [PATCH v12 12/30] ring-buffer: Export buffer_data_page and macros From: Vincent Donnefort To: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-trace-kernel@vger.kernel.org, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, jstultz@google.com, qperret@google.com, will@kernel.org, aneesh.kumar@kernel.org, kernel-team@android.com, linux-kernel@vger.kernel.org, Vincent Donnefort Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for allowing the writing of ring-buffer compliant pages outside of ring_buffer.c, move buffer_data_page and timestamps encoding macros into the publicly available ring_buffer_types.h. Reviewed-by: Steven Rostedt (Google) Signed-off-by: Vincent Donnefort diff --git a/include/linux/ring_buffer_types.h b/include/linux/ring_buffer_= types.h new file mode 100644 index 000000000000..54577021a49d --- /dev/null +++ b/include/linux/ring_buffer_types.h @@ -0,0 +1,41 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _LINUX_RING_BUFFER_TYPES_H +#define _LINUX_RING_BUFFER_TYPES_H + +#include + +#define TS_SHIFT 27 +#define TS_MASK ((1ULL << TS_SHIFT) - 1) +#define TS_DELTA_TEST (~TS_MASK) + +/* + * We need to fit the time_stamp delta into 27 bits. + */ +static inline bool test_time_stamp(u64 delta) +{ + return !!(delta & TS_DELTA_TEST); +} + +#define BUF_PAGE_HDR_SIZE offsetof(struct buffer_data_page, data) + +#define RB_EVNT_HDR_SIZE (offsetof(struct ring_buffer_event, array)) +#define RB_ALIGNMENT 4U +#define RB_MAX_SMALL_DATA (RB_ALIGNMENT * RINGBUF_TYPE_DATA_TYPE_LEN_MAX) +#define RB_EVNT_MIN_SIZE 8U /* two 32bit words */ + +#ifndef CONFIG_HAVE_64BIT_ALIGNED_ACCESS +# define RB_FORCE_8BYTE_ALIGNMENT 0 +# define RB_ARCH_ALIGNMENT RB_ALIGNMENT +#else +# define RB_FORCE_8BYTE_ALIGNMENT 1 +# define RB_ARCH_ALIGNMENT 8U +#endif + +#define RB_ALIGN_DATA __aligned(RB_ARCH_ALIGNMENT) + +struct buffer_data_page { + u64 time_stamp; /* page time stamp */ + local_t commit; /* write committed index */ + unsigned char data[] RB_ALIGN_DATA; /* data of buffer page */ +}; +#endif diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c index 190a90816f02..e0cdf53fa643 100644 --- a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ -4,6 +4,7 @@ * * Copyright (C) 2008 Steven Rostedt */ +#include #include #include #include @@ -157,23 +158,6 @@ int ring_buffer_print_entry_header(struct trace_seq *s) /* Used for individual buffers (after the counter) */ #define RB_BUFFER_OFF (1 << 20) =20 -#define BUF_PAGE_HDR_SIZE offsetof(struct buffer_data_page, data) - -#define RB_EVNT_HDR_SIZE (offsetof(struct ring_buffer_event, array)) -#define RB_ALIGNMENT 4U -#define RB_MAX_SMALL_DATA (RB_ALIGNMENT * RINGBUF_TYPE_DATA_TYPE_LEN_MAX) -#define RB_EVNT_MIN_SIZE 8U /* two 32bit words */ - -#ifndef CONFIG_HAVE_64BIT_ALIGNED_ACCESS -# define RB_FORCE_8BYTE_ALIGNMENT 0 -# define RB_ARCH_ALIGNMENT RB_ALIGNMENT -#else -# define RB_FORCE_8BYTE_ALIGNMENT 1 -# define RB_ARCH_ALIGNMENT 8U -#endif - -#define RB_ALIGN_DATA __aligned(RB_ARCH_ALIGNMENT) - /* define RINGBUF_TYPE_DATA for 'case RINGBUF_TYPE_DATA:' */ #define RINGBUF_TYPE_DATA 0 ... RINGBUF_TYPE_DATA_TYPE_LEN_MAX =20 @@ -316,10 +300,6 @@ EXPORT_SYMBOL_GPL(ring_buffer_event_data); #define for_each_online_buffer_cpu(buffer, cpu) \ for_each_cpu_and(cpu, buffer->cpumask, cpu_online_mask) =20 -#define TS_SHIFT 27 -#define TS_MASK ((1ULL << TS_SHIFT) - 1) -#define TS_DELTA_TEST (~TS_MASK) - static u64 rb_event_time_stamp(struct ring_buffer_event *event) { u64 ts; @@ -338,12 +318,6 @@ static u64 rb_event_time_stamp(struct ring_buffer_even= t *event) =20 #define RB_MISSED_MASK (3 << 30) =20 -struct buffer_data_page { - u64 time_stamp; /* page time stamp */ - local_t commit; /* write committed index */ - unsigned char data[] RB_ALIGN_DATA; /* data of buffer page */ -}; - struct buffer_data_read_page { unsigned order; /* order of the page */ struct buffer_data_page *data; /* actual data, stored in this page */ @@ -437,14 +411,6 @@ static struct buffer_data_page *alloc_cpu_data(int cpu= , int order) return dpage; } =20 -/* - * We need to fit the time_stamp delta into 27 bits. - */ -static inline bool test_time_stamp(u64 delta) -{ - return !!(delta & TS_DELTA_TEST); -} - struct rb_irq_work { struct irq_work work; wait_queue_head_t waiters; --=20 2.53.0.335.g19a08e0c02-goog