From nobody Fri Apr 3 09:50:21 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E15224B45 for ; Thu, 19 Feb 2026 13:15:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771506944; cv=none; b=XATgerOC71fY6x5m70In0hxQQpWB6ihntmOr7OA2fFPqu2yMGDwyxh/DSOEq521Rf2MzLFUGt/Hm4Y56ES3ogFUuK6YPNoDR82Ib11IsbXzSUIgn8vn21YAPZp8t29AoJ88UICLR/lPbljVcRBNaJfUC4G/NbmuE1BkLjsx7lfk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771506944; c=relaxed/simple; bh=Yt/Qne72t7ZUyx9gmAiN9PIbOHzYWhjojDp2xGX8Qf4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cJKGBKhqxOpdVW9+hMK5ml6hcxkvt8UvV23SdLxB+txszCfG7rsCQUHEd9Ww4KSH0CnhCsoqEElROEDxp7CEo2RRY4VYxqga8ksfNwchoWSGjBU8UVbQa7rJLsVPLIwEN9bjrNqhBmRsE+cUPwHYsSudcKfDqyY+HYBOZdhgjzk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gj6ddKej; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gj6ddKej" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771506940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8d/gcwZgVClPwsFGUuCBPxWwtUzzW80Rcoy/zgCLPmA=; b=gj6ddKejVNU7euqdyVtHWP2TSeXYPO2NEOB37Q42BPIyQRaRf4uBgYQEXPsqhmaniCfhqU wdw+3vY94KJwkAjVJmQj+uc7n5n+9SLT1sXa6E7y/d4QXj9BAmPmV/qh9Fl6RF5oq+dflw wwA1lcUIzL+jDP0KeweKRtYuMVuZqqM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-517--NOQNMZJOUiwED6UfB8QYA-1; Thu, 19 Feb 2026 08:15:37 -0500 X-MC-Unique: -NOQNMZJOUiwED6UfB8QYA-1 X-Mimecast-MFC-AGG-ID: -NOQNMZJOUiwED6UfB8QYA_1771506935 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7443C1956070; Thu, 19 Feb 2026 13:15:35 +0000 (UTC) Received: from ShadowPeak.redhat.com (unknown [10.44.32.59]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 217DD1954111; Thu, 19 Feb 2026 13:15:30 +0000 (UTC) From: Petr Oros To: netdev@vger.kernel.org Cc: ivecera@redhat.com, Petr Oros , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Arkadiusz Kubalewski , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, piotr.kwapulinski@intel.com Subject: [PATCH iwl-net v2] ice: fix missing dpll notification for SW pins Date: Thu, 19 Feb 2026 14:15:00 +0100 Message-ID: <20260219131500.2271897-1-poros@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Content-Type: text/plain; charset="utf-8" ice_dpll_notify_changes() sends dpll_pin_change_ntf() only for the direct CGU input pin stored in d->active_input. Software-controlled pins (SMA/U.FL) are separate dpll_pin objects that wrap a backing CGU input, but they never receive a change notification. As a result, userspace consumers such as synce4l that monitor SMA pins via dpll netlink never learn when the pin state transitions (e.g. from SELECTABLE to CONNECTED), even though 'dpll pin show' reports the correct state on demand. When the active input changes, also send dpll_pin_change_ntf() for any registered SMA/U.FL input pin whose backing CGU input matches the old or new active input. v2: - Extract ice_dpll_sw_pin_needs_notify() helper for readability, - Move loop variable into for() scope. Fixes: 2dd5d03c77e2 ("ice: redesign dpll sma/u.fl pins control") Signed-off-by: Petr Oros --- drivers/net/ethernet/intel/ice/ice_dpll.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethern= et/intel/ice/ice_dpll.c index c2ad39bfe177db..2a505d924fcbae 100644 --- a/drivers/net/ethernet/intel/ice/ice_dpll.c +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c @@ -2468,8 +2468,18 @@ static u64 ice_generate_clock_id(struct ice_pf *pf) * * Once change detected appropriate event is submitted to the dpll subsyst= em. */ +static bool +ice_dpll_sw_pin_needs_notify(struct ice_dpll_pin *p, + struct dpll_pin *active, struct dpll_pin *old) +{ + return p->pin && + p->direction =3D=3D DPLL_PIN_DIRECTION_INPUT && + (p->input->pin =3D=3D active || p->input->pin =3D=3D old); +} + static void ice_dpll_notify_changes(struct ice_dpll *d) { + struct ice_dplls *dplls =3D &d->pf->dplls; bool pin_notified =3D false; =20 if (d->prev_dpll_state !=3D d->dpll_state) { @@ -2477,6 +2487,8 @@ static void ice_dpll_notify_changes(struct ice_dpll *= d) dpll_device_change_ntf(d->dpll); } if (d->prev_input !=3D d->active_input) { + struct dpll_pin *old =3D d->prev_input; + if (d->prev_input) dpll_pin_change_ntf(d->prev_input); d->prev_input =3D d->active_input; @@ -2484,6 +2496,14 @@ static void ice_dpll_notify_changes(struct ice_dpll = *d) dpll_pin_change_ntf(d->active_input); pin_notified =3D true; } + for (int i =3D 0; i < ICE_DPLL_PIN_SW_NUM; i++) { + if (ice_dpll_sw_pin_needs_notify(&dplls->sma[i], + d->active_input, old)) + dpll_pin_change_ntf(dplls->sma[i].pin); + if (ice_dpll_sw_pin_needs_notify(&dplls->ufl[i], + d->active_input, old)) + dpll_pin_change_ntf(dplls->ufl[i].pin); + } } if (d->prev_phase_offset !=3D d->phase_offset) { d->prev_phase_offset =3D d->phase_offset; --=20 2.52.0