From nobody Fri Apr 3 08:02:06 2026 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E63A52765E2 for ; Thu, 19 Feb 2026 05:19:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771478344; cv=none; b=C7MklcdOkHvfa0jxM6BoILsP0w4Bg03YjPx7HwAGmCNhCl1/pZ/N1n9rzgDOO4PmDH2rvi4D/ocsDHaPpPv4KtY/1glbmflJ8DWuCz8OBft71ka+FfLXB9A18LMYc/V8KbkCHOOKflvVBv4oLY6IWxyaMbbYCAF7zC3iz0lqUFA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771478344; c=relaxed/simple; bh=yAOLt5cp2yu+UqjPxG15UIW33I+iBd4PUKxTeXhmCn0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X2uOeG8JeXOOx8ClquG9/1o0V2YBx+DSHpXB+r328/c4WZ8ovFRkI5gWFdUEJ5lsEmVc1J/ASKkYSrPHVe2do4quTYkAghdYH7xxXiTuX4VzBbLHfxdvIqJWren1WuP6ILuIwwKTN4pa0/3x+O6LWZLyBdKiNht5j1u/f66VxUw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VnPevLt+; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VnPevLt+" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-794f701a3e6so5417767b3.2 for ; Wed, 18 Feb 2026 21:19:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771478341; x=1772083141; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=pZ250747q10WS5+8kR/YF5mfo58r2Yqv/yzlUt3P8g8=; b=VnPevLt+euKQl8t9GJAjsiKRukc4WiYNqYPJr8x/QLcMnQEOYyTkZ2+IafugoVfaa4 wIYL3i4OF2llB2kq90QcaG/buZoXsmIHeQJMJXSBI7i7kM9I+hmamJZ5Ca8oy7ZXPDzl IFjrJZF+Uu1160Phf898Aq7gKTuT20oeQ4IuI4t3NbcY8AiKev53k3DJgxEJDssjnUQ4 gtw6KWqrt8JmTgfgqPJ4xiscr11cQgUQT8WYQLfbM8t7OyPOQdueIJJSaqAoy2jl2GzO d3z/qj6NpT8OdcEeoU1GH8beygJgO6lEwVHvOq0DBqD8mH4MyOZWtAcmDpvDm6EGZV1n yzNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771478341; x=1772083141; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pZ250747q10WS5+8kR/YF5mfo58r2Yqv/yzlUt3P8g8=; b=aofUp1jntsIRoTI1IgT9WLEL6L8r1iDIgqKFgcuRb/ONjRFjjJXf1y7GCwccBw6CMr j/CUEQCYePC3JmxLmh8aqIQNFTa40I9ocfX0SAr/F261McwR4CV1NVNqNTXgBqpeizOA cS7Sb8X8y6yGUTS/XGwwtTsfihYnV9zQzuTcts1xdKLf8QCk3u+nswaM5Szdm/WK7adL VLF7vW1Rn9ae8in0gEg2/c4CDz9D6P/zG7yN0kltC1dA48Ew5Tgpj2h/TK3xlBr9iGi1 6aN9qG57cKDWs1mrwWxrNkrogctRJHKFckVgUAS5S8cuMKDFW0X4YCK1NC7V5oyPaVID QJbA== X-Forwarded-Encrypted: i=1; AJvYcCV18+jQrHR8OP+h243rbiChSpkIWWJJ/ONVO21o8mhzJWDubed7UefQnhNu5VoidfHRIqFDCQZDpuOyzyE=@vger.kernel.org X-Gm-Message-State: AOJu0YwKsFh8Zzc8rAUMekAlou6E9D8/FmGTFnR5oHz0N5IrfhSYQ4kb 9Md2te2Nr4MhMtu7PTK3ADOhmVcoF8TZ29aJHri9MyfOyGQajgwYO+a/sWlqIJwPa0Y= X-Gm-Gg: AZuq6aLMZo3AW88LaXWCF1WVEX6IgV4rDUoapHnNsiDPfIFkJgkBRxNez1FY5z5Q65p 2Ig2cz34Uu/QzVt98aYJ48scv0x7xvF1MeYSABDjoG8JS/LUrOAoS/wxz6pFBol0hpUluwvnMdN eH1dUZu8taMrT89KSOWWpjNUZbPsJsaFne8ETZhi29zRNA9Qicx5hh4JLDwocRtMATVdtYoKAj9 S+u7hjCJOcuE4I1i1EWIyx0CFmviQjpjvwayva+ROmzEvXJO5lhAhh2LUCYpsfvzBpBCwziPQLn hdj9A1xq8l6A/S3/kUE964o8MyDBtmaVrpr0HKB42xel2otz5UXG1N9069o4Lm1Cvdfgj3p9z4R G53TJ09oPOLmWqAeMD1OyEmJzD5QXEO8jTuNPSb9U12KPc7/HY/7lvow0gZZQ1+jLfUbMiqx1y2 Ajp62Ss+LdGlEcoFy/I8Mygjceyljpz694KBAVz3+083APM3+VlyYlD58x/BBcYegoGlkMF7mG8 IX+KKtIHPAspt5veYdu2MyfE6ClDgoDN5OltuqGpKE= X-Received: by 2002:a05:690c:87:b0:798:1f8:3acc with SMTP id 00721157ae682-79803c7a3ebmr14472327b3.33.1771478340743; Wed, 18 Feb 2026 21:19:00 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23f251sm131638257b3.24.2026.02.18.21.19.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 21:19:00 -0800 (PST) From: Ethan Tidmore To: Carlos Maiolino , NeilBrown Cc: Christian Brauner , Jeff Layton , Amir Goldstein , "Darrick J . Wong" , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore , stable@vger.kernel.org Subject: [PATCH v2] xfs: Fix error pointer dereference Date: Wed, 18 Feb 2026 23:18:41 -0600 Message-ID: <20260219051841.60999-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function try_lookup_noperm() can return an error pointer and is not checked for one. Add checks for error pointer and propagate it. Fixes: 73597e3e42b4 ("xfs: ensure dentry consistency when the orphanage ado= pts a file") Cc: # v6.16 Signed-off-by: Ethan Tidmore --- fs/xfs/scrub/orphanage.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/fs/xfs/scrub/orphanage.c b/fs/xfs/scrub/orphanage.c index 52a108f6d5f4..3269a0646e19 100644 --- a/fs/xfs/scrub/orphanage.c +++ b/fs/xfs/scrub/orphanage.c @@ -442,6 +442,9 @@ xrep_adoption_check_dcache( return 0; =20 d_child =3D try_lookup_noperm(&qname, d_orphanage); + if (IS_ERR(d_child)) + return PTR_ERR(d_child); + if (d_child) { trace_xrep_adoption_check_child(sc->mp, d_child); =20 @@ -464,7 +467,7 @@ xrep_adoption_check_dcache( * There should not be any positive entries for the name, since we've * maintained our lock on the orphanage directory. */ -static void +static int xrep_adoption_zap_dcache( struct xrep_adoption *adopt) { @@ -476,9 +479,12 @@ xrep_adoption_zap_dcache( /* Invalidate all dentries for the adoption name */ d_orphanage =3D d_find_alias(VFS_I(sc->orphanage)); if (!d_orphanage) - return; + return 0; =20 d_child =3D try_lookup_noperm(&qname, d_orphanage); + if (IS_ERR(d_child)) + return PTR_ERR(d_child); + while (d_child !=3D NULL) { trace_xrep_adoption_invalidate_child(sc->mp, d_child); =20 @@ -497,6 +503,8 @@ xrep_adoption_zap_dcache( d_invalidate(d_child); dput(d_child); } + + return 0; } =20 /* @@ -592,7 +600,10 @@ xrep_adoption_move( xfs_dir_update_hook(sc->orphanage, sc->ip, 1, adopt->xname); =20 /* Remove negative dentries from the lost+found's dcache */ - xrep_adoption_zap_dcache(adopt); + error =3D xrep_adoption_zap_dcache(adopt); + if (error) + return error; + return 0; } =20 --=20 2.53.0