From nobody Sun Apr 5 18:18:48 2026 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7D9026ED3F for ; Thu, 19 Feb 2026 02:29:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771468179; cv=none; b=arYmxl4pSInfnnFt3Rb7IeFgw3e/NKofv5kbNd2lqVFPNf8fnYNciJT0Id2j+M80ycfw9uIQVPL0c2nGi+tgskc7hBBJTVtdR5T49dyHB1ZPfW6MogXkMVjGofDLMeeVvR9EPni80VAaO5X7joyOZNv6tZJz6HzXlziTLrznULQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771468179; c=relaxed/simple; bh=2ptV1Xx56QfDBrLdYoSATcUoNP/8s/g1i+FnXCc7fjY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=llYFBMJJRxs656CCYthiU6engng7u0sDWQozepSBzQRuFYlXQ87Izcj32dlDZcCw4Z88AlhXdtSAvefnm8gFBuuV+QSta4TV85WIBxrzaoilkJbAOVTTR74q551jLoj1ah5ERYVHBb9WgiFDc2Ox37QQgYk9MsPPWxhpXelwrG8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TGgnh/Bo; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TGgnh/Bo" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-12721cd256bso463466c88.1 for ; Wed, 18 Feb 2026 18:29:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771468178; x=1772072978; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3VoJX5vAwTEOYnmz7o7D9xEfXbcGfOzpGSFIbfxsNUg=; b=TGgnh/Boe6QQ+iF+sZfeqDa9Wi4yFH1/5ElXDenkc7mwKG37f88y9geMJZXtsAEK19 b8HaQpzDuL9S4AEd7jmuWYeKLWElhJmXerEusM0ya1zkLhd+yxzWaewXK9+CRdelDtBe a4X/ivCm0IhyfuVxU78C0ZLgO1JT2WwPMOZcqKwbfCNz/B4sHVeSrHjZvfrSizHPnfZt Ub6Cu36wgSM0/sA6dsx43AdUN5OGh52nsFBLmXU00dVdc5xeKWFp0rJBHZLDt932ZoWM as9GuBhog2TyFF+7s84/HjheYU6VOx4eqs1RZRkQHT+LU976XMXKrmVlPSlOMakiUm8a QD4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771468178; x=1772072978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3VoJX5vAwTEOYnmz7o7D9xEfXbcGfOzpGSFIbfxsNUg=; b=QP0j1Tom3LwEfYozemIlfyy6VrdJXbRCKBJsLHlz7KiRVy7N9oHgQ7uP6oAISq5CE1 En5sMqPmdALPoZ3ff41ngm+eZBjS2Y88xlVadAiC+NMepY6Vd+1xmpHjqSAxFm3nPUZ/ awpZA5SpDbnx/ClFtAFh0z/5Oj2zaOeEkiMjxMrClh2TOVhIZwtakmg3uiFQAy8nvgh4 gCUad23MudwIxQpPbDzrpG8qru6OoasQDNVcxnCHppavc/t0PAiE4PBAo5pysUbdySZd JpBjLQeH0LeW6psgTCxHOTEwI3UM6YRlR2fh3X2LCzvB+pcc7oCPBR7SwYFcLHzMAjTP Ylow== X-Forwarded-Encrypted: i=1; AJvYcCVfOfw7axjHs5lyxA7PtsHP63yBjuHJtUVgycCFVVN83yY1PaInlbp7BwMvRSDzVyBFDD33MTDFyzZmqCg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzz2iYQSGRSrDOv0glkqw+1Nkj+bqfhMzbYhwQbN5OGOI1EFbJw q8CxWcCmNfIuDD0oj6Yc/ipKXbLHfd0/nIKH4Dw1sAa9jZylE47JI1oX X-Gm-Gg: AZuq6aKxp3nnQmrxUPpTRLFwC6E6esaV8/ifOzidks1qcb0zyn9XYcnSL8W4SL3uXga kCUUYiK5ghNq8XS2L+ESuRyROPSNo6iqXg2jgqtKOOfe/SLYkiSegeO6qBVdf2XHDO9yz6McJPS /S7/m2jiaggTd57EQm10q+y8y4wKD3u3d+SVHkNAqg8Na/srOh5lXX/7xZbatxm1V7g3WUTsEkG yFqRUJP2+2UbjztePa8QU1Og9eGCqr/oE/DselxpMAYoXZsdc93Ux2F55zHrlYcQkzIkOyL+I5t jvprze93PQ0SbrvStKfnfPyo6oiTMQ25uBWnzR58uBjBI+A0Ujg6Ro3TJ+tjZM6OJV8FW/5/sl/ QLdRmWC9HQ7fjFr4CiLqlZTNoCh0ed76DuIGgdlbBK1fXIBq++zajvhqkea8PjGugb/aaJ7e3dG jYys3BRIOMQ/0FzPdFr9xProHGz75w4Fn2wBBw227iwSU+kv3rQw4bLHRpPTTDORNnGqDkvSJRN js0U2FKG3sc+ew= X-Received: by 2002:a05:7022:160a:b0:11a:2f10:fa46 with SMTP id a92af1059eb24-12741ae3323mr7734818c88.0.1771468177903; Wed, 18 Feb 2026 18:29:37 -0800 (PST) Received: from dtor-ws.sjc.corp.google.com ([2a00:79e0:2ebe:8:265b:f5ad:9e03:677e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2bacb577bcasm19609433eec.12.2026.02.18.18.29.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 18:29:37 -0800 (PST) From: Dmitry Torokhov To: Jonathan Cameron Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Subject: [PATCH v2 2/4] iio: adc: ti-ads7950: do not clobber gpio state in ti_ads7950_get() Date: Wed, 18 Feb 2026 18:29:26 -0800 Message-ID: <20260219022929.3558081-3-dmitry.torokhov@gmail.com> X-Mailer: git-send-email 2.53.0.335.g19a08e0c02-goog In-Reply-To: <20260219022929.3558081-1-dmitry.torokhov@gmail.com> References: <20260219022929.3558081-1-dmitry.torokhov@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" GPIO state was inadvertently overwritten by the result of sip_sync, reuniting in ti_ads7950_get() only returning 0 as gpio state (or error). Fix this by introducing a separate variable to hold the state. Reported-by: David Lechner Signed-off-by: Dmitry Torokhov --- drivers/iio/adc/ti-ads7950.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c index b8cc39fc39fb..2a7d4a1d9fa9 100644 --- a/drivers/iio/adc/ti-ads7950.c +++ b/drivers/iio/adc/ti-ads7950.c @@ -427,13 +427,14 @@ static int ti_ads7950_set(struct gpio_chip *chip, uns= igned int offset, static int ti_ads7950_get(struct gpio_chip *chip, unsigned int offset) { struct ti_ads7950_state *st =3D gpiochip_get_data(chip); - int ret; + int ret =3D 0; + bool state; =20 mutex_lock(&st->slock); =20 /* If set as output, return the output */ if (st->gpio_cmd_settings_bitmask & BIT(offset)) { - ret =3D (st->cmd_settings_bitmask & BIT(offset)) ? 1 : 0; + state =3D st->cmd_settings_bitmask & BIT(offset); goto out; } =20 @@ -444,7 +445,7 @@ static int ti_ads7950_get(struct gpio_chip *chip, unsig= ned int offset) if (ret) goto out; =20 - ret =3D ((st->single_rx >> 12) & BIT(offset)) ? 1 : 0; + state =3D (st->single_rx >> 12) & BIT(offset); =20 /* Revert back to original settings */ st->cmd_settings_bitmask &=3D ~TI_ADS7950_CR_GPIO_DATA; @@ -456,7 +457,7 @@ static int ti_ads7950_get(struct gpio_chip *chip, unsig= ned int offset) out: mutex_unlock(&st->slock); =20 - return ret; + return ret ?: state; } =20 static int ti_ads7950_get_direction(struct gpio_chip *chip, --=20 2.53.0.335.g19a08e0c02-goog