From nobody Sun Apr 5 16:27:57 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8991620C038 for ; Thu, 19 Feb 2026 01:03:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771463011; cv=none; b=DIudTHLe/ASGGdYbaVJOCewfZROg0cUQ1a0CACclbdij/E0i8NW1N57v8pxcnCoue6YGPHWELVmG/wUrcI4G0epPpmwkIrJQtj5UCz5eeTa03xBU2Ihws3+fLUSoEa6KFwV2n79woRqPucQpIUWuAVIWZNaVQxCPXiu1xyi1BFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771463011; c=relaxed/simple; bh=vsZtMHQ2ASJbwf0j2AAZePs7hvtaVUKaCCz26HKPPXo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hd17lTO4q4TBcpk3BSMO+VwvGsyhidgFrRJw1XaJ3MnuNMxFhki5XrP7dlzJrzfKKeJ9jdsIrH4DFb46wk0ep+ac2mX4lowA5aevXjcDi0G9KZWupFxX3onwnl6BhwoCmJ5DbvcbWvVGW+X8eKoqTtW6yt+AbjmC7Bvax5fCyMk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X3dhIWfC; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X3dhIWfC" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c6e1e748dc1so432809a12.1 for ; Wed, 18 Feb 2026 17:03:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771463010; x=1772067810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3Enxu4ND3YVzsEgyqJuOJ+YNy17cYtrsF6BFeskG1YA=; b=X3dhIWfCI1El/GaoKZITD057z1zO3g+yu4ajIuFY+IL1Ylm1EetIB/4FaSeEANQZ6a Mvm2qOKRT+6Jes43vYoFlA4g5bqS8EK9c0Wg7lUO7lfhEBSY7jNoUP0zjltA91xnRhi8 emJiIF6AExqaMuwWw/pcNCjalg75SjILQbUJXO1YZWF1jIdXM6DbazrWOzJRtGmqHqfx 5MUky87g+tndsi8epDlhP/sE7XK8rKSTxq4nDXl6e1PEg4zjPiN9is0yZhy/rWd4wDHN B0k/fZ+DV1mnn38zti5vVjkuzXBvpKuZ1UAoLvdDtWfgfXpEY3lj68ykdsfBXJtG6o4z fiHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771463010; x=1772067810; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3Enxu4ND3YVzsEgyqJuOJ+YNy17cYtrsF6BFeskG1YA=; b=lVMOG/H/2H71fGvR/PcLsn723DsD4GvS+BzPMUI8PzzwaAX0wIvdmSMXCNR1Dgb2s5 Q8vbTShiv+FlIEr/OC3t+w3CBVY4cYw6OsHikSyV3SzsoQlx7jxZ5JOvcjPeKIq1eAXE m3n1YhvFod5R+sQjeEcX38Pwj+yAt7aU9N+N3RZVZXa6I/1KPv0pby1xK6Z9eYXL5HJv x2JSetLiRnvyjLDUrswubwHWhICHwiOZzaohcMz2ZS+3edBVx5eamqHb7CPaLbUbNDgG UBb9dT5ozMnblX+R2AXTENyTinkMLwS+njjpJWNlYSooZZbPIwZTBzA4+JR13qnaGrqn UhYw== X-Forwarded-Encrypted: i=1; AJvYcCUiUsVM7yQTfgImLiqR+N0KuHVaZYgRWVo2hpd7mRz2y0JPIih3OxLNyWK9FN2LCxrCdEEHpZYY+cimojI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyou8NholHP5o812dng2CQxWyctDh77oouJlpDzLs+E/6imAyJb bGpl5up7MJuZT4pfKB7HokfQq1uEpamtFmnd5sPF7/5XY0+gW/H67AUx X-Gm-Gg: AZuq6aIpfdpxxuS61L1fcvnz+3xM/0aNJDK4xpFNo1JVcBulWF9nWgC4nX6kbH+VMXx IPPArrLwXc8+mzqQCT8UsGvoKoIIumolF51fWy5GnYna7u7yp1NdiSh2Y+y2yho6DFxW2arooes z5NsrYnt+niLf2jPL2O934ReffNeIBLKBqQM2C66cMqe9zVIYETFIDn48mBPZVyIjt9Mdd5y9Ei kUyXRmWQmaFb3DVSJBzXOmTn4iDfyC8kIhMFcwvFspGYr5yIDasWGIUuZz0OiSWMco9GJ0gB5DR CKCL1CMPUiNbA2xm2NPDaHUBo+admMT5dXrkMhVK31nr7uMuFCqsIEjQIPtHS/ZLu3ChYXvAkBg Co4ZoxNnas+KVCaq+zQ+qx75NkLl0c8aFbxJNIzquzR9pmnRl+FlNM05jEsVjN615Ed+6iwjH7u dPWV+kRvATCQkgTd1zU5uJXMUhum0RArR8NgE= X-Received: by 2002:a17:903:2bcb:b0:2aa:e3d1:1430 with SMTP id d9443c01a7336-2ad5f970533mr763625ad.23.1771463009884; Wed, 18 Feb 2026 17:03:29 -0800 (PST) Received: from arch ([2409:40c2:5404:5d47:7f61:3625:f2fb:6df4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1aadca84sm144265035ad.70.2026.02.18.17.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 17:03:29 -0800 (PST) From: bhargav To: lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, rougueprince47@gmail.com Subject: [PATCH] iio:frequency:ad9523:convert symbolic permissions to octal and remove unwanted arguments in macro Date: Thu, 19 Feb 2026 06:32:44 +0530 Message-ID: <20260219010244.191668-1-rougueprince47@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" this fixes following warnings in checkpatch WARNING: Argument 'x' is not used in function-like macro WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using o= ctal permissions '0444'. WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using o= ctal permissions '0200'. WARNING: Avoid multiple line dereference - prefer 'pdata->pll1_charge_pump_= current_nA' WARNING: Avoid multiple line dereference - prefer 'pdata->pll2_charge_pump_= current_nA' Signed-off-by: bhargav --- drivers/iio/frequency/ad9523.c | 38 ++++++++++++++++------------------ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c index 63c485e9e44c..a445b775191b 100644 --- a/drivers/iio/frequency/ad9523.c +++ b/drivers/iio/frequency/ad9523.c @@ -167,9 +167,9 @@ =20 /* AD9523_CHANNEL_CLOCK_DIST */ #define AD9523_CLK_DIST_DIV_PHASE(x) (((x) & 0x3F) << 18) -#define AD9523_CLK_DIST_DIV_PHASE_REV(x) ((ret >> 18) & 0x3F) +#define AD9523_CLK_DIST_DIV_PHASE_REV ((ret >> 18) & 0x3F) #define AD9523_CLK_DIST_DIV(x) ((((x) - 1) & 0x3FF) << 8) -#define AD9523_CLK_DIST_DIV_REV(x) (((ret >> 8) & 0x3FF) + 1) +#define AD9523_CLK_DIST_DIV_REV (((ret >> 8) & 0x3FF) + 1) #define AD9523_CLK_DIST_INV_DIV_OUTPUT_EN (1 << 7) #define AD9523_CLK_DIST_IGNORE_SYNC_EN (1 << 6) #define AD9523_CLK_DIST_PWR_DOWN_EN (1 << 5) @@ -558,52 +558,52 @@ static ssize_t ad9523_show(struct device *dev, return ret; } =20 -static IIO_DEVICE_ATTR(pll1_locked, S_IRUGO, +static IIO_DEVICE_ATTR(pll1_locked, 0444, ad9523_show, NULL, AD9523_STAT_PLL1_LD); =20 -static IIO_DEVICE_ATTR(pll2_locked, S_IRUGO, +static IIO_DEVICE_ATTR(pll2_locked, 0444, ad9523_show, NULL, AD9523_STAT_PLL2_LD); =20 -static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, 0444, ad9523_show, NULL, AD9523_STAT_REFA); =20 -static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, 0444, ad9523_show, NULL, AD9523_STAT_REFB); =20 -static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, 0444, ad9523_show, NULL, AD9523_STAT_REF_TEST); =20 -static IIO_DEVICE_ATTR(vcxo_clk_present, S_IRUGO, +static IIO_DEVICE_ATTR(vcxo_clk_present, 0444, ad9523_show, NULL, AD9523_STAT_VCXO); =20 -static IIO_DEVICE_ATTR(pll2_feedback_clk_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll2_feedback_clk_present, 0444, ad9523_show, NULL, AD9523_STAT_PLL2_FB_CLK); =20 -static IIO_DEVICE_ATTR(pll2_reference_clk_present, S_IRUGO, +static IIO_DEVICE_ATTR(pll2_reference_clk_present, 0444, ad9523_show, NULL, AD9523_STAT_PLL2_REF_CLK); =20 -static IIO_DEVICE_ATTR(sync_dividers, S_IWUSR, +static IIO_DEVICE_ATTR(sync_dividers, 0200, NULL, ad9523_store, AD9523_SYNC); =20 -static IIO_DEVICE_ATTR(store_eeprom, S_IWUSR, +static IIO_DEVICE_ATTR(store_eeprom, 0200, NULL, ad9523_store, AD9523_EEPROM); @@ -649,11 +649,11 @@ static int ad9523_read_raw(struct iio_dev *indio_dev, return IIO_VAL_INT; case IIO_CHAN_INFO_FREQUENCY: *val =3D st->vco_out_freq[st->vco_out_map[chan->channel]] / - AD9523_CLK_DIST_DIV_REV(ret); + AD9523_CLK_DIST_DIV_REV; return IIO_VAL_INT; case IIO_CHAN_INFO_PHASE: - code =3D (AD9523_CLK_DIST_DIV_PHASE_REV(ret) * 3141592) / - AD9523_CLK_DIST_DIV_REV(ret); + code =3D (AD9523_CLK_DIST_DIV_PHASE_REV * 3141592) / + AD9523_CLK_DIST_DIV_REV; *val =3D code / 1000000; *val2 =3D code % 1000000; return IIO_VAL_INT_PLUS_MICRO; @@ -701,7 +701,7 @@ static int ad9523_write_raw(struct iio_dev *indio_dev, break; case IIO_CHAN_INFO_PHASE: code =3D val * 1000000 + val2 % 1000000; - tmp =3D (code * AD9523_CLK_DIST_DIV_REV(ret)) / 3141592; + tmp =3D (code * AD9523_CLK_DIST_DIV_REV) / 3141592; tmp =3D clamp(tmp, 0, 63); reg &=3D ~AD9523_CLK_DIST_DIV_PHASE(~0); reg |=3D AD9523_CLK_DIST_DIV_PHASE(tmp); @@ -797,8 +797,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) return ret; =20 ret =3D ad9523_write(indio_dev, AD9523_PLL1_CHARGE_PUMP_CTRL, - AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata-> - pll1_charge_pump_current_nA) | + AD9523_PLL1_CHARGE_PUMP_CURRENT_nA(pdata->pll1_charge_pump_current_nA) | AD9523_PLL1_CHARGE_PUMP_MODE_NORMAL | AD9523_PLL1_BACKLASH_PW_MIN); if (ret < 0) @@ -842,8 +841,7 @@ static int ad9523_setup(struct iio_dev *indio_dev) */ =20 ret =3D ad9523_write(indio_dev, AD9523_PLL2_CHARGE_PUMP, - AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata-> - pll2_charge_pump_current_nA)); + AD9523_PLL2_CHARGE_PUMP_CURRENT_nA(pdata->pll2_charge_pump_current_nA)); if (ret < 0) return ret; =20 --=20 2.53.0