From nobody Sun Apr 5 16:34:16 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72B602F3632 for ; Thu, 19 Feb 2026 11:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771499521; cv=none; b=JpWyq7KDSClCTpEXhkOcQikbTNid9SrxV1ZLFYTmE522ZrgxNXK/IeCDOWas+lbjQYCcUvSKP5Valw0z67KdLEYCccVNiJGdG3qbv4pc6dn33LpTDswc5LvUVBqlzBysYKdKBz0peZllUjw+ojlmN4ht1Hcpwf3/elUPbdgWwB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771499521; c=relaxed/simple; bh=zbxY9b0ZlCq0UrOIJd6sjF+e77WKY8qgVD84bS+Ct8g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=EUpikfeh+1qFXO51p9au/5DRp4Ysv3ul3oJ54Z47oHc+luA45uLia1Igghq3lnLbfCZ2RPuQTnPiUXZ1UXjjWgKjEQ2hnBQNy28+hGtSK1T+10KCJ0ae9I8l7H+x2IN4nO01MRyGgtqcJEyF0FMETd4gS5rMFvJup+fEflHKNXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Aqpv5oaU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NOZBjilY; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Aqpv5oaU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NOZBjilY" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61J1Exa0160255 for ; Thu, 19 Feb 2026 11:11:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=vOvNdYCVSmVkwGXEsNxSmL jxoujgZy923FLHo8wDNN8=; b=Aqpv5oaUyjdHA8YT96METkbU8yj35aopI7zRw6 jBkftnIdd1qZnD2+IlgvxoDfcA1BPPcuyCHVfIz/WIRaXP+s0uECHK380CWhy0Z9 Rx542b8z54/9SbbNEqO1pQqegi0owcFVoUXfB7W+a2nFwWqNP0HtYs4DF+02FdUB J3DDy99883M9ebjyJ76dEgjTVcep+rG+y6fFaqYlsELBn//ztKHH2mM6TP2clCrq DBNAKB94Y9WxcFmllRnZUrgcRH3vbId7u9EAiSwF0L0oizA4NR4NL3MOAjurxzSs 8Q+nm35AFNS5DDlOUkIeibl3wezeD/r6a3ZvIvncrZjzUiYA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cdrpg975e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Feb 2026 11:11:59 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8c711251ac5so532648385a.1 for ; Thu, 19 Feb 2026 03:11:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771499519; x=1772104319; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=vOvNdYCVSmVkwGXEsNxSmLjxoujgZy923FLHo8wDNN8=; b=NOZBjilYX87nyoEA4XTcscDaNuGrsRNqtof71r+4JLwOD3DvTOsIQmSKL/R5qpItSJ BMenyfDp1QZCfEoPP9Himy8OjtH0DT6Q3lS1JFU4Vg4hCODSaF+q3uqijqHXoIaEPVdD uofFwk4AdVb6XJfE7U4mjoJGictPMpNVtyoFPpFu90jkGQShMdatYyAat4lW7WzVACoR zSS2/bvQOkZQ8i7yj8JV/ZvssK7/b0a7gZFCjJH6oO3LvIpmARYqujz6FhKV4D62A/OX DdDBUk+YjZi8HdUwdzFASuWoc7dMVEPSy8NEAu/2EbdtiT+M/+2cJbfhBzMbGhbfiqwr pP5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771499519; x=1772104319; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vOvNdYCVSmVkwGXEsNxSmLjxoujgZy923FLHo8wDNN8=; b=qJ4w/Y+8YiGYYLzPbAbBCiql6JrjUhWmIHfKs/5PXuEQTVbIILbTWJlrLc/S3+Xsg7 T+4g9Bry7ztcURrUgP9cU+aYbj/X0xwa71KmfvD8sfl/sGEnMMcKjrjkeG0sL37KsaQK uJmX7hsmQQAq6iPNj1SWExM3dOZcz2+0xIy6gxJtRnhKRftnqvuFhxDgPmkc4ACfpH+w +E+GIAhBUeA0IxFxsO2+evoKyVmR4706SNuorCyVCUPTrFynSmaqG8R8BnR0vAVsj7rq azokol5FN4OPO1IDjK4ddNC0hHqik2MdUMv4THFedYsVMcyPkHNvdvRAXgklo/Q4xNj9 lieg== X-Forwarded-Encrypted: i=1; AJvYcCU/4WelmrvjSSXVokzeMhSbdoX5bF/YRqlOY/mg0MpucPIeCVpq+idepVfe8YykA821KqDTsqNqDQ5kplY=@vger.kernel.org X-Gm-Message-State: AOJu0YzsEAZ2ebzNp0WWKBXLaXHQVwMWVp+mftP8A7YNW97rZ6ymUFT2 LkOaePO3dIY/Mr+X9f5OhfsdKtXFBzs+xKWd4us5bicozGcoAN82iMIh3SZjybkq0oN5bf5l2BF +EsMvSrYj00KX0tqggJ4KAV8gJUY0SebzBrOn7GmPKWdw3G3jvCvNyaI0ANeVWKyyTBdjD+4kwr Q= X-Gm-Gg: AZuq6aIsgBfq/L1G8m2p0bkwSIALBsirjXcdPPahvFRVJbz3X6fhTqnSbcr4URVC+Wk /56PcneOzFyJ6uNabBV3saOgUg8llHefIE1/B4+1JnYPjtpklpdAp2QhGiZ2m54uHYBa4CtOJjh xPJyBBmRmlCLxhTRFmFTBVdzpnovVDrjXwr8z8xoVefmEN4bOIVuL9ma6VEGEBrS6uuCYslLNim jV6/UqHH3SQmu3SZs8lTZZmKUhGqlQ84iMsvOcma4CveDf190T5KTqzgbtEasnMgLV1KwcVleO/ YWxLju+tWV3QkpmmINlpkzDx0Js/X8yfzLbpHYode8wCo/ertNv6JwxRj9s/r80mbld787WNtRj EKZ7YhFjxYcitxryM48SL8Czqmp9m/w== X-Received: by 2002:a05:620a:8bc1:b0:8cb:47b4:165f with SMTP id af79cd13be357-8cb47b4235amr1650125485a.14.1771499518416; Thu, 19 Feb 2026 03:11:58 -0800 (PST) X-Received: by 2002:a05:620a:8bc1:b0:8cb:47b4:165f with SMTP id af79cd13be357-8cb47b4235amr1650122485a.14.1771499517898; Thu, 19 Feb 2026 03:11:57 -0800 (PST) Received: from hackbox.lan ([86.121.162.109]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835d92267bsm1003935615e9.0.2026.02.19.03.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Feb 2026 03:11:57 -0800 (PST) From: Abel Vesa Date: Thu, 19 Feb 2026 13:11:48 +0200 Subject: [PATCH] phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260219-phy-qcom-qmp-ufs-fix-sm8650-pcs-g4-table-v1-1-f136505b57f6@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAPPvlmkC/yXNywqDMBCF4VeRWXcgCVW0r1K6yGWiKY3GjBZFf Pem7fKDw38OYMqBGG7VAZnegcM0FshLBXbQY08YXDEooRqhZIdp2HG2U8Q5Jlw9ow8bcmybWmC yjP0VF21ehJ2T2nlZi9YbKLmUqUx/V/fH37yaJ9nl24fz/AAhDg4CjAAAAA== X-Change-ID: 20260219-phy-qcom-qmp-ufs-fix-sm8650-pcs-g4-table-9d1adf1508fb To: Vinod Koul , Neil Armstrong , Konrad Dybcio Cc: Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Nitin Rawat , Abel Vesa X-Mailer: b4 0.15-dev-47773 X-Developer-Signature: v=1; a=openpgp-sha256; l=2491; i=abel.vesa@oss.qualcomm.com; h=from:subject:message-id; bh=zbxY9b0ZlCq0UrOIJd6sjF+e77WKY8qgVD84bS+Ct8g=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBplu/2nLEANE/+RGxkee6qF82zBRu6o+t4/dBv9 RHpgPiujVWJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCaZbv9gAKCRAbX0TJAJUV VikkD/9vK/KxNfCrXsqpjHZTVapOxrnG7w0vh7H64jya46zwEV8JS2fwNSqFZf8Xr4ulsRCeHcU 7Ij8VIKnDJmf22Pggu+h2avvL56D6hm1c5r1IJl9Hqy33Qq+uMORKJKMTJbyBb18gfrGmz+7oTh IAt/IQfK7TfVERp1KX92Q1vt0C58d0+icEYiQyYA1qsXuodRTY5zlwzUUmhAtvehLGdAkq8Ydo1 zGQ0bfxLTQ5A13k3+ahnMmOtpZdCXGnzRBaBVULQnoILyXz/1jFYOMyneBviuSN9HHgjllKR2ek yZ+Kej6CvnU4hnLohsgpDp5ujsinjsnZlnPHi3/lbYXrqFUDmaTDKb543ktDEM5dyNNdbQVDR/+ GCbWDc+/eITAkGO4nm74mhjl6NZcCNJRjOZjCQ2Dak9KazU6+mGjbfj25XAzdnrtZSE91w1w676 FGq5a03pDVnaGQ5IzyovPVn7h8uU2g2iKRvYvMBuY3gz7mVxGH0oMbkxdZi9Ebrqry5LYnVYaF2 DDnUM2cXdT1aCehliJJJvlygkAbEKXOYiT1pchk1XYI6qN36lc03vYNf5cpMM5CqnKZPO1aKyaP YUZZiML8f4ct+7ci6nkvQs5Kr/4oxILREuGC+U/J4q3wl6s/UZeflPzX8H0UK2IwNkfeymPDpw9 D91A7D4UkxxAS/A== X-Developer-Key: i=abel.vesa@oss.qualcomm.com; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-Proofpoint-GUID: OeqhCiIZkg2mFvJUxH-f_5zfh2CiJe_w X-Authority-Analysis: v=2.4 cv=JrL8bc4C c=1 sm=1 tr=0 ts=6996efff cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=oauzzCmhM186DRC0Y2yWPg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=iZjorvmLyqBVRiOuJXwA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE5MDEwMiBTYWx0ZWRfX3c8SMbXkxVPC 1l+hpgi9n3DmpnMRj7r0q1qJxLdP0zSep50oN46uUNu/Ml8g944tO93SsozEpWjx+KY03sh6zyZ zStJ/kSujRouX9ERxjE5VghE/rOrAzmViH8QXwl+nEVHZXFkDvrlWC0c4qjsSA75g0vwJZJ7k6Z nIoTBfUQol4bz9QGxo3mmiEeQG9MUEF2fLxQ7wiDxDnIPeAqNMCNhfMEISklOcsYExddsX/rDUf cAtHWWpp5XUh4RrcsS831n2IBzmVhzVJ0bCoX6pV156mphdLrGwcZKJ7d7hzMp0NrOd5DPGgNrX 7qFQSx31EcD96X2c5vS0X0sVEVW2EjFZwVQqd93zeE120eWVDO6mM2gwe18sgZHkX175G3IqAj8 7x882n2PqQ4xqrLgqS7MNwtl6K48cj1qNqOHiBnBPNGgxSp0IyU9qgTdn/Rp8qdmJgkN3mtQGiV 5c+fB+8KBKfVUl9T1iA== X-Proofpoint-ORIG-GUID: OeqhCiIZkg2mFvJUxH-f_5zfh2CiJe_w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-19_03,2026-02-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602190102 According to internal documentation, on SM8650, when the PHY is configured in Gear 4, the QPHY_V6_PCS_UFS_PLL_CNTL register needs to have the same value as for Gear 5. At the moment, there is no board that comes with a UFS 3.x device, so this issue doesn't show up, but with the new Eliza SoC, which uses the same init sequence as SM8650, on the MTP board, the link startup fails with the current Gear 4 PCS table. So fix that by moving the entry into the PCS generic table instead, while keeping the value from Gear 5 configuration. Cc: stable@vger.kernel.org # v6.10 Fixes: b9251e64a96f ("phy: qcom: qmp-ufs: update SM8650 tables for Gear 4 &= 5") Suggested-by: Nitin Rawat Signed-off-by: Abel Vesa Reviewed-by: Konrad Dybcio Reviewed-by: Neil Armstrong Tested-by: Neil Armstrong # on SM8650-HDK --- drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm= /phy-qcom-qmp-ufs.c index df138a5442eb..771bc7c2ab50 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c @@ -990,6 +990,7 @@ static const struct qmp_phy_init_tbl sm8650_ufsphy_pcs[= ] =3D { QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_MULTI_LANE_CTRL1, 0x02), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_MID_TERM_CTRL1, 0x43), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PCS_CTRL1, 0xc1), + QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PLL_CNTL, 0x33), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_LARGE_AMP_DRV_LVL, 0x0f), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_SIGDET_CTRL2, 0x68), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_POST_EMP_LVL_S4, 0x0e), @@ -999,13 +1000,11 @@ static const struct qmp_phy_init_tbl sm8650_ufsphy_p= cs[] =3D { }; =20 static const struct qmp_phy_init_tbl sm8650_ufsphy_g4_pcs[] =3D { - QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PLL_CNTL, 0x13), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_HSGEAR_CAPABILITY, 0x04), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_HSGEAR_CAPABILITY, 0x04), }; =20 static const struct qmp_phy_init_tbl sm8650_ufsphy_g5_pcs[] =3D { - QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_PLL_CNTL, 0x33), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_TX_HSGEAR_CAPABILITY, 0x05), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_HSGEAR_CAPABILITY, 0x05), QMP_PHY_INIT_CFG(QPHY_V6_PCS_UFS_RX_HS_G5_SYNC_LENGTH_CAPABILITY, 0x4d), --- base-commit: 50f68cc7be0a2cbf54d8f6aaf17df32fb01acc3f change-id: 20260219-phy-qcom-qmp-ufs-fix-sm8650-pcs-g4-table-9d1adf1508fb Best regards, -- =20 Abel Vesa