From nobody Fri Apr 3 08:09:57 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C676F30AACF for ; Wed, 18 Feb 2026 16:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771433490; cv=none; b=Q1Mh4pOV2Qb2CXhNuUIdsu7d5S1i+q4cXR514VPe1tl+Zz6/4g1OA5Ff+6ewyNBgsZGRBZ99A9PX37HdTszxhwyla3heSrZ8VYvHE5KX/ESJv6CfBevsLIe32NwSjCvIYDCtS3cFPi/mOleVgHs9tbRJ8RfoKPoZjr0LJgxeHgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771433490; c=relaxed/simple; bh=T+ddj9uth8B1FutWkYbruKcbeWNS950unthpcpOU8Mc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=poG+cqiKhwbb8ubld7nxA/3gLA9s1SaaQGFWJz54m0JE/AhlXfAHApobm5hqBv+uvT2V9o4nQdmjzoLGSJXbVPZ6KNgE09+eiK6odDYaVF6bNZqA5nNDXoXxQ1VaOGoLhFC7jTocLvdGgDJ7E2TuKj+ygLBmI/siCwYyKBRkGM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gjg2CntO; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gjg2CntO" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a8a7269547so48624665ad.0 for ; Wed, 18 Feb 2026 08:51:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771433489; x=1772038289; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=uxHzVkbJVuUf9PPiRw/JbF+frY9YqFQFTwH6XtexsFQ=; b=Gjg2CntOtpi9QBPoe+xCpItVxsVDN9QCLphCVTKSsEK+0AROCaMslZPWoae4cOiA+a eIDrLuxKbMHxxHWHQQP0gn7dYU/jLEarSSfCuvgUtnn+4hqEfWJZ3eikV5GUF2piI7bv GAJHm18MSpbQY4lWy15AN6ioSqIF8t/58OKWzQDg01Gy+haNcUI7bBhMuwvc9VWlrIX4 G4wb+PupIlUf+NQu5gQ1relHQlouB0A2mEU9e79oPXBklm+fdG0y9caJ/n+0qUPpQOQ3 wHV47+yn+wyz4YPJF03GcxXwkBgxXC4w64n/0jYdQAsXwCL4WORuTxktfxrmlZGEI7hm QsTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771433489; x=1772038289; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uxHzVkbJVuUf9PPiRw/JbF+frY9YqFQFTwH6XtexsFQ=; b=BlIOfFu/D+RztaC8FyQpnSeB6dLDGlxv6M/JWpoZP3A7Ev/FDtQnnWoqwoUah+qAk8 VSMUfhLJAo2tT6Qi07OAbxQipwqV5Fa8l29yNQNlUWluebORx/spWYjmXvpRfcsUckJy UUqwtSe5J9bPBMfzUEgYWsnnamEjdiqMxOxiC3+WVG/mP2rbK7BuAQREzhX/AkZ3BiXE d7qvBNTWce6vDmrtUw6y5dohIQSxf3gUXYA+rUlUdRIrFq+RuWVJktyd7bfO7mwL68Qa +WKhn8+YWpsg76TtoDY2d1m+Boum5tfTuJyEWDBP5BNLSGfitVXMWhy22I/9YiHPX5DG 3gJg== X-Forwarded-Encrypted: i=1; AJvYcCWVuAwyWFCHkj+2U5egGhJbUYS2IcAA6z0s3LCvP2PDNUW36CLFTakCudIbiGHLoqgL+p7WanUPCaJ4Kdk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7S8IlWh98YoIfn5BcOejZ/lM1uIjJm0VJqUzEoqnxcgpbklc7 pBwLd7D+oONnRf6PtqfaZbh8OrJe78xQWQzq1luc/noI2PX8gImeHPHn X-Gm-Gg: AZuq6aK2/ydu9ZAdCy9RhI9/kR2DdEj6pUuafvugqSkfVIullT6xDr0W5j8ClMB9to5 ZZs0OuRnrSEGyB66ykdesKrcPT3QsNYqQcZfIbBKIKs0BQnp8MQRFusflEl/deudEC9RQ/lwyeN VJEqsNMyL/YMvCvKAAOg/z4cxOvut71Rj6vJGjVjIl94x90Z2Vhlweg53jlIdIsilIMCF9uJ8yW SIAogLe/I5UZB0imRee2Hv+r92XM1QjFNJM/YdH6C71GCrEBjbyu/HjZvbliUWgwB+xs3A4luZB rMmDW+EUmGZYaNoS44SrSvJ/R+S6pzcN4LyhmgILjC59cXNHkme5xc6/caEo72AXeR4mZ4i4enW DXe5h7cA4x/6M2Axln44X2Krnk+dOBS4RCYmv9MkxqBkUoliQRqWEZujkDSroSgSvC5j1rID0h7 fD+6+C6G8ctBHHRvtw45PIfhCxLlgz6SQ8DfM9 X-Received: by 2002:a17:903:244a:b0:2ab:3cba:42fa with SMTP id d9443c01a7336-2ab4d06157dmr192384245ad.46.1771433489047; Wed, 18 Feb 2026 08:51:29 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:403:e988:3f54:236b]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ad1a6fa5cbsm176996885ad.9.2026.02.18.08.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 08:51:28 -0800 (PST) From: Felix Gu Date: Thu, 19 Feb 2026 00:51:22 +0800 Subject: [PATCH] pinctrl: meson: amlogic-a4: Fix device node reference leak in aml_dt_node_to_map_pinmux() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260219-a4-v1-1-9666d6edbe2f@gmail.com> X-B4-Tracking: v=1; b=H4sIAAnulWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDI0ML3UQTXWNzC6MUsyQDS5NkUyWgwoKi1LTMCrAh0bG1tQBDzA8VVAA AAA== X-Change-ID: 20260218-a4-3782d6b094c5 To: Xianwei Zhao , Linus Walleij , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: linux-amlogic@lists.infradead.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1771433485; l=1449; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=T+ddj9uth8B1FutWkYbruKcbeWNS950unthpcpOU8Mc=; b=j/cNO7oUv8KJAFH9hBKE9Q7aZLY1Mc9Wed+OTyOZmsNOTm2f+C274WzqExLijzSUROkMgdDav o4mMxRI63ByAnFOh6LcG2J0gZRy7RUaJv0GeXAc9vcUSRSY7hbUR4BM X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The of_get_parent() function returns a device_node with an incremented reference count. Use the __free(device_node) cleanup attribute to ensure of_node_put() is automatically called when pnode goes out of scope, fixing a reference leak. Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs") Signed-off-by: Felix Gu --- drivers/pinctrl/meson/pinctrl-amlogic-a4.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c b/drivers/pinctrl/m= eson/pinctrl-amlogic-a4.c index dfa32b11555c..e2293a872dcb 100644 --- a/drivers/pinctrl/meson/pinctrl-amlogic-a4.c +++ b/drivers/pinctrl/meson/pinctrl-amlogic-a4.c @@ -679,7 +679,6 @@ static int aml_dt_node_to_map_pinmux(struct pinctrl_dev= *pctldev, unsigned int *num_maps) { struct device *dev =3D pctldev->dev; - struct device_node *pnode; unsigned long *configs =3D NULL; unsigned int num_configs =3D 0; struct property *prop; @@ -693,7 +692,7 @@ static int aml_dt_node_to_map_pinmux(struct pinctrl_dev= *pctldev, return -ENOENT; } =20 - pnode =3D of_get_parent(np); + struct device_node *pnode __free(device_node) =3D of_get_parent(np); if (!pnode) { dev_info(dev, "Missing function node\n"); return -EINVAL; --- base-commit: fe9e3edb6a215515d1148d32a5c445c5bdd7916f change-id: 20260218-a4-3782d6b094c5 Best regards, --=20 Felix Gu