From nobody Sun Apr 5 16:36:19 2026 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD1A271A6D for ; Wed, 18 Feb 2026 21:46:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771451202; cv=none; b=AxTr7O+aCDiw/6pQyQ+37yXghwKhBOqJbnIuV4wmJIfydvHDT1WRsl0yKzmzm3PeZKSjy3wy5IrWw2M/WvtnJoz/yVeiycFpIzDncYaBgU0RZZQbck6nHA/5LmE+9OJHViV+/48y9550XLe3FVcjtTMsckm/cYP/Ggy26Rm68to= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771451202; c=relaxed/simple; bh=PXBdVbN41MShNidxvFBziUc2dR7KAi0w2vzpjdT0D4c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DiGBMd5+Ct/a0pSHzmfFZPbNEhRQ/uziQjQZTmr+l5uFMfz8TNKrILRyHe1r9xuDA6bdtxlGmDmB5ao+esnFHbL3z9rC9bRitKYpmjN1BFO7OAO+0cCZu/BSlK7jB8dORdIVgu3ZnKqN8jHljoPc+hnh34tEUP/oZ931pVXRL38= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bZGuO+rp; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bZGuO+rp" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-79801df2524so3054137b3.0 for ; Wed, 18 Feb 2026 13:46:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771451200; x=1772056000; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZTi8/gZFcbbN4HKkCmQok1Zxz6f/OdLOw5fiqjVka8U=; b=bZGuO+rpkaHIipTZPhsC9ou0jCyfeZh8qF0FdV6arHg454VSC+Mas1ObSVJt58+tKU fdSh40vt9tAkZZQ2T5Fi+U/0FBvOsFQbusTbttKj4y/SeiXF3AdxnzWPIDn04HNTa05B MOCdZV1SVWTamOlMLiKEGlVIlB6eFvOQgDbErYde61d4S5JneyUJvbuEq9BuV14i5OMG CJLK2r1xcKHQWHH/AAQW+iML9hs+PiQMCNYciOZOmJGo1+T01Au57kNHcnCSoaeJdKi3 xn/VC6D4YgcrZ+XLGHsGD5K7oJn34GlHDFVCG4qwViM022cjPk4CG23k+tzb7sTFs3XN I9Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771451200; x=1772056000; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZTi8/gZFcbbN4HKkCmQok1Zxz6f/OdLOw5fiqjVka8U=; b=Ai6rKmispqG0Ti+oKzMn+6f1BlULqFgfUVoVzU9cgeDwUmvgoMC0jSrtOCHlzbNDvv N9EqYePxX3z4kFfdKC6Y/jNpB1WKMAesLn6r8aMliz2t1ToysQCBv1xfE0Q0Iun0JoGx 0dVuypNzW858MQCW292FK0d3E3RSBPfA+szRtgrhx/ZKxA2peOATDhQMCWSgRpSZ4nFN ggXJR1nE/5bUSTMXawgOkWvGi+ibOJavtjNt+UmUVvtYUxKed3jq6jB/+R7zrG37Qw9V 1fnvUAFKi5cD+P6/WBFHYgRqOkWg7yqI5j2Y3JYuJuqnGscL6FwFB4kXJne54betPmnT Nyag== X-Forwarded-Encrypted: i=1; AJvYcCXxrh2Vg2z7v1w17HK7xObXSq9i4TpfxWDhwobjdvAY/YqKKK1qfGNarYQPayyrTRHrQVnJhGfppoUz5eE=@vger.kernel.org X-Gm-Message-State: AOJu0YyDryaxBOVeFMfe/KMplM3U2pqudHjOtvYAnxepCpMIrKyUB8rS dH7lP3Lzoxh5tiOZRKNqRB6V3864uhJuToctVvipxvmX/lxqIb3Qyxsz X-Gm-Gg: AZuq6aKIf+FFVBf8/8aWdC9o71VjZVbv2W7ew5t46iBsnO6pYO6oDz5lt9CD1bZTLBu LSrkoMfOtB35Ruuie1L9eC7vauxcqt0nO/cvidHrapBLuXvZFLF/PWVEvnIaVZZcrsEfY7RElOl EM/qu72wr7ILYXQRM3y3DVsYS3ZQyT4xxLbz5x+VyuN8Sz/ygEyS0XQgQfUVphDW1Ist42ZASLh vuxj/ZbchZ8nK4wO2IDelT5sMwsgwGB4Dc1OYqKkTvZWTrqxPdUvxwPnlhK6n0js+sjo+MDXGTq BXJF8Xo3g3OJ3IQ7LeiNCPpYlkydewLPJb57dtkmBFyfgtCnmzKEKhs3ZgFosGUBips3uF4nU59 SK1C79zyXX/Z0qD1nHQljSjoOzQaJHcNVaZcKqp7ve4EIUzcPhbn9rXidXTpjZNFfOmqyc0KPen ZK1jftTiqGHb1YdneUSmd6siv3hWWZZsh+Tw8MyBAi81Cf8oQ/wAZLHg/XKRryc58k32sq/KGVB iQY0BB0BdN07rOvioDpNrsHjCH/ngvaxnGe4XDZhZo= X-Received: by 2002:a05:690c:660c:b0:797:d006:404 with SMTP id 00721157ae682-797d0060a30mr102058627b3.43.1771451200361; Wed, 18 Feb 2026 13:46:40 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c16e7b0sm126745157b3.4.2026.02.18.13.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 13:46:40 -0800 (PST) From: Ethan Tidmore To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: sven@kernel.org, neal@gompa.dev, marcan@marcan.st, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] usb: typec: Fix error pointer dereference Date: Wed, 18 Feb 2026 15:46:21 -0600 Message-ID: <20260218214621.38154-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable tps->partner is checked for an error pointer and then if it is, it sends an error message but does not return and then immediately dereferenced a few lines below: tps->partner =3D typec_register_partner(tps->port, &desc); if (IS_ERR(tps->partner)) dev_warn(tps->dev, "%s: failed to register partnet\n", __func__); if (desc.identity) { typec_partner_set_identity(tps->partner); cd321x->cur_partner_identity =3D st.partner_identity; } Add early return and fix spelling mistake in error message. Detected by Smatch: drivers/usb/typec/tipd/core.c:827 cd321x_update_work() error: 'tps->partner' dereferencing possible ERR_PTR() Fixes: 82432bbfb9e83 ("usb: typec: tipd: Handle mode transitions for CD321x= ") Signed-off-by: Ethan Tidmore Reviewed-by: Heikki Krogerus --- drivers/usb/typec/tipd/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index e2b26af2b84a..43faec794b95 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -820,8 +820,10 @@ static void cd321x_update_work(struct work_struct *wor= k) desc.identity =3D &st.partner_identity; =20 tps->partner =3D typec_register_partner(tps->port, &desc); - if (IS_ERR(tps->partner)) - dev_warn(tps->dev, "%s: failed to register partnet\n", __func__); + if (IS_ERR(tps->partner)) { + dev_warn(tps->dev, "%s: failed to register partner\n", __func__); + return; + } =20 if (desc.identity) { typec_partner_set_identity(tps->partner); --=20 2.53.0