From nobody Fri Apr 3 08:05:38 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FEC231A7F1 for ; Wed, 18 Feb 2026 21:15:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771449308; cv=none; b=OGAkC5iuqrPo1nuG9q3qeoe3vUaAEGR55DLWlhhBeortXJqMHgtathxD3vHLGB+o1YmtwROq1U7UNRdC4tQ7jq6EbLxIInZA9G2CplFA5nHSHPKAdLZnXe2XLUeUUZMDDtML25k52mLQ64VxZYkYoboSIgetZN7j6/3sq6p+/jg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771449308; c=relaxed/simple; bh=SgZvd8Sskv0y3be4d0fIiN0IEvSgTvHHZpYtU5oVIAE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bGUc7yPdQeFO115n58kUwOrUsTPpwn8OSURcgDwZtj3zLRU0jRg1yqrpBTCbY3F5RkoCFWWp2fG+jHdu218Mi1hY+jb5NsSvlqBeo+KEkE2fO6C/JMJDZAYSD2PF/iMMWpZGXrfVsL3gPdTElSHaKcensT9hbWALdZDSgzvHdJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hRI9H51E; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hRI9H51E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771449305; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=eZU4gWKyKnQkKunk/pkzGylRrazxnAm7GHvdG5YZ6SY=; b=hRI9H51E4tlB2V1xwUEUNIf2/Ode5I7By/9mboHICZoKE8xp4V8mbzgBD7RKA9yqlLQ99j CYTdzuHRvI503IQx8C80oV+MUXtj0CWnlCDAwZvJsHtv+WPgglceWHR93ug4E4YHBIwKd5 EZD8x8DcY3/W/MPH4Uf8nsyHpT+yYkE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-vkcSGc0kMhSmxjFwUGM44w-1; Wed, 18 Feb 2026 16:15:02 -0500 X-MC-Unique: vkcSGc0kMhSmxjFwUGM44w-1 X-Mimecast-MFC-AGG-ID: vkcSGc0kMhSmxjFwUGM44w_1771449300 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7C4081955BC4; Wed, 18 Feb 2026 21:15:00 +0000 (UTC) Received: from ShadowPeak.redhat.com (unknown [10.44.32.59]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 770CB180066F; Wed, 18 Feb 2026 21:14:56 +0000 (UTC) From: Petr Oros To: netdev@vger.kernel.org Cc: ivecera@redhat.com, Petr Oros , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Arkadiusz Kubalewski , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH iwl-net] ice: fix missing dpll notification for SW pins Date: Wed, 18 Feb 2026 22:14:14 +0100 Message-ID: <20260218211414.1411163-1-poros@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Content-Type: text/plain; charset="utf-8" ice_dpll_notify_changes() sends dpll_pin_change_ntf() only for the direct CGU input pin stored in d->active_input. Software-controlled pins (SMA/U.FL) are separate dpll_pin objects that wrap a backing CGU input, but they never receive a change notification. As a result, userspace consumers such as synce4l that monitor SMA pins via dpll netlink never learn when the pin state transitions (e.g. from SELECTABLE to CONNECTED), even though 'dpll pin show' reports the correct state on demand. When the active input changes, also send dpll_pin_change_ntf() for any registered SMA/U.FL input pin whose backing CGU input matches the old or new active input. Fixes: 2dd5d03c77e2 ("ice: redesign dpll sma/u.fl pins control") Signed-off-by: Petr Oros --- drivers/net/ethernet/intel/ice/ice_dpll.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethern= et/intel/ice/ice_dpll.c index c2ad39bfe177db..6f855fe4c78d62 100644 --- a/drivers/net/ethernet/intel/ice/ice_dpll.c +++ b/drivers/net/ethernet/intel/ice/ice_dpll.c @@ -2470,13 +2470,17 @@ static u64 ice_generate_clock_id(struct ice_pf *pf) */ static void ice_dpll_notify_changes(struct ice_dpll *d) { + struct ice_dplls *dplls =3D &d->pf->dplls; bool pin_notified =3D false; + int i; =20 if (d->prev_dpll_state !=3D d->dpll_state) { d->prev_dpll_state =3D d->dpll_state; dpll_device_change_ntf(d->dpll); } if (d->prev_input !=3D d->active_input) { + struct dpll_pin *old =3D d->prev_input; + if (d->prev_input) dpll_pin_change_ntf(d->prev_input); d->prev_input =3D d->active_input; @@ -2484,6 +2488,20 @@ static void ice_dpll_notify_changes(struct ice_dpll = *d) dpll_pin_change_ntf(d->active_input); pin_notified =3D true; } + for (i =3D 0; i < ICE_DPLL_PIN_SW_NUM; i++) { + if (dplls->sma[i].pin && + dplls->sma[i].direction =3D=3D + DPLL_PIN_DIRECTION_INPUT && + (dplls->sma[i].input->pin =3D=3D d->active_input || + dplls->sma[i].input->pin =3D=3D old)) + dpll_pin_change_ntf(dplls->sma[i].pin); + if (dplls->ufl[i].pin && + dplls->ufl[i].direction =3D=3D + DPLL_PIN_DIRECTION_INPUT && + (dplls->ufl[i].input->pin =3D=3D d->active_input || + dplls->ufl[i].input->pin =3D=3D old)) + dpll_pin_change_ntf(dplls->ufl[i].pin); + } } if (d->prev_phase_offset !=3D d->phase_offset) { d->prev_phase_offset =3D d->phase_offset; --=20 2.52.0