From nobody Fri Apr 17 13:17:41 2026 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA46E3446BE for ; Wed, 18 Feb 2026 20:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771445226; cv=none; b=UIT+zczI4f25GMGs/KY3evtPPEHR73NHSVjXRJXMnQR9Asa9jf1+kfoEOUlPqWs7SWLsTEmGN+VM1njH/ZAJrrWSqSjB738dulr20LlOf8nadSPLVm4k/iyZyXOR7tBfPUfJKHPEri7c9qeOnbiDrN97iDFT327ExspEbPl5ils= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771445226; c=relaxed/simple; bh=aBhzfqfbVT4tlgc9EYum7W0bOLioD/FY2EzkMr3vbfo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=utu+PFmALHJSVePLdALpdgiQTS9CqF+b8Y5pH6dnDrNxhfOStK3V9mjGKSvgnQUnHbDdRv+QG17rOepO+CnUc39B3UzyyKewMzwjGwLBN85O8Gdok6N2D5R3PoKtoZ+TvmCRo1ktNEjc0COYpwqzuRCdybiqU53R2EgK+QE95bA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cRCVEJXn; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cRCVEJXn" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-7964fb9ae3dso2225967b3.0 for ; Wed, 18 Feb 2026 12:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771445224; x=1772050024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wzFBOFx15rx8Wpt9w9ms8Y2WzKThMM4oOB+R1c01Qi8=; b=cRCVEJXnDkDR8q2hx9q/Dcwnr71i/ewK3xVi6IqGXam1ZaL4M+ybCtw9Sl5PXgKWGu iXxlrA7PW5e3BeWLF40NH3poA9R1vdD4fc0H2DTYPtbBYObo9D2AweVe0rRplIDSfRoQ qwPnOHwNwVCRSaWXDVfPj0e47yivRWvMvcbNqRG/d/yik11zVyO8hATJ0y+5wQC/Hkov tYCQQaLn0ou/MZLTdZQ/ou1g+RDc0B1U9K46P4OBlRpS0TIB3qkMZYALWlhOd0qSQWtR hAZXDutzyh85dKq7o3h1kWDQOx34y0QKhgQUid3mgrA2MUCGy+zuc2WZUipVEC1ZOru2 otNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771445224; x=1772050024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wzFBOFx15rx8Wpt9w9ms8Y2WzKThMM4oOB+R1c01Qi8=; b=kLtGLREYBSYefRiUv/x9lLI7CFMCv9g+BE1Fy6SLTrN5GqNuS4y4Obko2b9/MqLa+d P6fqExDTTopax3JSOPgG58t/GY2/KvSb8o1S90qzSvNqSrXqJB4Hc7pG1JzRUG67fGF2 WgDCGgJoMgbYI/aICPmrxhsGrkJ6Ke0G+ZmW74wPrm1mr07NVklxFDdbHIUXBILJxOgh fBcE3qtwAigp/je7Ap/UDJZ2Piw4wm/iC087OYK8whH7QCXFMC54k++v4eCV3kO6vSkj LSenZ7EpHw1FfeZ8Gy+J372b1KUpCvhaXRLNfnwyCqFb7+c+vxkkQZI76yljZRbKg+6x B8wA== X-Forwarded-Encrypted: i=1; AJvYcCWxyll/P+TxuC8aclVYvsV5W33Tv47bAlHISVXoJF5ZpPLXGI8ZjGpWtFrGzlVewf9yXM0j1IwDIpu5TmQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywkih8Pt9vTjC6nu0pNx7ZR2iLjRO8Q9iJAUU5+5U1OqNBM1Xu3 cupK849sbhCAWzv9AuyRP1QiG1GN3wzT3nbHvwd7PkSIhP+Jj70XlJ65 X-Gm-Gg: AZuq6aKnZ5lI729+MIwwlIGUVM3ygYfmuaNiZOCRK68FF5KU1YKVLr/efvjpSGUx8Yz l/yvetpgUKmcIeOIuw6u4yoMtMAXfRcGa+vCFU5e1Pl1qj8JP1C9mKPPOxUy9tYrgDOpOWPDLau 5dfiOeo+dk9n1DAr2mi5eUPNV772macPeO0AOU3pFkA7GKFuh2NBrbdWo2W68LdzHqjXYDCg3pH wujIOJWtjzVifirf81CJYu/R2HnHDx/+K9YHSANdE2Gp5jXxDc2lpM27e7ENNb9GdylP4eh5mBt P1tX8ynBKewINYtHS7SAiyfGfogexlH5E1vv5jwF0An9REbvq8qY0o8l8nbqMN2Zo0IHAZPYLiZ MeuG8tfD314ni/3Fu5icxGt5M1NNSuyOBXfy4DlHBzx65ySR0e8zgHzTMGmziT1RzW3D6np+BL4 V3s27ayECdVAw6HsWmxi+L/zT3BNMe5LIvLsaK2WMePuzCXytPwhKXNY+iCWd/YD7aggCLcpLGb g565n5Sx5kOUX5E3PDL38OS7J/VPBtkr4mo/M4Eu3M= X-Received: by 2002:a05:690c:9a90:b0:794:d44c:866c with SMTP id 00721157ae682-79803d19d87mr4675757b3.60.1771445223871; Wed, 18 Feb 2026 12:07:03 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c023be7sm125920237b3.0.2026.02.18.12.07.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 12:07:03 -0800 (PST) From: Ethan Tidmore To: Andreas Gruenbacher , Matthew Wilcox Cc: Andrew Morton , gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] gfs2: Fix error pointer dereference Date: Wed, 18 Feb 2026 14:06:45 -0600 Message-ID: <20260218200645.15713-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function __filemap_get_folio() can return an error pointer and is not checked for one. Add check for error pointer. Detected by Smatch: fs/gfs2/meta_io.c:147 gfs2_getbuf() error: 'folio' dereferencing possible ERR_PTR() Fixes: 0eb751791df86 ("gfs2: convert gfs2_getbuf() to folios") Signed-off-by: Ethan Tidmore --- fs/gfs2/meta_io.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c index 3c8e4553102d..9c0ba4c3cb29 100644 --- a/fs/gfs2/meta_io.c +++ b/fs/gfs2/meta_io.c @@ -144,6 +144,8 @@ struct buffer_head *gfs2_getbuf(struct gfs2_glock *gl, = u64 blkno, int create) folio =3D __filemap_get_folio(mapping, index, FGP_LOCK | FGP_ACCESSED | FGP_CREAT, mapping_gfp_mask(mapping) | __GFP_NOFAIL); + if (IS_ERR(folio)) + return NULL; bh =3D folio_buffers(folio); if (!bh) bh =3D create_empty_buffers(folio, --=20 2.53.0