From nobody Fri Apr 17 13:17:58 2026 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BEB023ED6A for ; Wed, 18 Feb 2026 19:51:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771444296; cv=none; b=DFH6IQq8Bw73OPfxSNBwKMqzzaOAI4/GvTEgZ4ej4zS1rQmdDMgiKTPfoeBcKPLYe84QJJg/68WzVbSqtJ3MDLBtLCdlJd0ebGT1MeYRQIDDLc4mrW9zfq62WfHKSLMOyqJfYv4ewvotsdC4w8fkt6wKqeIn4vObG8fwrnM9AEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771444296; c=relaxed/simple; bh=o14jQr3MK0WAom64yndMqkc/N3aQelcLXwWK3gZYnNc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oSvOHoWsO6qmEEfty0rx71M2qV1rXXv3kayz9x8X4K7ZYX5peDRCvOAE3QspUWgZU96Pp8Am2R6dE3BoUqJcjVc8qFKD+P9yOT57gd0Wj41fei1//VoIJ685xt8HC3wEGg0qlZP9SNityi+tvCO7xv2S5J/tJdVmP2KazzKajqo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hmJCZaoi; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hmJCZaoi" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-797afd2e872so2558577b3.0 for ; Wed, 18 Feb 2026 11:51:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771444293; x=1772049093; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rhei553V0qQizYs5ft2+gJcj/d+TOeR7Ld/V97lPAMM=; b=hmJCZaoiY/zYuhlNFOuRi4cJ0Bo6D7bf0FwtLUkE0r9J87ZatltXW98o5yM0PL/LJg 4jSEP447wXsJgobxv/4dtAH3CvUoHHayL78BxzUTHN90zFJtoKu6yyG3JrFaR2LzdNy1 81WUL9OwXKB2sScZOX5GiRiboIvjlmPl9BPI1ABLZwEJ9gJFcbHIYNKKAGK5C/2EfKhT AEnaIOUNsUCb8msm1THZMlU9Lih+uU8OphgXlrhoAgyzLRxeyNNlZ0zvfNJgnqIx/Y2u t2MswnzI9m5rd1P4e8AtcDSSB2e0V80tuHUAZqqvmVpt46QS7DSfvtmrU/6w2Gy7H33Q 1oEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771444293; x=1772049093; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rhei553V0qQizYs5ft2+gJcj/d+TOeR7Ld/V97lPAMM=; b=ec75XofNSoiGnhBp3VFSf+GuF8eVzWiPuhcbtck0exU6paUzKvOrjeYi4z0ISmULDU TlCT3aLdOnLXvxdl9I/x9uvG7LOo8mFPEmEWen1gFHDysCoiNs0rDLTCWKco00Rq7Etr 0oTSCglcZ3GGJV2gO0SK/PDPyNQWl8uVvqELTtXiLBI+KMoM7EH2PhqvuCZF6Srq1aMs nTZN8QiXxMXLfr6GbTbAwLNdTr2ev9w9EgO/7XrMNFHGm6KccLwl7erFxDE85kiqsK5C FP7Q1Ls34hl5P5FBiam3me4l90Twb4DW14mFxuZxp6zj/z01kbC+PwJdTuJbeCCSr6vX r0dA== X-Forwarded-Encrypted: i=1; AJvYcCVeRyVybXJjKvLfhJuNhcb7sO4p5K5XTy9rG8LyucUgmY/bbUa00E3U+z7zsYfiB7WP4CgC1DikqF1f33k=@vger.kernel.org X-Gm-Message-State: AOJu0YxCe30+KuwUekfh4x/XTsEWmOGuuCgw8zy4IwfZLs0tNHWCFjpI C961YT2WRucO7h8KAHbQKUVyjXR9cJ7n98P4JKBG94Or+6A9PbjK6/ri X-Gm-Gg: AZuq6aKG1LqebQTGof8Dv6uHEiK9EHCN0fe3sDR/rtOlcjfSxyYx2aQsTmh4n3FUDEc 4ysf5kaprYEYDSjD+n6pHCODtgj8gUvn3S0ifQu2NasF9s4KoToGZDNUu4e7Oe7frNDy54c6BBu OU4zKmwoms08YWflyMelCPTA4aLRpL0sD+ENDBoC3ElyEzhkZOwJ3u22dOYwUgw2DUejOW6Y4nC PGw1fcxo+CcukdvSkFfRa63g3hu93F4/h1Sag9QmBJfYTtLqwCIZaUD2jQFGL2F0dqWuy0Z8cFF g9UO1defR1ymO3ZYXW/UPDgIFIApT1im7Qj1tgYQmoPBQpshzXmJLPADC8Fn6SljPQ4Vx4d/Xp8 H7TeNuiAwdIP+h/UDOyn6Ev+GCAcOMv+aW+sxxVBXAJKhl1EoJBFjLPWWNinf5tVrWk2YHV9fB2 ECoXEGGWnKNXpzhveRnASp8St/d7/fNs247ogAlYsSazAHi9KsWb1QSS0aB2HaqkDTEZsFRlL2R /BWXvY9Rq1+QuWQldulfAxzw+LHHB3up5cRfcflF2g= X-Received: by 2002:a05:690c:17:b0:794:8d58:cac0 with SMTP id 00721157ae682-797ac51634amr127805617b3.16.1771444293184; Wed, 18 Feb 2026 11:51:33 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c18b3desm121944387b3.14.2026.02.18.11.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 11:51:32 -0800 (PST) From: Ethan Tidmore To: Carlos Maiolino , NeilBrown Cc: Christian Brauner , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] xfs: Fix error pointer dereference Date: Wed, 18 Feb 2026 13:51:15 -0600 Message-ID: <20260218195115.14049-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function try_lookup_noperm() can return an error pointer and is not checked for one. Add checks for error pointer. Detected by Smatch: fs/xfs/scrub/orphanage.c:449 xrep_adoption_check_dcache() error:=20 'd_child' dereferencing possible ERR_PTR() fs/xfs/scrub/orphanage.c:485 xrep_adoption_zap_dcache() error:=20 'd_child' dereferencing possible ERR_PTR() Fixes: 06c567403ae5a ("Use try_lookup_noperm() instead of d_hash_and_lookup= () outside of VFS") Signed-off-by: Ethan Tidmore --- fs/xfs/scrub/orphanage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/xfs/scrub/orphanage.c b/fs/xfs/scrub/orphanage.c index 52a108f6d5f4..cdb0f486f50c 100644 --- a/fs/xfs/scrub/orphanage.c +++ b/fs/xfs/scrub/orphanage.c @@ -442,7 +442,7 @@ xrep_adoption_check_dcache( return 0; =20 d_child =3D try_lookup_noperm(&qname, d_orphanage); - if (d_child) { + if (!IS_ERR_OR_NULL(d_child)) { trace_xrep_adoption_check_child(sc->mp, d_child); =20 if (d_is_positive(d_child)) { @@ -479,7 +479,7 @@ xrep_adoption_zap_dcache( return; =20 d_child =3D try_lookup_noperm(&qname, d_orphanage); - while (d_child !=3D NULL) { + while (!IS_ERR_OR_NULL(d_child)) { trace_xrep_adoption_invalidate_child(sc->mp, d_child); =20 ASSERT(d_is_negative(d_child)); --=20 2.53.0