From nobody Fri Apr 17 14:56:47 2026 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8609F3451AB for ; Wed, 18 Feb 2026 19:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771443205; cv=none; b=mXKdXdAPJOMgFxpNFF9T+oxWADAT19GLrQvIsr1xtImVBWgvU5UJ6gvzfTd6E12Cn00dkzz3ibQDTj2zww2Ci5F8YpkGbgvUbdQaMSKqLoAcZxNpZ662VHyqPySvGP5BidEcMH+dW83KNpQsc43KbYh6bebEiuWScVora20elB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771443205; c=relaxed/simple; bh=pRjxSY2hK/P3m06NybehEmPkcEcTFuE9eeyU3AyZp7g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SLwT6MhgPBGW+vDaAfu/S7as2yrb4UrHbnh3Lmfl+r9qf8aYhOw1VCZ2Ze6mlRvzxKoieE/r2go0K2Tmw0Ea0e62TYZ6HhFiVhTLOz4rIPxDTCK4/cK9FhKvUAPuGvqCehOGBuarzYEGC9iuD2ICZDTE9YPbCnA3w2S6dINwlnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lunfIJZJ; arc=none smtp.client-ip=209.85.128.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lunfIJZJ" Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-79427f739b0so1767517b3.3 for ; Wed, 18 Feb 2026 11:33:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771443203; x=1772048003; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=isj4uUQXBkvxAIQbP/qQhWrPSh6AxlVjOVunCf1FAu0=; b=lunfIJZJ7zquc3s+fv7MI+6zpSVSFGWsIb+sSlJsguHqFvlQ7NMW6qHRykeX256FYk X55vavfjaxeMktCaxWai/oZMZWrAkEYJa/+A7H5FSA0ZsecJNRudkyGa5ufE6LOmHmu4 DbO905wmgCOB5xAXYvE6d5rlly+y+vE8rUCwI1R0cCUfc64c33Cp/9nAkmLzhUozuJYg ohfwYKWzSTzg5PKnwNsO8LsWC+i6iAM98rpxw78YGmuEhF6S4KLvIOctiK/08WGsVJj5 Yjpcybd4ZE3mEW7YP7QqppG9UPe7L9d74QW8c0XqfT23FxfDQ8YKgyuXAcYCPaoYTsX2 Uw7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771443203; x=1772048003; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=isj4uUQXBkvxAIQbP/qQhWrPSh6AxlVjOVunCf1FAu0=; b=vRUhOrIvQLn+jxgUYu7JjZY6uTDgemHwPUVeEFOVbow2TYMeFMnTjPnhO8iAtWbDtm Px6GcgDnL+OqfFTnKnYlZg8Q3JAQI6n/VMfUCDByPo9Ms74H1u9Ky8kVxfH8LgT2pFqo TxOQD+i9EeQDC7FvLQUgMa4eYNHmQoD2LeOP4KefUozJMzmat3gyXXZgHjwHB5Z+/9oC c0NKw+8/Yw9bt4bx+O/jK5lLISohOzOLxYQgW80h3ROkX6ixPjClL0OAEq4QFnYWVgcX lj+ayRIjJbW4Hn8KABpzFE3hNtPEF4mVxzPpoxNlG1rTyJM+DLcYjBNYpxdyYoKVICAJ 33YA== X-Forwarded-Encrypted: i=1; AJvYcCXbnaP6zbVTSfl60sFzBNjlvdc9fejrqbopFmk3mBXNFG/+2UtC0cAuJSZIGfzeRhofpXJbDnUYVlWB4ig=@vger.kernel.org X-Gm-Message-State: AOJu0YzWaaAQidQxuYi6sXOxEUEq3cASqkAcKEbuMd1F6MPvUMEIonq9 c1EREAdYUWlBm8kfaWBuSOELsBRwXCWGkqDhr7UpJtkPPlD6I5HDB4tH X-Gm-Gg: AZuq6aLZFXe+ObtKRqv/p9taIfL1WnJGwcYqGHC6u2CRGyUvfcX02J+r+VSgqE7AZtl JX6VyNFOax9OD5YU/7AL7KayURQQdnz6+JbvEPvqCW4CEMkQ3EuTbCi4H+LQgh3Do+5LPZSv9j0 rZ5srf50IQsnzoM5q+z2vCSZFRb4CbE8KX6alR4q7WPCha5gvAyskW7IMnIPz0GSRGMScW39URc MeXtOQQbu+RxZDpEEBtmnXaRquOcMtKR/1GIAlCTxiFTzp9srIVJlsoAGaexxfIZBsZQ5I6/wPc VQTA/pnyvr2glXc0aS92NHrT73nEKaVSN4AjZ5EiBaisrFCcTWYG1S0ao0mXjuQ+iFvyu/VfRCF AM3TWpx+r/QHafOJr47SdJW9q8iTYjBntp/4BpIb0vy3TzEMLOlMyaD4aKvXuHvQdXK3wEW6B+I cp0Ol6J8vB6YBLoRKLrq2OLICr0XDr0gOUoLZDFWrj8CDFCdYcEYA+P4DaGvRGqwROS/Z7Opqme 2FC8gCxUlPVSe0u9W70Qig9esyaaSbOJR90IZmBDEi2z/QA9ue7Hg== X-Received: by 2002:a05:690c:6c8b:b0:797:ab82:7521 with SMTP id 00721157ae682-79803c7bf5dmr4113457b3.34.1771443203551; Wed, 18 Feb 2026 11:33:23 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-797a5caf0e4sm63661217b3.27.2026.02.18.11.33.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 11:33:23 -0800 (PST) From: Ethan Tidmore To: Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] hfsplus: Fix error pointer dereference Date: Wed, 18 Feb 2026 13:33:05 -0600 Message-ID: <20260218193305.11316-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function hfs_bnode_find() can return an error pointer and is not checked for one. Add error pointer check. Detected by Smatch: fs/hfsplus/brec.c:441 hfs_brec_update_parent() error:=20 'fd->bnode' dereferencing possible ERR_PTR() Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Ethan Tidmore --- fs/hfsplus/brec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/hfsplus/brec.c b/fs/hfsplus/brec.c index 6796c1a80e99..efe79a8f1d98 100644 --- a/fs/hfsplus/brec.c +++ b/fs/hfsplus/brec.c @@ -434,6 +434,9 @@ static int hfs_brec_update_parent(struct hfs_find_data = *fd) new_node->parent =3D tree->root; } fd->bnode =3D hfs_bnode_find(tree, new_node->parent); + if (IS_ERR(fd->bnode)) + return PTR_ERR(fd->bnode); + /* create index key and entry */ hfs_bnode_read_key(new_node, fd->search_key, 14); cnid =3D cpu_to_be32(new_node->this); --=20 2.53.0