From nobody Fri Apr 3 08:27:06 2026 Received: from pdx-out-004.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-004.esa.us-west-2.outbound.mail-perimeter.amazon.com [44.246.77.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE50E279355 for ; Wed, 18 Feb 2026 14:35:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=44.246.77.92 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771425337; cv=none; b=aVzvw/SNXpyDEYMKmE0sTGfqwlHMgioTPgrIHnzfMkA5y9T+Kh/0S2aHmNeuP5tlkGgy172EcQZD/66k93npCqVN/TOm8VeVHAK2pXtmO4F+mjLfSTVRVw3xHLxB6qoE0sVEp5Wo6m9+gCHqyRLjf26CvCplJ/jViSWFMiI57EM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771425337; c=relaxed/simple; bh=7R3oQ+gY64LEgUdD+rrHOLyEH2xx5P0cbAZhlYV97tE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JlgF0PoKDt4tuheTKTn+HDaFxormuVKBWQlbUDD6LM3jduK0TGfBRw4lOKdwbiiaaw1IePgfKkTHYaSQx1JcRsoNRKvm6QGzhDuK4zKB+pD5xMm5eOciyt2mPBsUelgh+EnfRbiGOEOZ8eODuqWtr04KsLmsQxpfyMys5lV+x3Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.com; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=Ra8+vlLK; arc=none smtp.client-ip=44.246.77.92 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="Ra8+vlLK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1771425335; x=1802961335; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Kt+JYlmLC8S632f23NjynpBZGNVCDSSCZjdmoEG0rs4=; b=Ra8+vlLKaSgrREt4l5/XAt7QOg6q+PTARJ9jXQaOObYxKn8ttk2B7qMK cNlmV/4WjEmeUGV9jmYA+dnRrpqXCXpIvK0LDhN/Qv/GfOpgs4bph252J TQfWJ00sicyyOvnC2pEcF6+rCEDJYVSh3Iesn1UwncR9Fzp9muzzaGd0a 0C8hI8wJdm2Jr1GPH4MBDi0dNpSRRpu3AW0xStJ8l3xqOiyWr54B7/HeQ jU7REuo5+AhKY6yEjwVJkmXyfhtm2jXEnYNTlEevkjgk8Qd3WxJi4Z8c7 Q9GqRlfq8/kRexKMBSedOPOF5UGfTOa/FByMsm0Ny4SVPl3s9Ws0OmTLm Q==; X-CSE-ConnectionGUID: MNB7gRjmTY6/r5P8NjuqSw== X-CSE-MsgGUID: P77f/YS+TVCaU2NxxIPwRw== X-IronPort-AV: E=Sophos;i="6.21,298,1763424000"; d="scan'208";a="13284428" Received: from ip-10-5-6-203.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203]) by internal-pdx-out-004.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2026 14:35:33 +0000 Received: from EX19MTAUWA001.ant.amazon.com [205.251.233.182:3798] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.23.250:2525] with esmtp (Farcaster) id f5ccaf72-88de-47e8-967e-206a7fc27c21; Wed, 18 Feb 2026 14:35:32 +0000 (UTC) X-Farcaster-Flow-ID: f5ccaf72-88de-47e8-967e-206a7fc27c21 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWA001.ant.amazon.com (10.250.64.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Wed, 18 Feb 2026 14:35:32 +0000 Received: from dev-dsk-farbere-1a-46ecabed.eu-west-1.amazon.com (172.19.116.181) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Wed, 18 Feb 2026 14:35:30 +0000 From: Eliav Farber To: , , , , , , , CC: Subject: [PATCH v2 2/3] mtd: spi-nor: winbond: Fix locking support for w25q256jw Date: Wed, 18 Feb 2026 14:35:22 +0000 Message-ID: <20260218143523.17467-3-farbere@amazon.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260218143523.17467-1-farbere@amazon.com> References: <20260218143523.17467-1-farbere@amazon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: EX19D042UWA002.ant.amazon.com (10.13.139.17) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Content-Type: text/plain; charset="utf-8" The Winbond w25q256jw device: - Supports lock/unlock via SR. - Has Top/Bottom (TB) protect bit. - Uses Status Register bit 6 as the Top/Bottom (TB) protect bit. - Supports four Block Protect (BP) bits. Update the flash parameters by enabling SPI_NOR_HAS_LOCK, SPI_NOR_HAS_TB, SPI_NOR_TB_SR_BIT6 and SPI_NOR_4BIT_BP. Without these flags, the locking configuration is incorrect. Reference: https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=3Den= &DocNo=3DDA00-W25Q256JW.1 Signed-off-by: Eliav Farber --- drivers/mtd/spi-nor/winbond.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c index 55f1209936d5..6d325da121b4 100644 --- a/drivers/mtd/spi-nor/winbond.c +++ b/drivers/mtd/spi-nor/winbond.c @@ -274,6 +274,7 @@ static const struct flash_info winbond_nor_parts[] =3D { .id =3D SNOR_ID(0xef, 0x60, 0x19), .name =3D "w25q256jw", .size =3D SZ_32M, + .flags =3D SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SPI_= NOR_4BIT_BP, .no_sfdp_flags =3D SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ, }, { .id =3D SNOR_ID(0xef, 0x60, 0x20), --=20 2.47.3