From nobody Fri Apr 3 06:46:20 2026 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9415E2FD1BF for ; Wed, 18 Feb 2026 11:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771412514; cv=none; b=HuNp/+7jzy53c4MGy6WcfoXrJVECLPIbddI80ag6qmwokCWXgBcE0InRLU2KqK+VhtFmPoKEureQnNTqKjW3cqSxgWm7XddhvoJS/BglZbei4jl7fnzHsANNR1XyuBhS0RmgIb4SKtKyb7Ys4nX+sap4i2uueVF5a5HUVyie/Ys= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771412514; c=relaxed/simple; bh=mtJ7tmHpf4O0rAYDjo0ur8EJ65nUAAHFMbS0duMHe3s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ujzvi1Kafb80Ef3QhsiWgd8Q9sw/CTpkdYhcyvXNV0kriWOI1N7v/eaZCVy0kh2/DSnZAH/h9SH8EbMWGguTCXhOc7Co+18uiFq1TJvSjf42qdXY7bNcX1Qyg8MNHftLrevDyn/2xjcwY2+F0qHt5q/SjUlBwEfbzTcjGPc2kig= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DWRPPPEW; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DWRPPPEW" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-824c9da9928so2463889b3a.3 for ; Wed, 18 Feb 2026 03:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771412512; x=1772017312; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QEh2x9C41ySCmS9IgH4my6kPFolL4MAILeh/ncPke2I=; b=DWRPPPEWOb6paBL3I2g9Z6WqYHMdoyehrfoFzYajLBSEHerwYRxi11ImGpCv9Of98c uqpruC9BMTf7DAEkAqZu5VwgdYNcXxbyvcqRWaPqOav805BfROlqs6bgUfHYX73ZytX0 +jnSeT6mtxHAhXgb4MYVj30tV2ZcTfyt200n1mCk2NpGHsUq/yXWsonksw7jSn4jnfU2 SwnMixsbyzHoRBKnvI1o1h1QcqnMbeZKLihGbkg5Y7OD/VlEz05br30yJjYOI2agDjxs NcTK6uK4JmUmt8QQsfpV3Yu1xV+29SoTzlyAtlzXFTV+zR7U7DrTmasxDQaDOlJU7V12 hWtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771412512; x=1772017312; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QEh2x9C41ySCmS9IgH4my6kPFolL4MAILeh/ncPke2I=; b=tXXdoMmeuX200kFL5tamHMVcmMZabcF6yr8Q3LzlbE77dYoiUpmXLo6jN0s6HWbRea AHp8L5AWpBJBhhbZZTJNcQM6uEibSkpMiwelAz1w7JPVdOhWMVE4FPujABdFOT5o2Fzg Fdhech533es6+c5gnEjfjkAGMPgtJPukdRVbSXLB4ESiE+t+qarWNfHTRUkncYf12ziq qMz1LnkSTsRjN3oDY5D/BAQJkozTeRAJ4NvZoheZZc0ImraHRZawzRj0rmiTN7EvezaW Y1AZevZ6rmOSCu4mMzpx5wTIc2ZY20v3etElzmMMLzCKC7pDYQvN2whvV94i7I6K/lS4 Znnw== X-Forwarded-Encrypted: i=1; AJvYcCXlDdcWP6uFytY90FHrnk9QH7v5HFQ+Z70k47zDGJ7Ll+MyiL2LHShPVjR17oNhdwf/LFKhenBg0hJSpLE=@vger.kernel.org X-Gm-Message-State: AOJu0YxcL+HwQAb741Lq7QrH10f8qeg3gum7KmbSXZQlfYSFCoc8eQk+ 4fiMSNCMr9h61zqr0+U13qjBRUG+QzY3UYNDo0NfgJCfSVR87mbOv4o+ X-Gm-Gg: AZuq6aLwxc7tTnLEDEOOgUOLyUtMMXN3QSOydC80VdwsfCrVx9nARXbyRjcQEynCRPb 99IMW1WwZNv2mp1PAViCJ3205VSuZNvFuh4yo3oLM/vIrS4Kj6TZblGU/Yy8Cw25FrlIRK4AISH UwQv+WJDms1XB0p8lc9D1DLnS53vtzahla5NWWOdL7kV+WO0Gj54Tw3L2sQ26+mBiAnX8AqI2hL FokWPzDkR0VsENSE8M7E1RIfQ5BtuR0zdBBy8QTivRFLZLc4jV/N+XVQg1ryR7srFgW649ToAAt d+a8rIL3JezxkaWPQO3vhuiQOyGOdDXT3LtaISk+e8myziIVrtMlkfvvDkCImh4YaPiATg05OzF zciBIrUw9HnqOU4UD5J3OwUZZr8MyxnWIUckyeJynYwBLwcva+/pyDaVUT2buwBqV4CsOxCu7PY trpCMv9beRIofzSviLxR2f80wGqKROJ4gVZBNN6wGcZ/YMJoa0rUgsXVu6aZE3Uc0xOZPa X-Received: by 2002:a05:6a00:1590:b0:7fb:cf05:93cb with SMTP id d2e1a72fcca58-82527460066mr1139313b3a.1.1771412511875; Wed, 18 Feb 2026 03:01:51 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([110.93.227.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6a2c4e5sm16582293b3a.4.2026.02.18.03.01.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Feb 2026 03:01:51 -0800 (PST) From: Zeeshan Ahmad To: Thinh Nguyen , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH] usb: dwc3: qcom: simplify error check in dwc3_qcom_find_num_ports() Date: Wed, 18 Feb 2026 16:01:21 +0500 Message-ID: <20260218110121.10185-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The platform_get_irq_byname_optional() function returns a non-zero IRQ number on success and a negative error code on failure. It never returns zero. The current implementation checks for a return value less than or equal to zero. Since zero is not a valid return value, simplify the check to only look for negative error codes. Signed-off-by: Zeeshan Ahmad --- drivers/usb/dwc3/dwc3-qcom-legacy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom-legacy.c b/drivers/usb/dwc3/dwc3-qc= om-legacy.c index d3fad0fcfdac..34c578309802 100644 --- a/drivers/usb/dwc3/dwc3-qcom-legacy.c +++ b/drivers/usb/dwc3/dwc3-qcom-legacy.c @@ -620,14 +620,14 @@ static int dwc3_qcom_find_num_ports(struct platform_d= evice *pdev) int irq; =20 irq =3D platform_get_irq_byname_optional(pdev, "dp_hs_phy_1"); - if (irq <=3D 0) + if (irq < 0) return 1; =20 for (port_num =3D 2; port_num <=3D DWC3_QCOM_MAX_PORTS; port_num++) { sprintf(irq_name, "dp_hs_phy_%d", port_num); =20 irq =3D platform_get_irq_byname_optional(pdev, irq_name); - if (irq <=3D 0) + if (irq < 0) return port_num - 1; } =20 --=20 2.43.0