From nobody Fri Apr 17 16:42:40 2026 Received: from mail-oa1-f99.google.com (mail-oa1-f99.google.com [209.85.160.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC4152E11D2 for ; Wed, 18 Feb 2026 05:27:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.99 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771392477; cv=none; b=cOIq1o+n/AYNU6hUhIsPR+KWujKBciGzqgnq6S/GjJunBqef6CvDevoB1YbmP1DmG+YPlla/GQUOpcGpO8ph0ceZNx65tg9TZIT+hG5JjIDcvsaToqAv4qZvsedEb83Yi/rosiJPPRmXDwPgcTjb2us6r3Qbmzhshv6p8jFdNNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771392477; c=relaxed/simple; bh=d5u5IAe7gfu6AXao34YA2COKVVZ98LvXS69WLYLlTaQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=qQ7Wc2QA/yCiLu2Q49Tgp9JRYrDLac0/tYipF8J47693O5RnzcD4rumptU1YP0HOeN+s4tDlHUKW/TFRdTHndPTu9lnQLKsQQuOQzkKeWDvU5iMeIGMVUkYdtX9PecxpneAY4hIJe+qFWkTwKFJ65DgkHaiPVPctdjZB1wwDyKw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=h57hZ/AQ; arc=none smtp.client-ip=209.85.160.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="h57hZ/AQ" Received: by mail-oa1-f99.google.com with SMTP id 586e51a60fabf-40ee8b4f925so3224873fac.3 for ; Tue, 17 Feb 2026 21:27:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771392475; x=1771997275; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2B9PV0MGzW5R2FMwBcx2SJsM/aIOtYftHSo0JobyAqM=; b=QSn7BFu3ZhJBnjIh2uTR9irLwflAFxsUz9OfCm2TM8oUrqiIaeL+t4MldTilmbm8si QGchMPdPEPRCKNURQxt+ygzDujazDiGVVcNoOGhap76eX5NCJkxsVWPTJ/Vy8tqzv7BP dJmNj09BNpP9cLhKIQxuUjw1cWfXVYFHfbughr7YReIlHtKewhzPKwx9xffyFpDJMRkR 7PK2rol0BQG9nhiHCYr+UsfJXceH/9D2gwgJmipXzmwKyt2OeRdPhPPnF2hcYFJUT6j4 2HcQrYqyos0QoYh5rkVyDdSzxa9g2wYTRobr/X7lMc9e2H9Ku4s34lkLubUBd4MdXpyB hI7w== X-Forwarded-Encrypted: i=1; AJvYcCUrgxmAbOEnG51bAQf+Rx5/2qD53oVEBrdz3L1oo22FtlH0NDtiVJ+vA/IbIEGygPgOcGtmuRQc/LF/YYg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjh4eRTuWjlZNKyCZEkOHivl2Dy9G+eWNfjLd0vsSJdwMqjIAp GxmWn1Rdpaqnd4f3pTpsREhjy3sxNr1LXlG156cDRGegXkv1NOShMm7rTzxr4jSSrNz3OEh4wBj grzB7jNDTR4vgxXDPzy9EDf9cybrlTrlktxMVGJhJMnZL6kcHnDSvvCJEIkqbrlD+mTd7vl8mtC C4s0BNywMIUnOINebYqUBqivldcGIrGooET63uY4zHmJWrWleG2KvpfLv2jXh3UD6iDpHmDOa+H V8kzEacCOJVg4XWTg== X-Gm-Gg: AZuq6aKZ23+49V2PLOqnzzMy2DqbYt+H4iItQBNm/JVdT/Yh2lvyQHsxiczDFeKbtUA zLBrX81X9/ro/inq0G1J7fltX6c4914etmNhqzf5B/J43C6brWxkW+YGNdD8HYSMRVItR6XA0vm 2zmn7N3CY53r7EaDuSo5oloSVHWNOGEjDaDDxhCwlG4mWga7Z7mnCko7+KBqDA5kuTsmx8orhtx nE+svIza/uKdgqMx6gTWz5mO4NpsoIGHSsItWCqeoZ6WHcxfHU0JG7uPRjA3PtZqUw+3yJQndna lgUN6KnX9tnt4VvO7FavIyBmabR2SK0GhHAj1NOgX57shVMTxismtg3X/ckjG7vPWEOXgdJUsu7 MJCDedDM3aVtVsXOlwTc2//Ps5o5TLbOuL6oR0qck1e3BUPTLN/zJN8hV/qd62DmItzBn/GF16y forhnb4Z9jn9AEiGwz884b41fr6AeABeYAO6Mz9QqeOTFjakuJv7L9nPY= X-Received: by 2002:a05:6871:8216:b0:409:6ce6:a374 with SMTP id 586e51a60fabf-41528fde3b0mr386232fac.16.1771392475432; Tue, 17 Feb 2026 21:27:55 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-94.dlp.protect.broadcom.com. [144.49.247.94]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-40eaf0acc91sm3736574fac.11.2026.02.17.21.27.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Feb 2026 21:27:55 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c6de06e6c08so3643614a12.3 for ; Tue, 17 Feb 2026 21:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1771392474; x=1771997274; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2B9PV0MGzW5R2FMwBcx2SJsM/aIOtYftHSo0JobyAqM=; b=h57hZ/AQiNJdUvS26Gpl6tpAyhA+r61nCLGcvvjj1yQclSvwuyoxUYSIlk/ggrdvAu 56ZRdDcpyS7hKCgo5W448QGvsbAYmXz4HW6IocVAbMVycCKmJmULBXktydKIoClRa/6r vxo4r4ehFfdcY8/jUqX3JSsDXrtYZL7sh9jV0= X-Forwarded-Encrypted: i=1; AJvYcCU5mhqIIJTeAly9+nQAbTLzPYAJBzrsMAVEjE6pwxNz9RMht+KOLbo+1HRgCSxZEvrvlIpBBwpGitXET5g=@vger.kernel.org X-Received: by 2002:a05:6a00:3ccb:b0:823:1570:1e81 with SMTP id d2e1a72fcca58-825275e5ebcmr991227b3a.53.1771392473104; Tue, 17 Feb 2026 21:27:53 -0800 (PST) X-Received: by 2002:a05:6a00:3ccb:b0:823:1570:1e81 with SMTP id d2e1a72fcca58-825275e5ebcmr991152b3a.53.1771392471280; Tue, 17 Feb 2026 21:27:51 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824c6b69efdsm14894102b3a.40.2026.02.17.21.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 21:27:50 -0800 (PST) From: Vikas Gupta To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rajashekar.hudumula@broadcom.com, Vikas Gupta , Bhargava Chenna Marreddy Subject: [PATCH net v2] bnge: fix reserving resources from FW Date: Wed, 18 Feb 2026 10:57:55 +0530 Message-ID: <20260218052755.4097468-1-vikas.gupta@broadcom.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" HWRM_FUNC_CFG is used to reserve resources, whereas HWRM_FUNC_QCFG is intended for querying resource information from the firmware. Since __bnge_hwrm_reserve_pf_rings() reserves resources for a specific PF, the command type should be HWRM_FUNC_CFG. Changes in v2: -Fix commit message. Fixes: 627c67f038d2 ("bng_en: Add resource management support") Signed-off-by: Vikas Gupta Reviewed-by: Bhargava Chenna Marreddy Reviewed-by: Simon Horman --- drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c b/drivers/n= et/ethernet/broadcom/bnge/bnge_hwrm_lib.c index 84c90a957719..91a4ef9e3150 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_hwrm_lib.c @@ -442,7 +442,7 @@ __bnge_hwrm_reserve_pf_rings(struct bnge_dev *bd, struc= t bnge_hw_rings *hwr) struct hwrm_func_cfg_input *req; u32 enables =3D 0; =20 - if (bnge_hwrm_req_init(bd, req, HWRM_FUNC_QCFG)) + if (bnge_hwrm_req_init(bd, req, HWRM_FUNC_CFG)) return NULL; =20 req->fid =3D cpu_to_le16(0xffff); --=20 2.47.1