From nobody Fri Apr 3 07:42:52 2026 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 799A22FF158 for ; Wed, 18 Feb 2026 04:37:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389474; cv=none; b=CeBTRetFdqYEj4NVljNjJepq/spC38PAumP49owRiN/rczd+ZiCTwkTdxzwjGyezUmIA8BPXSNKNFNZbdg9zVL/0e79HeGVB2rIRgPF3Rl5iFCWThQ69uuNcexMPLKpDgcI1Zk2/H1A2dX04sLI9OohufCdezUZNRaPqOX5qc9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389474; c=relaxed/simple; bh=I33BA+Xs3H2s+wN1ueVG8ItbqrqoSJ0FwZ0ktBaaB18=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RjH4Bb3E4JlLV1mel3e1NYsyKeocUYGCLiRLVEK1/IzgsWLR3GCbfomNDn5s5l+cJKR6yD5hkHCyzmOUkJqZ5hn0+hzxGsVqvNJ3cZy6yAMa3qs5zERXUDFnOqr8g7zSWw2qoQZy68LYLRjsCo4o7nrFI2PCdyoQSrWK2pg4JRY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d/hLL/Xb; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d/hLL/Xb" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-797ab169454so36543887b3.3 for ; Tue, 17 Feb 2026 20:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389472; x=1771994272; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pj54F/VLsWjgNsa4Etjj+8Jo41r9O+F6M7507QFPSho=; b=d/hLL/XbveBythF4/YMkxXTX7oPkNEa8H29/dgw41c3ZXCxaVfxhdp9LxEK+5+UaT4 EwoHIy70s9Jss3NJaY4NxhQ43yFxQHiz49Pq2F4OX1ZxAswcjKwsTe5W0/nTwnFukAnV 4sy5AP9wALQtZVjbH59Cj2yDblmJkrVowYeSOC5wDokygzNrcbM1+YCjTtT/1ePoSYMl oFrih/uPmm83eXo6448/tDY13RpWn1N/9jeBcXciFfBiIynesn6M1jCt4vRiPq9UFQ5o rZZRGm24AihHHmN1b7lKSgE7huqU20ToSabya+pzb4gjkCW0+/X6ML+1Y5Y+HrStxZsQ I9Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389472; x=1771994272; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pj54F/VLsWjgNsa4Etjj+8Jo41r9O+F6M7507QFPSho=; b=pmaq4VvAVqiJJbaIXvFdOzp73gumfBgxcGXtR6IuCaUfdwavO8AKVAzJS8+MxuQYqO cjBPFds3nAmDEhHO/CK+xKlgVr6U1JbVAPeWSlNM98CUuOyQXc5+iZxmMHD1w8KJ4Ojb t2xDHZce9l+kFLLtqnoPoElubsYPmNR8cfHdryBbhvUrCsH5xVTGsba9OCNA4Ia1y6r3 ETzIotUZpfnzoL5i3RWEwXD0pB6QU8mOS3ENnwvNWOzlzjugA/5m9Tgtt9QSapTq9s0p EmSJlgN/zmWyzWqGTPLqVDrXRBadaTMCBbrcnxC8JBVzA0pUoZKfzuptVjCYwg3zNV7q ktig== X-Forwarded-Encrypted: i=1; AJvYcCXyT1+x25SMhK2giYspx//xuEbEaiFSF6G6hZ9q/et+vVp6y0EAJnDJmsPcnhDwRafXDQxvplKD0s3FfGc=@vger.kernel.org X-Gm-Message-State: AOJu0YxpGOT3O4kfaUo8p6q24jm/ZPH5dfQ1+qOy1rpXYg6aB77al84j xMZxFGaNQRCd3XM1m/BAv0uZJr7Dy09Es6p/OhJrS6FmxQ/PxwZtjlwm X-Gm-Gg: AZuq6aL+CPSTlhtnFV7AbMP+GKvZtCT5EkO3gx4jGjrzpY31Q81/EwihS2urCQJ6PMQ Ks0oEJ76cO8jK1GrXdbgusEflvoIXDX2SXBwltGNFClAmuwkDkJo9bNgElyerKZMvOLY7qOLC71 1HI6L/anBBfrov1BO6ElO3poTS6VGyMgroFT7VqoDKtCst8gXuePs41uQVt0Fl6puCGxC851Jz8 OAf+Sr5p23uSwaHeWU1hBG5mDBw7tFjHkJmiNfNDofLWaL8/tts33c8XQ25J3T5CgnONQ6NUI2n px63goGcYNDz/zOIfqq1XqHRQxy9A2DFnAKzlczyzDAw68LDHxEtJGkQSH3LPNxmRH4n8dF4fZ/ 5rtxAKENAIsFvQ1QYKwG3t10+cBKMo3Esq/kOwkkLXW4CRwH9xvZlCiS/coASOZUe1DTLemarLe AJiKlU1Zy24ItF1T4jTaSBe+nbhLLvX/VXnrxBdkJg+a2i4Yq+KztvF8hxO//7trS+eucgfmqGR JvuOoOMIgQ7xaP5UpVUU2j3zXO4Ky5Tnb7l+C4nv1wCC09FqYDLPg== X-Received: by 2002:a05:690c:600d:b0:796:c34b:9b01 with SMTP id 00721157ae682-797ac62e274mr115747997b3.55.1771389472482; Tue, 17 Feb 2026 20:37:52 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:51 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 6/9] iio: light: gp2ap020a00f: Use temporary variable for struct device Date: Tue, 17 Feb 2026 22:37:25 -0600 Message-ID: <20260218043728.609659-7-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Use temporary variable for struct device to make code neater. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 34 +++++++++++++++----------------- 1 file changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index f9ff8bbbe5ec..54b5d1993035 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -1192,6 +1192,7 @@ static int gp2ap020a00f_read_event_config(struct iio_= dev *indio_dev, static int gp2ap020a00f_read_channel(struct gp2ap020a00f_data *data, struct iio_chan_spec const *chan, int *val) { + struct device *dev =3D &data->client->dev; enum gp2ap020a00f_cmd cmd; int err; =20 @@ -1211,27 +1212,23 @@ static int gp2ap020a00f_read_channel(struct gp2ap02= 0a00f_data *data, =20 err =3D gp2ap020a00f_exec_cmd(data, cmd); if (err < 0) { - dev_err(&data->client->dev, - "gp2ap020a00f_exec_cmd failed\n"); - goto error_ret; + dev_err(dev, "gp2ap020a00f_exec_cmd failed\n"); + return err; } =20 err =3D gp2ap020a00f_read_output(data, chan->address, val); if (err < 0) - dev_err(&data->client->dev, - "gp2ap020a00f_read_output failed\n"); + dev_err(dev, "gp2ap020a00f_read_output failed\n"); =20 err =3D gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_SHUTDOWN); if (err < 0) - dev_err(&data->client->dev, - "Failed to shut down the device.\n"); + dev_err(dev, "Failed to shut down the device.\n"); =20 if (cmd =3D=3D GP2AP020A00F_CMD_READ_RAW_CLEAR || cmd =3D=3D GP2AP020A00F_CMD_READ_RAW_IR) gp2ap020a00f_output_to_lux(data, val); =20 -error_ret: return err; } =20 @@ -1421,18 +1418,19 @@ static const struct iio_buffer_setup_ops gp2ap020a0= 0f_buffer_setup_ops =3D { static int gp2ap020a00f_probe(struct i2c_client *client) { const struct i2c_device_id *id =3D i2c_client_get_device_id(client); + struct device *dev =3D &client->dev; struct gp2ap020a00f_data *data; struct iio_dev *indio_dev; struct regmap *regmap; int err; =20 - indio_dev =3D devm_iio_device_alloc(&client->dev, sizeof(*data)); + indio_dev =3D devm_iio_device_alloc(dev, sizeof(*data)); if (!indio_dev) return -ENOMEM; =20 data =3D iio_priv(indio_dev); =20 - data->vled_reg =3D devm_regulator_get(&client->dev, "vled"); + data->vled_reg =3D devm_regulator_get(dev, "vled"); if (IS_ERR(data->vled_reg)) return PTR_ERR(data->vled_reg); =20 @@ -1442,7 +1440,7 @@ static int gp2ap020a00f_probe(struct i2c_client *clie= nt) =20 regmap =3D devm_regmap_init_i2c(client, &gp2ap020a00f_regmap_config); if (IS_ERR(regmap)) { - dev_err(&client->dev, "Regmap initialization failed.\n"); + dev_err(dev, "Regmap initialization failed.\n"); err =3D PTR_ERR(regmap); goto error_regulator_disable; } @@ -1453,7 +1451,7 @@ static int gp2ap020a00f_probe(struct i2c_client *clie= nt) ARRAY_SIZE(gp2ap020a00f_reg_init_tab)); =20 if (err < 0) { - dev_err(&client->dev, "Device initialization failed.\n"); + dev_err(dev, "Device initialization failed.\n"); goto error_regulator_disable; } =20 @@ -1478,11 +1476,10 @@ static int gp2ap020a00f_probe(struct i2c_client *cl= ient) goto error_regulator_disable; =20 /* Allocate trigger */ - data->trig =3D devm_iio_trigger_alloc(&client->dev, "%s-trigger", - indio_dev->name); + data->trig =3D devm_iio_trigger_alloc(dev, "%s-trigger", indio_dev->name); if (data->trig =3D=3D NULL) { err =3D -ENOMEM; - dev_err(&indio_dev->dev, "Failed to allocate iio trigger.\n"); + dev_err(dev, "Failed to allocate iio trigger.\n"); goto error_uninit_buffer; } =20 @@ -1494,7 +1491,7 @@ static int gp2ap020a00f_probe(struct i2c_client *clie= nt) "gp2ap020a00f_als_event", indio_dev); if (err < 0) { - dev_err(&client->dev, "Irq request failed.\n"); + dev_err(dev, "Irq request failed.\n"); goto error_uninit_buffer; } =20 @@ -1502,7 +1499,7 @@ static int gp2ap020a00f_probe(struct i2c_client *clie= nt) =20 err =3D iio_trigger_register(data->trig); if (err < 0) { - dev_err(&client->dev, "Failed to register iio trigger.\n"); + dev_err(dev, "Failed to register iio trigger.\n"); goto error_free_irq; } =20 @@ -1528,12 +1525,13 @@ static void gp2ap020a00f_remove(struct i2c_client *= client) { struct iio_dev *indio_dev =3D i2c_get_clientdata(client); struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); + struct device *dev =3D &client->dev; int err; =20 err =3D gp2ap020a00f_set_operation_mode(data, GP2AP020A00F_OPMODE_SHUTDOWN); if (err < 0) - dev_err(&indio_dev->dev, "Failed to power off the device.\n"); + dev_err(dev, "Failed to power off the device.\n"); =20 iio_device_unregister(indio_dev); iio_trigger_unregister(data->trig); --=20 2.53.0