From nobody Fri Apr 3 07:42:52 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C27652FC881 for ; Wed, 18 Feb 2026 04:37:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389472; cv=none; b=uXqoQa/rJAIAvfzzM79x9Uj1UCAzcm7Iv5SSLIu1SHUK7R0xsz1dOYj2W/cWKgVu0RpRvYaCJGds8nmqBIzsvEnGwNArAR3tH7VQjz3LeahTY49evpVDJGqiKXmKfXH5ve14sTqdkOeROGTpvO9pqe0br70gfTiKC7DrvaWFkIk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771389472; c=relaxed/simple; bh=JoAZJDoiWPN35rMghHaD46+8b456UvXitcTsjZHErg8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YGAWIvv9DY6SqzsW0n4SOdOs8VgjKJH38C17zmdjvyyFiwGYWjk83qEjRiMGzS46k2spyOfsT55w9S9SsF4uOZ8BgPWlo0pSBy9GyTFoLPgtaTG2Au6huPdxSyxkUyP3bQnW2HStSSxC0Im7uietxqOsOndKvHdrRsy0ZRx/b/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YipxEGCM; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YipxEGCM" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7946a1f2430so40492457b3.1 for ; Tue, 17 Feb 2026 20:37:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771389470; x=1771994270; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kJMl8aGE3aksQFMSCHrKQEMvQMnBaLOVn3cqjYbpNCI=; b=YipxEGCMRfN7xJ5zU2tQ8QAPRJwIbewhxOZobfxH9hvKqrnSEIBcLAeiLMQf7LAsOb onJHEPkn1N8ciUi5xfmbHvv8f7jZRVBNXvdZAfgp7gavEoPWxrtnLqJDDCqhyRYM0AKj fzUm7VZzYsWqIo5UHqkaeBM4TATZ5+8S4x6KFT0Lh3hf+dyib93wgfZ/D4ghfcM7U7RK OPIK8q5/upEroc2WbvkLqoe35gnsTJawbdNWqk3fDPZOI0cFaLvldeJPDZh7O8KJgP/P LTytJ06046bfJMyyeeslERDJICZypQq9SVPbbT/Fk7NMADwAGNJOxJ7pkDKwXor7C7lm CR8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771389470; x=1771994270; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kJMl8aGE3aksQFMSCHrKQEMvQMnBaLOVn3cqjYbpNCI=; b=GCXSEwcO1QKDvCNPEDAlsz/Xl2QUmfgowsQ24WxGBatYAz2D1nEGKSLGYXFY6dYcDt SVm3lSu+qT3gET0CD8btBzPlQjaZdGl+dpOYh9Fmw3cJIBCJyWq3vN1tsH0sZ3fs34h5 D0DJxwFqCfh9vXJ382Dsx45xIANWNM4GjSgk8G8lsjbIhWlnaADvbVaGI0bjfa67BS+C vVMhrSh7DwAX1wxJY/3m8cI/BeCnJvXWmkVueMrStKlg5FtQP8QWocXEmlbn65uKEl2P 07Y7Zfo8xb9Go1g4+eVqdVkQWi+nOqmLe4aK9ni79rjUblCTdsx/XsMUqqJ7X0GWBVAM 6+vw== X-Forwarded-Encrypted: i=1; AJvYcCVvDuD8QX+qZPlZiQ9Ny/ImzI/hrksWxnyoRKJwx/TDiohrLqb5R6ux9NJ53o143UYYj11Rc1cUAYUXK2c=@vger.kernel.org X-Gm-Message-State: AOJu0YyxlTJvi6F8AE/7x7OqIPLBQQ09gWUni0UUQgch8Fqz24uo9kzD aUb+hHEcc6LBs4h5/4T2MyFtdAvNdnopJRu1LI2gNN3n8/XZoQ+J3g/B X-Gm-Gg: AZuq6aIuf5yJ65aN2P72/pEE271YYNEiDwmmqlxrDeTm2CmqGieGFOU/vkIn2v3AVNT lFST0LlFCRyV+NSyFTzqDnLlHnRtlbLLqc6oE9rEkUIh7r5xCYIE2E8YLpwLI8r1QrX5tMUke3O UFUijBPI4/WCOM78ocYjjyqAq5ojmBkI3l7vnbon6AQMWR8kRdUXH4TQGBt9DLjUmyI804Yo1xu GLgNQxWmavwuvRfVOr8OXgI/jLEaGTN8YNaQoul/fz3ZUDoCBHeMoY/Wp/JHxxh5rK0cX3+Qbx0 K1EMAgDy0T38Jl+PyOfqtWVxEqh8EpXgo2Tkv7Fdy0c/m+tk8K7bmpdOGuO+0sdxRyaJ6L7ES28 NGXbQLYuPrr+UIi2d5vDKkly2CauZsgs3slWYbyAE7n++UTljaGMEP8phAcTPuXT1yaSefCym/M wYwk/3pPstWFDh//URc2gawNFs7AR9Xo5/G/CeE1tLKInD0flHInSnEq1AxoZ9FFsSgI6ayeDCy 0SP2zWtMiDNFkWJrzdSKy0sM4qQ0a9TrMaZo742iDE= X-Received: by 2002:a05:690c:83:b0:796:2fde:5df3 with SMTP id 00721157ae682-797ac5d44f9mr92487807b3.40.1771389469689; Tue, 17 Feb 2026 20:37:49 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00:e3a8:26f7:7e08:88e1]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c23e4bdsm119850617b3.32.2026.02.17.20.37.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Feb 2026 20:37:49 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org, andy@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , Ethan Tidmore Subject: [PATCH v4 3/9] iio: light: gp2ap020a00f: Use correct types for 16-bit LE data Date: Tue, 17 Feb 2026 22:37:22 -0600 Message-ID: <20260218043728.609659-4-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260218043728.609659-1-ethantidmore06@gmail.com> References: <20260218043728.609659-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Andy Shevchenko Instead of using byte arrays and then explicit castings, change the types of byte arrays to be __le16 and update the endianness conversions accordingly. Signed-off-by: Andy Shevchenko Signed-off-by: Ethan Tidmore --- v4: - Integrate Andy Shevchenko's cleanups. drivers/iio/light/gp2ap020a00f.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index deca9fd77fdd..82b078f6a43d 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -462,7 +462,7 @@ static int gp2ap020a00f_write_event_threshold(struct gp= 2ap020a00f_data *data, =20 return regmap_bulk_write(data->regmap, GP2AP020A00F_THRESH_REG(th_val_id), - (u8 *)&thresh_buf, 2); + &thresh_buf, sizeof(thresh_buf)); } =20 static int gp2ap020a00f_alter_opmode(struct gp2ap020a00f_data *data, @@ -698,18 +698,18 @@ static int wait_conversion_complete_irq(struct gp2ap0= 20a00f_data *data) static int gp2ap020a00f_read_output(struct gp2ap020a00f_data *data, unsigned int output_reg, int *val) { - u8 reg_buf[2]; + __le16 reg_buf; int err; =20 err =3D wait_conversion_complete_irq(data); if (err < 0) dev_dbg(&data->client->dev, "data ready timeout\n"); =20 - err =3D regmap_bulk_read(data->regmap, output_reg, reg_buf, 2); + err =3D regmap_bulk_read(data->regmap, output_reg, ®_buf, sizeof(reg_b= uf)); if (err < 0) return err; =20 - *val =3D le16_to_cpup((__le16 *)reg_buf); + *val =3D le16_to_cpu(reg_buf); =20 return err; } @@ -867,8 +867,9 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(in= t irq, void *data) { struct iio_dev *indio_dev =3D data; struct gp2ap020a00f_data *priv =3D iio_priv(indio_dev); - u8 op_reg_flags, d0_reg_buf[2]; unsigned int output_val, op_reg_val; + __le16 d0_reg_buf; + u8 op_reg_flags; int thresh_val_id, ret; =20 /* Read interrupt flags */ @@ -896,11 +897,11 @@ static irqreturn_t gp2ap020a00f_thresh_event_handler(= int irq, void *data) * transition is required. */ ret =3D regmap_bulk_read(priv->regmap, GP2AP020A00F_D0_L_REG, - d0_reg_buf, 2); + &d0_reg_buf, sizeof(d0_reg_buf)); if (ret < 0) goto done; =20 - output_val =3D le16_to_cpup((__le16 *)d0_reg_buf); + output_val =3D le16_to_cpu(d0_reg_buf); =20 if (gp2ap020a00f_adjust_lux_mode(priv, output_val)) goto done; @@ -967,17 +968,15 @@ static irqreturn_t gp2ap020a00f_trigger_handler(int i= rq, void *data) int i, out_val, ret; =20 iio_for_each_active_channel(indio_dev, i) { - ret =3D regmap_bulk_read(priv->regmap, - GP2AP020A00F_DATA_REG(i), - &priv->buffer[d_size], 2); + ret =3D regmap_bulk_read(priv->regmap, GP2AP020A00F_DATA_REG(i), + &priv->buffer[d_size], 2); if (ret < 0) goto done; =20 if (i =3D=3D GP2AP020A00F_SCAN_MODE_LIGHT_CLEAR || i =3D=3D GP2AP020A00F_SCAN_MODE_LIGHT_IR) { - out_val =3D le16_to_cpup((__le16 *)&priv->buffer[d_size]); + out_val =3D get_unaligned_le16(&priv->buffer[d_size]); gp2ap020a00f_output_to_lux(priv, &out_val); - put_unaligned_le32(out_val, &priv->buffer[d_size]); d_size +=3D 4; } else { --=20 2.53.0